87325 2012-05-23 17:02:43 -0700 [chromium/mac] Unbreak popup menus. 2012-05-23 19:40:36 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thakis thakis levin webkit.review.bot oldest_to_newest 632206 0 thakis 2012-05-23 17:02:43 -0700 [chromium/mac] Unbreak popup menus. 632207 1 143685 thakis 2012-05-23 17:03:11 -0700 Created attachment 143685 Patch 632215 2 thakis 2012-05-23 17:07:10 -0700 http://svn.webkit.org/repository/webkit/trunk@117607 added this function. The Chromium/Mac build doesn't use the file added in that change. Adding it doesn't help, as the category calls a 10.7-only function. Just don't use the category for chromium/mac. 632220 3 143685 levin 2012-05-23 17:10:21 -0700 Comment on attachment 143685 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143685&action=review > Source/WebCore/platform/mac/WebCoreNSCellExtras.m:25 > +#include "config.h" I think you can remove this. 632224 4 levin 2012-05-23 17:11:52 -0700 (In reply to comment #2) > http://svn.webkit.org/repository/webkit/trunk@117607 added this function. The Chromium/Mac build doesn't use the file added in that change. Adding it doesn't help, as the category calls a 10.7-only function. Just don't use the category for chromium/mac. It would be nice if this explanation was in the change log as it is much more informative than what is in there now! 632232 5 143688 thakis 2012-05-23 17:15:53 -0700 Created attachment 143688 Patch 632233 6 thakis 2012-05-23 17:16:22 -0700 (In reply to comment #3) > (From update of attachment 143685 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=143685&action=review > > > Source/WebCore/platform/mac/WebCoreNSCellExtras.m:25 > > +#include "config.h" > > I think you can remove this. Thanks. I had an oldish WebKit checkout (from bisecting), and my checkout didn't have that line yet. Rebased. 632334 7 143688 webkit.review.bot 2012-05-23 19:40:31 -0700 Comment on attachment 143688 Patch Clearing flags on attachment: 143688 Committed r118312: <http://trac.webkit.org/changeset/118312> 632335 8 webkit.review.bot 2012-05-23 19:40:36 -0700 All reviewed patches have been landed. Closing bug. 143685 2012-05-23 17:03:11 -0700 2012-05-23 17:15:49 -0700 Patch bug-87325-20120523170310.patch text/plain 1979 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3NjIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTcxMjQyMzdjMmFjYWQ1 MDgyNDY2MjM3OGRkNzk5OTAzYzVkMTE1YS4uMjcyMGViMWNkNmViNDc2YTcxNzkzMDVmMTRmNGM1 NzY5ODYxZWZmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA1LTIzICBOaWNv IFdlYmVyICA8dGhha2lzQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW0vbWFjXSBV bmJyZWFrIHBvcHVwIG1lbnVzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODczMjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBGaXhlcyBodHRwOi8vY3JidWcuY29tLzEyOTQxOAorCisgICAgICAgICogcGxh dGZvcm0vbWFjL1dlYkNvcmVOU0NlbGxFeHRyYXMuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMv V2ViQ29yZU5TQ2VsbEV4dHJhcy5tOgorCiAyMDEyLTA1LTE4ICBUb255IENoYW5nICA8dG9ueUBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgcmVtb3ZlIHRoZSBDU1NfR1JJRF9MQVlPVVQgY29tcGls ZXIgZGVmaW5lLCBidXQgZGVmYXVsdCBncmlkIGxheW91dCB0byBvZmYKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJDb3JlTlNDZWxsRXh0cmFzLmggYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9tYWMvV2ViQ29yZU5TQ2VsbEV4dHJhcy5oCmluZGV4IDE3Nzc4NjE2 YTQxY2E5ZDMxN2ViNTllYmNhZGVlMmI2MzExMGY2ZDYuLjI2YmU0NjJlMTQxNmE5OTQyMmRkZmRm NzFlMWI5ZTIxMDU4NGMyNDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21h Yy9XZWJDb3JlTlNDZWxsRXh0cmFzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFj L1dlYkNvcmVOU0NlbGxFeHRyYXMuaApAQCAtMjUsNyArMjUsNyBAQAogCiAjaW1wb3J0IDxBcHBL aXQvQXBwS2l0Lmg+CiAKLSNkZWZpbmUgQlVUVE9OX0NFTExfRFJBV19XSVRIX0ZSQU1FX0RSQVdT X0ZPQ1VTX1JJTkcgKGRlZmluZWQoQlVJTERJTkdfT05fU05PV19MRU9QQVJEKSB8fCBkZWZpbmVk KEJVSUxESU5HX09OX0xJT04pKQorI2RlZmluZSBCVVRUT05fQ0VMTF9EUkFXX1dJVEhfRlJBTUVf RFJBV1NfRk9DVVNfUklORyAoZGVmaW5lZChCVUlMRElOR19PTl9TTk9XX0xFT1BBUkQpIHx8IGRl ZmluZWQoQlVJTERJTkdfT05fTElPTikgfHwgUExBVEZPUk0oQ0hST01JVU0pKQogCiAjaWYgIUJV VFRPTl9DRUxMX0RSQVdfV0lUSF9GUkFNRV9EUkFXU19GT0NVU19SSU5HCiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJDb3JlTlNDZWxsRXh0cmFzLm0gYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvV2ViQ29yZU5TQ2VsbEV4dHJhcy5tCmluZGV4IGRmNzVm N2Y5NDg2MGQ2NzI5OWI5NjI3ZmNkOWIxYTVjOTBhODJiYTQuLjA4YjM2N2EwNjZhNmUzNGQ5NGUw MmY5YjA0NGU4YTk4NTU0YmRhOTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L21hYy9XZWJDb3JlTlNDZWxsRXh0cmFzLm0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bWFjL1dlYkNvcmVOU0NlbGxFeHRyYXMubQpAQCAtMjIsNyArMjIsNyBAQAogICogQVJJU0lORyBJ TiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNF RCBPRgogICogVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogICovCi0KKyNpbmNsdWRl ICJjb25maWcuaCIKICNpbXBvcnQgIldlYkNvcmVOU0NlbGxFeHRyYXMuaCIKIAogI2lmICFCVVRU T05fQ0VMTF9EUkFXX1dJVEhfRlJBTUVfRFJBV1NfRk9DVVNfUklORwo= 143688 2012-05-23 17:15:53 -0700 2012-05-23 19:40:31 -0700 Patch bug-87325-20120523171552.patch text/plain 1719 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4MTQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjJhZjViZDA1YmZhYzdk MDEwNjExNzg1ZmE0M2NhZDE1Mjg1N2Y2NS4uZWIyNTJiM2U3MmYzZWQwNjMwZTVlNjQxMzg5NzFj YzM0NWI2M2M4MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA1LTIzICBOaWNv IFdlYmVyICA8dGhha2lzQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW0vbWFjXSBV bmJyZWFrIHBvcHVwIG1lbnVzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODczMjUKKworICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBMZXZpbi4KKwor ICAgICAgICBodHRwOi8vc3ZuLndlYmtpdC5vcmcvcmVwb3NpdG9yeS93ZWJraXQvdHJ1bmtAMTE3 NjA3IGFkZGVkIHRoaXMgZnVuY3Rpb24sIGJ1dCB0aGUKKyAgICAgICAgQ2hyb21pdW0vTWFjIGJ1 aWxkIGRvZXNuJ3QgdXNlIHRoZSBmaWxlIGFkZGVkIGluIHRoYXQgY2hhbmdlIGFuZCBoZW5jZSBk aWRuJ3QgaGF2ZQorICAgICAgICB0aGUgY2F0ZWdvcnkgbWV0aG9kLi4gQWRkaW5nIGl0IGRvZXNu J3QgaGVscCwgYXMgdGhlIGNhdGVnb3J5IGNhbGxzIGEKKyAgICAgICAgMTAuNy1vbmx5IGZ1bmN0 aW9uLiBKdXN0IGRvbid0IHVzZSB0aGUgY2F0ZWdvcnkgZm9yIGNocm9taXVtL21hYy4gRml4ZXMK KyAgICAgICAgaHR0cDovL2NyYnVnLmNvbS8xMjk0MTgKKworICAgICAgICAqIHBsYXRmb3JtL21h Yy9XZWJDb3JlTlNDZWxsRXh0cmFzLmg6CisKIDIwMTItMDUtMjMgIFJ5b3N1a2UgTml3YSAgPHJu aXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgV2ViS2l0IHNwZW5kcyB+MjAlIG9mIHRpbWUgaW4g SFRNTFRleHRBcmVhRWxlbWVudDo6ZGVmYXVsdFZhbHVlKCkgd2hlbiBvcGVuaW5nIGEgcmV2aWV3 IHBhZ2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJDb3JlTlND ZWxsRXh0cmFzLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvV2ViQ29yZU5TQ2VsbEV4 dHJhcy5oCmluZGV4IDE3Nzc4NjE2YTQxY2E5ZDMxN2ViNTllYmNhZGVlMmI2MzExMGY2ZDYuLjI2 YmU0NjJlMTQxNmE5OTQyMmRkZmRmNzFlMWI5ZTIxMDU4NGMyNDYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJDb3JlTlNDZWxsRXh0cmFzLmgKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbWFjL1dlYkNvcmVOU0NlbGxFeHRyYXMuaApAQCAtMjUsNyArMjUs NyBAQAogCiAjaW1wb3J0IDxBcHBLaXQvQXBwS2l0Lmg+CiAKLSNkZWZpbmUgQlVUVE9OX0NFTExf RFJBV19XSVRIX0ZSQU1FX0RSQVdTX0ZPQ1VTX1JJTkcgKGRlZmluZWQoQlVJTERJTkdfT05fU05P V19MRU9QQVJEKSB8fCBkZWZpbmVkKEJVSUxESU5HX09OX0xJT04pKQorI2RlZmluZSBCVVRUT05f Q0VMTF9EUkFXX1dJVEhfRlJBTUVfRFJBV1NfRk9DVVNfUklORyAoZGVmaW5lZChCVUlMRElOR19P Tl9TTk9XX0xFT1BBUkQpIHx8IGRlZmluZWQoQlVJTERJTkdfT05fTElPTikgfHwgUExBVEZPUk0o Q0hST01JVU0pKQogCiAjaWYgIUJVVFRPTl9DRUxMX0RSQVdfV0lUSF9GUkFNRV9EUkFXU19GT0NV U19SSU5HCiAK