87322 2012-05-23 16:45:11 -0700 improve StyleRareNonInheritedData bit packing on Windows 2012-05-24 11:34:32 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tony tony eric rniwa webkit.review.bot oldest_to_newest 632184 0 tony 2012-05-23 16:45:11 -0700 improve StyleRareNonInheritedData bit packing on Windows 632188 1 143678 tony 2012-05-23 16:48:40 -0700 Created attachment 143678 Patch 632190 2 tony 2012-05-23 16:49:37 -0700 I didn't add a compile assert because it's OK for this struct to grow slowly. 632230 3 143678 eric 2012-05-23 17:15:34 -0700 Comment on attachment 143678 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143678&action=review LGTM. > Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp:150 > bool StyleRareNonInheritedData::operator==(const StyleRareNonInheritedData& o) const Presumably we could optimize the comparison order. Do you believe that was attempted previously? I'm OK with this kept in this order if you think it's unlikely to matter for perf. 632237 4 143678 rniwa 2012-05-23 17:17:53 -0700 Comment on attachment 143678 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143678&action=review > Source/WebCore/rendering/style/StyleRareNonInheritedData.h:176 > - bool m_hasAspectRatio : 1; // Whether or not an aspect ratio has been specified. > #if USE(ACCELERATED_COMPOSITING) > - bool m_runningAcceleratedAnimation : 1; > + unsigned m_runningAcceleratedAnimation : 1; > #endif > + unsigned m_hasAspectRatio : 1; // Whether or not an aspect ratio has been specified. Could you please add a compile assertion? 632878 5 143678 tony 2012-05-24 09:35:15 -0700 Comment on attachment 143678 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143678&action=review >> Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp:150 >> bool StyleRareNonInheritedData::operator==(const StyleRareNonInheritedData& o) const > > Presumably we could optimize the comparison order. Do you believe that was attempted previously? I'm OK with this kept in this order if you think it's unlikely to matter for perf. I don't think perf was a concern. Looking at the history of the header file, members have been reordered multiple times for bit packing reasons. I bet it was just an oversight that this wasn't reordered. >> Source/WebCore/rendering/style/StyleRareNonInheritedData.h:176 >> + unsigned m_hasAspectRatio : 1; // Whether or not an aspect ratio has been specified. > > Could you please add a compile assertion? Do you think it's worth it given that this object can grow? It's already 448 bytes on my 64 bit machine. 632898 6 rniwa 2012-05-24 10:14:23 -0700 (In reply to comment #5) > >> Source/WebCore/rendering/style/StyleRareNonInheritedData.h:176 > >> + unsigned m_hasAspectRatio : 1; // Whether or not an aspect ratio has been specified. > > > > Could you please add a compile assertion? > > Do you think it's worth it given that this object can grow? It's already 448 bytes on my 64 bit machine. Oh, I see. Maybe not then. 632993 7 143678 webkit.review.bot 2012-05-24 11:34:28 -0700 Comment on attachment 143678 Patch Clearing flags on attachment: 143678 Committed r118396: <http://trac.webkit.org/changeset/118396> 632994 8 webkit.review.bot 2012-05-24 11:34:32 -0700 All reviewed patches have been landed. Closing bug. 143678 2012-05-23 16:48:40 -0700 2012-05-24 11:34:28 -0700 Patch bug-87322-20120523164841.patch text/plain 8329 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4MjExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjEwOGU0YTI0YjJlZGQ1 NzFjMDU3MjU4ZGM1YzE0Njg5YjJjOTk4MC4uMDVlYzcwNjRhOTk5ZGEzNDY2ODJiMGJiZWZmY2M2 NTMyYWEzNzRhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA1LTIzICBUb255 IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgaW1wcm92ZSBTdHlsZVJhcmVO b25Jbmhlcml0ZWREYXRhIGJpdCBwYWNraW5nIG9uIFdpbmRvd3MKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3MzIyCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWNjZXNzb3JzIGZvciBtX3J1bm5pbmdBY2Nl bGVyYXRlZEFuaW1hdGlvbiBhbmQgbV9oYXNBc3BlY3RSYXRpbyBhcmUgb24gUmVuZGVyU3R5bGUg YWxyZWFkeS4KKworICAgICAgICBBbHNvIHJlb3JkZXIgdGhlIHZhcmlhYmxlcyBpbiBvcGVyYXRv cj09IHRvIGJlIGNvbnNpc3RlbnQgd2l0aCB0aGUgY29uc3RydWN0b3IgYW5kIGhlYWRlciBmaWxl LgorICAgICAgICBUaGlzIG1ha2VzIGl0IGVhc2llciB0byBhZGQgb3IgcmVtb3ZlIHZhbHVlcy4K KworICAgICAgICBObyBuZXcgdGVzdHMsIGp1c3QgcmVmYWN0b3JpbmcuCisKKyAgICAgICAgKiBy ZW5kZXJpbmcvc3R5bGUvU3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpTdHlsZVJhcmVOb25Jbmhlcml0ZWREYXRhOjpTdHlsZVJhcmVOb25Jbmhlcml0ZWRE YXRhKToKKyAgICAgICAgKFdlYkNvcmU6OlN0eWxlUmFyZU5vbkluaGVyaXRlZERhdGE6Om9wZXJh dG9yPT0pOgorICAgICAgICAqIHJlbmRlcmluZy9zdHlsZS9TdHlsZVJhcmVOb25Jbmhlcml0ZWRE YXRhLmg6CisgICAgICAgIChTdHlsZVJhcmVOb25Jbmhlcml0ZWREYXRhKToKKwogMjAxMi0wNS0y MyAgUm9iaW4gRHVubiAgPHJvYmluQGFsbGR1bm4uY29tPgogCiAgICAgICAgIFt3eF0gRml4IG1l bW9yeSBsZWFrIGluIEZvbnRIb2xkZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvc3R5bGUvU3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YS5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvc3R5bGUvU3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YS5jcHAKaW5kZXggZDg3 YjFhY2MwZDY0NWUzYzAzMDY5YWRkNzhlNTlmMTcyMDRlNTBiNS4uY2E4OWY1ZmRiOTBhMDcwMjUw N2QxM2I1OGIzZGU0NDYzOWM4Mzc5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL3N0eWxlL1N0eWxlUmFyZU5vbkluaGVyaXRlZERhdGEuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9zdHlsZS9TdHlsZVJhcmVOb25Jbmhlcml0ZWREYXRhLmNwcApAQCAtNjks MTAgKzY5LDEwIEBAIFN0eWxlUmFyZU5vbkluaGVyaXRlZERhdGE6OlN0eWxlUmFyZU5vbkluaGVy aXRlZERhdGEoKQogICAgICwgbV90ZXh0Q29tYmluZShSZW5kZXJTdHlsZTo6aW5pdGlhbFRleHRD b21iaW5lKCkpCiAgICAgLCBtX3dyYXBGbG93KFJlbmRlclN0eWxlOjppbml0aWFsV3JhcEZsb3co KSkKICAgICAsIG1fd3JhcFRocm91Z2goUmVuZGVyU3R5bGU6OmluaXRpYWxXcmFwVGhyb3VnaCgp KQotICAgICwgbV9oYXNBc3BlY3RSYXRpbyhmYWxzZSkKICNpZiBVU0UoQUNDRUxFUkFURURfQ09N UE9TSVRJTkcpCiAgICAgLCBtX3J1bm5pbmdBY2NlbGVyYXRlZEFuaW1hdGlvbihmYWxzZSkKICNl bmRpZgorICAgICwgbV9oYXNBc3BlY3RSYXRpbyhmYWxzZSkKIHsKICAgICBtX21hc2tCb3hJbWFn ZS5zZXRNYXNrRGVmYXVsdHMoKTsKIH0KQEAgLTEzNiwxMCArMTM2LDEwIEBAIFN0eWxlUmFyZU5v bkluaGVyaXRlZERhdGE6OlN0eWxlUmFyZU5vbkluaGVyaXRlZERhdGEoY29uc3QgU3R5bGVSYXJl Tm9uSW5oZXJpdGVkCiAgICAgLCBtX3RleHRDb21iaW5lKG8ubV90ZXh0Q29tYmluZSkKICAgICAs IG1fd3JhcEZsb3coby5tX3dyYXBGbG93KQogICAgICwgbV93cmFwVGhyb3VnaChvLm1fd3JhcFRo cm91Z2gpCi0gICAgLCBtX2hhc0FzcGVjdFJhdGlvKG8ubV9oYXNBc3BlY3RSYXRpbykKICNpZiBV U0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCiAgICAgLCBtX3J1bm5pbmdBY2NlbGVyYXRlZEFu aW1hdGlvbihvLm1fcnVubmluZ0FjY2VsZXJhdGVkQW5pbWF0aW9uKQogI2VuZGlmCisgICAgLCBt X2hhc0FzcGVjdFJhdGlvKG8ubV9oYXNBc3BlY3RSYXRpbykKIHsKIH0KIApAQCAtMTQ5LDExICsx NDksMTggQEAgU3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YTo6flN0eWxlUmFyZU5vbkluaGVyaXRl ZERhdGEoKQogCiBib29sIFN0eWxlUmFyZU5vbkluaGVyaXRlZERhdGE6Om9wZXJhdG9yPT0oY29u c3QgU3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YSYgbykgY29uc3QKIHsKLSAgICByZXR1cm4gbGlu ZUNsYW1wID09IG8ubGluZUNsYW1wCisgICAgcmV0dXJuIG9wYWNpdHkgPT0gby5vcGFjaXR5Cisg ICAgICAgICYmIG1fYXNwZWN0UmF0aW9EZW5vbWluYXRvciA9PSBvLm1fYXNwZWN0UmF0aW9EZW5v bWluYXRvcgorICAgICAgICAmJiBtX2FzcGVjdFJhdGlvTnVtZXJhdG9yID09IG8ubV9hc3BlY3RS YXRpb051bWVyYXRvcgorICAgICAgICAmJiBtX2NvdW50ZXJJbmNyZW1lbnQgPT0gby5tX2NvdW50 ZXJJbmNyZW1lbnQKKyAgICAgICAgJiYgbV9jb3VudGVyUmVzZXQgPT0gby5tX2NvdW50ZXJSZXNl dAorICAgICAgICAmJiBtX3BlcnNwZWN0aXZlID09IG8ubV9wZXJzcGVjdGl2ZQorICAgICAgICAm JiBtX3BlcnNwZWN0aXZlT3JpZ2luWCA9PSBvLm1fcGVyc3BlY3RpdmVPcmlnaW5YCisgICAgICAg ICYmIG1fcGVyc3BlY3RpdmVPcmlnaW5ZID09IG8ubV9wZXJzcGVjdGl2ZU9yaWdpblkKKyAgICAg ICAgJiYgbGluZUNsYW1wID09IG8ubGluZUNsYW1wCiAjaWYgRU5BQkxFKERBU0hCT0FSRF9TVVBQ T1JUKQogICAgICAgICAmJiBtX2Rhc2hib2FyZFJlZ2lvbnMgPT0gby5tX2Rhc2hib2FyZFJlZ2lv bnMKICNlbmRpZgotICAgICAgICAmJiBvcGFjaXR5ID09IG8ub3BhY2l0eQogICAgICAgICAmJiBt X2RlcHJlY2F0ZWRGbGV4aWJsZUJveCA9PSBvLm1fZGVwcmVjYXRlZEZsZXhpYmxlQm94CiAgICAg ICAgICYmIG1fZmxleGlibGVCb3ggPT0gby5tX2ZsZXhpYmxlQm94CiAgICAgICAgICYmIG1fbWFy cXVlZSA9PSBvLm1fbWFycXVlZQpAQCAtMTY2LDUzICsxNzMsNDYgQEAgYm9vbCBTdHlsZVJhcmVO b25Jbmhlcml0ZWREYXRhOjpvcGVyYXRvcj09KGNvbnN0IFN0eWxlUmFyZU5vbkluaGVyaXRlZERh dGEmIG8pIGMKICAgICAgICAgJiYgbV9ncmlkSXRlbSA9PSBvLm1fZ3JpZEl0ZW0KICAgICAgICAg JiYgY29udGVudERhdGFFcXVpdmFsZW50KG8pCiAgICAgICAgICYmIGNvdW50ZXJEYXRhRXF1aXZh bGVudChvKQotICAgICAgICAmJiB1c2VyRHJhZyA9PSBvLnVzZXJEcmFnCi0gICAgICAgICYmIHRl eHRPdmVyZmxvdyA9PSBvLnRleHRPdmVyZmxvdwotICAgICAgICAmJiBtYXJnaW5CZWZvcmVDb2xs YXBzZSA9PSBvLm1hcmdpbkJlZm9yZUNvbGxhcHNlCi0gICAgICAgICYmIG1hcmdpbkFmdGVyQ29s bGFwc2UgPT0gby5tYXJnaW5BZnRlckNvbGxhcHNlCi0gICAgICAgICYmIG1hdGNoTmVhcmVzdE1h aWxCbG9ja3F1b3RlQ29sb3IgPT0gby5tYXRjaE5lYXJlc3RNYWlsQmxvY2txdW90ZUNvbG9yCi0g ICAgICAgICYmIG1fYXBwZWFyYW5jZSA9PSBvLm1fYXBwZWFyYW5jZQotICAgICAgICAmJiBtX2Jv cmRlckZpdCA9PSBvLm1fYm9yZGVyRml0Ci0gICAgICAgICYmIG1fdGV4dENvbWJpbmUgPT0gby5t X3RleHRDb21iaW5lCi0gICAgICAgICYmIG1fYXNwZWN0UmF0aW9EZW5vbWluYXRvciA9PSBvLm1f YXNwZWN0UmF0aW9EZW5vbWluYXRvcgotICAgICAgICAmJiBtX2FzcGVjdFJhdGlvTnVtZXJhdG9y ID09IG8ubV9hc3BlY3RSYXRpb051bWVyYXRvcgotICAgICAgICAmJiBtX2NvdW50ZXJJbmNyZW1l bnQgPT0gby5tX2NvdW50ZXJJbmNyZW1lbnQKLSAgICAgICAgJiYgbV9jb3VudGVyUmVzZXQgPT0g by5tX2NvdW50ZXJSZXNldAotICAgICAgICAmJiBtX2hhc0FzcGVjdFJhdGlvID09IG8ubV9oYXNB c3BlY3RSYXRpbwotI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKLSAgICAgICAgJiYg IW1fcnVubmluZ0FjY2VsZXJhdGVkQW5pbWF0aW9uICYmICFvLm1fcnVubmluZ0FjY2VsZXJhdGVk QW5pbWF0aW9uCi0jZW5kaWYKICAgICAgICAgJiYgc2hhZG93RGF0YUVxdWl2YWxlbnQobykKICAg ICAgICAgJiYgcmVmbGVjdGlvbkRhdGFFcXVpdmFsZW50KG8pCiAgICAgICAgICYmIGFuaW1hdGlv bkRhdGFFcXVpdmFsZW50KG8pCiAgICAgICAgICYmIHRyYW5zaXRpb25EYXRhRXF1aXZhbGVudChv KQogICAgICAgICAmJiBtX21hc2sgPT0gby5tX21hc2sKICAgICAgICAgJiYgbV9tYXNrQm94SW1h Z2UgPT0gby5tX21hc2tCb3hJbWFnZQotICAgICAgICAmJiAobV90cmFuc2Zvcm1TdHlsZTNEID09 IG8ubV90cmFuc2Zvcm1TdHlsZTNEKQotICAgICAgICAmJiAobV9iYWNrZmFjZVZpc2liaWxpdHkg PT0gby5tX2JhY2tmYWNlVmlzaWJpbGl0eSkKLSAgICAgICAgJiYgKG1fcGVyc3BlY3RpdmUgPT0g by5tX3BlcnNwZWN0aXZlKQotICAgICAgICAmJiAobV9wZXJzcGVjdGl2ZU9yaWdpblggPT0gby5t X3BlcnNwZWN0aXZlT3JpZ2luWCkKLSAgICAgICAgJiYgKG1fcGVyc3BlY3RpdmVPcmlnaW5ZID09 IG8ubV9wZXJzcGVjdGl2ZU9yaWdpblkpCi0gICAgICAgICYmIChtX3BhZ2VTaXplID09IG8ubV9w YWdlU2l6ZSkKLSAgICAgICAgJiYgKG1fcGFnZVNpemVUeXBlID09IG8ubV9wYWdlU2l6ZVR5cGUp Ci0gICAgICAgICYmIChtX2Zsb3dUaHJlYWQgPT0gby5tX2Zsb3dUaHJlYWQpCi0gICAgICAgICYm IChtX3JlZ2lvblRocmVhZCA9PSBvLm1fcmVnaW9uVGhyZWFkKQotICAgICAgICAmJiAobV9yZWdp b25PdmVyZmxvdyA9PSBvLm1fcmVnaW9uT3ZlcmZsb3cpCi0gICAgICAgICYmIChtX3dyYXBTaGFw ZUluc2lkZSA9PSBvLm1fd3JhcFNoYXBlSW5zaWRlKQotICAgICAgICAmJiAobV93cmFwU2hhcGVP dXRzaWRlID09IG8ubV93cmFwU2hhcGVPdXRzaWRlKQotICAgICAgICAmJiAobV93cmFwRmxvdyA9 PSBvLm1fd3JhcEZsb3cpCi0gICAgICAgICYmIChtX3dyYXBUaHJvdWdoID09IG8ubV93cmFwVGhy b3VnaCkKLSAgICAgICAgJiYgKG1fd3JhcE1hcmdpbiA9PSBvLm1fd3JhcE1hcmdpbikKLSAgICAg ICAgJiYgKG1fd3JhcFBhZGRpbmcgPT0gby5tX3dyYXBQYWRkaW5nKQorICAgICAgICAmJiBtX3Bh Z2VTaXplID09IG8ubV9wYWdlU2l6ZQorICAgICAgICAmJiBtX3dyYXBTaGFwZUluc2lkZSA9PSBv Lm1fd3JhcFNoYXBlSW5zaWRlCisgICAgICAgICYmIG1fd3JhcFNoYXBlT3V0c2lkZSA9PSBvLm1f d3JhcFNoYXBlT3V0c2lkZQorICAgICAgICAmJiBtX3dyYXBNYXJnaW4gPT0gby5tX3dyYXBNYXJn aW4KKyAgICAgICAgJiYgbV93cmFwUGFkZGluZyA9PSBvLm1fd3JhcFBhZGRpbmcKICAgICAgICAg JiYgbV92aXNpdGVkTGlua0JhY2tncm91bmRDb2xvciA9PSBvLm1fdmlzaXRlZExpbmtCYWNrZ3Jv dW5kQ29sb3IKICAgICAgICAgJiYgbV92aXNpdGVkTGlua091dGxpbmVDb2xvciA9PSBvLm1fdmlz aXRlZExpbmtPdXRsaW5lQ29sb3IKICAgICAgICAgJiYgbV92aXNpdGVkTGlua0JvcmRlckxlZnRD b2xvciA9PSBvLm1fdmlzaXRlZExpbmtCb3JkZXJMZWZ0Q29sb3IKICAgICAgICAgJiYgbV92aXNp dGVkTGlua0JvcmRlclJpZ2h0Q29sb3IgPT0gby5tX3Zpc2l0ZWRMaW5rQm9yZGVyUmlnaHRDb2xv cgogICAgICAgICAmJiBtX3Zpc2l0ZWRMaW5rQm9yZGVyVG9wQ29sb3IgPT0gby5tX3Zpc2l0ZWRM aW5rQm9yZGVyVG9wQ29sb3IKICAgICAgICAgJiYgbV92aXNpdGVkTGlua0JvcmRlckJvdHRvbUNv bG9yID09IG8ubV92aXNpdGVkTGlua0JvcmRlckJvdHRvbUNvbG9yCi0gICAgICAgICYmIChtX3Jl Z2lvbkJyZWFrQWZ0ZXIgPT0gby5tX3JlZ2lvbkJyZWFrQWZ0ZXIpCi0gICAgICAgICYmIChtX3Jl Z2lvbkJyZWFrQmVmb3JlID09IG8ubV9yZWdpb25CcmVha0JlZm9yZSkKLSAgICAgICAgJiYgKG1f cmVnaW9uQnJlYWtJbnNpZGUgPT0gby5tX3JlZ2lvbkJyZWFrSW5zaWRlKTsKKyAgICAgICAgJiYg bV9mbG93VGhyZWFkID09IG8ubV9mbG93VGhyZWFkCisgICAgICAgICYmIG1fcmVnaW9uVGhyZWFk ID09IG8ubV9yZWdpb25UaHJlYWQKKyAgICAgICAgJiYgbV9yZWdpb25PdmVyZmxvdyA9PSBvLm1f cmVnaW9uT3ZlcmZsb3cKKyAgICAgICAgJiYgbV9yZWdpb25CcmVha0FmdGVyID09IG8ubV9yZWdp b25CcmVha0FmdGVyCisgICAgICAgICYmIG1fcmVnaW9uQnJlYWtCZWZvcmUgPT0gby5tX3JlZ2lv bkJyZWFrQmVmb3JlCisgICAgICAgICYmIG1fcmVnaW9uQnJlYWtJbnNpZGUgPT0gby5tX3JlZ2lv bkJyZWFrSW5zaWRlCisgICAgICAgICYmIG1fcGFnZVNpemVUeXBlID09IG8ubV9wYWdlU2l6ZVR5 cGUKKyAgICAgICAgJiYgbV90cmFuc2Zvcm1TdHlsZTNEID09IG8ubV90cmFuc2Zvcm1TdHlsZTNE CisgICAgICAgICYmIG1fYmFja2ZhY2VWaXNpYmlsaXR5ID09IG8ubV9iYWNrZmFjZVZpc2liaWxp dHkKKyAgICAgICAgJiYgdXNlckRyYWcgPT0gby51c2VyRHJhZworICAgICAgICAmJiB0ZXh0T3Zl cmZsb3cgPT0gby50ZXh0T3ZlcmZsb3cKKyAgICAgICAgJiYgbWFyZ2luQmVmb3JlQ29sbGFwc2Ug PT0gby5tYXJnaW5CZWZvcmVDb2xsYXBzZQorICAgICAgICAmJiBtYXJnaW5BZnRlckNvbGxhcHNl ID09IG8ubWFyZ2luQWZ0ZXJDb2xsYXBzZQorICAgICAgICAmJiBtYXRjaE5lYXJlc3RNYWlsQmxv Y2txdW90ZUNvbG9yID09IG8ubWF0Y2hOZWFyZXN0TWFpbEJsb2NrcXVvdGVDb2xvcgorICAgICAg ICAmJiBtX2FwcGVhcmFuY2UgPT0gby5tX2FwcGVhcmFuY2UKKyAgICAgICAgJiYgbV9ib3JkZXJG aXQgPT0gby5tX2JvcmRlckZpdAorICAgICAgICAmJiBtX3RleHRDb21iaW5lID09IG8ubV90ZXh0 Q29tYmluZQorICAgICAgICAmJiBtX3dyYXBGbG93ID09IG8ubV93cmFwRmxvdworICAgICAgICAm JiBtX3dyYXBUaHJvdWdoID09IG8ubV93cmFwVGhyb3VnaAorI2lmIFVTRShBQ0NFTEVSQVRFRF9D T01QT1NJVElORykKKyAgICAgICAgJiYgIW1fcnVubmluZ0FjY2VsZXJhdGVkQW5pbWF0aW9uICYm ICFvLm1fcnVubmluZ0FjY2VsZXJhdGVkQW5pbWF0aW9uCisjZW5kaWYKKyAgICAgICAgJiYgbV9o YXNBc3BlY3RSYXRpbyA9PSBvLm1faGFzQXNwZWN0UmF0aW87CiB9CiAKIGJvb2wgU3R5bGVSYXJl Tm9uSW5oZXJpdGVkRGF0YTo6Y29udGVudERhdGFFcXVpdmFsZW50KGNvbnN0IFN0eWxlUmFyZU5v bkluaGVyaXRlZERhdGEmIG8pIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvc3R5bGUvU3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YS5oIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL3N0eWxlL1N0eWxlUmFyZU5vbkluaGVyaXRlZERhdGEuaAppbmRleCAxOGFhMzU5 NmMwYTljOWU0MmFjZDliZDdmMjYxZWMyNGQ5NDczMGUxLi4xOWYxZWZlYzA0ZGNkZTg3YWZiYjlm MzAwNWQyODc1ZDUzMDdiNDMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv c3R5bGUvU3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9zdHlsZS9TdHlsZVJhcmVOb25Jbmhlcml0ZWREYXRhLmgKQEAgLTE3MCwxMCArMTcw LDEwIEBAIHB1YmxpYzoKICAgICB1bnNpZ25lZCBtX3dyYXBGbG93OiAzOyAvLyBXcmFwRmxvdwog ICAgIHVuc2lnbmVkIG1fd3JhcFRocm91Z2g6IDE7IC8vIFdyYXBUaHJvdWdoCiAKLSAgICBib29s IG1faGFzQXNwZWN0UmF0aW8gOiAxOyAvLyBXaGV0aGVyIG9yIG5vdCBhbiBhc3BlY3QgcmF0aW8g aGFzIGJlZW4gc3BlY2lmaWVkLgogI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKLSAg ICBib29sIG1fcnVubmluZ0FjY2VsZXJhdGVkQW5pbWF0aW9uIDogMTsKKyAgICB1bnNpZ25lZCBt X3J1bm5pbmdBY2NlbGVyYXRlZEFuaW1hdGlvbiA6IDE7CiAjZW5kaWYKKyAgICB1bnNpZ25lZCBt X2hhc0FzcGVjdFJhdGlvIDogMTsgLy8gV2hldGhlciBvciBub3QgYW4gYXNwZWN0IHJhdGlvIGhh cyBiZWVuIHNwZWNpZmllZC4KIAogcHJpdmF0ZToKICAgICBTdHlsZVJhcmVOb25Jbmhlcml0ZWRE YXRhKCk7Cg==