87309 2012-05-23 13:52:30 -0700 Refactor SVGAnimateTransformElement to avoid expensive determineAnimatedPropertyType call 2012-05-24 08:30:28 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Trivial --- 1 pdr pdr schenney webkit.review.bot zimmermann oldest_to_newest 632011 0 pdr 2012-05-23 13:52:30 -0700 This is a minor refactor of SVGAnimateTransformElement::hasValidAttributeType() to use m_animatedPropertyType instead of computing it on the fly. This same optimization was done in https://bugs.webkit.org/show_bug.cgi?id=75096 for SVGAnimateElement. Patch forthcoming. 632037 1 143646 pdr 2012-05-23 14:05:32 -0700 Created attachment 143646 Avoid expensive determineAnimatedPropertyType call 632042 2 143648 pdr 2012-05-23 14:07:15 -0700 Created attachment 143648 Fixed changelog 632455 3 143648 zimmermann 2012-05-23 23:44:30 -0700 Comment on attachment 143648 Fixed changelog Good idea, r=me! 632826 4 143648 webkit.review.bot 2012-05-24 08:30:24 -0700 Comment on attachment 143648 Fixed changelog Clearing flags on attachment: 143648 Committed r118379: <http://trac.webkit.org/changeset/118379> 632827 5 webkit.review.bot 2012-05-24 08:30:28 -0700 All reviewed patches have been landed. Closing bug. 143646 2012-05-23 14:05:32 -0700 2012-05-23 14:07:15 -0700 Avoid expensive determineAnimatedPropertyType call 87309.1.patch text/plain 2471 pdr SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExODI0MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA1LTIzICBQaGlsaXAg Um9nZXJzICA8cGRyQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmVmYWN0b3IgU1ZHQW5pbWF0ZVRy YW5zZm9ybUVsZW1lbnQgdG8gYXZvaWQgZXhwZW5zaXZlIGRldGVybWluZUFuaW1hdGVkUHJvcGVy dHlUeXBlIGNhbGwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTg3MzA5CisKKyAgICAgICAgVGhpcyBpcyBhIHNpbXBsZSByZWZhY3RvciB0aGF0IG1hdGNo ZXMgdGhlIHdvcmsgZG9uZSBpbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODczMDkgdG8gYXZvaWQgYW4gZXhwZW5zaXZlIGNhbGwuCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBh Y3R1YWwgZWZmZWN0cyBiZXlvbmQgcGVyZm9ybWFuY2UgaW1wcm92ZW1lbnQuCisKKyAgICAgICAg KiBzdmcvU1ZHQW5pbWF0ZUVsZW1lbnQuaDoKKyAgICAgICAgKFNWR0FuaW1hdGVFbGVtZW50KToK KyAgICAgICAgKiBzdmcvU1ZHQW5pbWF0ZVRyYW5zZm9ybUVsZW1lbnQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6U1ZHQW5pbWF0ZVRyYW5zZm9ybUVsZW1lbnQ6Omhhc1ZhbGlkQXR0cmlidXRlVHlw ZSk6CisKIDIwMTItMDUtMjMgIEFiaGlzaGVrIEFyeWEgIDxpbmZlcm5vQGNocm9taXVtLm9yZz4K IAogICAgICAgICBBU1NFUlQgZmFpbHVyZSB0b1JlbmRlclByb2dyZXNzIGluIEhUTUxQcm9ncmVz c0VsZW1lbnQ6OmRpZEVsZW1lbnRTdGF0ZUNoYW5nZQpJbmRleDogU291cmNlL1dlYkNvcmUvc3Zn L1NWR0FuaW1hdGVFbGVtZW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvc3ZnL1NW R0FuaW1hdGVFbGVtZW50LmgJKHJldmlzaW9uIDExODE2NCkKKysrIFNvdXJjZS9XZWJDb3JlL3N2 Zy9TVkdBbmltYXRlRWxlbWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC01NSwxMSArNTUsMTIgQEAg cHJvdGVjdGVkOgogCiAgICAgdmlydHVhbCB2b2lkIHRhcmdldEVsZW1lbnRXaWxsQ2hhbmdlKFNW R0VsZW1lbnQqIGN1cnJlbnRUYXJnZXQsIFNWR0VsZW1lbnQqIG9sZFRhcmdldCkgT1ZFUlJJREU7 CiAKKyAgICBBbmltYXRlZFByb3BlcnR5VHlwZSBtX2FuaW1hdGVkUHJvcGVydHlUeXBlOworCiBw cml2YXRlOgogICAgIFNWR0FuaW1hdGVkVHlwZUFuaW1hdG9yKiBlbnN1cmVBbmltYXRvcigpOwog CiAgICAgdmlydHVhbCBib29sIGhhc1ZhbGlkQXR0cmlidXRlVHlwZSgpOwotICAgIEFuaW1hdGVk UHJvcGVydHlUeXBlIG1fYW5pbWF0ZWRQcm9wZXJ0eVR5cGU7CiAKICAgICBPd25QdHI8U1ZHQW5p bWF0ZWRUeXBlPiBtX2Zyb21UeXBlOwogICAgIE93blB0cjxTVkdBbmltYXRlZFR5cGU+IG1fdG9U eXBlOwpJbmRleDogU291cmNlL1dlYkNvcmUvc3ZnL1NWR0FuaW1hdGVUcmFuc2Zvcm1FbGVtZW50 LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9zdmcvU1ZHQW5pbWF0ZVRyYW5zZm9y bUVsZW1lbnQuY3BwCShyZXZpc2lvbiAxMTgxNjQpCisrKyBTb3VyY2UvV2ViQ29yZS9zdmcvU1ZH QW5pbWF0ZVRyYW5zZm9ybUVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NSw5ICs0NSwx MSBAQCBQYXNzUmVmUHRyPFNWR0FuaW1hdGVUcmFuc2Zvcm1FbGVtZW50PiBTCiAKIGJvb2wgU1ZH QW5pbWF0ZVRyYW5zZm9ybUVsZW1lbnQ6Omhhc1ZhbGlkQXR0cmlidXRlVHlwZSgpCiB7Ci0gICAg aWYgKFNWR0VsZW1lbnQqIHRhcmdldEVsZW1lbnQgPSB0aGlzLT50YXJnZXRFbGVtZW50KCkpCi0g ICAgICAgIHJldHVybiBkZXRlcm1pbmVBbmltYXRlZFByb3BlcnR5VHlwZSh0YXJnZXRFbGVtZW50 KSA9PSBBbmltYXRlZFRyYW5zZm9ybUxpc3Q7Ci0gICAgcmV0dXJuIGZhbHNlOworICAgIFNWR0Vs ZW1lbnQqIHRhcmdldEVsZW1lbnQgPSB0aGlzLT50YXJnZXRFbGVtZW50KCk7CisgICAgaWYgKCF0 YXJnZXRFbGVtZW50KQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICByZXR1cm4gbV9hbmlt YXRlZFByb3BlcnR5VHlwZSA9PSBBbmltYXRlZFRyYW5zZm9ybUxpc3Q7CiB9CiAKIGJvb2wgU1ZH QW5pbWF0ZVRyYW5zZm9ybUVsZW1lbnQ6OmlzU3VwcG9ydGVkQXR0cmlidXRlKGNvbnN0IFF1YWxp ZmllZE5hbWUmIGF0dHJOYW1lKQo= 143648 2012-05-23 14:07:15 -0700 2012-05-24 08:30:24 -0700 Fixed changelog 87309.1.patch text/plain 2471 pdr SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExODI0MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA1LTIzICBQaGlsaXAg Um9nZXJzICA8cGRyQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmVmYWN0b3IgU1ZHQW5pbWF0ZVRy YW5zZm9ybUVsZW1lbnQgdG8gYXZvaWQgZXhwZW5zaXZlIGRldGVybWluZUFuaW1hdGVkUHJvcGVy dHlUeXBlIGNhbGwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTg3MzA5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGhpcyBpcyBhIHNpbXBsZSByZWZhY3RvciB0aGF0IG1hdGNoZXMgdGhlIHdvcmsgZG9uZSBp bgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODczMDkg dG8gYXZvaWQgYW4gZXhwZW5zaXZlIGNhbGwuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBh Y3R1YWwgZWZmZWN0cyBiZXlvbmQgcGVyZm9ybWFuY2UgaW1wcm92ZW1lbnQuCisKKyAgICAgICAg KiBzdmcvU1ZHQW5pbWF0ZUVsZW1lbnQuaDoKKyAgICAgICAgKFNWR0FuaW1hdGVFbGVtZW50KToK KyAgICAgICAgKiBzdmcvU1ZHQW5pbWF0ZVRyYW5zZm9ybUVsZW1lbnQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6U1ZHQW5pbWF0ZVRyYW5zZm9ybUVsZW1lbnQ6Omhhc1ZhbGlkQXR0cmlidXRlVHlw ZSk6CisKIDIwMTItMDUtMjMgIEFiaGlzaGVrIEFyeWEgIDxpbmZlcm5vQGNocm9taXVtLm9yZz4K IAogICAgICAgICBBU1NFUlQgZmFpbHVyZSB0b1JlbmRlclByb2dyZXNzIGluIEhUTUxQcm9ncmVz c0VsZW1lbnQ6OmRpZEVsZW1lbnRTdGF0ZUNoYW5nZQpJbmRleDogU291cmNlL1dlYkNvcmUvc3Zn L1NWR0FuaW1hdGVFbGVtZW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvc3ZnL1NW R0FuaW1hdGVFbGVtZW50LmgJKHJldmlzaW9uIDExODE2NCkKKysrIFNvdXJjZS9XZWJDb3JlL3N2 Zy9TVkdBbmltYXRlRWxlbWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC01NSwxMSArNTUsMTIgQEAg cHJvdGVjdGVkOgogCiAgICAgdmlydHVhbCB2b2lkIHRhcmdldEVsZW1lbnRXaWxsQ2hhbmdlKFNW R0VsZW1lbnQqIGN1cnJlbnRUYXJnZXQsIFNWR0VsZW1lbnQqIG9sZFRhcmdldCkgT1ZFUlJJREU7 CiAKKyAgICBBbmltYXRlZFByb3BlcnR5VHlwZSBtX2FuaW1hdGVkUHJvcGVydHlUeXBlOworCiBw cml2YXRlOgogICAgIFNWR0FuaW1hdGVkVHlwZUFuaW1hdG9yKiBlbnN1cmVBbmltYXRvcigpOwog CiAgICAgdmlydHVhbCBib29sIGhhc1ZhbGlkQXR0cmlidXRlVHlwZSgpOwotICAgIEFuaW1hdGVk UHJvcGVydHlUeXBlIG1fYW5pbWF0ZWRQcm9wZXJ0eVR5cGU7CiAKICAgICBPd25QdHI8U1ZHQW5p bWF0ZWRUeXBlPiBtX2Zyb21UeXBlOwogICAgIE93blB0cjxTVkdBbmltYXRlZFR5cGU+IG1fdG9U eXBlOwpJbmRleDogU291cmNlL1dlYkNvcmUvc3ZnL1NWR0FuaW1hdGVUcmFuc2Zvcm1FbGVtZW50 LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9zdmcvU1ZHQW5pbWF0ZVRyYW5zZm9y bUVsZW1lbnQuY3BwCShyZXZpc2lvbiAxMTgxNjQpCisrKyBTb3VyY2UvV2ViQ29yZS9zdmcvU1ZH QW5pbWF0ZVRyYW5zZm9ybUVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NSw5ICs0NSwx MSBAQCBQYXNzUmVmUHRyPFNWR0FuaW1hdGVUcmFuc2Zvcm1FbGVtZW50PiBTCiAKIGJvb2wgU1ZH QW5pbWF0ZVRyYW5zZm9ybUVsZW1lbnQ6Omhhc1ZhbGlkQXR0cmlidXRlVHlwZSgpCiB7Ci0gICAg aWYgKFNWR0VsZW1lbnQqIHRhcmdldEVsZW1lbnQgPSB0aGlzLT50YXJnZXRFbGVtZW50KCkpCi0g ICAgICAgIHJldHVybiBkZXRlcm1pbmVBbmltYXRlZFByb3BlcnR5VHlwZSh0YXJnZXRFbGVtZW50 KSA9PSBBbmltYXRlZFRyYW5zZm9ybUxpc3Q7Ci0gICAgcmV0dXJuIGZhbHNlOworICAgIFNWR0Vs ZW1lbnQqIHRhcmdldEVsZW1lbnQgPSB0aGlzLT50YXJnZXRFbGVtZW50KCk7CisgICAgaWYgKCF0 YXJnZXRFbGVtZW50KQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICByZXR1cm4gbV9hbmlt YXRlZFByb3BlcnR5VHlwZSA9PSBBbmltYXRlZFRyYW5zZm9ybUxpc3Q7CiB9CiAKIGJvb2wgU1ZH QW5pbWF0ZVRyYW5zZm9ybUVsZW1lbnQ6OmlzU3VwcG9ydGVkQXR0cmlidXRlKGNvbnN0IFF1YWxp ZmllZE5hbWUmIGF0dHJOYW1lKQo=