87295 2012-05-23 11:54:48 -0700 [EFL] Update test expectations for layout test fast/events/click-focus-control.html 2012-05-29 12:16:31 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 alexander.shalamov alexander.shalamov gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 631872 0 alexander.shalamov 2012-05-23 11:54:48 -0700 Form control elements are mouse focusable only in QT and GTK ports. Test expectation for EFL port need to be updated. 631890 1 143613 alexander.shalamov 2012-05-23 12:15:29 -0700 Created attachment 143613 Patch updated test expectations unskipped failing test case 631909 2 143613 rakuco 2012-05-23 12:36:07 -0700 Comment on attachment 143613 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143613&action=review > LayoutTests/ChangeLog:8 > + Added platform specific test expectation. Nit: This is redundant, since there's a line saying "Added" below. > LayoutTests/ChangeLog:9 > + Unskip passing test. Nit: This could be moved to the line related to Skipped below. > LayoutTests/platform/efl/fast/events/click-focus-control-expected.txt:8 > +FAIL Some form elements didn't get focus Have you verified this failure is expected for the port? It'd be good to explain in the ChangeLog why. 632433 3 143735 alexander.shalamov 2012-05-23 22:47:14 -0700 Created attachment 143735 Patch Made changes according to review comments 632435 4 alexander.shalamov 2012-05-23 22:51:36 -0700 (In reply to comment #2) > Have you verified this failure is expected for the port? It'd be good to explain in the ChangeLog why. bool HTMLFormControlElement::isMouseFocusable() const { #if PLATFORM(GTK) || PLATFORM(QT) return HTMLElement::isMouseFocusable(); #else return false; #endif } and bool HTMLInputElement::isMouseFocusable() const { if (isTextField()) return HTMLTextFormControlElement::isFocusable(); return HTMLTextFormControlElement::isMouseFocusable(); } If form control element is not a text field, it won't be focusable. Only GTK and QT ports support that. 632859 5 143735 eric 2012-05-24 09:07:57 -0700 Comment on attachment 143735 Patch OK. 632903 6 143735 webkit.review.bot 2012-05-24 10:17:22 -0700 Comment on attachment 143735 Patch Clearing flags on attachment: 143735 Committed r118388: <http://trac.webkit.org/changeset/118388> 632905 7 webkit.review.bot 2012-05-24 10:17:27 -0700 All reviewed patches have been landed. Closing bug. 143613 2012-05-23 12:15:29 -0700 2012-05-23 22:47:14 -0700 Patch efl_87295_update_test_expectations.patch text/plain 1734 alexander.shalamov ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkNTQ2OGU0Li5lNTM0YjJkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDUt MjMgIEFsZXhhbmRlciBTaGFsYW1vdiAgPGFsZXhhbmRlci5zaGFsYW1vdkBpbnRlbC5jb20+CisK KyAgICAgICAgW0VGTF0gVXBkYXRlIHRlc3QgZXhwZWN0YXRpb25zIGZvciBsYXlvdXQgdGVzdCBm YXN0L2V2ZW50cy9jbGljay1mb2N1cy1jb250cm9sLmh0bWwKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3Mjk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgcGxhdGZvcm0gc3BlY2lmaWMgdGVzdCBl eHBlY3RhdGlvbi4KKyAgICAgICAgVW5za2lwIHBhc3NpbmcgdGVzdC4KKworICAgICAgICAqIHBs YXRmb3JtL2VmbC9Ta2lwcGVkOgorICAgICAgICAqIHBsYXRmb3JtL2VmbC9mYXN0L2V2ZW50cy9j bGljay1mb2N1cy1jb250cm9sLWV4cGVjdGVkLnR4dDogQWRkZWQuCisKIDIwMTItMDUtMjMgIEFs aWNlIEJveGhhbGwgIDxhYm94aGFsbEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQVg6IENvbnRl bnRlZGl0YWJsZSB0YWJsZXMgc2hvdWxkIGFsd2F5cyBiZSBleHBvc2VkIGFzIGRhdGEgdGFibGVz CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvU2tpcHBlZCBiL0xheW91dFRl c3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVkCmluZGV4IDRlMDlkYzYuLjFkZTQ4ZWIgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3Bs YXRmb3JtL2VmbC9Ta2lwcGVkCkBAIC02NDUsNyArNjQ1LDYgQEAgZmFzdC9ldmVudHMvYXR0ZW1w dC1zY3JvbGwtd2l0aC1uby1zY3JvbGxiYXJzLmh0bWwKIGZhc3QvZXZlbnRzL2NsaWNrLWZvY3Vz LWFuY2hvci5odG1sCiAKICMgQlVHOiBmb2N1cyBidWdzCi1mYXN0L2V2ZW50cy9jbGljay1mb2N1 cy1jb250cm9sLmh0bWwKIGZhc3QvZXZlbnRzL2ZyYW1lLXRhYi1mb2N1cy5odG1sCiBmYXN0L2Zv cm1zL2ZvY3VzMi5odG1sCiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9m YXN0L2V2ZW50cy9jbGljay1mb2N1cy1jb250cm9sLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3Rz L3BsYXRmb3JtL2VmbC9mYXN0L2V2ZW50cy9jbGljay1mb2N1cy1jb250cm9sLWV4cGVjdGVkLnR4 dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi4xYThjYjc5Ci0tLSAvZGV2L251 bGwKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL2Zhc3QvZXZlbnRzL2NsaWNrLWZvY3Vz LWNvbnRyb2wtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsOSBAQAorVGhpcyB0ZXN0IGVuc3VyZXMg dGhhdCB3ZSBjYW4gY2xpY2sgdG8gZm9jdXMgYW4gYSBlbGVtZW50LiBDbGljayBvbiB0aGUgZWxl bWVudCBiZWxvdy4KKworVGhlIGV4cGVjdGVkIHJlc3VsdCBpcyBwbGF0Zm9ybSBzcGVjaWZpYy4g TWFjIGRvZXNuJ3QgYWxsb3cgc29tZSBmb3JtIGNvbnRyb2xzIHRvIGJlIG1vdXNlIGZvY3VzYWJs ZS4KKworUmVzdWx0CisKK2E0IHJlY2VpdmVkIGZvY3VzICgpCitGQUlMIFNvbWUgZm9ybSBlbGVt ZW50cyBkaWRuJ3QgZ2V0IGZvY3VzCisK 143735 2012-05-23 22:47:14 -0700 2012-05-29 12:16:31 -0700 Patch efl_87295_update_test_expectations_v2.patch text/plain 1721 alexander.shalamov ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkNTQ2OGU0Li41ZmM2Njk2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDUt MjMgIEFsZXhhbmRlciBTaGFsYW1vdiAgPGFsZXhhbmRlci5zaGFsYW1vdkBpbnRlbC5jb20+CisK KyAgICAgICAgW0VGTF0gVXBkYXRlIHRlc3QgZXhwZWN0YXRpb25zIGZvciBsYXlvdXQgdGVzdCBm YXN0L2V2ZW50cy9jbGljay1mb2N1cy1jb250cm9sLmh0bWwKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3Mjk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSFRNTEZvcm1Db250cm9sRWxlbWVudCBpcyBub3Qg bW91c2UgZm9jdXNhYmxlIGluIEVGTCBwb3J0LgorCisgICAgICAgICogcGxhdGZvcm0vZWZsL1Nr aXBwZWQ6CisgICAgICAgICogcGxhdGZvcm0vZWZsL2Zhc3QvZXZlbnRzL2NsaWNrLWZvY3VzLWNv bnRyb2wtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKwogMjAxMi0wNS0yMyAgQWxpY2UgQm94aGFsbCAg PGFib3hoYWxsQGNocm9taXVtLm9yZz4KIAogICAgICAgICBBWDogQ29udGVudGVkaXRhYmxlIHRh YmxlcyBzaG91bGQgYWx3YXlzIGJlIGV4cG9zZWQgYXMgZGF0YSB0YWJsZXMKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v ZWZsL1NraXBwZWQKaW5kZXggNGUwOWRjNi4uMWRlNDhlYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvcGxhdGZvcm0vZWZsL1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1Nr aXBwZWQKQEAgLTY0NSw3ICs2NDUsNiBAQCBmYXN0L2V2ZW50cy9hdHRlbXB0LXNjcm9sbC13aXRo LW5vLXNjcm9sbGJhcnMuaHRtbAogZmFzdC9ldmVudHMvY2xpY2stZm9jdXMtYW5jaG9yLmh0bWwK IAogIyBCVUc6IGZvY3VzIGJ1Z3MKLWZhc3QvZXZlbnRzL2NsaWNrLWZvY3VzLWNvbnRyb2wuaHRt bAogZmFzdC9ldmVudHMvZnJhbWUtdGFiLWZvY3VzLmh0bWwKIGZhc3QvZm9ybXMvZm9jdXMyLmh0 bWwKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL2Zhc3QvZXZlbnRzL2Ns aWNrLWZvY3VzLWNvbnRyb2wtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZs L2Zhc3QvZXZlbnRzL2NsaWNrLWZvY3VzLWNvbnRyb2wtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjFhOGNiNzkKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9lZmwvZmFzdC9ldmVudHMvY2xpY2stZm9jdXMtY29udHJvbC1leHBl Y3RlZC50eHQKQEAgLTAsMCArMSw5IEBACitUaGlzIHRlc3QgZW5zdXJlcyB0aGF0IHdlIGNhbiBj bGljayB0byBmb2N1cyBhbiBhIGVsZW1lbnQuIENsaWNrIG9uIHRoZSBlbGVtZW50IGJlbG93Lgor CitUaGUgZXhwZWN0ZWQgcmVzdWx0IGlzIHBsYXRmb3JtIHNwZWNpZmljLiBNYWMgZG9lc24ndCBh bGxvdyBzb21lIGZvcm0gY29udHJvbHMgdG8gYmUgbW91c2UgZm9jdXNhYmxlLgorCitSZXN1bHQK KworYTQgcmVjZWl2ZWQgZm9jdXMgKCkKK0ZBSUwgU29tZSBmb3JtIGVsZW1lbnRzIGRpZG4ndCBn ZXQgZm9jdXMKKwo=