87290 2012-05-23 11:17:16 -0700 AX: Prevents assertion from potentially dereferencing null pointer. 2012-05-23 17:30:12 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dtseng dtseng cfleizach dmazzoni webkit.review.bot oldest_to_newest 631832 0 dtseng 2012-05-23 11:17:16 -0700 ax: Prevents assertion from potentially dereferencing null pointer. 631834 1 143601 dtseng 2012-05-23 11:21:27 -0700 Created attachment 143601 Patch 631838 2 webkit.review.bot 2012-05-23 11:24:02 -0700 Attachment 143601 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 631863 3 143601 cfleizach 2012-05-23 11:48:06 -0700 Comment on attachment 143601 Patch fix style issue, otherwise looks ok Also the title of the bug should be capital "AX" not lowercase 631867 4 143607 dtseng 2012-05-23 11:51:03 -0700 Created attachment 143607 Patch 631886 5 cfleizach 2012-05-23 12:10:58 -0700 (In reply to comment #4) > Created an attachment (id=143607) [details] > Patch title of bug should be uppercase AX 632108 6 143662 dtseng 2012-05-23 15:23:39 -0700 Created attachment 143662 Patch 632111 7 143662 cfleizach 2012-05-23 15:24:15 -0700 Comment on attachment 143662 Patch looks good. i assume you want CQ too 632245 8 143662 webkit.review.bot 2012-05-23 17:30:07 -0700 Comment on attachment 143662 Patch Clearing flags on attachment: 143662 Committed r118281: <http://trac.webkit.org/changeset/118281> 632246 9 webkit.review.bot 2012-05-23 17:30:12 -0700 All reviewed patches have been landed. Closing bug. 143601 2012-05-23 11:21:27 -0700 2012-05-23 11:51:00 -0700 Patch bug-87290-20120523112225.patch text/plain 2062 dtseng SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExODIwNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA1LTIzICBEYXZpZCBU c2VuZyAgPGR0c2VuZ0Bnb29nbGUuY29tPgorCisgICAgICAgIGF4OiBQcmV2ZW50cyBhc3NlcnRp b24gZnJvbSBwb3RlbnRpYWxseSBkZXJlZmVyZW5jaW5nIG51bGwgcG9pbnRlci4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3MjkwCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiAoT09Q UyEpCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlUYWJsZS5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5VGFibGU6OmNlbGxGb3JDb2x1bW5BbmRSb3cp OgorCiAyMDEyLTA1LTIzICBSb2JpbiBEdW5uICA8cm9iaW5AYWxsZHVubi5jb20+CiAKICAgICAg ICAgW3d4XSBJbXBsZW1lbnQgdHJhbnNwYXJlbmN5IGxheWVyIHN1cHBvcnQuCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlUYWJsZS5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5VGFibGUuY3Bw CShyZXZpc2lvbiAxMTYzNTQpCisrKyBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vz c2liaWxpdHlUYWJsZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUwMCw3ICs1MDAsNyBAQCBBY2Nl c3NpYmlsaXR5VGFibGVDZWxsKiBBY2Nlc3NpYmlsaXR5VGFiCiAgICAgICAgICAgICAgICAgZm9y IChpbnQgdGVzdFJvdyA9IHNlY3Rpb25TcGVjaWZpY1JvdyAtIDE7IHRlc3RSb3cgPj0gMDsgLS10 ZXN0Um93KSB7CiAgICAgICAgICAgICAgICAgICAgIGNlbGwgPSB0YWJsZVNlY3Rpb24tPnByaW1h cnlDZWxsQXQodGVzdFJvdywgY29sdW1uKTsKICAgICAgICAgICAgICAgICAgICAgLy8gY2VsbCBv dmVybGFwcGVkLiB1c2UgdGhpcyBvbmUKLSAgICAgICAgICAgICAgICAgICAgQVNTRVJUKGNlbGwt PnJvd1NwYW4oKSA+PSAxKTsKKyAgICAgICAgICAgICAgICAgICAgQVNTRVJUKCFjZWxsIHx8IGNl bGwtPnJvd1NwYW4oKSA+PSAxKTsKICAgICAgICAgICAgICAgICAgICAgaWYgKGNlbGwgJiYgKChj ZWxsLT5yb3dJbmRleCgpICsgKGNlbGwtPnJvd1NwYW4oKSAtIDEpKSA+PSBzZWN0aW9uU3BlY2lm aWNSb3cpKQogICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICAgICAg ICAgIGNlbGwgPSAwOwpAQCAtNTExLDcgKzUxMSw3IEBAIEFjY2Vzc2liaWxpdHlUYWJsZUNlbGwq IEFjY2Vzc2liaWxpdHlUYWIKICAgICAgICAgICAgICAgICAgICAgZm9yIChpbnQgdGVzdENvbCA9 IGNvbHVtbiAtIDE7IHRlc3RDb2wgPj0gMDsgLS10ZXN0Q29sKSB7CiAgICAgICAgICAgICAgICAg ICAgICAgICBjZWxsID0gdGFibGVTZWN0aW9uLT5wcmltYXJ5Q2VsbEF0KHNlY3Rpb25TcGVjaWZp Y1JvdywgdGVzdENvbCk7CiAgICAgICAgICAgICAgICAgICAgICAgICAvLyBjZWxsIG92ZXJsYXBw ZWQuIHVzZSB0aGlzIG9uZQotICAgICAgICAgICAgICAgICAgICAgICAgQVNTRVJUKGNlbGwtPnJv d1NwYW4oKSA+PSAxKTsKKyAgICAgICAgICAgICAgICAgICAgICAgIEFTU0VSVCghY2VsbCB8fCBj ZWxsLT5yb3dTcGFuKCkgPj0gMSk7CiAgICAgICAgICAgICAgICAgICAgICAgICBpZiAoY2VsbCAm JiAoKGNlbGwtPmNvbCgpICsgKGNlbGwtPmNvbFNwYW4oKSAtIDEpKSA+PSBjb2x1bW4pKQogICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgICAgICAgICAgICAg Y2VsbCA9IDA7Cg== 143607 2012-05-23 11:51:03 -0700 2012-05-23 15:23:36 -0700 Patch bug-87290-20120523115202.patch text/plain 2091 dtseng SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExODIwNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA1LTIzICBEYXZpZCBU c2VuZyAgPGR0c2VuZ0Bnb29nbGUuY29tPgorCisgICAgICAgIGF4OiBQcmV2ZW50cyBhc3NlcnRp b24gZnJvbSBwb3RlbnRpYWxseSBkZXJlZmVyZW5jaW5nIG51bGwgcG9pbnRlci4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3MjkwCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdlcyB0byBhc3NlcnRp b25zLiBDb3ZlcmFnZSBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIGFjY2Vzc2liaWxp dHkvQWNjZXNzaWJpbGl0eVRhYmxlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxp dHlUYWJsZTo6Y2VsbEZvckNvbHVtbkFuZFJvdyk6CisKIDIwMTItMDUtMjMgIFJvYmluIER1bm4g IDxyb2JpbkBhbGxkdW5uLmNvbT4KIAogICAgICAgICBbd3hdIEltcGxlbWVudCB0cmFuc3BhcmVu Y3kgbGF5ZXIgc3VwcG9ydC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNj ZXNzaWJpbGl0eVRhYmxlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9hY2Nlc3Np YmlsaXR5L0FjY2Vzc2liaWxpdHlUYWJsZS5jcHAJKHJldmlzaW9uIDExNjM1NCkKKysrIFNvdXJj ZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVRhYmxlLmNwcAkod29ya2luZyBj b3B5KQpAQCAtNTAwLDcgKzUwMCw3IEBAIEFjY2Vzc2liaWxpdHlUYWJsZUNlbGwqIEFjY2Vzc2li aWxpdHlUYWIKICAgICAgICAgICAgICAgICBmb3IgKGludCB0ZXN0Um93ID0gc2VjdGlvblNwZWNp ZmljUm93IC0gMTsgdGVzdFJvdyA+PSAwOyAtLXRlc3RSb3cpIHsKICAgICAgICAgICAgICAgICAg ICAgY2VsbCA9IHRhYmxlU2VjdGlvbi0+cHJpbWFyeUNlbGxBdCh0ZXN0Um93LCBjb2x1bW4pOwog ICAgICAgICAgICAgICAgICAgICAvLyBjZWxsIG92ZXJsYXBwZWQuIHVzZSB0aGlzIG9uZQotICAg ICAgICAgICAgICAgICAgICBBU1NFUlQoY2VsbC0+cm93U3BhbigpID49IDEpOworICAgICAgICAg ICAgICAgICAgICBBU1NFUlQoIWNlbGwgfHwgY2VsbC0+cm93U3BhbigpID49IDEpOwogICAgICAg ICAgICAgICAgICAgICBpZiAoY2VsbCAmJiAoKGNlbGwtPnJvd0luZGV4KCkgKyAoY2VsbC0+cm93 U3BhbigpIC0gMSkpID49IHNlY3Rpb25TcGVjaWZpY1JvdykpCiAgICAgICAgICAgICAgICAgICAg ICAgICBicmVhazsKICAgICAgICAgICAgICAgICAgICAgY2VsbCA9IDA7CkBAIC01MTEsNyArNTEx LDcgQEAgQWNjZXNzaWJpbGl0eVRhYmxlQ2VsbCogQWNjZXNzaWJpbGl0eVRhYgogICAgICAgICAg ICAgICAgICAgICBmb3IgKGludCB0ZXN0Q29sID0gY29sdW1uIC0gMTsgdGVzdENvbCA+PSAwOyAt LXRlc3RDb2wpIHsKICAgICAgICAgICAgICAgICAgICAgICAgIGNlbGwgPSB0YWJsZVNlY3Rpb24t PnByaW1hcnlDZWxsQXQoc2VjdGlvblNwZWNpZmljUm93LCB0ZXN0Q29sKTsKICAgICAgICAgICAg ICAgICAgICAgICAgIC8vIGNlbGwgb3ZlcmxhcHBlZC4gdXNlIHRoaXMgb25lCi0gICAgICAgICAg ICAgICAgICAgICAgICBBU1NFUlQoY2VsbC0+cm93U3BhbigpID49IDEpOworICAgICAgICAgICAg ICAgICAgICAgICAgQVNTRVJUKCFjZWxsIHx8IGNlbGwtPnJvd1NwYW4oKSA+PSAxKTsKICAgICAg ICAgICAgICAgICAgICAgICAgIGlmIChjZWxsICYmICgoY2VsbC0+Y29sKCkgKyAoY2VsbC0+Y29s U3BhbigpIC0gMSkpID49IGNvbHVtbikpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYnJl YWs7CiAgICAgICAgICAgICAgICAgICAgICAgICBjZWxsID0gMDsK 143662 2012-05-23 15:23:39 -0700 2012-05-23 17:30:07 -0700 Patch bug-87290-20120523152438.patch text/plain 2091 dtseng SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExODIwNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA1LTIzICBEYXZpZCBU c2VuZyAgPGR0c2VuZ0Bnb29nbGUuY29tPgorCisgICAgICAgIEFYOiBQcmV2ZW50cyBhc3NlcnRp b24gZnJvbSBwb3RlbnRpYWxseSBkZXJlZmVyZW5jaW5nIG51bGwgcG9pbnRlci4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3MjkwCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdlcyB0byBhc3NlcnRp b25zLiBDb3ZlcmFnZSBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIGFjY2Vzc2liaWxp dHkvQWNjZXNzaWJpbGl0eVRhYmxlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxp dHlUYWJsZTo6Y2VsbEZvckNvbHVtbkFuZFJvdyk6CisKIDIwMTItMDUtMjMgIFJvYmluIER1bm4g IDxyb2JpbkBhbGxkdW5uLmNvbT4KIAogICAgICAgICBbd3hdIEltcGxlbWVudCB0cmFuc3BhcmVu Y3kgbGF5ZXIgc3VwcG9ydC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNj ZXNzaWJpbGl0eVRhYmxlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9hY2Nlc3Np YmlsaXR5L0FjY2Vzc2liaWxpdHlUYWJsZS5jcHAJKHJldmlzaW9uIDExNjM1NCkKKysrIFNvdXJj ZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVRhYmxlLmNwcAkod29ya2luZyBj b3B5KQpAQCAtNTAwLDcgKzUwMCw3IEBAIEFjY2Vzc2liaWxpdHlUYWJsZUNlbGwqIEFjY2Vzc2li aWxpdHlUYWIKICAgICAgICAgICAgICAgICBmb3IgKGludCB0ZXN0Um93ID0gc2VjdGlvblNwZWNp ZmljUm93IC0gMTsgdGVzdFJvdyA+PSAwOyAtLXRlc3RSb3cpIHsKICAgICAgICAgICAgICAgICAg ICAgY2VsbCA9IHRhYmxlU2VjdGlvbi0+cHJpbWFyeUNlbGxBdCh0ZXN0Um93LCBjb2x1bW4pOwog ICAgICAgICAgICAgICAgICAgICAvLyBjZWxsIG92ZXJsYXBwZWQuIHVzZSB0aGlzIG9uZQotICAg ICAgICAgICAgICAgICAgICBBU1NFUlQoY2VsbC0+cm93U3BhbigpID49IDEpOworICAgICAgICAg ICAgICAgICAgICBBU1NFUlQoIWNlbGwgfHwgY2VsbC0+cm93U3BhbigpID49IDEpOwogICAgICAg ICAgICAgICAgICAgICBpZiAoY2VsbCAmJiAoKGNlbGwtPnJvd0luZGV4KCkgKyAoY2VsbC0+cm93 U3BhbigpIC0gMSkpID49IHNlY3Rpb25TcGVjaWZpY1JvdykpCiAgICAgICAgICAgICAgICAgICAg ICAgICBicmVhazsKICAgICAgICAgICAgICAgICAgICAgY2VsbCA9IDA7CkBAIC01MTEsNyArNTEx LDcgQEAgQWNjZXNzaWJpbGl0eVRhYmxlQ2VsbCogQWNjZXNzaWJpbGl0eVRhYgogICAgICAgICAg ICAgICAgICAgICBmb3IgKGludCB0ZXN0Q29sID0gY29sdW1uIC0gMTsgdGVzdENvbCA+PSAwOyAt LXRlc3RDb2wpIHsKICAgICAgICAgICAgICAgICAgICAgICAgIGNlbGwgPSB0YWJsZVNlY3Rpb24t PnByaW1hcnlDZWxsQXQoc2VjdGlvblNwZWNpZmljUm93LCB0ZXN0Q29sKTsKICAgICAgICAgICAg ICAgICAgICAgICAgIC8vIGNlbGwgb3ZlcmxhcHBlZC4gdXNlIHRoaXMgb25lCi0gICAgICAgICAg ICAgICAgICAgICAgICBBU1NFUlQoY2VsbC0+cm93U3BhbigpID49IDEpOworICAgICAgICAgICAg ICAgICAgICAgICAgQVNTRVJUKCFjZWxsIHx8IGNlbGwtPnJvd1NwYW4oKSA+PSAxKTsKICAgICAg ICAgICAgICAgICAgICAgICAgIGlmIChjZWxsICYmICgoY2VsbC0+Y29sKCkgKyAoY2VsbC0+Y29s U3BhbigpIC0gMSkpID49IGNvbHVtbikpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYnJl YWs7CiAgICAgICAgICAgICAgICAgICAgICAgICBjZWxsID0gMDsK