87289 2012-05-23 11:12:53 -0700 [BlackBerry] UI thread unnecessarily blocks on WebKit thread when servicing requestAnimationFrames 2012-05-23 13:11:52 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 anlo anlo anilsson tonikitoo webkit.review.bot oldest_to_newest 631826 0 anlo 2012-05-23 11:12:53 -0700 DisplayRefreshMonitor has a mutex to protect m_scheduled and m_previousFrameDone. Those flags are used to signal between the UI thread and WebKit thread. m_scheduled signals when a frame has been requested by WebKit thread. m_previousFrameDone indicates whether the frame change signaled by UI thread has been performed by WebKit thread. Since both UI thread and WebKit thread lock m_mutex, it is possible for the UI thread to block waiting for the WebKit thread. This is unnecessary: if the UI thread cannot immediately lock the mutex, it can deal with those flags on the next animation tick. 631879 1 143609 anlo 2012-05-23 12:00:06 -0700 Created attachment 143609 Patch 631951 2 143609 webkit.review.bot 2012-05-23 13:11:47 -0700 Comment on attachment 143609 Patch Clearing flags on attachment: 143609 Committed r118230: <http://trac.webkit.org/changeset/118230> 631952 3 webkit.review.bot 2012-05-23 13:11:52 -0700 All reviewed patches have been landed. Closing bug. 143609 2012-05-23 12:00:06 -0700 2012-05-23 13:11:47 -0700 Patch bug-87289-20120523150037.patch text/plain 2014 anlo U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4MjA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTIzZmQ4MmYzNjM0NDAz ZTk2ZjRhMWQ4ODY1YmFmZDNkNWY4NjFjNS4uOGIyOWNmYTRjOTgyOTQyMzYzZWViNjkwMGRhYmEz ZjhiNjk4MGQ4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA1LTIzICBBbmRy ZXcgTG8gIDxhbmxvQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIFVJIHRocmVhZCB1 bm5lY2Vzc2FyaWx5IGJsb2NrcyBvbiBXZWJLaXQgdGhyZWFkIHdoZW4gc2VydmljaW5nIHJlcXVl c3RBbmltYXRpb25GcmFtZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTg3Mjg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgcmVxdWVzdEFuaW1hdGlvbkZyYW1lIGFscmVhZHkgY292ZXJlZCBieSB0ZXN0cyBp biBMYXlvdXRUZXN0cy9mYXN0L2FuaW1hdGlvbi4KKworICAgICAgICBJZiBVSSB0aHJlYWQgY2Fu bm90IGFjcXVpcmUgRGlzcGxheVJlZnJlc2hNb25pdG9yIG11dGV4IGltbWVkaWF0ZWx5LAorICAg ICAgICBhdm9pZCBibG9ja2luZyBvbiB0aGUgbXV0ZXgsIGl0IGNhbiB0cmlnZ2VyIHRoZSBmcmFt ZSBjaGFuZ2Ugb24gdGhlIG5leHQKKyAgICAgICAgYW5pbWF0aW9uIHRpY2sgaW5zdGVhZC4KKwor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvRGlzcGxheVJlZnJlc2hNb25p dG9yQmxhY2tCZXJyeS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEaXNwbGF5UmVmcmVzaE1vbml0 b3I6OmRpc3BsYXlMaW5rRmlyZWQpOgorCiAyMDEyLTA1LTIzICBSb2JpbiBEdW5uICA8cm9iaW5A YWxsZHVubi5jb20+CiAKICAgICAgICAgW3d4XSBJbXBsZW1lbnQgdHJhbnNwYXJlbmN5IGxheWVy IHN1cHBvcnQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9i bGFja2JlcnJ5L0Rpc3BsYXlSZWZyZXNoTW9uaXRvckJsYWNrQmVycnkuY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9EaXNwbGF5UmVmcmVzaE1vbml0b3JC bGFja0JlcnJ5LmNwcAppbmRleCA0NTkyNjhkOGU3NjMzOTE4MDlmODQ3YWZjNTY1OGY3YjYxOTQz NTU4Li4xOWQyNjczZDY3NTMxMDcyYjFmNjg4ODNiMzExMTliZTRlYmNhM2ZiIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0Rpc3BsYXlSZWZy ZXNoTW9uaXRvckJsYWNrQmVycnkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2JsYWNrYmVycnkvRGlzcGxheVJlZnJlc2hNb25pdG9yQmxhY2tCZXJyeS5jcHAKQEAg LTc0LDE2ICs3NCwyMCBAQCBib29sIERpc3BsYXlSZWZyZXNoTW9uaXRvcjo6cmVxdWVzdFJlZnJl c2hDYWxsYmFjaygpCiAKIHZvaWQgRGlzcGxheVJlZnJlc2hNb25pdG9yOjpkaXNwbGF5TGlua0Zp cmVkKCkKIHsKLSAgICBNdXRleExvY2tlciBsb2NrKG1fbXV0ZXgpOworICAgIGlmICghbV9tdXRl eC50cnlMb2NrKCkpCisgICAgICAgIHJldHVybjsKIAotICAgIGlmICghbV9zY2hlZHVsZWQgfHwg IW1fcHJldmlvdXNGcmFtZURvbmUpCisgICAgaWYgKCFtX3NjaGVkdWxlZCB8fCAhbV9wcmV2aW91 c0ZyYW1lRG9uZSkgeworICAgICAgICBtX211dGV4LnVubG9jaygpOwogICAgICAgICByZXR1cm47 CisgICAgfQogCiAgICAgbV9wcmV2aW91c0ZyYW1lRG9uZSA9IGZhbHNlOwogCiAgICAgbV90aW1l c3RhbXAgPSBjdXJyZW50VGltZSgpOwogCiAgICAgY2FsbE9uTWFpblRocmVhZChoYW5kbGVEaXNw bGF5UmVmcmVzaGVkTm90aWZpY2F0aW9uT25NYWluVGhyZWFkLCB0aGlzKTsKKyAgICBtX211dGV4 LnVubG9jaygpOwogfQogCiB9Cg==