87248 2012-05-23 04:44:50 -0700 Kill some frivolous null-checking of Element::m_attributeData. 2012-05-23 07:04:53 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling oldest_to_newest 631502 0 kling 2012-05-23 04:44:50 -0700 From the grumpy-old-man department.. 631536 1 143542 kling 2012-05-23 05:21:09 -0700 Created attachment 143542 Patchbox 20 631544 2 143542 koivisto 2012-05-23 05:31:01 -0700 Comment on attachment 143542 Patchbox 20 r=me 631632 3 143542 kling 2012-05-23 07:04:25 -0700 Comment on attachment 143542 Patchbox 20 Clearing flags on attachment: 143542 Committed r118175: <http://trac.webkit.org/changeset/118175> 631634 4 kling 2012-05-23 07:04:53 -0700 All reviewed patches have been landed. Closing bug. 143542 2012-05-23 05:21:09 -0700 2012-05-23 07:04:24 -0700 Patchbox 20 bug-87248.diff text/plain 6364 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwZjM5MDYyLi40ZDc3NWFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjkg QEAKIDIwMTItMDUtMjMgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCisgICAg ICAgIEtpbGwgc29tZSBmcml2b2xvdXMgbnVsbC1jaGVja2luZyBvZiBFbGVtZW50OjptX2F0dHJp YnV0ZURhdGEuCisgICAgICAgIDxodHRwOi8vd2Via2l0Lm9yZy9iLzg3MjQ4PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlcGxhY2UgdW5uZWNlc3Nh cnkgRWxlbWVudDo6bV9hdHRyaWJ1dGVEYXRhIHdpdGggYXNzZXJ0aW9ucyB3aGVyZSBpdCBtYWtl cyBzZW5zZS4KKyAgICAgICAgT3RoZXJzIGFyZSBmbGF0IG91dCByZW1vdmVkIGJlY2F1c2UgaXQg c2hvdWxkIGJlIG9idmlvdXMgZnJvbSBjb250ZXh0IHRoYXQgaXQncyBub24tbnVsbC4KKyAgICAg ICAgRS5nIGlmIGFuIGF0dHJpYnV0ZSBoYXMgY2hhbmdlZCwgd2UncmUgb2J2aW91c2x5IHN0b3Jp bmcgaXQgc29tZXdoZXJlLgorCisgICAgICAgIEFsc28gYWRkZWQgYSBzaG9ydC1jaXJjdWl0IHRv IEVsZW1lbnQ6Om5vcm1hbGl6ZSgpIGlmIHRoZXJlIGFyZSBubyBBdHRyIG9iamVjdHMKKyAgICAg ICAgYXNzb2NpYXRlZCB3aXRoIHRoZSBlbGVtZW50LgorCisgICAgICAgICogZG9tL0VsZW1lbnQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6RWxlbWVudDo6fkVsZW1lbnQpOgorICAgICAgICAoV2Vi Q29yZTo6RWxlbWVudDo6YXR0cmlidXRlQ2hhbmdlZCk6CisgICAgICAgIChXZWJDb3JlOjpFbGVt ZW50OjppbnNlcnRlZEludG8pOgorICAgICAgICAoV2ViQ29yZTo6RWxlbWVudDo6cmVtb3ZlZEZy b20pOgorICAgICAgICAoV2ViQ29yZTo6RWxlbWVudDo6cmVtb3ZlQXR0cmlidXRlTm9kZSk6Cisg ICAgICAgIChXZWJDb3JlOjpFbGVtZW50Ojpub3JtYWxpemVBdHRyaWJ1dGVzKToKKyAgICAgICAg KiBkb20vU3R5bGVkRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTdHlsZWRFbGVtZW50 OjpjbGFzc0F0dHJpYnV0ZUNoYW5nZWQpOgorCisyMDEyLTA1LTIzICBBbmRyZWFzIEtsaW5nICA8 a2xpbmdAd2Via2l0Lm9yZz4KKwogICAgICAgICBMZXQgRWxlbWVudDo6ZGV0YWNoQXR0cmlidXRl KCkgaGFuZGxlIHJlbW92YWwgb2YgdGhlIGF0dHJpYnV0ZS4KICAgICAgICAgPGh0dHA6Ly93ZWJr aXQub3JnL2IvODcyNDI+CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50 LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAppbmRleCBjMDA5ZDFjLi45MTAw OTY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCkBAIC0xMzQsOCArMTM0LDExIEBAIEVsZW1lbnQ6 On5FbGVtZW50KCkKIAogICAgIGlmIChzaGFkb3coKSkKICAgICAgICAgcmFyZURhdGEoKS0+bV9z aGFkb3cuY2xlYXIoKTsKLSAgICBpZiAobV9hdHRyaWJ1dGVEYXRhICYmIGhhc0F0dHJMaXN0KCkp CisKKyAgICBpZiAoaGFzQXR0ckxpc3QoKSkgeworICAgICAgICBBU1NFUlQobV9hdHRyaWJ1dGVE YXRhKTsKICAgICAgICAgbV9hdHRyaWJ1dGVEYXRhLT5kZXRhY2hBdHRyT2JqZWN0c0Zyb21FbGVt ZW50KHRoaXMpOworICAgIH0KIH0KIAogaW5saW5lIEVsZW1lbnRSYXJlRGF0YSogRWxlbWVudDo6 cmFyZURhdGEoKSBjb25zdApAQCAtNjk5LDE0ICs3MDIsMTIgQEAgdm9pZCBFbGVtZW50OjphdHRy aWJ1dGVDaGFuZ2VkKGNvbnN0IEF0dHJpYnV0ZSYgYXR0cmlidXRlKQogICAgIGRvY3VtZW50KCkt PmluY0RPTVRyZWVWZXJzaW9uKCk7CiAKICAgICBpZiAoaXNJZEF0dHJpYnV0ZU5hbWUoYXR0cmli dXRlLm5hbWUoKSkpIHsKLSAgICAgICAgaWYgKGF0dHJpYnV0ZURhdGEoKSkgewotICAgICAgICAg ICAgaWYgKGF0dHJpYnV0ZS5pc051bGwoKSkKLSAgICAgICAgICAgICAgICBhdHRyaWJ1dGVEYXRh KCktPnNldElkRm9yU3R5bGVSZXNvbHV0aW9uKG51bGxBdG9tKTsKLSAgICAgICAgICAgIGVsc2Ug aWYgKGRvY3VtZW50KCktPmluUXVpcmtzTW9kZSgpKQotICAgICAgICAgICAgICAgIGF0dHJpYnV0 ZURhdGEoKS0+c2V0SWRGb3JTdHlsZVJlc29sdXRpb24oYXR0cmlidXRlLnZhbHVlKCkubG93ZXIo KSk7Ci0gICAgICAgICAgICBlbHNlCi0gICAgICAgICAgICAgICAgYXR0cmlidXRlRGF0YSgpLT5z ZXRJZEZvclN0eWxlUmVzb2x1dGlvbihhdHRyaWJ1dGUudmFsdWUoKSk7Ci0gICAgICAgIH0KKyAg ICAgICAgaWYgKGF0dHJpYnV0ZS5pc051bGwoKSkKKyAgICAgICAgICAgIGF0dHJpYnV0ZURhdGEo KS0+c2V0SWRGb3JTdHlsZVJlc29sdXRpb24obnVsbEF0b20pOworICAgICAgICBlbHNlIGlmIChk b2N1bWVudCgpLT5pblF1aXJrc01vZGUoKSkKKyAgICAgICAgICAgIGF0dHJpYnV0ZURhdGEoKS0+ c2V0SWRGb3JTdHlsZVJlc29sdXRpb24oYXR0cmlidXRlLnZhbHVlKCkubG93ZXIoKSk7CisgICAg ICAgIGVsc2UKKyAgICAgICAgICAgIGF0dHJpYnV0ZURhdGEoKS0+c2V0SWRGb3JTdHlsZVJlc29s dXRpb24oYXR0cmlidXRlLnZhbHVlKCkpOwogICAgICAgICBzZXROZWVkc1N0eWxlUmVjYWxjKCk7 CiAgICAgfSBlbHNlIGlmIChhdHRyaWJ1dGUubmFtZSgpID09IEhUTUxOYW1lczo6bmFtZUF0dHIp CiAgICAgICAgIHNldEhhc05hbWUoIWF0dHJpYnV0ZS5pc051bGwoKSk7CkBAIC05MDAsMTggKzkw MSwxMyBAQCBOb2RlOjpJbnNlcnRpb25Ob3RpZmljYXRpb25SZXF1ZXN0IEVsZW1lbnQ6Omluc2Vy dGVkSW50byhOb2RlKiBpbnNlcnRpb25Qb2ludCkKICAgICBpZiAoIWluc2VydGlvblBvaW50LT5p bkRvY3VtZW50KCkpCiAgICAgICAgIHJldHVybiBJbnNlcnRpb25Eb25lOwogCi0gICAgaWYgKG1f YXR0cmlidXRlRGF0YSkgewotICAgICAgICBpZiAoaGFzSUQoKSkgewotICAgICAgICAgICAgQXR0 cmlidXRlKiBpZEl0ZW0gPSBnZXRBdHRyaWJ1dGVJdGVtKGRvY3VtZW50KCktPmlkQXR0cmlidXRl TmFtZSgpKTsKLSAgICAgICAgICAgIGlmIChpZEl0ZW0gJiYgIWlkSXRlbS0+aXNOdWxsKCkpCi0g ICAgICAgICAgICAgICAgdXBkYXRlSWQobnVsbEF0b20sIGlkSXRlbS0+dmFsdWUoKSk7Ci0gICAg ICAgIH0KLSAgICAgICAgaWYgKGhhc05hbWUoKSkgewotICAgICAgICAgICAgQXR0cmlidXRlKiBu YW1lSXRlbSA9IGdldEF0dHJpYnV0ZUl0ZW0oSFRNTE5hbWVzOjpuYW1lQXR0cik7Ci0gICAgICAg ICAgICBpZiAobmFtZUl0ZW0gJiYgIW5hbWVJdGVtLT5pc051bGwoKSkKLSAgICAgICAgICAgICAg ICB1cGRhdGVOYW1lKG51bGxBdG9tLCBuYW1lSXRlbS0+dmFsdWUoKSk7Ci0gICAgICAgIH0KLSAg ICB9CisgICAgY29uc3QgQXRvbWljU3RyaW5nJiBpZFZhbHVlID0gZ2V0SWRBdHRyaWJ1dGUoKTsK KyAgICBpZiAoIWlkVmFsdWUuaXNOdWxsKCkpCisgICAgICAgIHVwZGF0ZUlkKG51bGxBdG9tLCBp ZFZhbHVlKTsKKworICAgIGNvbnN0IEF0b21pY1N0cmluZyYgbmFtZVZhbHVlID0gZ2V0TmFtZUF0 dHJpYnV0ZSgpOworICAgIGlmICghbmFtZVZhbHVlLmlzTnVsbCgpKQorICAgICAgICB1cGRhdGVO YW1lKG51bGxBdG9tLCBuYW1lVmFsdWUpOwogCiAgICAgcmV0dXJuIEluc2VydGlvbkRvbmU7CiB9 CkBAIC05MjYsMTggKzkyMiwxMyBAQCB2b2lkIEVsZW1lbnQ6OnJlbW92ZWRGcm9tKE5vZGUqIGlu c2VydGlvblBvaW50KQogICAgIHNldFNhdmVkTGF5ZXJTY3JvbGxPZmZzZXQoSW50U2l6ZSgpKTsK IAogICAgIGlmIChpbnNlcnRpb25Qb2ludC0+aW5Eb2N1bWVudCgpKSB7Ci0gICAgICAgIGlmICht X2F0dHJpYnV0ZURhdGEpIHsKLSAgICAgICAgICAgIGlmIChoYXNJRCgpKSB7Ci0gICAgICAgICAg ICAgICAgQXR0cmlidXRlKiBpZEl0ZW0gPSBnZXRBdHRyaWJ1dGVJdGVtKGRvY3VtZW50KCktPmlk QXR0cmlidXRlTmFtZSgpKTsKLSAgICAgICAgICAgICAgICBpZiAoaWRJdGVtICYmICFpZEl0ZW0t PmlzTnVsbCgpKQotICAgICAgICAgICAgICAgICAgICB1cGRhdGVJZChpZEl0ZW0tPnZhbHVlKCks IG51bGxBdG9tKTsKLSAgICAgICAgICAgIH0KLSAgICAgICAgICAgIGlmIChoYXNOYW1lKCkpIHsK LSAgICAgICAgICAgICAgICBBdHRyaWJ1dGUqIG5hbWVJdGVtID0gZ2V0QXR0cmlidXRlSXRlbShI VE1MTmFtZXM6Om5hbWVBdHRyKTsKLSAgICAgICAgICAgICAgICBpZiAobmFtZUl0ZW0gJiYgIW5h bWVJdGVtLT5pc051bGwoKSkKLSAgICAgICAgICAgICAgICAgICAgdXBkYXRlTmFtZShuYW1lSXRl bS0+dmFsdWUoKSwgbnVsbEF0b20pOwotICAgICAgICAgICAgfQotICAgICAgICB9CisgICAgICAg IGNvbnN0IEF0b21pY1N0cmluZyYgaWRWYWx1ZSA9IGdldElkQXR0cmlidXRlKCk7CisgICAgICAg IGlmICghaWRWYWx1ZS5pc051bGwoKSkKKyAgICAgICAgICAgIHVwZGF0ZUlkKGlkVmFsdWUsIG51 bGxBdG9tKTsKKworICAgICAgICBjb25zdCBBdG9taWNTdHJpbmcmIG5hbWVWYWx1ZSA9IGdldE5h bWVBdHRyaWJ1dGUoKTsKKyAgICAgICAgaWYgKCFuYW1lVmFsdWUuaXNOdWxsKCkpCisgICAgICAg ICAgICB1cGRhdGVOYW1lKG5hbWVWYWx1ZSwgbnVsbEF0b20pOwogICAgIH0KIAogICAgIENvbnRh aW5lck5vZGU6OnJlbW92ZWRGcm9tKGluc2VydGlvblBvaW50KTsKQEAgLTE0MzQsOCArMTQyNSw3 IEBAIFBhc3NSZWZQdHI8QXR0cj4gRWxlbWVudDo6cmVtb3ZlQXR0cmlidXRlTm9kZShBdHRyKiBh dHRyLCBFeGNlcHRpb25Db2RlJiBlYykKICAgICBBU1NFUlQoZG9jdW1lbnQoKSA9PSBhdHRyLT5k b2N1bWVudCgpKTsKIAogICAgIEVsZW1lbnRBdHRyaWJ1dGVEYXRhKiBhdHRyaWJ1dGVEYXRhID0g dXBkYXRlZEF0dHJpYnV0ZURhdGEoKTsKLSAgICBpZiAoIWF0dHJpYnV0ZURhdGEpCi0gICAgICAg IHJldHVybiAwOworICAgIEFTU0VSVChhdHRyaWJ1dGVEYXRhKTsKIAogICAgIHNpemVfdCBpbmRl eCA9IGF0dHJpYnV0ZURhdGEtPmdldEF0dHJpYnV0ZUl0ZW1JbmRleChhdHRyLT5xdWFsaWZpZWRO YW1lKCkpOwogICAgIGlmIChpbmRleCA9PSBub3RGb3VuZCkgewpAQCAtMTcxNCwxMCArMTcwNCwx MiBAQCB2b2lkIEVsZW1lbnQ6OmNhbmNlbEZvY3VzQXBwZWFyYW5jZVVwZGF0ZSgpCiAKIHZvaWQg RWxlbWVudDo6bm9ybWFsaXplQXR0cmlidXRlcygpCiB7Ci0gICAgRWxlbWVudEF0dHJpYnV0ZURh dGEqIGF0dHJpYnV0ZURhdGEgPSB1cGRhdGVkQXR0cmlidXRlRGF0YSgpOwotICAgIGlmICghYXR0 cmlidXRlRGF0YSB8fCBhdHRyaWJ1dGVEYXRhLT5pc0VtcHR5KCkpCisgICAgaWYgKCFoYXNBdHRy TGlzdCgpKQogICAgICAgICByZXR1cm47CiAKKyAgICBFbGVtZW50QXR0cmlidXRlRGF0YSogYXR0 cmlidXRlRGF0YSA9IHVwZGF0ZWRBdHRyaWJ1dGVEYXRhKCk7CisgICAgQVNTRVJUKGF0dHJpYnV0 ZURhdGEpOworCiAgICAgY29uc3QgVmVjdG9yPEF0dHJpYnV0ZT4mIGF0dHJpYnV0ZXMgPSBhdHRy aWJ1dGVEYXRhLT5hdHRyaWJ1dGVWZWN0b3IoKTsKICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8 IGF0dHJpYnV0ZXMuc2l6ZSgpOyArK2kpIHsKICAgICAgICAgaWYgKFJlZlB0cjxBdHRyPiBhdHRy ID0gYXR0cklmRXhpc3RzKGF0dHJpYnV0ZXNbaV0ubmFtZSgpKSkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2RvbS9TdHlsZWRFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TdHls ZWRFbGVtZW50LmNwcAppbmRleCBkNTViMDA5Li4zMTQ5OTQ2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9kb20vU3R5bGVkRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL1N0 eWxlZEVsZW1lbnQuY3BwCkBAIC0xNjMsNyArMTYzLDcgQEAgdm9pZCBTdHlsZWRFbGVtZW50Ojpj bGFzc0F0dHJpYnV0ZUNoYW5nZWQoY29uc3QgQXRvbWljU3RyaW5nJiBuZXdDbGFzc1N0cmluZykK ICAgICAgICAgZW5zdXJlQXR0cmlidXRlRGF0YSgpLT5zZXRDbGFzcyhuZXdDbGFzc1N0cmluZywg c2hvdWxkRm9sZENhc2UpOwogICAgICAgICBpZiAoRE9NVG9rZW5MaXN0KiBjbGFzc0xpc3QgPSBv cHRpb25hbENsYXNzTGlzdCgpKQogICAgICAgICAgICAgc3RhdGljX2Nhc3Q8Q2xhc3NMaXN0Kj4o Y2xhc3NMaXN0KS0+cmVzZXQobmV3Q2xhc3NTdHJpbmcpOwotICAgIH0gZWxzZSBpZiAoYXR0cmli dXRlRGF0YSgpKQorICAgIH0gZWxzZQogICAgICAgICBhdHRyaWJ1dGVEYXRhKCktPmNsZWFyQ2xh c3MoKTsKICAgICBzZXROZWVkc1N0eWxlUmVjYWxjKCk7CiB9Cg==