87243 2012-05-23 03:31:37 -0700 [Qt][WK2] Small refactoring WebPage::confirmComposition. 2012-05-23 06:03:48 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 michael.bruning michael.bruning menard webkit.review.bot zoltan oldest_to_newest 631458 0 michael.bruning 2012-05-23 03:31:37 -0700 [Qt][WK2] Small refactoring WebPage::confirmComposition. 631459 1 143521 michael.bruning 2012-05-23 03:33:31 -0700 Created attachment 143521 Patch 631460 2 webkit.review.bot 2012-05-23 03:38:44 -0700 Attachment 143521 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 631508 3 143534 michael.bruning 2012-05-23 04:49:50 -0700 Created attachment 143534 Patch 631568 4 143534 webkit.review.bot 2012-05-23 06:03:31 -0700 Comment on attachment 143534 Patch Clearing flags on attachment: 143534 Committed r118165: <http://trac.webkit.org/changeset/118165> 631569 5 webkit.review.bot 2012-05-23 06:03:48 -0700 All reviewed patches have been landed. Closing bug. 143521 2012-05-23 03:33:31 -0700 2012-05-23 04:49:36 -0700 Patch bug-87243-20120523123329.patch text/plain 2302 michael.bruning U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4MTUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOWEwNWNjNTNlY2VmMDk2 ZTIyMDJkMDlmNDNiNmFhM2FjYTg0MDNmZi4uOTM3MzIzMjA2Yjc1MjZmNmU4NjA0M2I2YTRiNTZh YzBhNzdlODU0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA1LTIzICBNaWNo YWVsIEJyw7xuaW5nICA8bWljaGFlbC5icnVuaW5nQG5va2lhLmNvbT4KKworICAgICAgICBbUXRd W1dLMl0gU21hbGwgcmVmYWN0b3JpbmcgV2ViUGFnZTo6Y29uZmlybUNvbXBvc2l0aW9uLgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENoYW5nZSBuZXN0 ZWQgaWYgaW50byBhbiBlYXJseSByZXR1cm4gdG8gcmVkdWNlIGNvbXBsZXhpdHkuCisKKyAgICAg ICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvcXQvV2ViUGFnZVF0LmNwcDoKKyAgICAgICAgKFdlYktp dDo6V2ViUGFnZTo6Y29uZmlybUNvbXBvc2l0aW9uKToKKwogMjAxMi0wNS0yMyAgVG9yIEFybmUg VmVzdGLDuCAgPHRvci5hcm5lLnZlc3Rib0Bub2tpYS5jb20+CiAKICAgICAgICAgW1F0XSBNYWtl IFF0V2ViRXJyb3IgcmV0dXJuIHRoZSBmYWlsaW5nIFVSTCBhcyBhIFFTdHJpbmcgaW5zdGVhZCBv ZiBRVXJsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvcXQv V2ViUGFnZVF0LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9xdC9XZWJQ YWdlUXQuY3BwCmluZGV4IDcxODBhOGM4ODM2MDY5ZDc2OGRjZjA5NzE2MTU2YTBiYjU2NjA0YmQu LjQwMDcxOTgyYmUxODdjOGMwY2RlNGRkODkwYTM3MWM4NDU0NzAzYzkgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9xdC9XZWJQYWdlUXQuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9xdC9XZWJQYWdlUXQuY3BwCkBAIC0zMzYs MTIgKzMzNiwxMiBAQCB2b2lkIFdlYlBhZ2U6OmNvbmZpcm1Db21wb3NpdGlvbihjb25zdCBTdHJp bmcmIGNvbXBvc2l0aW9uU3RyaW5nLCBpbnQ2NF90IHNlbGVjdAogICAgIEVkaXRvciogZWRpdG9y ID0gdGFyZ2V0RnJhbWUtPmVkaXRvcigpOwogICAgIGVkaXRvci0+Y29uZmlybUNvbXBvc2l0aW9u KGNvbXBvc2l0aW9uU3RyaW5nKTsKIAotICAgIFJlZlB0cjxSYW5nZT4gc2VsZWN0aW9uUmFuZ2U7 Ci0gICAgaWYgKHNlbGVjdGlvblN0YXJ0ICE9IC0xKSB7Ci0gICAgICAgIEVsZW1lbnQqIHNjb3Bl ID0gdGFyZ2V0RnJhbWUtPnNlbGVjdGlvbigpLT5yb290RWRpdGFibGVFbGVtZW50KCk7Ci0gICAg ICAgIHNlbGVjdGlvblJhbmdlID0gVGV4dEl0ZXJhdG9yOjpyYW5nZUZyb21Mb2NhdGlvbkFuZExl bmd0aChzY29wZSwgc2VsZWN0aW9uU3RhcnQsIHNlbGVjdGlvbkxlbmd0aCk7Ci0gICAgICAgIEFT U0VSVF9XSVRIX01FU1NBR0Uoc2VsZWN0aW9uUmFuZ2UsICJJbnZhbGlkIHNlbGVjdGlvbjogWyVs bGQ6JWxsZF0gaW4gdGV4dCBvZiBsZW5ndGggJWQiLCBzdGF0aWNfY2FzdDxsb25nIGxvbmc+KHNl bGVjdGlvblN0YXJ0KSwgc3RhdGljX2Nhc3Q8bG9uZyBsb25nPihzZWxlY3Rpb25MZW5ndGgpLCBz Y29wZS0+aW5uZXJUZXh0KCkubGVuZ3RoKCkpOwotICAgIH0KKyAgICBpZiAoc2VsZWN0aW9uU3Rh cnQgPT0gLTEpCisgICAgICAgIHJldHVybjsKKworICAgIEVsZW1lbnQqIHNjb3BlID0gdGFyZ2V0 RnJhbWUtPnNlbGVjdGlvbigpLT5yb290RWRpdGFibGVFbGVtZW50KCk7CisgICAgUmVmUHRyPFJh bmdlPiBzZWxlY3Rpb25SYW5nZSA9IFRleHRJdGVyYXRvcjo6cmFuZ2VGcm9tTG9jYXRpb25BbmRM ZW5ndGgoc2NvcGUsIHNlbGVjdGlvblN0YXJ0LCBzZWxlY3Rpb25MZW5ndGgpOworICAgIEFTU0VS VF9XSVRIX01FU1NBR0Uoc2VsZWN0aW9uUmFuZ2UsICJJbnZhbGlkIHNlbGVjdGlvbjogWyVsbGQ6 JWxsZF0gaW4gdGV4dCBvZiBsZW5ndGggJWQiLCBzdGF0aWNfY2FzdDxsb25nIGxvbmc+KHNlbGVj dGlvblN0YXJ0KSwgc3RhdGljX2Nhc3Q8bG9uZyBsb25nPihzZWxlY3Rpb25MZW5ndGgpLCBzY29w ZS0+aW5uZXJUZXh0KCkubGVuZ3RoKCkpOwogCiAgICAgaWYgKHNlbGVjdGlvblJhbmdlKSB7CiAg ICAgICAgIFZpc2libGVTZWxlY3Rpb24gc2VsZWN0aW9uKHNlbGVjdGlvblJhbmdlLmdldCgpLCBT RUxfREVGQVVMVF9BRkZJTklUWSk7Cg== 143534 2012-05-23 04:49:50 -0700 2012-05-23 06:03:31 -0700 Patch bug-87243-20120523134948.patch text/plain 2324 michael.bruning U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4MTYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODI3MmNjZDRiMTYwYzQ5 M2RmOGIxYTc0ZWJkYzdjZTQyODNhMDU3OS4uYjY4YzM4ZTJkMzU4ZjQxMGY3ODlhNWVkZGI1YTli NmE4YzBkNWY3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA1LTIzICBNaWNo YWVsIEJyw7xuaW5nICA8bWljaGFlbC5icnVuaW5nQG5va2lhLmNvbT4KKworICAgICAgICBbUXRd W1dLMl0gU21hbGwgcmVmYWN0b3JpbmcgV2ViUGFnZTo6Y29uZmlybUNvbXBvc2l0aW9uLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODcyNDMKKworICAg ICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4KKworICAgICAgICBD aGFuZ2UgbmVzdGVkIGlmIGludG8gYW4gZWFybHkgcmV0dXJuIHRvIHJlZHVjZSBjb21wbGV4aXR5 LgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL3F0L1dlYlBhZ2VRdC5jcHA6CisgICAg ICAgIChXZWJLaXQ6OldlYlBhZ2U6OmNvbmZpcm1Db21wb3NpdGlvbik6CisKIDIwMTItMDUtMjMg IEFsbGFuIFNhbmRmZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBub2tpYS5jb20+CiAKICAgICAg ICAgW1F0XSBGbG9hdFNpemUgUXQgU3VwcG9ydApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJQYWdlL3F0L1dlYlBhZ2VRdC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYlBhZ2UvcXQvV2ViUGFnZVF0LmNwcAppbmRleCA3MTgwYThjODgzNjA2OWQ3Njhk Y2YwOTcxNjE1NmEwYmI1NjYwNGJkLi40MDA3MTk4MmJlMTg3YzhjMGNkZTRkZDg5MGEzNzFjODQ1 NDcwM2M5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvcXQv V2ViUGFnZVF0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvcXQv V2ViUGFnZVF0LmNwcApAQCAtMzM2LDEyICszMzYsMTIgQEAgdm9pZCBXZWJQYWdlOjpjb25maXJt Q29tcG9zaXRpb24oY29uc3QgU3RyaW5nJiBjb21wb3NpdGlvblN0cmluZywgaW50NjRfdCBzZWxl Y3QKICAgICBFZGl0b3IqIGVkaXRvciA9IHRhcmdldEZyYW1lLT5lZGl0b3IoKTsKICAgICBlZGl0 b3ItPmNvbmZpcm1Db21wb3NpdGlvbihjb21wb3NpdGlvblN0cmluZyk7CiAKLSAgICBSZWZQdHI8 UmFuZ2U+IHNlbGVjdGlvblJhbmdlOwotICAgIGlmIChzZWxlY3Rpb25TdGFydCAhPSAtMSkgewot ICAgICAgICBFbGVtZW50KiBzY29wZSA9IHRhcmdldEZyYW1lLT5zZWxlY3Rpb24oKS0+cm9vdEVk aXRhYmxlRWxlbWVudCgpOwotICAgICAgICBzZWxlY3Rpb25SYW5nZSA9IFRleHRJdGVyYXRvcjo6 cmFuZ2VGcm9tTG9jYXRpb25BbmRMZW5ndGgoc2NvcGUsIHNlbGVjdGlvblN0YXJ0LCBzZWxlY3Rp b25MZW5ndGgpOwotICAgICAgICBBU1NFUlRfV0lUSF9NRVNTQUdFKHNlbGVjdGlvblJhbmdlLCAi SW52YWxpZCBzZWxlY3Rpb246IFslbGxkOiVsbGRdIGluIHRleHQgb2YgbGVuZ3RoICVkIiwgc3Rh dGljX2Nhc3Q8bG9uZyBsb25nPihzZWxlY3Rpb25TdGFydCksIHN0YXRpY19jYXN0PGxvbmcgbG9u Zz4oc2VsZWN0aW9uTGVuZ3RoKSwgc2NvcGUtPmlubmVyVGV4dCgpLmxlbmd0aCgpKTsKLSAgICB9 CisgICAgaWYgKHNlbGVjdGlvblN0YXJ0ID09IC0xKQorICAgICAgICByZXR1cm47CisKKyAgICBF bGVtZW50KiBzY29wZSA9IHRhcmdldEZyYW1lLT5zZWxlY3Rpb24oKS0+cm9vdEVkaXRhYmxlRWxl bWVudCgpOworICAgIFJlZlB0cjxSYW5nZT4gc2VsZWN0aW9uUmFuZ2UgPSBUZXh0SXRlcmF0b3I6 OnJhbmdlRnJvbUxvY2F0aW9uQW5kTGVuZ3RoKHNjb3BlLCBzZWxlY3Rpb25TdGFydCwgc2VsZWN0 aW9uTGVuZ3RoKTsKKyAgICBBU1NFUlRfV0lUSF9NRVNTQUdFKHNlbGVjdGlvblJhbmdlLCAiSW52 YWxpZCBzZWxlY3Rpb246IFslbGxkOiVsbGRdIGluIHRleHQgb2YgbGVuZ3RoICVkIiwgc3RhdGlj X2Nhc3Q8bG9uZyBsb25nPihzZWxlY3Rpb25TdGFydCksIHN0YXRpY19jYXN0PGxvbmcgbG9uZz4o c2VsZWN0aW9uTGVuZ3RoKSwgc2NvcGUtPmlubmVyVGV4dCgpLmxlbmd0aCgpKTsKIAogICAgIGlm IChzZWxlY3Rpb25SYW5nZSkgewogICAgICAgICBWaXNpYmxlU2VsZWN0aW9uIHNlbGVjdGlvbihz ZWxlY3Rpb25SYW5nZS5nZXQoKSwgU0VMX0RFRkFVTFRfQUZGSU5JVFkpOwo=