87221 2012-05-23 00:14:40 -0700 [Gtk] EventSender should properly handle (left|right)(control|shift|alt) after r118001 2012-05-23 05:59:55 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan pnormand webkit.review.bot oldest_to_newest 631312 0 zan 2012-05-23 00:14:40 -0700 EventSender for Chromium and Mac ports was updated in r118001[1] with six more keys that should be handled: leftControl leftShift leftAlt rightControl rightShift rightAlt Mac fixed this in r118064. 1: http://trac.webkit.org/changeset/118001 2: http://trac.webkit.org/changeset/118064 631409 1 143505 zan 2012-05-23 02:14:13 -0700 Created attachment 143505 Patch 631565 2 143505 webkit.review.bot 2012-05-23 05:59:29 -0700 Comment on attachment 143505 Patch Clearing flags on attachment: 143505 Committed r118164: <http://trac.webkit.org/changeset/118164> 631567 3 webkit.review.bot 2012-05-23 05:59:55 -0700 All reviewed patches have been landed. Closing bug. 143505 2012-05-23 02:14:13 -0700 2012-05-23 05:59:28 -0700 Patch bug-87221-20120523111412.patch text/plain 7058 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4MTQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjJhZjViZDA1YmZhYzdk MDEwNjExNzg1ZmE0M2NhZDE1Mjg1N2Y2NS4uNWJhMmE2NjA5OWVjZDA2MTE2Njk3MDIyNGQ4ODIy OTZmY2JmZGRlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA1LTIzICBaYW4g RG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CisKKyAgICAgICAgW0d0a10gRXZlbnRT ZW5kZXIgc2hvdWxkIHByb3Blcmx5IGhhbmRsZSAobGVmdHxyaWdodCkoY29udHJvbHxzaGlmdHxh bHQpIGFmdGVyIHIxMTgwMDEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTg3MjIxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzIC0gY292ZXJlZCBieSBmYXN0L2V2ZW50cy9rZXlkb3duLWxl ZnRyaWdodC1rZXlzLmh0bWwuCisKKyAgICAgICAgV2luZG93cyBrZXkgY29kZSBmb3Igc2hpZnQs IGNvbnRyb2wgYW5kIGFsdCBrZXlzIHNob3VsZCByZXNwZWN0IHRoZQorICAgICAgICBsZWZ0IG9y IHJpZ2h0IHBvc2l0aW9uIG9mIHRoYXQga2V5LiBUaGlzIHdheSB0aGUgRE9NIGxvY2F0aW9uIGNv ZGUgb2YKKyAgICAgICAgYSBrZXkgZXZlbnQgaXMgcHJvcGVybHkgZGV0ZXJtaW5lZCBmb3IgdGhl c2Uga2V5cy4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9QbGF0Zm9ybUtleWJvYXJkRXZlbnRH dGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGxhdGZvcm1LZXlib2FyZEV2ZW50Ojp3aW5kb3dz S2V5Q29kZUZvckdka0tleUNvZGUpOgorCiAyMDEyLTA1LTIzICBSeW9zdWtlIE5pd2EgIDxybml3 YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFdlYktpdCBzcGVuZHMgfjIwJSBvZiB0aW1lIGluIEhU TUxUZXh0QXJlYUVsZW1lbnQ6OmRlZmF1bHRWYWx1ZSgpIHdoZW4gb3BlbmluZyBhIHJldmlldyBw YWdlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUGxhdGZvcm1LZXli b2FyZEV2ZW50R3RrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9QbGF0Zm9ybUtl eWJvYXJkRXZlbnRHdGsuY3BwCmluZGV4IDgxYmU5MzA2Y2EzZjBkZWU0YjY2NjA5NWZkZGExODgx ODM2NWUzZjMuLjcwNmQ2ZTI1Yzk5MDA1YTI0MjAwY2E5ZDRmMDUwMjU1ZmUyMmY0YzYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9QbGF0Zm9ybUtleWJvYXJkRXZlbnRH dGsuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9QbGF0Zm9ybUtleWJvYXJk RXZlbnRHdGsuY3BwCkBAIC0yMTMsMTcgKzIxMywxNCBAQCBpbnQgUGxhdGZvcm1LZXlib2FyZEV2 ZW50Ojp3aW5kb3dzS2V5Q29kZUZvckdka0tleUNvZGUodW5zaWduZWQga2V5Y29kZSkKICAgICAg ICAgY2FzZSBHREtfS1BfRW50ZXI6CiAgICAgICAgIGNhc2UgR0RLX1JldHVybjoKICAgICAgICAg ICAgIHJldHVybiBWS19SRVRVUk47IC8vKDBEKSBSZXR1cm4ga2V5Ci0gICAgICAgIGNhc2UgR0RL X1NoaWZ0X0w6Ci0gICAgICAgIGNhc2UgR0RLX1NoaWZ0X1I6Ci0gICAgICAgICAgICByZXR1cm4g VktfU0hJRlQ7IC8vICgxMCkgU0hJRlQga2V5Ci0gICAgICAgIGNhc2UgR0RLX0NvbnRyb2xfTDoK LSAgICAgICAgY2FzZSBHREtfQ29udHJvbF9SOgotICAgICAgICAgICAgcmV0dXJuIFZLX0NPTlRS T0w7IC8vICgxMSkgQ1RSTCBrZXkKKworICAgICAgICAgICAgLy8gVktfU0hJRlQgKDEwKSBTSElG VCBrZXkKKyAgICAgICAgICAgIC8vIFZLX0NPTlRST0wgKDExKSBDVFJMIGtleQorCiAgICAgICAg IGNhc2UgR0RLX01lbnU6CiAgICAgICAgICAgICByZXR1cm4gVktfQVBQUzsgIC8vICg1RCkgQXBw bGljYXRpb25zIGtleSAoTmF0dXJhbCBrZXlib2FyZCkKLSAgICAgICAgY2FzZSBHREtfQWx0X0w6 Ci0gICAgICAgIGNhc2UgR0RLX0FsdF9SOgotICAgICAgICAgICAgcmV0dXJuIFZLX01FTlU7IC8v ICgxMikgQUxUIGtleQorCisgICAgICAgICAgICAvLyBWS19NRU5VICgxMikgQUxUIGtleQogCiAg ICAgICAgIGNhc2UgR0RLX1BhdXNlOgogICAgICAgICAgICAgcmV0dXJuIFZLX1BBVVNFOyAvLyAo MTMpIFBBVVNFIGtleQpAQCAtNDAzLDEyICs0MDAsMTkgQEAgaW50IFBsYXRmb3JtS2V5Ym9hcmRF dmVudDo6d2luZG93c0tleUNvZGVGb3JHZGtLZXlDb2RlKHVuc2lnbmVkIGtleWNvZGUpCiAgICAg ICAgIGNhc2UgR0RLX1Njcm9sbF9Mb2NrOgogICAgICAgICAgICAgcmV0dXJuIFZLX1NDUk9MTDsg Ly8gKDkxKSBTQ1JPTEwgTE9DSyBrZXkKIAotICAgICAgICAgICAgLy8gVktfTFNISUZUIChBMCkg TGVmdCBTSElGVCBrZXkKLSAgICAgICAgICAgIC8vIFZLX1JTSElGVCAoQTEpIFJpZ2h0IFNISUZU IGtleQotICAgICAgICAgICAgLy8gVktfTENPTlRST0wgKEEyKSBMZWZ0IENPTlRST0wga2V5Ci0g ICAgICAgICAgICAvLyBWS19SQ09OVFJPTCAoQTMpIFJpZ2h0IENPTlRST0wga2V5Ci0gICAgICAg ICAgICAvLyBWS19MTUVOVSAoQTQpIExlZnQgTUVOVSBrZXkKLSAgICAgICAgICAgIC8vIFZLX1JN RU5VIChBNSkgUmlnaHQgTUVOVSBrZXkKKyAgICAgICAgY2FzZSBHREtfU2hpZnRfTDoKKyAgICAg ICAgICAgIHJldHVybiBWS19MU0hJRlQ7IC8vIChBMCkgTGVmdCBTSElGVCBrZXkKKyAgICAgICAg Y2FzZSBHREtfU2hpZnRfUjoKKyAgICAgICAgICAgIHJldHVybiBWS19SU0hJRlQ7IC8vIChBMSkg UmlnaHQgU0hJRlQga2V5CisgICAgICAgIGNhc2UgR0RLX0NvbnRyb2xfTDoKKyAgICAgICAgICAg IHJldHVybiBWS19MQ09OVFJPTDsgLy8gKEEyKSBMZWZ0IENPTlRST0wga2V5CisgICAgICAgIGNh c2UgR0RLX0NvbnRyb2xfUjoKKyAgICAgICAgICAgIHJldHVybiBWS19SQ09OVFJPTDsgLy8gKEEz KSBSaWdodCBDT05UUk9MIGtleQorICAgICAgICBjYXNlIEdES19BbHRfTDoKKyAgICAgICAgICAg IHJldHVybiBWS19MTUVOVTsgLy8gKEE0KSBMZWZ0IE1FTlUga2V5CisgICAgICAgIGNhc2UgR0RL X0FsdF9SOgorICAgICAgICAgICAgcmV0dXJuIFZLX1JNRU5VOyAvLyAoQTUpIFJpZ2h0IE1FTlUg a2V5CisKICAgICAgICAgICAgIC8vIFZLX0JST1dTRVJfQkFDSyAoQTYpIFdpbmRvd3MgMjAwMC9Y UDogQnJvd3NlciBCYWNrIGtleQogICAgICAgICAgICAgLy8gVktfQlJPV1NFUl9GT1JXQVJEIChB NykgV2luZG93cyAyMDAwL1hQOiBCcm93c2VyIEZvcndhcmQga2V5CiAgICAgICAgICAgICAvLyBW S19CUk9XU0VSX1JFRlJFU0ggKEE4KSBXaW5kb3dzIDIwMDAvWFA6IEJyb3dzZXIgUmVmcmVzaCBr ZXkKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAx NTk5ZmZiZmIzY2VhY2I1YmI4MWE0Y2IzMmM2Yjk4YmU5ODM5YzZkLi5mZDk5NTJjNDc5NmJiMWM0 ZTJkMzliNmZkZTZiNTlkZjJkYTQzMGU1IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysr IGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDUtMjMgIFphbiBEb2Jl cnNlayAgPHphbmRvYmVyc2VrQGdtYWlsLmNvbT4KKworICAgICAgICBbR3RrXSBFdmVudFNlbmRl ciBzaG91bGQgcHJvcGVybHkgaGFuZGxlIChsZWZ0fHJpZ2h0KShjb250cm9sfHNoaWZ0fGFsdCkg YWZ0ZXIgcjExODAwMQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9ODcyMjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBDb252ZXJ0IGxlZnRBbHQsIGxlZnRDb250cm9sLCBsZWZ0U2hpZnQsIHJpZ2h0QWx0LCBy aWdodENvbnRyb2wgYW5kCisgICAgICAgIHJpZ2h0U2hpZnQga2V5IG5hbWVzIGludG8gcHJvcGVy IEdESyBrZXkgc3ltYm9scy4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2d0ay9FdmVudFNl bmRlci5jcHA6CisgICAgICAgIChjcmVhdGVLZXlQcmVzc0V2ZW50KToKKwogMjAxMi0wNS0yMyAg Q2hyaXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVtZXpAaW50ZWwuY29tPgogCiAgICAgICAg IFtFRkxdIEVGTCdzIERSVCBkb2VzIG5vdCBwcmludCBkaWRGYWlsUHJvdmlzaW9uYWxMb2FkV2l0 aEVycm9yIG1lc3NhZ2VzCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRXZl bnRTZW5kZXIuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0V2ZW50U2VuZGVyLmNwcApp bmRleCA5MmFjYmU3MzM5NzdmYWM4MDk3OWU5NDczYmMyN2Q4ZDVkODE2OGYxLi5iYzM4YTIwMjky MTJmNGM1YjNjYWI0OWM1MGMwMDY2YzVhNTYxMDY1IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVu ZGVyVHJlZS9ndGsvRXZlbnRTZW5kZXIuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0 ay9FdmVudFNlbmRlci5jcHAKQEAgLTcwNSw2ICs3MDUsMTggQEAgc3RhdGljIEdka0V2ZW50KiBj cmVhdGVLZXlQcmVzc0V2ZW50KEpTQ29udGV4dFJlZiBjb250ZXh0LCBzaXplX3QgYXJndW1lbnRD b3VudCwKICAgICAgICAgICAgIGdka0tleVN5bSA9IEdES19GMTE7CiAgICAgICAgIGVsc2UgaWYg KEpTU3RyaW5nSXNFcXVhbFRvVVRGOENTdHJpbmcoY2hhcmFjdGVyLCAiRjEyIikpCiAgICAgICAg ICAgICBnZGtLZXlTeW0gPSBHREtfRjEyOworICAgICAgICBlbHNlIGlmIChKU1N0cmluZ0lzRXF1 YWxUb1VURjhDU3RyaW5nKGNoYXJhY3RlciwgImxlZnRBbHQiKSkKKyAgICAgICAgICAgIGdka0tl eVN5bSA9IEdES19BbHRfTDsKKyAgICAgICAgZWxzZSBpZiAoSlNTdHJpbmdJc0VxdWFsVG9VVEY4 Q1N0cmluZyhjaGFyYWN0ZXIsICJsZWZ0Q29udHJvbCIpKQorICAgICAgICAgICAgZ2RrS2V5U3lt ID0gR0RLX0NvbnRyb2xfTDsKKyAgICAgICAgZWxzZSBpZiAoSlNTdHJpbmdJc0VxdWFsVG9VVEY4 Q1N0cmluZyhjaGFyYWN0ZXIsICJsZWZ0U2hpZnQiKSkKKyAgICAgICAgICAgIGdka0tleVN5bSA9 IEdES19TaGlmdF9MOworICAgICAgICBlbHNlIGlmIChKU1N0cmluZ0lzRXF1YWxUb1VURjhDU3Ry aW5nKGNoYXJhY3RlciwgInJpZ2h0QWx0IikpCisgICAgICAgICAgICBnZGtLZXlTeW0gPSBHREtf QWx0X1I7CisgICAgICAgIGVsc2UgaWYgKEpTU3RyaW5nSXNFcXVhbFRvVVRGOENTdHJpbmcoY2hh cmFjdGVyLCAicmlnaHRDb250cm9sIikpCisgICAgICAgICAgICBnZGtLZXlTeW0gPSBHREtfQ29u dHJvbF9SOworICAgICAgICBlbHNlIGlmIChKU1N0cmluZ0lzRXF1YWxUb1VURjhDU3RyaW5nKGNo YXJhY3RlciwgInJpZ2h0U2hpZnQiKSkKKyAgICAgICAgICAgIGdka0tleVN5bSA9IEdES19TaGlm dF9SOwogICAgICAgICBlbHNlIHsKICAgICAgICAgICAgIGludCBjaGFyQ29kZSA9IEpTU3RyaW5n R2V0Q2hhcmFjdGVyc1B0cihjaGFyYWN0ZXIpWzBdOwogICAgICAgICAgICAgaWYgKGNoYXJDb2Rl ID09ICdcbicgfHwgY2hhckNvZGUgPT0gJ1xyJykKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0No YW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBiNWU1NWJjYThiOWU3ZGY3MmM3 MDE3NjZkNjk2MDllZjhkMDM5YmVkLi43ZGRjZTM5MTY0OTk0ZjM3MDVhNTQ5ZGM3ZGMwNTVmNGY1 MTU1MDMxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDUtMjMgIFphbiBEb2JlcnNlayAg PHphbmRvYmVyc2VrQGdtYWlsLmNvbT4KKworICAgICAgICBbR3RrXSBFdmVudFNlbmRlciBzaG91 bGQgcHJvcGVybHkgaGFuZGxlIChsZWZ0fHJpZ2h0KShjb250cm9sfHNoaWZ0fGFsdCkgYWZ0ZXIg cjExODAwMQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 ODcyMjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBS ZW1vdmUgZmFpbGluZyB0ZXN0IGV4cGVjdGF0aW9ucyBmb3IgZmFzdC9ldmVudHMva2V5ZG93bi1s ZWZ0cmlnaHQta2V5cy5odG1sLAorICAgICAgICB0aGUgdGVzdCBzaG91bGQgcGFzcyBub3cuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvdGVzdF9leHBlY3RhdGlvbnMudHh0OgorCiAyMDEyLTA1 LTIzICBNaWtoYWlsIFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgog CiAgICAgICAgIFtFRkxdW0RSVF0gV2ViYXJjaGl2ZXMgdGVzdHMgZ2FyZGVuaW5nCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvdGVzdF9leHBlY3RhdGlvbnMudHh0IGIvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAppbmRleCBlYjY0Njk5 NzNkY2IzMWZhMzVmYjA4OGM2ZWY2MWNhOTk2NGY0OGYwLi5iMDBiNmFjM2RjODlhYTNjZmU0NjM2 ODc1YmE3ZTc3YTU4N2Y5NDA5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsv dGVzdF9leHBlY3RhdGlvbnMudHh0CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay90ZXN0 X2V4cGVjdGF0aW9ucy50eHQKQEAgLTEzMzcsOCArMTMzNyw2IEBAIEJVR1dLODY5NzEgOiBzdmcv Y3VzdG9tL25vbi1zY2FsaW5nLXN0cm9rZS1tYXJrZXJzLnN2ZyA9IFRFWFQgUEFTUwogLy8gVGhp cyB0ZXN0IG1ha2VzIHRoZSB0ZXN0IHRoYXQgZm9sbG93cyBpdCBjcmFzaC90aW1lb3V0CiBCVUdX Szg3MjA4IFNLSVAgOiBodHRwL3Rlc3RzL2Nvb2tpZXMvanMtZ2V0LWFuZC1zZXQtaHR0cC1vbmx5 LWNvb2tpZS5waHAgPSBGQUlMCiAKLUJVR1dLODcyMjEgOiBmYXN0L2V2ZW50cy9rZXlkb3duLWxl ZnRyaWdodC1rZXlzLmh0bWwgPSBGQUlMCi0KIEJVR1dLODcwODggOiBmYXN0L2pzL25hbWVzLmh0 bWwgPSBGQUlMCiAKIC8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLwo=