87203 2012-05-22 21:16:05 -0700 [EFL] Modify keycode conversion functions to return keycodes with location information after r118001. 2012-05-24 10:43:46 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rakuco rakuco gyuyoung.kim lucas.de.marchi morrita tkent webkit.review.bot oldest_to_newest 631157 0 rakuco 2012-05-22 21:16:05 -0700 [EFL] Modify keycode conversion functions to return keycodes with location information after r118001. 631162 1 143450 rakuco 2012-05-22 21:18:55 -0700 Created attachment 143450 Patch 631201 2 143450 gyuyoung.kim 2012-05-22 21:58:49 -0700 Comment on attachment 143450 Patch Looks good to me. thanks. 632933 3 143450 webkit.review.bot 2012-05-24 10:43:42 -0700 Comment on attachment 143450 Patch Clearing flags on attachment: 143450 Committed r118391: <http://trac.webkit.org/changeset/118391> 632934 4 webkit.review.bot 2012-05-24 10:43:46 -0700 All reviewed patches have been landed. Closing bug. 143450 2012-05-22 21:18:55 -0700 2012-05-24 10:43:42 -0700 Patch bug-87203-20120523011852.patch text/plain 5880 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4MDg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTRmZmQzZmFkOTVjYTI4 MDc2MzJlNGRhNDdkZmU3NGM1ZDJjNWE5Yi4uOWRmZWQxMjM1OWE2MmU0ZjRkMzE5ZDJjMzRhNzYy NjlhOTlmYzJiNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA1LTIyICBSYXBo YWVsIEt1Ym8gZGEgQ29zdGEgIDxyYWt1Y29Ad2Via2l0Lm9yZz4KKworICAgICAgICBbRUZMXSBN b2RpZnkga2V5Y29kZSBjb252ZXJzaW9uIGZ1bmN0aW9ucyB0byByZXR1cm4ga2V5Y29kZXMgd2l0 aCBsb2NhdGlvbiBpbmZvcm1hdGlvbiBhZnRlciByMTE4MDAxLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODcyMDMKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgdGhlIHJlcXVpcmVkIGNoYW5nZXMgdG8g bWFrZQorICAgICAgICBmYXN0L2V2ZW50cy9rZXlkb3duLWxlZnRyaWdodC1rZXlzLmh0bWwgcGFz cyBhZnRlciByMTE4MDAxLgorCisgICAgICAgICogcGxhdGZvcm0vZWZsL0VmbEtleWJvYXJkVXRp bGl0aWVzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmNyZWF0ZVdpbmRvd3NLZXlNYXApOiBUcmFu c2xhdGUgdGhlIGtleWNvZGVzIGZvcgorICAgICAgICAie2xlZnQscmlnaHR9e1NoaWZ0LEFsdCxD b250cm9sfSIgaW50byB0aGUgcmlnaHQgd2luZG93cyBrZXlib2FyZAorICAgICAgICBkZWZpbml0 aW9ucy4KKwogMjAxMi0wNS0yMiAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAog ICAgICAgICBSRUdSRVNTSU9OIChyOTgzNTkpOiBWaWRlbyBkb2VzIG5vdCByZW5kZXIgb24gaHR0 cDovL3BhbmljLmNvbS9kaWV0Y29kYS8KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2VmbC9FZmxLZXlib2FyZFV0aWxpdGllcy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9lZmwvRWZsS2V5Ym9hcmRVdGlsaXRpZXMuY3BwCmluZGV4IDIxMGRiODFlYTg5MzAxZjZmZGE4 MTU5YTlkYmIyMDc0YTBmMWVlMmMuLjE2YjJjNmFkOTYxZTk1OGZiZGYzMjdhYTZmNjAyNmVjMGU5 YTgyNGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9FZmxLZXlib2Fy ZFV0aWxpdGllcy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0VmbEtleWJv YXJkVXRpbGl0aWVzLmNwcApAQCAtMTE0LDEzICsxMTQsMTQgQEAgc3RhdGljIHZvaWQgY3JlYXRl V2luZG93c0tleU1hcCgpCiB7CiAgICAgd2luZG93c0tleU1hcCgpLnNldCgiUmV0dXJuIiwgVktf UkVUVVJOKTsKICAgICB3aW5kb3dzS2V5TWFwKCkuc2V0KCJLUF9SZXR1cm4iLCBWS19SRVRVUk4p OwotICAgIHdpbmRvd3NLZXlNYXAoKS5zZXQoIkFsdF9MIiwgVktfTUVOVSk7CisgICAgd2luZG93 c0tleU1hcCgpLnNldCgiQWx0X0wiLCBWS19MTUVOVSk7CisgICAgd2luZG93c0tleU1hcCgpLnNl dCgiQWx0X1IiLCBWS19STUVOVSk7CiAgICAgd2luZG93c0tleU1hcCgpLnNldCgiSVNPX0xldmVs M19TaGlmdCIsIFZLX01FTlUpOwogICAgIHdpbmRvd3NLZXlNYXAoKS5zZXQoIk1lbnUiLCBWS19N RU5VKTsKLSAgICB3aW5kb3dzS2V5TWFwKCkuc2V0KCJTaGlmdF9MIiwgVktfU0hJRlQpOwotICAg IHdpbmRvd3NLZXlNYXAoKS5zZXQoIlNoaWZ0X1IiLCBWS19TSElGVCk7Ci0gICAgd2luZG93c0tl eU1hcCgpLnNldCgiQ29udHJvbF9MIiwgVktfQ09OVFJPTCk7Ci0gICAgd2luZG93c0tleU1hcCgp LnNldCgiQ29udHJvbF9SIiwgVktfQ09OVFJPTCk7CisgICAgd2luZG93c0tleU1hcCgpLnNldCgi U2hpZnRfTCIsIFZLX0xTSElGVCk7CisgICAgd2luZG93c0tleU1hcCgpLnNldCgiU2hpZnRfUiIs IFZLX1JTSElGVCk7CisgICAgd2luZG93c0tleU1hcCgpLnNldCgiQ29udHJvbF9MIiwgVktfTENP TlRST0wpOworICAgIHdpbmRvd3NLZXlNYXAoKS5zZXQoIkNvbnRyb2xfUiIsIFZLX1JDT05UUk9M KTsKICAgICB3aW5kb3dzS2V5TWFwKCkuc2V0KCJQYXVzZSIsIFZLX1BBVVNFKTsKICAgICB3aW5k b3dzS2V5TWFwKCkuc2V0KCJCcmVhayIsIFZLX1BBVVNFKTsKICAgICB3aW5kb3dzS2V5TWFwKCku c2V0KCJDYXBzX0xvY2siLCBWS19DQVBJVEFMKTsKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxv ZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzMGYxNTFlM2U5MmNjNjRiYjBiYWIyNGFlZGI2NGJl YTQ0NWRlZjFjLi43NWViNjg0N2ZjOGI1NmZiMjI3ODUzZGQ4ZWQ2YzA5OTI5ZmZkNDc2IDEwMDY0 NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTcgQEAKKzIwMTItMDUtMjIgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPHJha3Vjb0B3ZWJraXQu b3JnPgorCisgICAgICAgIFtFRkxdIE1vZGlmeSBrZXljb2RlIGNvbnZlcnNpb24gZnVuY3Rpb25z IHRvIHJldHVybiBrZXljb2RlcyB3aXRoIGxvY2F0aW9uIGluZm9ybWF0aW9uIGFmdGVyIHIxMTgw MDEuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NzIw MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCB0 aGUgcmVxdWlyZWQgY2hhbmdlcyB0byBtYWtlCisgICAgICAgIGZhc3QvZXZlbnRzL2tleWRvd24t bGVmdHJpZ2h0LWtleXMuaHRtbCBwYXNzIGFmdGVyIHIxMTgwMDEuCisKKyAgICAgICAgKiBEdW1w UmVuZGVyVHJlZS9lZmwvRXZlbnRTZW5kZXIuY3BwOgorICAgICAgICAoa2V5TmFtZUZyb21KU1Zh bHVlKTogVHJhbnNsYXRlICJ7bGVmdCxyaWdodH17U2hpZnQsQWx0LENvbnRyb2x9IgorICAgICAg ICBpbnRvIHRoZSBwcm9wZXIgWDExIGtleXN5bSBkZWZpbml0aW9ucy4KKwogMjAxMi0wNS0yMiAg WGlhbnpodSBXYW5nICA8d2FuZ3hpYW56aHVAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJv bWl1bV0gTW92ZSBjb25kaXRpb25zIGluIER1bXBSZW5kZXJUcmVlLmd5cGkgaW50byBEdW1wUmVu ZGVyVHJlZS5neXAKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9FdmVudFNl bmRlci5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRXZlbnRTZW5kZXIuY3BwCmluZGV4 IGVlMGNmNGE5Y2QzZWE3YjY1ZTQwYzUzYzJkYTExZjhkNGFlZTQzODkuLjVkYTcyNWE3MTIwNTNm YTNjMDU2YjE2ODk0OWI2Y2FmODAzZjQ5ZmQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJU cmVlL2VmbC9FdmVudFNlbmRlci5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0V2 ZW50U2VuZGVyLmNwcApAQCAtNDE0LDYgKzQxNCwxOCBAQCBzdGF0aWMgS2V5RXZlbnRJbmZvKiBr ZXlOYW1lRnJvbUpTVmFsdWUoSlNTdHJpbmdSZWYgY2hhcmFjdGVyLCB1bnNpZ25lZCBtb2RpZmll cgogICAgICAgICByZXR1cm4gbmV3IEtleUV2ZW50SW5mbygiUHJpbnQiLCAiIiwgbW9kaWZpZXJz KTsKICAgICBpZiAoZXF1YWxzKGNoYXJhY3RlciwgIm1lbnUiKSkKICAgICAgICAgcmV0dXJuIG5l dyBLZXlFdmVudEluZm8oIk1lbnUiLCAiIiwgbW9kaWZpZXJzKTsKKyAgICBpZiAoZXF1YWxzKGNo YXJhY3RlciwgImxlZnRDb250cm9sIikpCisgICAgICAgIHJldHVybiBuZXcgS2V5RXZlbnRJbmZv KCJDb250cm9sX0wiLCAiIiwgbW9kaWZpZXJzKTsKKyAgICBpZiAoZXF1YWxzKGNoYXJhY3Rlciwg InJpZ2h0Q29udHJvbCIpKQorICAgICAgICByZXR1cm4gbmV3IEtleUV2ZW50SW5mbygiQ29udHJv bF9SIiwgIiIsIG1vZGlmaWVycyk7CisgICAgaWYgKGVxdWFscyhjaGFyYWN0ZXIsICJsZWZ0U2hp ZnQiKSkKKyAgICAgICAgcmV0dXJuIG5ldyBLZXlFdmVudEluZm8oIlNoaWZ0X0wiLCAiIiwgbW9k aWZpZXJzKTsKKyAgICBpZiAoZXF1YWxzKGNoYXJhY3RlciwgInJpZ2h0U2hpZnQiKSkKKyAgICAg ICAgcmV0dXJuIG5ldyBLZXlFdmVudEluZm8oIlNoaWZ0X1IiLCAiIiwgbW9kaWZpZXJzKTsKKyAg ICBpZiAoZXF1YWxzKGNoYXJhY3RlciwgImxlZnRBbHQiKSkKKyAgICAgICAgcmV0dXJuIG5ldyBL ZXlFdmVudEluZm8oIkFsdF9MIiwgIiIsIG1vZGlmaWVycyk7CisgICAgaWYgKGVxdWFscyhjaGFy YWN0ZXIsICJyaWdodEFsdCIpKQorICAgICAgICByZXR1cm4gbmV3IEtleUV2ZW50SW5mbygiQWx0 X1IiLCAiIiwgbW9kaWZpZXJzKTsKICAgICBpZiAoZXF1YWxzKGNoYXJhY3RlciwgIkYxIikpCiAg ICAgICAgIHJldHVybiBuZXcgS2V5RXZlbnRJbmZvKCJGMSIsICIiLCBtb2RpZmllcnMpOwogICAg IGlmIChlcXVhbHMoY2hhcmFjdGVyLCAiRjIiKSkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0No YW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA5NWNlZTY0YWE4YmY3NDM0Mzli YWYwYzc4NjQ5MWE4NTRhOGIwZDIwLi40OTJhZWE5ZWQzNGM5OWQyOTFiZWJkYTJmZTI5OThmMWUx NzAwNjg1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTItMDUtMjIgIFJhcGhhZWwgS3VibyBk YSBDb3N0YSAgPHJha3Vjb0B3ZWJraXQub3JnPgorCisgICAgICAgIFtFRkxdIE1vZGlmeSBrZXlj b2RlIGNvbnZlcnNpb24gZnVuY3Rpb25zIHRvIHJldHVybiBrZXljb2RlcyB3aXRoIGxvY2F0aW9u IGluZm9ybWF0aW9uIGFmdGVyIHIxMTgwMDEuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD04NzIwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZWZsL3Rlc3RfZXhwZWN0YXRpb25zLnR4dDog VW5za2lwIGZhc3QvZXZlbnRzL2tleWRvd24tbGVmdHJpZ2h0LWtleXMuaHRtbC4KKwogMjAxMi0w NS0yMiAgSmVzc2llIEJlcmxpbiAgPGpiZXJsaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtNYWMg V0syXSBwbGF0Zm9ybS9tYWMtd2syL3BsdWdpbnMvbW91c2UtZXZlbnRzLXNjYWxlZC5odG1sIGZh aWxpbmcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC90ZXN0X2V4cGVjdGF0 aW9ucy50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvdGVzdF9leHBlY3RhdGlvbnMudHh0 CmluZGV4IDQ0YTYwMjI5YzIzNzNlYTE1YWE0NTljZjZmN2FmMzRiOTA1ZTJmYzcuLmFjNDA1MTM3 OTdhZjQ1Y2Y5Njg2NzU0NjYxM2VmMTVhNzdjZDA5N2MgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L3BsYXRmb3JtL2VmbC90ZXN0X2V4cGVjdGF0aW9ucy50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vZWZsL3Rlc3RfZXhwZWN0YXRpb25zLnR4dApAQCAtNjQwLDYgKzY0MCwzIEBAIEJVR1dL ODY2MzcgOiBlZGl0aW5nL3NwZWxsaW5nL3NwZWxsY2hlY2stcGFzdGUtZGlzYWJsZWQuaHRtbCA9 IFRFWFQKIEJVR1dLODY2MzcgOiBlZGl0aW5nL3NwZWxsaW5nL3NwZWxsY2hlY2stcXVldWUuaHRt bCA9IFRFWFQKIEJVR1dLODY2MzcgOiBlZGl0aW5nL3NwZWxsaW5nL3NwZWxsY2hlY2stc2VxdWVu Y2VudW0uaHRtbCA9IFRFWFQKIEJVR1dLODY2MzcgOiBlZGl0aW5nL3NwZWxsaW5nL3NwZWxsaW5n LW1hcmtlci1kZXNjcmlwdGlvbi5odG1sID0gVEVYVAotCi0vLyBUaGUgRUZMIHBvcnQgbmVlZHMg dG8gaW1wbGVtZW50IERPTV9LRVlfTE9DQVRJT05fTEVGVCBhbmQgRE9NX0tFWV9MT0NBVElPTl9S SUdIVAotQlVHV0s4NjY5NCA6IGZhc3QvZXZlbnRzL2tleWRvd24tbGVmdHJpZ2h0LWtleXMuaHRt bCA9IFRFWFQK