87195 2012-05-22 18:41:48 -0700 REGRESSION(r92695, r112399): insertHTML doesn't respect current selection range and inserts HTML to incorrect position 2012-05-24 17:29:15 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All All RESOLVED FIXED InRadar, Regression P1 Normal --- 1 jaroslav.benc rniwa adele ap enrica leandrogracia max.hong.shen rniwa tony webkit.review.bot oldest_to_newest 631059 0 jaroslav.benc 2012-05-22 18:41:48 -0700 Copy / paste text as described in the attached example Note that this breaks web-based editors using insertHTML to paste text from clipboard (safe paste) We have observed it on the DEV channel for some time, now it's in the BETA channel but not in the STABLE. Observed in Chrome 20 (BETA) and reported here - https://code.google.com/p/chromium/issues/detail?id=129283 631060 1 143431 jaroslav.benc 2012-05-22 18:42:49 -0700 Created attachment 143431 Text case - copy/paste text in the editable area as described in the example 632122 2 ap 2012-05-23 15:42:16 -0700 Could you please mentioned which editors are broken, and describe what goes wrong in those? The results in the test case are quite dramatic, is this what happens on actual sites too? 632128 3 ap 2012-05-23 15:51:03 -0700 I have a fairly long range: <http://trac.webkit.org/log/trunk/?rev=112406&stop_rev=112382> Perhaps <http://trac.webkit.org/changeset/112389> "Selectively retrieve text content around a given position" or <http://trac.webkit.org/changeset/112399> "An extra line break is inserted when pasting into a font element"? 632130 4 ap 2012-05-23 15:51:22 -0700 <rdar://problem/11519707> 632132 5 ap 2012-05-23 15:53:22 -0700 There latter seems more likely, of course. 632140 6 rniwa 2012-05-23 16:03:11 -0700 It's likely http://trac.webkit.org/changeset/112399. 632727 7 max.hong.shen 2012-05-24 06:42:49 -0700 I will look at it. (In reply to comment #6) > It's likely http://trac.webkit.org/changeset/112399. 633303 8 rniwa 2012-05-24 15:36:28 -0700 This regression came from the combination of r92695 and r112399. It's a very sneaky bug. 633347 9 143918 rniwa 2012-05-24 16:28:07 -0700 Created attachment 143918 Fixes the bug 633359 10 rniwa 2012-05-24 16:40:00 -0700 That was quick. Thanks! 633397 11 max.hong.shen 2012-05-24 17:28:05 -0700 Thanks for fixing it. Sorry I didn't get a chance to work on it during the day, and was about to look at it with my son tonight, then I saw your fix :-) Thanks again! (In reply to comment #10) > That was quick. Thanks! 633399 12 143918 webkit.review.bot 2012-05-24 17:29:10 -0700 Comment on attachment 143918 Fixes the bug Clearing flags on attachment: 143918 Committed r118449: <http://trac.webkit.org/changeset/118449> 633400 13 webkit.review.bot 2012-05-24 17:29:15 -0700 All reviewed patches have been landed. Closing bug. 143431 2012-05-22 18:42:49 -0700 2012-05-22 18:42:49 -0700 Text case - copy/paste text in the editable area as described in the example insertHTML.html text/html 632 jaroslav.benc PGJvZHk+DQo8Yj4gSG93IHRvIHJlcHJvZHVjZTogPC9iPjxicj4NCi0gZG91YmxlIGNsaWNrIG9u ICJjb3B5QW5kUGFzdGVNZSIgPGJyPg0KLSBDVFJMK0MgPGJyPg0KLSBDVExSK1YgPGJyPg0KCTxw cmUgaWQ9InRlc3QiIGNvbnRlbnRFZGl0YWJsZT0idHJ1ZSIgc3R5bGU9ImJvcmRlcjoxcHggc29s aWQgYmxhY2siPg0KCQk8Yj50ZXN0IDxpPmNvcHlBbmRQYXN0ZU1lPTwvaT48L2I+DQoJPC9wcmU+ DQoJDQoJPHNjcmlwdD4NCgkJZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRlc3QiKS5hZGRFdmVu dExpc3RlbmVyKCJwYXN0ZSIsIGZ1bmN0aW9uKGV2KXsNCgkJCWRvY3VtZW50LmV4ZWNDb21tYW5k KCdJbnNlcnRIdG1sJywgZmFsc2UsIGV2LmNsaXBib2FyZERhdGEuZ2V0RGF0YSgidGV4dC9wbGFp biIpKTsgICAgICAgICAgICAgICAgICAgICAgICAJCQkNCgkJCWV2LnByZXZlbnREZWZhdWx0KCk7 CQkJDQoJCX0sIGZhbHNlKTsNCgk8L3NjcmlwdD4NCgkNCjxiPiBJbmNvcnJlY3QgcmVzdWx0IGlu IENocm9tZSAyMCBiZXRhOiA8L2I+IGNvcHlBbmRQYXN0ZU1ldGVzdCA9PGJyPg0KPGI+IENvcnJl Y3QgcmVzdWx0IGluIENocm9tZSAxOTogPC9iPiB0ZXN0IGNvcHlBbmRQYXN0ZU1lPTxicj4NCjwv Ym9keT4= 143918 2012-05-24 16:28:07 -0700 2012-05-24 17:29:10 -0700 Fixes the bug bug-87195-20120524163127.patch text/plain 4577 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExODQzNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA1LTI0ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIxMTIzOTkp OiBpbnNlcnRIVE1MIGRvZXNuJ3QgcmVzcGVjdCBjdXJyZW50IHNlbGVjdGlvbiByYW5nZSBhbmQg aW5zZXJ0cyBIVE1MIHRvIGluY29ycmVjdCBwb3NpdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODcxOTUKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgYnVnIHdhcyBjYXVzZWQgYnkgb3VyIHBhc3Np bmcgaW5zZXJ0aW9uUG9zLmFuY2hvck5vZGUoKSB0byBzcGxpdFRyZWVUb05vZGUncyBzdGFydCBu b2RlIGV2ZW4gd2hlbgorICAgICAgICB0aGUgcG9zaXRpb24ncyB0eXBlIHdhcyBhbiBvZmZzZXQg aW4gYSBjb250YWluZXIuIEZpeGVkIHRoZSBidWcgYnkgcGFzc2luZyB0aGUgbm9kZSBhZnRlciB0 aGUgaW5zZXJ0IHBvc2l0aW9uCisgICAgICAgIG9yIHRoZSBjb250YWluZXIgbm9kZSBpZiB0aGUg cG9zaXRpb24gaXMgYXQgdGhlIGVuZCBvZiB0aGUgY29udGFpbmVyLgorCisgICAgICAgIFRlc3Q6 IGVkaXRpbmcvcGFzdGVib2FyZC9wYXN0ZS1hdC1lbmQtb2Ytbm9kZS1mb2xsb3dlZC1ieS1pbmxp bmUtZWxlbWVudC5odG1sCisKKyAgICAgICAgKiBlZGl0aW5nL1JlcGxhY2VTZWxlY3Rpb25Db21t YW5kLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlcGxhY2VTZWxlY3Rpb25Db21tYW5kOjpkb0Fw cGx5KToKKwogMjAxMi0wNS0yNCAgQ3J5c3RhbCBaaGFuZyAgPGhhaXpoYW5nQHJpbS5jb20+CiAK ICAgICAgICAgW0JsYWNrQmVycnldIEltcGxlbWVudCBzZWxlY3QgcG9wdXAgYW5kIHJlbW92ZSBv bGQgaG9vayB0byBhaXIgcG9wdXAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvUmVwbGFj ZVNlbGVjdGlvbkNvbW1hbmQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2VkaXRp bmcvUmVwbGFjZVNlbGVjdGlvbkNvbW1hbmQuY3BwCShyZXZpc2lvbiAxMTgzOTQpCisrKyBTb3Vy Y2UvV2ViQ29yZS9lZGl0aW5nL1JlcGxhY2VTZWxlY3Rpb25Db21tYW5kLmNwcAkod29ya2luZyBj b3B5KQpAQCAtOTM2LDcgKzkzNiwxMCBAQCB2b2lkIFJlcGxhY2VTZWxlY3Rpb25Db21tYW5kOjpk b0FwcGx5KCkKIAogICAgICAgICBpZiAoUmVmUHRyPE5vZGU+IG5vZGVUb1NwbGl0VG8gPSBub2Rl VG9TcGxpdFRvQXZvaWRQYXN0aW5nSW50b0lubGluZU5vZGVzV2l0aFN0eWxlKGluc2VydGlvblBv cykpIHsKICAgICAgICAgICAgIGlmIChpbnNlcnRpb25Qb3MuY29udGFpbmVyTm9kZSgpICE9IG5v ZGVUb1NwbGl0VG8tPnBhcmVudE5vZGUoKSkgewotICAgICAgICAgICAgICAgIG5vZGVUb1NwbGl0 VG8gPSBzcGxpdFRyZWVUb05vZGUoaW5zZXJ0aW9uUG9zLmFuY2hvck5vZGUoKSwgbm9kZVRvU3Bs aXRUby0+cGFyZW50Tm9kZSgpKS5nZXQoKTsKKyAgICAgICAgICAgICAgICBOb2RlKiBzcGxpdFN0 YXJ0ID0gaW5zZXJ0aW9uUG9zLmNvbXB1dGVOb2RlQWZ0ZXJQb3NpdGlvbigpOworICAgICAgICAg ICAgICAgIGlmICghc3BsaXRTdGFydCkKKyAgICAgICAgICAgICAgICAgICAgc3BsaXRTdGFydCA9 IGluc2VydGlvblBvcy5jb250YWluZXJOb2RlKCk7CisgICAgICAgICAgICAgICAgbm9kZVRvU3Bs aXRUbyA9IHNwbGl0VHJlZVRvTm9kZShzcGxpdFN0YXJ0LCBub2RlVG9TcGxpdFRvLT5wYXJlbnRO b2RlKCkpLmdldCgpOwogICAgICAgICAgICAgICAgIGluc2VydGlvblBvcyA9IHBvc2l0aW9uSW5Q YXJlbnRCZWZvcmVOb2RlKG5vZGVUb1NwbGl0VG8uZ2V0KCkpOwogICAgICAgICAgICAgfQogICAg ICAgICB9CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMTg0MzcpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VM b2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wNS0yNCAgUnlvc3VrZSBO aXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTEyMzk5KTog aW5zZXJ0SFRNTCBkb2Vzbid0IHJlc3BlY3QgY3VycmVudCBzZWxlY3Rpb24gcmFuZ2UgYW5kIGlu c2VydHMgSFRNTCB0byBpbmNvcnJlY3QgcG9zaXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3MTk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgcmVncmVzc2lvbiB0ZXN0LgorCisgICAgICAg ICogZWRpdGluZy9wYXN0ZWJvYXJkL3Bhc3RlLWF0LWVuZC1vZi1ub2RlLWZvbGxvd2VkLWJ5LWlu bGluZS1lbGVtZW50LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZWRpdGluZy9wYXN0 ZWJvYXJkL3Bhc3RlLWF0LWVuZC1vZi1ub2RlLWZvbGxvd2VkLWJ5LWlubGluZS1lbGVtZW50Lmh0 bWw6IEFkZGVkLgorCiAyMDEyLTA1LTI0ICBKZXNzaWUgQmVybGluICA8amJlcmxpbkBhcHBsZS5j b20+CiAKICAgICAgICAgW1dpbl0gTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vc2VsZWN0 aW9uLXBsdWdpbi1jbGVhci1jcmFzaC5odG1sIGNyYXNoZXMKSW5kZXg6IExheW91dFRlc3RzL2Vk aXRpbmcvcGFzdGVib2FyZC9wYXN0ZS1hdC1lbmQtb2Ytbm9kZS1mb2xsb3dlZC1ieS1pbmxpbmUt ZWxlbWVudC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZWRpdGluZy9w YXN0ZWJvYXJkL3Bhc3RlLWF0LWVuZC1vZi1ub2RlLWZvbGxvd2VkLWJ5LWlubGluZS1lbGVtZW50 LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2VkaXRpbmcvcGFzdGVi b2FyZC9wYXN0ZS1hdC1lbmQtb2Ytbm9kZS1mb2xsb3dlZC1ieS1pbmxpbmUtZWxlbWVudC1leHBl Y3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsOSBAQAorVGhpcyB0ZXN0cyBpbnNlcnRp bmcgYSB0ZXh0IGluIHRoZSBtaWRkbGUgb2YgYSB0ZXh0IG5vZGUuIFlvdSBzaG91bGQgc2VlICIx IFR3byAzIiBiZWxvdy4KK3wgPGI+Cit8ICAgIjEgIgorfCAiVHdvPCNzZWxlY3Rpb24tY2FyZXQ+ IgorfCA8Yj4KK3wgICA8aT4KK3wgICAgICIgMyIKK3wgIgorIgpJbmRleDogTGF5b3V0VGVzdHMv ZWRpdGluZy9wYXN0ZWJvYXJkL3Bhc3RlLWF0LWVuZC1vZi1ub2RlLWZvbGxvd2VkLWJ5LWlubGlu ZS1lbGVtZW50Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZWRpdGluZy9wYXN0ZWJv YXJkL3Bhc3RlLWF0LWVuZC1vZi1ub2RlLWZvbGxvd2VkLWJ5LWlubGluZS1lbGVtZW50Lmh0bWwJ KHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9lZGl0aW5nL3Bhc3RlYm9hcmQvcGFzdGUtYXQt ZW5kLW9mLW5vZGUtZm9sbG93ZWQtYnktaW5saW5lLWVsZW1lbnQuaHRtbAkocmV2aXNpb24gMCkK QEAgLTAsMCArMSwyMCBAQAorPCFET0NUWVBFIGh0bWw+DQorPGh0bWw+DQorPGJvZHk+DQorPHAg aWQ9ImRlc2NyaXB0aW9uIj5UaGlzIHRlc3RzIGluc2VydGluZyBhIHRleHQgaW4gdGhlIG1pZGRs ZSBvZiBhIHRleHQgbm9kZS4gWW91IHNob3VsZCBzZWUgIjEgVHdvIDMiIGJlbG93LjwvcD4NCis8 cHJlIGlkPSJ0ZXN0IiBjb250ZW50RWRpdGFibGU9InRydWUiIHN0eWxlPSJib3JkZXI6MXB4IHNv bGlkIGJsYWNrIj4NCis8Yj4xIDxpPjIgMzwvaT48L2I+DQorPC9wcmU+DQorPHNjcmlwdCBzcmM9 Ii4uLy4uL3Jlc291cmNlcy9kdW1wLWFzLW1hcmt1cC5qcyI+PC9zY3JpcHQ+DQorPHNjcmlwdD4N CitnZXRTZWxlY3Rpb24oKS5zZWxlY3RBbGxDaGlsZHJlbihkb2N1bWVudC5xdWVyeVNlbGVjdG9y KCdpJykpOw0KK3ZhciB0ZXh0ID0gZG9jdW1lbnQucXVlcnlTZWxlY3RvcignaScpLmZpcnN0Q2hp bGQ7DQorZ2V0U2VsZWN0aW9uKCkuc2V0QmFzZUFuZEV4dGVudCh0ZXh0LCAwLCB0ZXh0LCAxKTsN Citkb2N1bWVudC5leGVjQ29tbWFuZCgnSW5zZXJ0SHRtbCcsIGZhbHNlLCAnVHdvJyk7DQorDQor TWFya3VwLmRlc2NyaXB0aW9uKGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdkZXNjcmlwdGlvbicp LnRleHRDb250ZW50KTsNCitNYXJrdXAuZHVtcCgndGVzdCcpOw0KKw0KKzwvc2NyaXB0Pg0KKzwv Ym9keT4NCis8L2h0bWw+DQo=