87179 2012-05-22 16:17:04 -0700 DFG CSE should eliminate redundant WeakJSConstants 2012-05-25 16:01:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo webkit-unassigned oldest_to_newest 630885 0 fpizlo 2012-05-22 16:17:04 -0700 This will allow it to eliminate more redundant CheckStructures. This is only going to be a tiny win, since the bytecode parser usually eliminates these (it only misses those cases that are later revealed by CFG simplification). But it's an easy change, so it's worth it. 630898 1 143393 fpizlo 2012-05-22 16:25:26 -0700 Created attachment 143393 the patch 631336 2 fpizlo 2012-05-23 00:39:30 -0700 Landed in http://trac.webkit.org/changeset/118141 634391 3 fpizlo 2012-05-25 16:01:18 -0700 Merged in http://trac.webkit.org/changeset/118582 143393 2012-05-22 16:25:26 -0700 2012-05-22 16:28:36 -0700 the patch weakjsconst_cse_patch_1.diff text/plain 2489 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTE4MDc3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDEyLTA1LTIyICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHIENTRSBzaG91bGQgZWxpbWluYXRlIHJlZHVuZGFudCBXZWFrSlNDb25zdGFudHMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3MTc5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBkZmcvREZHQ1NFUGhh c2UuY3BwOgorICAgICAgICAoSlNDOjpERkc6OkNTRVBoYXNlOjp3ZWFrQ29uc3RhbnRDU0UpOgor ICAgICAgICAoQ1NFUGhhc2UpOgorICAgICAgICAoSlNDOjpERkc6OkNTRVBoYXNlOjpwZXJmb3Jt Tm9kZUNTRSk6CisgICAgICAgICogZGZnL0RGR05vZGUuaDoKKyAgICAgICAgKEpTQzo6REZHOjpO b2RlOjp3ZWFrQ29uc3RhbnQpOgorCiAyMDEyLTA1LTIxICBGaWxpcCBQaXpsbyAgPGZwaXpsb0Bh cHBsZS5jb20+CiAKICAgICAgICAgREZHIENvbnZlcnRUaGlzIHNob3VsZCBqdXN0IGJlIGEgQ2hl Y2tTdHJ1Y3R1cmUgaWYgdGhlIHN0cnVjdHVyZSBpcyBrbm93bgpJbmRleDogU291cmNlL0phdmFT Y3JpcHRDb3JlL2RmZy9ERkdDU0VQaGFzZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL2RmZy9ERkdDU0VQaGFzZS5jcHAJKHJldmlzaW9uIDExODA2MCkKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQ1NFUGhhc2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x NDAsNiArMTQwLDIyIEBAIHByaXZhdGU6CiAgICAgICAgIHJldHVybiBOb05vZGU7CiAgICAgfQog ICAgIAorICAgIE5vZGVJbmRleCB3ZWFrQ29uc3RhbnRDU0UoTm9kZSYgbm9kZSkKKyAgICB7Cisg ICAgICAgIGZvciAodW5zaWduZWQgaSA9IGVuZEluZGV4Rm9yUHVyZUNTRSgpOyBpLS07KSB7Cisg ICAgICAgICAgICBOb2RlSW5kZXggaW5kZXggPSBtX2N1cnJlbnRCbG9jay0+YXQoaSk7CisgICAg ICAgICAgICBOb2RlJiBvdGhlck5vZGUgPSBtX2dyYXBoW2luZGV4XTsKKyAgICAgICAgICAgIGlm IChvdGhlck5vZGUub3AoKSAhPSBXZWFrSlNDb25zdGFudCkKKyAgICAgICAgICAgICAgICBjb250 aW51ZTsKKyAgICAgICAgICAgIAorICAgICAgICAgICAgaWYgKG90aGVyTm9kZS53ZWFrQ29uc3Rh bnQoKSAhPSBub2RlLndlYWtDb25zdGFudCgpKQorICAgICAgICAgICAgICAgIGNvbnRpbnVlOwor ICAgICAgICAgICAgCisgICAgICAgICAgICByZXR1cm4gaW5kZXg7CisgICAgICAgIH0KKyAgICAg ICAgcmV0dXJuIE5vTm9kZTsKKyAgICB9CisgICAgCiAgICAgTm9kZUluZGV4IGltcHVyZUNTRShO b2RlJiBub2RlKQogICAgIHsKICAgICAgICAgTm9kZUluZGV4IGNoaWxkMSA9IGNhbm9uaWNhbGl6 ZShub2RlLmNoaWxkMSgpKTsKQEAgLTY1MCw2ICs2NjYsMTEgQEAgcHJpdmF0ZToKICAgICAgICAg ICAgIHNldFJlcGxhY2VtZW50KGNvbnN0YW50Q1NFKG5vZGUpKTsKICAgICAgICAgICAgIGJyZWFr OwogICAgICAgICAgICAgCisgICAgICAgIGNhc2UgV2Vha0pTQ29uc3RhbnQ6CisgICAgICAgICAg ICAvLyBGSVhNRTogaGF2ZSBDU0UgZm9yIHdlYWsgY29uc3RhbnRzIGFnYWluc3Qgc3Ryb25nIGNv bnN0YW50cyBhbmQgdmljZS12ZXJzYS4KKyAgICAgICAgICAgIHNldFJlcGxhY2VtZW50KHdlYWtD b25zdGFudENTRShub2RlKSk7CisgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgIAogICAg ICAgICBjYXNlIEdldEFycmF5TGVuZ3RoOgogICAgICAgICAgICAgc2V0UmVwbGFjZW1lbnQoaW1w dXJlQ1NFKG5vZGUpKTsKICAgICAgICAgICAgIGJyZWFrOwpJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdOb2RlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L2RmZy9ERkdOb2RlLmgJKHJldmlzaW9uIDExODA2MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kZmcvREZHTm9kZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0yMzQsNiArMjM0LDcgQEAgc3RydWN0 IE5vZGUgewogICAgIAogICAgIEpTQ2VsbCogd2Vha0NvbnN0YW50KCkKICAgICB7CisgICAgICAg IEFTU0VSVChvcCgpID09IFdlYWtKU0NvbnN0YW50KTsKICAgICAgICAgcmV0dXJuIGJpdHdpc2Vf Y2FzdDxKU0NlbGwqPihtX29wSW5mbyk7CiAgICAgfQogICAgIAo=