87176 2012-05-22 15:57:17 -0700 [Chromium] Move conditions in DumpRenderTree.gypi into DumpRenderTree.gyp 2012-05-22 17:20:27 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66687 1 wangxianzhu wangxianzhu abarth tkent tony webkit.review.bot oldest_to_newest 630861 0 wangxianzhu 2012-05-22 15:57:17 -0700 For now both DumpRenderTree.gypi and DumpRenderTree.gyp contain conditions about DumpRenderTree sources. I think we should move all conditions into DumpRenderTree.gyp. Some conditions in DumpRenderTree.gypi (e.g. the ones about win and mac) are also redundant and should be removed. 630888 1 143391 wangxianzhu 2012-05-22 16:19:07 -0700 Created attachment 143391 patch 630960 2 143391 webkit.review.bot 2012-05-22 17:20:22 -0700 Comment on attachment 143391 patch Clearing flags on attachment: 143391 Committed r118085: <http://trac.webkit.org/changeset/118085> 630961 3 webkit.review.bot 2012-05-22 17:20:27 -0700 All reviewed patches have been landed. Closing bug. 143391 2012-05-22 16:19:07 -0700 2012-05-22 17:20:22 -0700 patch 87176 text/plain 3544 wangxianzhu SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDExODA3NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDEyLTA1LTIyICBYaWFuemh1IFdhbmcgIDx3YW5neGlhbnpodUBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBNb3ZlIGNvbmRpdGlvbnMgaW4gRHVtcFJlbmRl clRyZWUuZ3lwaSBpbnRvIER1bXBSZW5kZXJUcmVlLmd5cAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODcxNzYKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVl Lmd5cC9EdW1wUmVuZGVyVHJlZS5neXA6CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvRHVtcFJl bmRlclRyZWUuZ3lwaToKKwogMjAxMi0wNS0yMiAgSmVzc2llIEJlcmxpbiAgPGpiZXJsaW5AYXBw bGUuY29tPgogCiAgICAgICAgIFdUUiBmaXggYWZ0ZXIgcjExODAwMS4KSW5kZXg6IFRvb2xzL0R1 bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLmd5cGkKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvRHVt cFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUuZ3lwaQkocmV2aXNpb24gMTE4MDY4KQorKysgVG9v bHMvRHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUuZ3lwaQkod29ya2luZyBjb3B5KQpAQCAt MzcsNiArMzcsNyBAQAogICAgICAgICAgICAgJ2Nocm9taXVtL1Rlc3RTaGVsbExpbnV4LmNwcCcs CiAgICAgICAgICAgICAnY2hyb21pdW0vVGVzdFNoZWxsR3RrLmNwcCcsCiAgICAgICAgICAgICAn Y2hyb21pdW0vVGVzdFNoZWxsTWFjLm1tJywKKyAgICAgICAgICAgICdjaHJvbWl1bS9UZXN0U2hl bGxTdHViLmNwcCcsCiAgICAgICAgICAgICAnY2hyb21pdW0vVGVzdFNoZWxsV2luLmNwcCcsCiAg ICAgICAgICAgICAnY2hyb21pdW0vVGVzdFdlYlBsdWdpbi5jcHAnLAogICAgICAgICAgICAgJ2No cm9taXVtL1Rlc3RXZWJQbHVnaW4uaCcsCkBAIC00Niw2ICs0NywxMiBAQAogICAgICAgICAgICAg J2Nocm9taXVtL1dlYlBlcm1pc3Npb25zLmgnLAogICAgICAgICAgICAgJ2Nocm9taXVtL1dlYlBy ZWZlcmVuY2VzLmNwcCcsCiAgICAgICAgICAgICAnY2hyb21pdW0vV2ViUHJlZmVyZW5jZXMuaCcs CisgICAgICAgICAgICAnY2hyb21pdW0vV2ViVGhlbWVDb250cm9sRFJUV2luLmNwcCcsCisgICAg ICAgICAgICAnY2hyb21pdW0vV2ViVGhlbWVDb250cm9sRFJUV2luLmgnLAorICAgICAgICAgICAg J2Nocm9taXVtL1dlYlRoZW1lRW5naW5lRFJUTWFjLm1tJywKKyAgICAgICAgICAgICdjaHJvbWl1 bS9XZWJUaGVtZUVuZ2luZURSVE1hYy5oJywKKyAgICAgICAgICAgICdjaHJvbWl1bS9XZWJUaGVt ZUVuZ2luZURSVFdpbi5jcHAnLAorICAgICAgICAgICAgJ2Nocm9taXVtL1dlYlRoZW1lRW5naW5l RFJUV2luLmgnLAogICAgICAgICAgICAgJ2Nocm9taXVtL1dlYlVzZXJNZWRpYUNsaWVudE1vY2su Y3BwJywKICAgICAgICAgICAgICdjaHJvbWl1bS9XZWJVc2VyTWVkaWFDbGllbnRNb2NrLmgnLAog ICAgICAgICAgICAgJ2Nocm9taXVtL1dlYlZpZXdIb3N0LmNwcCcsCkBAIC03NCwyNiArODEsNSBA QAogICAgICAgICAgICAgJ1Rlc3ROZXRzY2FwZVBsdWdJbi9UZXN0cy9Qcml2YXRlQnJvd3Npbmcu Y3BwJywKICAgICAgICAgICAgICdUZXN0TmV0c2NhcGVQbHVnSW4vbWFpbi5jcHAnLAogICAgICAg ICBdLAotICAgICAgICAnY29uZGl0aW9ucyc6IFsKLSAgICAgICAgICAgIFsnKE9TPT0ibGludXgi IGFuZCB0b29sa2l0X3VzZXNfZ3RrIT0xKSBvciBPUz09ImFuZHJvaWQiJywgewotICAgICAgICAg ICAgICAgICdkcnRfZmlsZXMnOiBbCi0gICAgICAgICAgICAgICAgICAgICdjaHJvbWl1bS9UZXN0 U2hlbGxTdHViLmNwcCcsCi0gICAgICAgICAgICAgICAgXSwKLSAgICAgICAgICAgIH1dLAotICAg ICAgICAgICAgWydPUz09IndpbiInLCB7Ci0gICAgICAgICAgICAgICAgJ2RydF9maWxlcyc6IFsK LSAgICAgICAgICAgICAgICAgICAgJ2Nocm9taXVtL1dlYlRoZW1lQ29udHJvbERSVFdpbi5jcHAn LAotICAgICAgICAgICAgICAgICAgICAnY2hyb21pdW0vV2ViVGhlbWVDb250cm9sRFJUV2luLmgn LAotICAgICAgICAgICAgICAgICAgICAnY2hyb21pdW0vV2ViVGhlbWVFbmdpbmVEUlRXaW4uY3Bw JywKLSAgICAgICAgICAgICAgICAgICAgJ2Nocm9taXVtL1dlYlRoZW1lRW5naW5lRFJUV2luLmgn LAotICAgICAgICAgICAgICAgIF0sCi0gICAgICAgICAgICB9XSwKLSAgICAgICAgICAgIFsnT1M9 PSJtYWMiJywgewotICAgICAgICAgICAgICAgICdkcnRfZmlsZXMnOiBbCi0gICAgICAgICAgICAg ICAgICAgICdjaHJvbWl1bS9XZWJUaGVtZUVuZ2luZURSVE1hYy5tbScsCi0gICAgICAgICAgICAg ICAgICAgICdjaHJvbWl1bS9XZWJUaGVtZUVuZ2luZURSVE1hYy5oJywKLSAgICAgICAgICAgICAg ICBdLAotICAgICAgICAgICAgfV0sCi0gICAgICAgIF0sCiAgICAgfQogfQpJbmRleDogVG9vbHMv RHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUuZ3lwL0R1bXBSZW5kZXJUcmVlLmd5cAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJlZS9EdW1wUmVuZGVyVHJlZS5neXAvRHVtcFJl bmRlclRyZWUuZ3lwCShyZXZpc2lvbiAxMTgwNjgpCisrKyBUb29scy9EdW1wUmVuZGVyVHJlZS9E dW1wUmVuZGVyVHJlZS5neXAvRHVtcFJlbmRlclRyZWUuZ3lwCSh3b3JraW5nIGNvcHkpCkBAIC0x MDQsNiArMTA0LDEzIEBACiAgICAgICAgICAgICAgICAgJzxAKGRydF9maWxlcyknLAogICAgICAg ICAgICAgXSwKICAgICAgICAgICAgICdjb25kaXRpb25zJzogWworICAgICAgICAgICAgICAgIFsn T1M9PSJtYWMiIG9yIE9TPT0id2luIiBvciB0b29sa2l0X3VzZXNfZ3RrPT0xJywgeworICAgICAg ICAgICAgICAgICAgICAjIFRoZXNlIHBsYXRmb3JtcyBoYXZlIHRoZWlyIG93biBpbXBsZW1lbnRh dGlvbnMgb2YKKyAgICAgICAgICAgICAgICAgICAgIyBjaGVja0xheW91dFRlc3RTeXN0ZW1EZXBl bmRlbmNpZXMoKSBhbmQgb3BlblN0YXJ0dXBEaWFsb2coKS4KKyAgICAgICAgICAgICAgICAgICAg J3NvdXJjZXMvJzogWworICAgICAgICAgICAgICAgICAgICAgICAgWydleGNsdWRlJywgJ1Rlc3RT aGVsbFN0dWJcXC5jcHAkJ10sCisgICAgICAgICAgICAgICAgICAgIF0sCisgICAgICAgICAgICAg ICAgfV0sCiAgICAgICAgICAgICAgICAgWydPUz09IndpbiInLCB7CiAgICAgICAgICAgICAgICAg ICAgICdkZXBlbmRlbmNpZXMnOiBbCiAgICAgICAgICAgICAgICAgICAgICAgICAnTGF5b3V0VGVz dEhlbHBlcicsCg==