87171 2012-05-22 14:37:30 -0700 REGRESSION (r98359): Video does not render on http://panic.com/dietcoda/ 2012-05-22 17:23:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Mac OS X 10.7 RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 1 jer.noble jer.noble eric.carlson feature-media-reviews webkit.review.bot oldest_to_newest 630777 0 jer.noble 2012-05-22 14:37:30 -0700 REGRESSION (r98359): Video does not render on http://panic.com/dietcoda/ 630780 1 jer.noble 2012-05-22 14:39:37 -0700 Behavior is very timing-specific. Only occurs on platforms that support MediaPlayerPlatformAVFoundationObjC. (i.e. Mac >= Lion). 630781 2 jer.noble 2012-05-22 14:39:50 -0700 Aha. We get an "AssetMetadataLoaded" notification from MediaPlayerPrivateAVFoundationObjC and call metadataLoaded(), which calls prepareForRendering(). However, prepareForRendering() checks the m_readyState to see if it's at least HaveMetadata, and it's not, so the layer is never created. m_readyState is then updated to HaveMetadata when the notification calls updateStates(). 630782 3 jer.noble 2012-05-22 14:40:11 -0700 <rdar://problem/11497837> 630785 4 143368 jer.noble 2012-05-22 14:44:54 -0700 Created attachment 143368 Patch 630923 5 143368 mjs 2012-05-22 16:53:01 -0700 Comment on attachment 143368 Patch r=me 630967 6 jer.noble 2012-05-22 17:23:08 -0700 Committed r118087: <http://trac.webkit.org/changeset/118087> 143368 2012-05-22 14:44:54 -0700 2012-05-22 16:53:01 -0700 Patch bug-87171-20120522144453.patch text/plain 2285 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3ODU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmQxZTVlMTlhYThiYTU2 M2MzNmJiNWFjMjc1NTg4ZjI0MGYyNmY3Yi4uMTA0MGIwOTljYjQzMTBjMzQ2NjI5NjZiMjhjMDI4 YmE5NmVlNGI4MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA1LTIyICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHI5ODM1 OSk6IFZpZGVvIGRvZXMgbm90IHJlbmRlciBvbiBodHRwOi8vcGFuaWMuY29tL2RpZXRjb2RhLwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODcxNzEKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVz dHM7IGJlaGF2aW9yIGlzIHZlcnkgdGltaW5nIHNwZWNpZmljIGFuZCBvbmx5IG9jY3VycyBvbiBh IHN1YnNldCBvZiBhbGwgcGxhdGZvcm1zLgorCisgICAgICAgIEluc3RlYWQgb2YgY2FsbGluZyBw cmVwYXJlRm9yUmVuZGVyaW5nKCkgZnJvbSBtZXRhZGF0YUxvYWRlZCgpLCB3aGljaCBtYXkgZmFp bCBhbmQgY2F1c2Ugc3Vic2VxdWVudAorICAgICAgICBjYWxscyB0byBwcmVwYXJlRm9yUmVuZGVy aW5nKCkgdG8gc2hvcnQgY2lyY3VpdCwgY2FsbCBjcmVhdGVWaWRlb0xheWVyKCkgZGlyZWN0bHks IHdoaWNoIGFjaGlldmVzCisgICAgICAgIHRoZSBvcmlnaW5hbCBnb2FscyBvZiB0aGUgZml4IGZv ciBodHRwOi8vd2Via2l0Lm9yZy9iLzcwNDQ4LCBidXQgd2l0aG91dCBicmVha2luZyBzdWJzZXF1 ZW50IGNhbGxzCisgICAgICAgIHRvIHByZXBhcmVGb3JSZW5kZXJpbmcoKSBpZiBjYWxsZWQgYXQg dGhlIHdyb25nIHRpbWUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRp b24vTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 Ok1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbjo6bWV0YWRhdGFMb2FkZWQpOgorCiAyMDEy LTA1LTIxICBMdWNhcyBGb3JzY2hsZXIgIDxsZm9yc2NobGVyQGFwcGxlLmNvbT4KIAogICAgIE1l cmdlIDExNzY1MgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv YXZmb3VuZGF0aW9uL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbi5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vTWVkaWFQbGF5ZXJQcml2YXRl QVZGb3VuZGF0aW9uLmNwcAppbmRleCBhMjhjYWUyYWQ2ZDg4NWZiOTU5M2VhYjA3MDhmNjYwZDhk MWY1YTA4Li45M2M4N2JmMTZlNzdkMjI3MzBjMWUyN2NjM2MyZWM3ZGEyYjc0OTNiIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vTWVkaWFQ bGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9hdmZvdW5kYXRpb24vTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uLmNw cApAQCAtNTMxLDExICs1MzEsMTMgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRp b246Om1ldGFkYXRhTG9hZGVkKCkKICAgICBtX2xvYWRpbmdNZXRhZGF0YSA9IGZhbHNlOwogICAg IHRyYWNrc0NoYW5nZWQoKTsKIAorI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKICAg ICAvLyBBVkZvdW5kYXRpb24gd2lsbCBub3QgcmV0dXJuIHRydWUgZm9yIGZpcnN0VmlkZW9GcmFt ZUF2YWlsYWJsZSB1bnRpbAotICAgIC8vIGFuIEFWUGxheWVyTGF5ZXIgaGFzIGJlZW4gYWRkZWQg dG8gdGhlIEFWUGxheWVySXRlbSwgc28gY2FsbCBwcmVwYXJlRm9yUmVuZGVyaW5nKCkKKyAgICAv LyBhbiBBVlBsYXllckxheWVyIGhhcyBiZWVuIGFkZGVkIHRvIHRoZSBBVlBsYXllckl0ZW0sIHNv IGNhbGwgY3JlYXRlVmlkZW9MYXllcigpCiAgICAgLy8gaGVyZSB0byB0cmlnZ2VyIGFsbG9jYXRp b24gb2YgYSBBVlBsYXllckxheWVyLgogICAgIGlmIChtX2NhY2hlZEhhc1ZpZGVvKQotICAgICAg ICBwcmVwYXJlRm9yUmVuZGVyaW5nKCk7CisgICAgICAgIGNyZWF0ZVZpZGVvTGF5ZXIoKTsKKyNl bmRpZgogfQogCiB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbjo6cmF0ZUNoYW5n ZWQoKQo=