87153 2012-05-22 11:40:14 -0700 [chromium] Forcibly sync running animations in the waiting state when synchronized start times are needed. 2012-05-24 07:13:08 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 vollick vollick cc-bugs enne jamesr webkit.review.bot oldest_to_newest 630598 0 vollick 2012-05-22 11:40:14 -0700 Currently, when we force a sync of the animations, we blindly copy them to the impl thread. This is a problem if the main thread is waiting for a synchronized start time and the animation has already started on the main thread. In this case, we would copy the running animation over to the impl thread, where it would happily tick, but would never send an 'animation started' notification to the main thread. If the main thread animation requires this notification, we must copy the animation over in a 'waiting' state. 630600 1 143336 vollick 2012-05-22 11:42:03 -0700 Created attachment 143336 Patch 632113 2 143336 jamesr 2012-05-23 15:27:32 -0700 Comment on attachment 143336 Patch Looks good. 632749 3 143336 webkit.review.bot 2012-05-24 07:13:03 -0700 Comment on attachment 143336 Patch Clearing flags on attachment: 143336 Committed r118364: <http://trac.webkit.org/changeset/118364> 632750 4 webkit.review.bot 2012-05-24 07:13:08 -0700 All reviewed patches have been landed. Closing bug. 143336 2012-05-22 11:42:03 -0700 2012-05-24 07:13:03 -0700 Patch bug-87153-20120522144202.patch text/plain 5052 vollick U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3OTYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODE0Y2Q5ZGIyY2U5NGNk MjY3YjIxZjEyMjE1ZmQzN2E1NTI4OGM0Zi4uMzdkZjcxN2I1NDRiMTNlMmM1MmY5NWI1ODZkMDJh YWRkYWUxMWZlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA1LTIyICBJYW4g Vm9sbGljayAgPHZvbGxpY2tAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gRm9y Y2libHkgc3luYyBydW5uaW5nIGFuaW1hdGlvbnMgaW4gdGhlIHdhaXRpbmcgc3RhdGUgd2hlbiBz eW5jaHJvbml6ZWQgc3RhcnQgdGltZXMgYXJlIG5lZWRlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3MTUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVW5pdCB0ZXN0OiBDQ0xheWVyQW5pbWF0aW9uQ29u dHJvbGxlclRlc3QuRm9yY2VTeW5jV2hlblN5bmNocm9uaXplZFN0YXJ0VGltZU5lZWRlZAorCisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllckFuaW1hdGlvbkNv bnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q0NMYXllckFuaW1hdGlvbkNvbnRyb2xs ZXI6OnJlcGxhY2VJbXBsVGhyZWFkQW5pbWF0aW9ucyk6CisKIDIwMTItMDUtMjIgIFl1cnkgU2Vt aWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjog YW5ub3RhdGUgSW5qZWN0ZWRTY3JpcHRTb3VyY2UuanMgZm9yIGNsb3N1cmUgY29tcGlsZXIKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggNzUxMWIwNDFlMjNlMjFiNTQzZmExNDczMjhjYjRj ZDEyYzhkMDg1MS4uNGQyMmY2YTc3NmVjYzRiMzEzMGYxMTQ1NDgyYjRmMzg3YTg5M2EyNSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNiBAQAogMjAxMi0wNS0yMiAgSWFu IFZvbGxpY2sgIDx2b2xsaWNrQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbY2hyb21pdW1dIEZv cmNpYmx5IHN5bmMgcnVubmluZyBhbmltYXRpb25zIGluIHRoZSB3YWl0aW5nIHN0YXRlIHdoZW4g c3luY2hyb25pemVkIHN0YXJ0IHRpbWVzIGFyZSBuZWVkZWQuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NzE1MworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogdGVzdHMvQ0NMYXllckFuaW1hdGlvbkNvbnRy b2xsZXJUZXN0LmNwcDoKKyAgICAgICAgKFdlYktpdFRlc3RzOjpURVNUKToKKyAgICAgICAgKFdl YktpdFRlc3RzKToKKworMjAxMi0wNS0yMiAgSWFuIFZvbGxpY2sgIDx2b2xsaWNrQGNocm9taXVt Lm9yZz4KKwogICAgICAgICBbY2hyb21pdW1dIFNwZWVkIHVwIENDTGF5ZXJUcmVlSG9zdFRlc3RU aWNrQW5pbWF0aW9uV2hpbGVCYWNrZ3JvdW5kZWQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTg2ODcxCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJBbmltYXRpb25Db250cm9sbGVy LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5 ZXJBbmltYXRpb25Db250cm9sbGVyLmNwcAppbmRleCA5OGY0MDE0NDhiNDljNzQyYzJhOGY3Njk1 MTE4MmNmZTJiN2I1ZWNiLi4xNGZiNzhhNjVjMjU4MDI3NGVhZjY4OTAxZjUyZTRiZjc3YzU4YmJj IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9j Yy9DQ0xheWVyQW5pbWF0aW9uQ29udHJvbGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllckFuaW1hdGlvbkNvbnRyb2xsZXIuY3Bw CkBAIC00NTEsOCArNDUxLDE2IEBAIHZvaWQgQ0NMYXllckFuaW1hdGlvbkNvbnRyb2xsZXI6OnB1 cmdlRmluaXNoZWRBbmltYXRpb25zKGRvdWJsZSBtb25vdG9uaWNUaW1lLCBDCiB2b2lkIENDTGF5 ZXJBbmltYXRpb25Db250cm9sbGVyOjpyZXBsYWNlSW1wbFRocmVhZEFuaW1hdGlvbnMoQ0NMYXll ckFuaW1hdGlvbkNvbnRyb2xsZXIqIGNvbnRyb2xsZXJJbXBsKSBjb25zdAogewogICAgIGNvbnRy b2xsZXJJbXBsLT5tX2FjdGl2ZUFuaW1hdGlvbnMuY2xlYXIoKTsKLSAgICBmb3IgKHNpemVfdCBp ID0gMDsgaSA8IG1fYWN0aXZlQW5pbWF0aW9ucy5zaXplKCk7ICsraSkKLSAgICAgICAgY29udHJv bGxlckltcGwtPmFkZChtX2FjdGl2ZUFuaW1hdGlvbnNbaV0tPmNsb25lRm9ySW1wbFRocmVhZCgp KTsKKyAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IG1fYWN0aXZlQW5pbWF0aW9ucy5zaXplKCk7 ICsraSkgeworICAgICAgICBPd25QdHI8Q0NBY3RpdmVBbmltYXRpb24+IHRvQWRkKG1fYWN0aXZl QW5pbWF0aW9uc1tpXS0+Y2xvbmVGb3JJbXBsVGhyZWFkKCkpOworICAgICAgICBpZiAobV9hY3Rp dmVBbmltYXRpb25zW2ldLT5uZWVkc1N5bmNocm9uaXplZFN0YXJ0VGltZSgpKSB7CisgICAgICAg ICAgICAvLyBXZSBoYXZlbid0IHJlY2VpdmVkIGFuIGFuaW1hdGlvbiBzdGFydGVkIG5vdGlmaWNh dGlvbiB5ZXQsIHNvIGl0CisgICAgICAgICAgICAvLyBpcyBpbXBvcnRhbnQgdGhhdCB3ZSBhZGQg aXQgaW4gYSAnd2FpdGluZycgYW5kIG5vdCAncnVubmluZycgc3RhdGUuCisgICAgICAgICAgICB0 b0FkZC0+c2V0UnVuU3RhdGUoQ0NBY3RpdmVBbmltYXRpb246OldhaXRpbmdGb3JUYXJnZXRBdmFp bGFiaWxpdHksIDApOworICAgICAgICAgICAgdG9BZGQtPnNldFN0YXJ0VGltZSgwKTsKKyAgICAg ICAgfQorICAgICAgICBjb250cm9sbGVySW1wbC0+YWRkKHRvQWRkLnJlbGVhc2UoKSk7CisgICAg fQogfQogCiB2b2lkIENDTGF5ZXJBbmltYXRpb25Db250cm9sbGVyOjp0aWNrQW5pbWF0aW9ucyhk b3VibGUgbW9ub3RvbmljVGltZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v dGVzdHMvQ0NMYXllckFuaW1hdGlvbkNvbnRyb2xsZXJUZXN0LmNwcCBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vdGVzdHMvQ0NMYXllckFuaW1hdGlvbkNvbnRyb2xsZXJUZXN0LmNwcAppbmRleCAx ZDU0MDlmOThlZGQxYTM5NGVlNGY5OTlkYTZkNDc1MmNhNjY1OGUzLi44MjcxOTRiYmM0MTUzNmYy ZmFjMzQ5MWQzZDUxZTQ0ODhhMTE0MmY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3Rlc3RzL0NDTGF5ZXJBbmltYXRpb25Db250cm9sbGVyVGVzdC5jcHAKKysrIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS90ZXN0cy9DQ0xheWVyQW5pbWF0aW9uQ29udHJvbGxlclRlc3QuY3Bw CkBAIC03NDcsNCArNzQ3LDMyIEBAIFRFU1QoQ0NMYXllckFuaW1hdGlvbkNvbnRyb2xsZXJUZXN0 LCBBYm9ydEFHcm91cGVkQW5pbWF0aW9uKQogICAgIEVYUEVDVF9FUSgwLjc1LCBkdW1teS5vcGFj aXR5KCkpOwogfQogCitURVNUKENDTGF5ZXJBbmltYXRpb25Db250cm9sbGVyVGVzdCwgRm9yY2VT eW5jV2hlblN5bmNocm9uaXplZFN0YXJ0VGltZU5lZWRlZCkKK3sKKyAgICBGYWtlTGF5ZXJBbmlt YXRpb25Db250cm9sbGVyQ2xpZW50IGR1bW15SW1wbDsKKyAgICBPd25QdHI8Q0NMYXllckFuaW1h dGlvbkNvbnRyb2xsZXI+IGNvbnRyb2xsZXJJbXBsKENDTGF5ZXJBbmltYXRpb25Db250cm9sbGVy OjpjcmVhdGUoJmR1bW15SW1wbCkpOworICAgIE93blB0cjxDQ0FuaW1hdGlvbkV2ZW50c1ZlY3Rv cj4gZXZlbnRzKGFkb3B0UHRyKG5ldyBDQ0FuaW1hdGlvbkV2ZW50c1ZlY3RvcikpOworICAgIEZh a2VMYXllckFuaW1hdGlvbkNvbnRyb2xsZXJDbGllbnQgZHVtbXk7CisgICAgT3duUHRyPENDTGF5 ZXJBbmltYXRpb25Db250cm9sbGVyPiBjb250cm9sbGVyKAorICAgICAgICBDQ0xheWVyQW5pbWF0 aW9uQ29udHJvbGxlcjo6Y3JlYXRlKCZkdW1teSkpOworCisgICAgT3duUHRyPENDQWN0aXZlQW5p bWF0aW9uPiB0b0FkZChjcmVhdGVBY3RpdmVBbmltYXRpb24oYWRvcHRQdHIobmV3IEZha2VGbG9h dFRyYW5zaXRpb24oMiwgMCwgMSkpLCAwLCBDQ0FjdGl2ZUFuaW1hdGlvbjo6T3BhY2l0eSkpOwor ICAgIHRvQWRkLT5zZXROZWVkc1N5bmNocm9uaXplZFN0YXJ0VGltZSh0cnVlKTsKKyAgICBjb250 cm9sbGVyLT5hZGQodG9BZGQucmVsZWFzZSgpKTsKKworICAgIGNvbnRyb2xsZXItPmFuaW1hdGUo MCwgMCk7CisgICAgRVhQRUNUX1RSVUUoY29udHJvbGxlci0+aGFzQWN0aXZlQW5pbWF0aW9uKCkp OworICAgIENDQWN0aXZlQW5pbWF0aW9uKiBhY3RpdmVBbmltYXRpb24gPSBjb250cm9sbGVyLT5n ZXRBY3RpdmVBbmltYXRpb24oMCwgQ0NBY3RpdmVBbmltYXRpb246Ok9wYWNpdHkpOworICAgIEVY UEVDVF9UUlVFKGFjdGl2ZUFuaW1hdGlvbik7CisgICAgRVhQRUNUX1RSVUUoYWN0aXZlQW5pbWF0 aW9uLT5uZWVkc1N5bmNocm9uaXplZFN0YXJ0VGltZSgpKTsKKworICAgIGNvbnRyb2xsZXItPnNl dEZvcmNlU3luYygpOworCisgICAgY29udHJvbGxlci0+cHVzaEFuaW1hdGlvblVwZGF0ZXNUbyhj b250cm9sbGVySW1wbC5nZXQoKSk7CisKKyAgICBhY3RpdmVBbmltYXRpb24gPSBjb250cm9sbGVy SW1wbC0+Z2V0QWN0aXZlQW5pbWF0aW9uKDAsIENDQWN0aXZlQW5pbWF0aW9uOjpPcGFjaXR5KTsK KyAgICBFWFBFQ1RfVFJVRShhY3RpdmVBbmltYXRpb24pOworICAgIEVYUEVDVF9FUShDQ0FjdGl2 ZUFuaW1hdGlvbjo6V2FpdGluZ0ZvclRhcmdldEF2YWlsYWJpbGl0eSwgYWN0aXZlQW5pbWF0aW9u LT5ydW5TdGF0ZSgpKTsKK30KKwogfSAvLyBuYW1lc3BhY2UK