8715 2006-05-02 20:31:19 -0700 REGRESSION: Caret to the right of an image is a big black rectangle. 2006-05-12 09:40:41 -0700 1 1 1 Unclassified WebKit HTML Editing 420+ Mac OS X 10.4 RESOLVED FIXED EasyFix, Regression P1 Normal --- 1 justin.garcia darin oldest_to_newest 40928 0 justin.garcia 2006-05-02 20:31:19 -0700 See the testcase 40929 1 8089 justin.garcia 2006-05-02 20:31:46 -0700 Created attachment 8089 testcase 41611 2 darin 2006-05-09 09:07:10 -0700 The bug is in RenderBox::caretRect. There's a line of code that says: rect.setWidth(m_width - caretWidth) which should instead say: rect.move(IntSize(m_width - caretWidth, 0)) 41814 3 8197 darin 2006-05-09 22:54:06 -0700 Created attachment 8197 patch 42105 4 darin 2006-05-12 09:40:41 -0700 Committed revision 14323. 8089 2006-05-02 20:31:46 -0700 2006-05-02 20:31:46 -0700 testcase caret-image.html text/html 303 justin.garcia PGRpdiBpZD0idGVzdCIgY29udGVudGVkaXRhYmxlPSJ0cnVlIj5mcmVlPGltZyBzcmM9Imh0dHA6 Ly93d3cuZ29vZ2xlLmNvbS9pbnRsL2VuL2ltYWdlcy9sb2dvLmdpZiI+bHVuY2g8L2Rpdj4KCjxz Y3JpcHQ+CnZhciBzID0gd2luZG93LmdldFNlbGVjdGlvbigpOwp2YXIgZSA9IGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCJ0ZXN0Iik7CgpzLnNldFBvc2l0aW9uKGUsIDApOwpzLm1vZGlmeSgibW92 ZSIsICJmb3J3YXJkIiwgIndvcmQiKTsKcy5tb2RpZnkoIm1vdmUiLCAiZm9yd2FyZCIsICJjaGFy YWN0ZXIiKTsKPC9zY3JpcHQ+ 8197 2006-05-09 22:54:06 -0700 2006-05-11 20:19:32 -0700 patch FatCaretPatch.txt text/plain 945 darin SW5kZXg6IHJlbmRlcmluZy9SZW5kZXJCb3guY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHJlbmRlcmluZy9S ZW5kZXJCb3guY3BwCShyZXZpc2lvbiAxNDI3MikKKysrIHJlbmRlcmluZy9SZW5kZXJCb3guY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0xNzkxLDcgKzE3OTEsNyBAQAogICAgIGNvbnN0IGludCBjYXJl dFdpZHRoID0gMTsKICAgICBJbnRSZWN0IHJlY3QoeFBvcygpLCB5UG9zKCksIGNhcmV0V2lkdGgs IG1faGVpZ2h0KTsKICAgICBpZiAob2Zmc2V0ICE9IDApCi0gICAgICAgIHJlY3Quc2V0V2lkdGgo bV93aWR0aCAtIGNhcmV0V2lkdGgpOworICAgICAgICByZWN0Lm1vdmUoSW50U2l6ZShtX3dpZHRo IC0gY2FyZXRXaWR0aCwgMCkpOwogICAgIGlmIChJbmxpbmVCb3gqIGJveCA9IGlubGluZUJveFdy YXBwZXIoKSkgewogICAgICAgICBSb290SW5saW5lQm94KiByb290Qm94ID0gYm94LT5yb290KCk7 CiAgICAgICAgIGludCB0b3AgPSByb290Qm94LT50b3BPdmVyZmxvdygpOwpAQCAtMTgxNiwxMSAr MTgxNiwxMSBAQAogICAgIGlmICghY2IgfHwgIWNiLT5hYnNvbHV0ZVBvc2l0aW9uKGNieCwgY2J5 KSkKICAgICAgICAgLy8gTm8gcG9pbnQgcmV0dXJuaW5nIGEgcmVsYXRpdmUgcG9zaXRpb24uCiAg ICAgICAgIHJldHVybiBJbnRSZWN0KCk7Ci0gICAgcmVjdC5tb3ZlKGNieCwgY2J5KTsKIAogICAg IGlmIChleHRyYVdpZHRoVG9FbmRPZkxpbmUpCi0gICAgICAgICpleHRyYVdpZHRoVG9FbmRPZkxp bmUgPSBtX3dpZHRoIC0gcmVjdC5yaWdodCgpOworICAgICAgICAqZXh0cmFXaWR0aFRvRW5kT2ZM aW5lID0geFBvcygpICsgbV93aWR0aCAtIHJlY3QucmlnaHQoKTsKIAorICAgIHJlY3QubW92ZShj YngsIGNieSk7CiAgICAgcmV0dXJuIHJlY3Q7CiB9CiAK