87145 2012-05-22 10:48:35 -0700 REGRESSION (r117815) fast/css/zoom-in-length-round-trip.html fails on Mac bots 2012-05-22 12:15:12 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Mac All RESOLVED FIXED LayoutTestFailure, Regression P2 Normal --- 1 beidson leviw eae eric leviw szledan oldest_to_newest 630535 0 beidson 2012-05-22 10:48:35 -0700 REGRESSION (r117815) fast/css/zoom-in-length-round-trip.html fails on Mac bots Link to change: http://trac.webkit.org/changeset/117815 Link to example of failure: http://build.webkit.org/results/Lion%20Release%20(Tests)/r117988%20(8548)/results.html 117815 purported to be only about enabling a feature on Chromium, so it seems odd it could have caused this. But it never failed up to and including 117813, then has been failing started in 117815. 117814 cannot possibly have affected Mac as it only touched a Chromium.cpp file - (http://trac.webkit.org/changeset/117814) - so 117815 must be it. 630541 1 beidson 2012-05-22 10:53:02 -0700 Skipped in http://trac.webkit.org/changeset/118003 Please unskip after you have resolved the regression. 630575 2 eric 2012-05-22 11:24:39 -0700 It's possible, but it would have come from an earlier change in teh subpixel change I think. 630582 3 beidson 2012-05-22 11:28:55 -0700 (In reply to comment #2) > It's possible, but it would have come from an earlier change in teh subpixel change I think. I'm having a hard time grok'ing this sentence. All I know is that from 117813 back the test was fine. 630584 4 leviw 2012-05-22 11:30:40 -0700 (In reply to comment #3) > (In reply to comment #2) > > It's possible, but it would have come from an earlier change in teh subpixel change I think. > > I'm having a hard time grok'ing this sentence. > > All I know is that from 117813 back the test was fine. The numbers being returned are correct, it looks like a test issue. 630601 5 143337 eae 2012-05-22 11:42:33 -0700 Created attachment 143337 Patch 630607 6 143337 eric 2012-05-22 11:46:22 -0700 Comment on attachment 143337 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143337&action=review > LayoutTests/fast/css/zoom-in-length-round-trip.html:33 > + if (hasSubpixelSupport && (target.offsetWidth == 1 || target.offsetWidth == 2) && (target.offsetHeight == 10 || target.offsetHeight == 11)) I don'dt quite understnad thsi complicated check. 630611 7 eae 2012-05-22 11:48:30 -0700 (In reply to comment #6) > (From update of attachment 143337 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=143337&action=review > > > LayoutTests/fast/css/zoom-in-length-round-trip.html:33 > > + if (hasSubpixelSupport && (target.offsetWidth == 1 || target.offsetWidth == 2) && (target.offsetHeight == 10 || target.offsetHeight == 11)) > > I don'dt quite understnad thsi complicated check. That's why I added the comment... 630612 8 143337 leviw 2012-05-22 11:49:04 -0700 Comment on attachment 143337 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143337&action=review Please also unskip this test on Mac before landing. > LayoutTests/fast/css/zoom-in-length-round-trip.html:33 > + if (hasSubpixelSupport && (target.offsetWidth == 1 || target.offsetWidth == 2) && (target.offsetHeight == 10 || target.offsetHeight == 11)) This is ugly to have to do, but okay. 630621 9 beidson 2012-05-22 11:55:42 -0700 Even though Levi r+'ed, please unskip the test as well. 630624 10 eae 2012-05-22 11:57:19 -0700 (In reply to comment #9) > Even though Levi r+'ed, please unskip the test as well. Will do! 630626 11 leviw 2012-05-22 11:57:25 -0700 (In reply to comment #8) > (From update of attachment 143337 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=143337&action=review > > Please also unskip this test on Mac before landing. ^^^ :) 630628 12 eae 2012-05-22 11:59:49 -0700 Committed r118013: <http://trac.webkit.org/changeset/118013> 630651 13 leviw 2012-05-22 12:15:12 -0700 *** Bug 87099 has been marked as a duplicate of this bug. *** 143337 2012-05-22 11:42:33 -0700 2012-05-22 12:14:39 -0700 Patch bug-87145-20120522114232.patch text/plain 2393 eae SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDExODAxMCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA1LTIyICBFbWlsIEEgRWtsdW5kICA8 ZWFlQGNocm9taXVtLm9yZz4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTE3ODE1KSBmYXN0L2Nz cy96b29tLWluLWxlbmd0aC1yb3VuZC10cmlwLmh0bWwgZmFpbHMgb24gTWFjIGJvdHMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3MTQ1CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IHpvb20taW4tbGVu Z3RoLXJvdW5kLXRyaXAgdG8gc3VwcG9ydCBzdWJwaXhlbCBzdXBwb3J0IHR1cm5lZCBvbiBvciBv ZmYuCisKKyAgICAgICAgKiBmYXN0L2Nzcy96b29tLWluLWxlbmd0aC1yb3VuZC10cmlwLmh0bWw6 CisKIDIwMTItMDUtMjIgIEFiaGlzaGVrIEFyeWEgIDxpbmZlcm5vQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBBc3NlcnRpb24gZmFpbHVyZSAodG9SZW5kZXJCb3goKSBjYWxsZWQgb24gYSBSZW5k ZXJJbmxpbmUpIGJlbmVhdGggUmVuZGVyQmxvY2s6OmJsb2NrQmVmb3JlV2l0aGluU2VsZWN0aW9u Um9vdCgpCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Nzcy96b29tLWluLWxlbmd0aC1yb3VuZC10 cmlwLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9jc3Mvem9vbS1pbi1sZW5n dGgtcm91bmQtdHJpcC5odG1sCShyZXZpc2lvbiAxMTc5MzEpCisrKyBMYXlvdXRUZXN0cy9mYXN0 L2Nzcy96b29tLWluLWxlbmd0aC1yb3VuZC10cmlwLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTcs NiArNyw3IEBACiA8cHJlIGlkPSJjb25zb2xlIj48L3ByZT4KIDxkaXYgaWQ9ImNvbnRhaW5lciI+ CiAgICAgPGRpdiBpZD0idGFyZ2V0IiBzdHlsZT0id2lkdGg6IDFweDsgaGVpZ2h0OiAxMHB4OyI+ PC9kaXY+CisgICAgPGRpdiBpZD0ic3VicGl4ZWwtdGVzdCIgc3R5bGU9IndpZHRoOiA0LjVweDsg aGVpZ2h0OiAxMHB4OyI+PC9kaXY+CiA8L2Rpdj4KIDxzY3JpcHQ+CiAgICAgZnVuY3Rpb24gbG9n KG1lc3NhZ2UpCkBAIC0yMiwxMyArMjMsMTUgQEAKICAgICB2YXIgY29udGFpbmVyU3R5bGUgPSBk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgiY29udGFpbmVyIikuc3R5bGU7CiAgICAgdmFyIHpvb207 CiAgICAgdmFyIGZhaWxlZCA9IGZhbHNlOworCisgICAgdmFyIHJlY3QgPSBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgnc3VicGl4ZWwtdGVzdCcpLmdldEJvdW5kaW5nQ2xpZW50UmVjdCgpOworICAg IHZhciBoYXNTdWJwaXhlbFN1cHBvcnQgPSByZWN0LnJpZ2h0IC0gcmVjdC5sZWZ0ID09IDQuNTsK ICAgICAKICAgICBmb3IgKHpvb20gPSAxMDA7IHpvb20gPD0gMjAwOyB6b29tICs9IDEpIHsKICAg ICAgICAgY29udGFpbmVyU3R5bGUuc2V0UHJvcGVydHkoInpvb20iLCB6b29tIC8gMTAwKTsKLSAg ICAgICAgdmFyIHJlY3QgPSB0YXJnZXQuZ2V0Qm91bmRpbmdDbGllbnRSZWN0KCk7Ci0gICAgICAg IHZhciB3aWR0aCA9IE1hdGgucm91bmQocmVjdC5yaWdodCAtIHJlY3QubGVmdCk7Ci0gICAgICAg IHZhciBoZWlnaHQgPSBNYXRoLnJvdW5kKHJlY3QuYm90dG9tIC0gcmVjdC50b3ApOwotICAgICAg ICBpZiAod2lkdGggIT09IDEgfHwgaGVpZ2h0ICE9PSAxMCkgeworICAgICAgICBpZiAodGFyZ2V0 Lm9mZnNldFdpZHRoICE9IDEgfHwgdGFyZ2V0Lm9mZnNldEhlaWdodCAhPSAxMCkgeworICAgICAg ICAgICAgaWYgKGhhc1N1YnBpeGVsU3VwcG9ydCAmJiAodGFyZ2V0Lm9mZnNldFdpZHRoID09IDEg fHwgdGFyZ2V0Lm9mZnNldFdpZHRoID09IDIpICYmICh0YXJnZXQub2Zmc2V0SGVpZ2h0ID09IDEw IHx8IHRhcmdldC5vZmZzZXRIZWlnaHQgPT0gMTEpKQorICAgICAgICAgICAgICAgIGNvbnRpbnVl OyAvLyBXaXRoIHN1YnBpeGVsIGxheW91dCBhbmQgcGl4ZWwgc25hcHBpbmcgd2UgZXh0ZW5kIHRo ZSBib3ggd2l0aCBvbmUgcGl4ZWwgYXQgY2VydGFpbiB6b29tIGxldmVscy4KICAgICAgICAgICAg IGZhaWxlZCA9IHRydWU7CiAgICAgICAgICAgICBsb2coIkZBSUwgYXQgIiArIHpvb20gKyAiJSBt YWduaWZpY2F0aW9uOiAxIG1hcHBlZCB0byAiICsgdGFyZ2V0Lm9mZnNldFdpZHRoICsgIiBhbmQg MTAgbWFwcGVkIHRvICIgKyB0YXJnZXQub2Zmc2V0SGVpZ2h0ICsgIi4iKTsKICAgICAgICAgfQo=