87142 2012-05-22 10:12:17 -0700 REGRESSION(r117613): Dromaeo/jslib-style-prototype regressed by 20% 2012-12-18 09:49:55 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tony tony kling koivisto menard rniwa webkit.review.bot oldest_to_newest 630490 0 tony 2012-05-22 10:12:17 -0700 Probably because I moved CSSPropertyDisplay from the fast table to the slow table. 630588 1 tony 2012-05-22 11:32:38 -0700 http://webkit-perf.appspot.com/graph.html#tests=[[39020,2001,3001]]&sel=1337320768437.756,1337421568437.756,3097.560975609756,5841.463414634147&displayrange=7&datatype=running 630593 2 143334 tony 2012-05-22 11:35:54 -0700 Created attachment 143334 Patch 630595 3 tony 2012-05-22 11:37:13 -0700 This seemed to fix the regression on my machine, but I see a 5% swing in the test results locally, so it's hard to be certain (the graph shows similar variance). 630716 4 143334 webkit.review.bot 2012-05-22 13:49:21 -0700 Comment on attachment 143334 Patch Clearing flags on attachment: 143334 Committed r118044: <http://trac.webkit.org/changeset/118044> 630717 5 webkit.review.bot 2012-05-22 13:49:26 -0700 All reviewed patches have been landed. Closing bug. 631337 6 rniwa 2012-05-23 00:39:45 -0700 It does appear that this patch fixed the regression: http://webkit-perf.appspot.com/graph.html#tests=[[39020,2001,3001]]&sel=1337739099058.127,1337757519362.6953,3278.688524590164,6426.229508196721&displayrange=7&datatype=running 793748 7 ap 2012-12-18 09:49:55 -0800 This caused bug 105275. 143334 2012-05-22 11:35:54 -0700 2012-05-22 13:49:21 -0700 Patch bug-87142-20120522113554.patch text/plain 6875 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3OTkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDg2Y2MwMmYxYmZjMmRj OWMyYjdmYzNhYzY4NWMwM2E4MzliYWZkOS4uYTE3YWE1YTRlZjQzNzQyMTMzYjlhMjExODIzMWE1 YTkyZjQ3OTc1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA1LTIyICBUb255 IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMTE3NjEz KTogRHJvbWFlby9qc2xpYi1zdHlsZS1wcm90b3R5cGUgcmVncmVzc2VkIGJ5IDIwJQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODcxNDIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNb3ZlIENTU1Byb3BlcnR5 RGlzcGxheSBiYWNrIGludG8gaXNWYWxpZEtleXdvcmRQcm9wZXJ0eUFuZFZhbHVlLgorICAgICAg ICBQYXNzIGluIHRoZSBwYXJzZXIgY29udGV4dCBzbyB3ZSBjYW4gY2hlY2sgd2hldGhlciB3ZSdy ZSBncmlkIG9yIG5vdC4KKworICAgICAgICBObyBuZXcgdGVzdHMuIENvdmVyZWQgYnkgRHJvbWFl by9qc2xpYi1zdHlsZS1wcm90b3R5cGUgcGVyZiB0ZXN0LgorCisgICAgICAgICogY3NzL0NTU1Bh cnNlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjppc1ZhbGlkS2V5d29yZFByb3BlcnR5QW5kVmFs dWUpOgorICAgICAgICAoV2ViQ29yZTo6aXNLZXl3b3JkUHJvcGVydHlJRCk6CisgICAgICAgIChX ZWJDb3JlOjpwYXJzZUtleXdvcmRWYWx1ZSk6CisgICAgICAgIChXZWJDb3JlOjpDU1NQYXJzZXI6 OnBhcnNlVmFsdWUpOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VyOjpwYXJzZUZvbnQpOgor CiAyMDEyLTA1LTIyICBWc2V2b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFdlYiBJbnNwZWN0b3I6IEphdmFTY3JpcHRTb3VyY2VGcmFtZSBzaG91bGQgYmUgYmFz ZWQgb24gSmF2YVNjcmlwdFNvdXJjZSBub3QgVUlTb3VyY2VDb2RlLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFy c2VyLmNwcAppbmRleCBhYjVkODA0MWY3MGY5NjUzYzVmYWQ4YzQyNGIxOTFlNDQyMGYwZjQ0Li4y ZmU3MzdhN2VmNTA4N2U2NGM0NGFkZTY1Mzc5YzBkNGQzZjFiMWUxIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NT UGFyc2VyLmNwcApAQCAtNDk0LDcgKzQ5NCw3IEBAIHN0YXRpYyBib29sIHBhcnNlU2ltcGxlTGVu Z3RoVmFsdWUoU3R5bGVQcm9wZXJ0eVNldCogZGVjbGFyYXRpb24sIENTU1Byb3BlcnR5SUQKICAg ICByZXR1cm4gdHJ1ZTsKIH0KIAotc3RhdGljIGlubGluZSBib29sIGlzVmFsaWRLZXl3b3JkUHJv cGVydHlBbmRWYWx1ZShDU1NQcm9wZXJ0eUlEIHByb3BlcnR5SWQsIGludCB2YWx1ZUlEKQorc3Rh dGljIGlubGluZSBib29sIGlzVmFsaWRLZXl3b3JkUHJvcGVydHlBbmRWYWx1ZShDU1NQcm9wZXJ0 eUlEIHByb3BlcnR5SWQsIGludCB2YWx1ZUlELCBjb25zdCBDU1NQYXJzZXJDb250ZXh0JiBwYXJz ZXJDb250ZXh0KQogewogICAgIGlmICghdmFsdWVJRCkKICAgICAgICAgcmV0dXJuIGZhbHNlOwpA QCAtNTMyLDYgKzUzMiwxNyBAQCBzdGF0aWMgaW5saW5lIGJvb2wgaXNWYWxpZEtleXdvcmRQcm9w ZXJ0eUFuZFZhbHVlKENTU1Byb3BlcnR5SUQgcHJvcGVydHlJZCwgaW50CiAgICAgICAgIGlmICh2 YWx1ZUlEID09IENTU1ZhbHVlTHRyIHx8IHZhbHVlSUQgPT0gQ1NTVmFsdWVSdGwpCiAgICAgICAg ICAgICByZXR1cm4gdHJ1ZTsKICAgICAgICAgYnJlYWs7CisgICAgY2FzZSBDU1NQcm9wZXJ0eURp c3BsYXk6CisgICAgICAgIC8vIGlubGluZSB8IGJsb2NrIHwgbGlzdC1pdGVtIHwgcnVuLWluIHwg aW5saW5lLWJsb2NrIHwgdGFibGUgfAorICAgICAgICAvLyBpbmxpbmUtdGFibGUgfCB0YWJsZS1y b3ctZ3JvdXAgfCB0YWJsZS1oZWFkZXItZ3JvdXAgfCB0YWJsZS1mb290ZXItZ3JvdXAgfCB0YWJs ZS1yb3cgfAorICAgICAgICAvLyB0YWJsZS1jb2x1bW4tZ3JvdXAgfCB0YWJsZS1jb2x1bW4gfCB0 YWJsZS1jZWxsIHwgdGFibGUtY2FwdGlvbiB8IC13ZWJraXQtYm94IHwgLXdlYmtpdC1pbmxpbmUt Ym94IHwgbm9uZSB8IGluaGVyaXQKKyAgICAgICAgLy8gLXdlYmtpdC1mbGV4IHwgLXdlYmtpdC1p bmxpbmUtZmxleCB8IC13ZWJraXQtZ3JpZCB8IC13ZWJraXQtaW5saW5lLWdyaWQKKyAgICAgICAg aWYgKCh2YWx1ZUlEID49IENTU1ZhbHVlSW5saW5lICYmIHZhbHVlSUQgPD0gQ1NTVmFsdWVXZWJr aXRJbmxpbmVGbGV4KSB8fCB2YWx1ZUlEID09IENTU1ZhbHVlTm9uZSkKKyAgICAgICAgICAgIHJl dHVybiB0cnVlOworICAgICAgICBpZiAocGFyc2VyQ29udGV4dC5pc0NTU0dyaWRMYXlvdXRFbmFi bGVkICYmICh2YWx1ZUlEID09IENTU1ZhbHVlV2Via2l0R3JpZCB8fCB2YWx1ZUlEID09IENTU1Zh bHVlV2Via2l0SW5saW5lR3JpZCkpCisgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICAgICAg YnJlYWs7CisKICAgICBjYXNlIENTU1Byb3BlcnR5RW1wdHlDZWxsczogLy8gc2hvdyB8IGhpZGUg fCBpbmhlcml0CiAgICAgICAgIGlmICh2YWx1ZUlEID09IENTU1ZhbHVlU2hvdyB8fCB2YWx1ZUlE ID09IENTU1ZhbHVlSGlkZSkKICAgICAgICAgICAgIHJldHVybiB0cnVlOwpAQCAtODE5LDYgKzgz MCw3IEBAIHN0YXRpYyBpbmxpbmUgYm9vbCBpc0tleXdvcmRQcm9wZXJ0eUlEKENTU1Byb3BlcnR5 SUQgcHJvcGVydHlJZCkKICAgICBjYXNlIENTU1Byb3BlcnR5Q2FwdGlvblNpZGU6CiAgICAgY2Fz ZSBDU1NQcm9wZXJ0eUNsZWFyOgogICAgIGNhc2UgQ1NTUHJvcGVydHlEaXJlY3Rpb246CisgICAg Y2FzZSBDU1NQcm9wZXJ0eURpc3BsYXk6CiAgICAgY2FzZSBDU1NQcm9wZXJ0eUVtcHR5Q2VsbHM6 CiAgICAgY2FzZSBDU1NQcm9wZXJ0eUZsb2F0OgogICAgIGNhc2UgQ1NTUHJvcGVydHlGb250U3R5 bGU6CkBAIC05MDIsNyArOTE0LDcgQEAgc3RhdGljIGlubGluZSBib29sIGlzS2V5d29yZFByb3Bl cnR5SUQoQ1NTUHJvcGVydHlJRCBwcm9wZXJ0eUlkKQogICAgIH0KIH0KIAotc3RhdGljIGJvb2wg cGFyc2VLZXl3b3JkVmFsdWUoU3R5bGVQcm9wZXJ0eVNldCogZGVjbGFyYXRpb24sIENTU1Byb3Bl cnR5SUQgcHJvcGVydHlJZCwgY29uc3QgU3RyaW5nJiBzdHJpbmcsIGJvb2wgaW1wb3J0YW50KQor c3RhdGljIGJvb2wgcGFyc2VLZXl3b3JkVmFsdWUoU3R5bGVQcm9wZXJ0eVNldCogZGVjbGFyYXRp b24sIENTU1Byb3BlcnR5SUQgcHJvcGVydHlJZCwgY29uc3QgU3RyaW5nJiBzdHJpbmcsIGJvb2wg aW1wb3J0YW50LCBjb25zdCBDU1NQYXJzZXJDb250ZXh0JiBwYXJzZXJDb250ZXh0KQogewogICAg IEFTU0VSVCghc3RyaW5nLmlzRW1wdHkoKSk7CiAKQEAgLTkyMiw3ICs5MzQsNyBAQCBzdGF0aWMg Ym9vbCBwYXJzZUtleXdvcmRWYWx1ZShTdHlsZVByb3BlcnR5U2V0KiBkZWNsYXJhdGlvbiwgQ1NT UHJvcGVydHlJRCBwcm9wZQogICAgICAgICB2YWx1ZSA9IGNzc1ZhbHVlUG9vbCgpLmNyZWF0ZUlu aGVyaXRlZFZhbHVlKCk7CiAgICAgZWxzZSBpZiAodmFsdWVJRCA9PSBDU1NWYWx1ZUluaXRpYWwp CiAgICAgICAgIHZhbHVlID0gY3NzVmFsdWVQb29sKCkuY3JlYXRlRXhwbGljaXRJbml0aWFsVmFs dWUoKTsKLSAgICBlbHNlIGlmIChpc1ZhbGlkS2V5d29yZFByb3BlcnR5QW5kVmFsdWUocHJvcGVy dHlJZCwgdmFsdWVJRCkpCisgICAgZWxzZSBpZiAoaXNWYWxpZEtleXdvcmRQcm9wZXJ0eUFuZFZh bHVlKHByb3BlcnR5SWQsIHZhbHVlSUQsIHBhcnNlckNvbnRleHQpKQogICAgICAgICB2YWx1ZSA9 IGNzc1ZhbHVlUG9vbCgpLmNyZWF0ZUlkZW50aWZpZXJWYWx1ZSh2YWx1ZUlEKTsKICAgICBlbHNl CiAgICAgICAgIHJldHVybiBmYWxzZTsKQEAgLTk0OCw3ICs5NjAsNyBAQCBib29sIENTU1BhcnNl cjo6cGFyc2VWYWx1ZShTdHlsZVByb3BlcnR5U2V0KiBkZWNsYXJhdGlvbiwgQ1NTUHJvcGVydHlJ RCBwcm9wZXJ0eQogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICBpZiAocGFyc2VDb2xvclZhbHVl KGRlY2xhcmF0aW9uLCBwcm9wZXJ0eUlELCBzdHJpbmcsIGltcG9ydGFudCwgY3NzUGFyc2VyTW9k ZSkpCiAgICAgICAgIHJldHVybiB0cnVlOwotICAgIGlmIChwYXJzZUtleXdvcmRWYWx1ZShkZWNs YXJhdGlvbiwgcHJvcGVydHlJRCwgc3RyaW5nLCBpbXBvcnRhbnQpKQorICAgIGlmIChwYXJzZUtl eXdvcmRWYWx1ZShkZWNsYXJhdGlvbiwgcHJvcGVydHlJRCwgc3RyaW5nLCBpbXBvcnRhbnQsIGNv bnRleHRTdHlsZVNoZWV0LT5wYXJzZXJDb250ZXh0KCkpKQogICAgICAgICByZXR1cm4gdHJ1ZTsK IAogICAgIENTU1BhcnNlckNvbnRleHQgY29udGV4dChjc3NQYXJzZXJNb2RlKTsKQEAgLTE0NDUs NyArMTQ1Nyw3IEBAIGJvb2wgQ1NTUGFyc2VyOjpwYXJzZVZhbHVlKENTU1Byb3BlcnR5SUQgcHJv cElkLCBib29sIGltcG9ydGFudCkKICAgICB9CiAKICAgICBpZiAoaXNLZXl3b3JkUHJvcGVydHlJ RChwcm9wSWQpKSB7Ci0gICAgICAgIGlmICghaXNWYWxpZEtleXdvcmRQcm9wZXJ0eUFuZFZhbHVl KHByb3BJZCwgaWQpKQorICAgICAgICBpZiAoIWlzVmFsaWRLZXl3b3JkUHJvcGVydHlBbmRWYWx1 ZShwcm9wSWQsIGlkLCBtX2NvbnRleHQpKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAg ICAgICBpZiAobV92YWx1ZUxpc3QtPm5leHQoKSAmJiAhaW5TaG9ydGhhbmQoKSkKICAgICAgICAg ICAgIHJldHVybiBmYWxzZTsKQEAgLTE0NTcsMTcgKzE0NjksNiBAQCBib29sIENTU1BhcnNlcjo6 cGFyc2VWYWx1ZShDU1NQcm9wZXJ0eUlEIHByb3BJZCwgYm9vbCBpbXBvcnRhbnQpCiAgICAgUmVm UHRyPENTU1ZhbHVlPiBwYXJzZWRWYWx1ZTsKIAogICAgIHN3aXRjaCAocHJvcElkKSB7Ci0gICAg Y2FzZSBDU1NQcm9wZXJ0eURpc3BsYXk6Ci0gICAgICAgIC8vIGlubGluZSB8IGJsb2NrIHwgbGlz dC1pdGVtIHwgcnVuLWluIHwgaW5saW5lLWJsb2NrIHwgdGFibGUgfAotICAgICAgICAvLyBpbmxp bmUtdGFibGUgfCB0YWJsZS1yb3ctZ3JvdXAgfCB0YWJsZS1oZWFkZXItZ3JvdXAgfCB0YWJsZS1m b290ZXItZ3JvdXAgfCB0YWJsZS1yb3cgfAotICAgICAgICAvLyB0YWJsZS1jb2x1bW4tZ3JvdXAg fCB0YWJsZS1jb2x1bW4gfCB0YWJsZS1jZWxsIHwgdGFibGUtY2FwdGlvbiB8IC13ZWJraXQtYm94 IHwgLXdlYmtpdC1pbmxpbmUtYm94IHwgbm9uZSB8IGluaGVyaXQKLSAgICAgICAgLy8gLXdlYmtp dC1mbGV4IHwgLXdlYmtpdC1pbmxpbmUtZmxleCB8IC13ZWJraXQtZ3JpZCB8IC13ZWJraXQtaW5s aW5lLWdyaWQKLSAgICAgICAgaWYgKChpZCA+PSBDU1NWYWx1ZUlubGluZSAmJiBpZCA8PSBDU1NW YWx1ZVdlYmtpdElubGluZUZsZXgpIHx8IGlkID09IENTU1ZhbHVlTm9uZSkKLSAgICAgICAgICAg IHZhbGlkUHJpbWl0aXZlID0gdHJ1ZTsKLSAgICAgICAgZWxzZSBpZiAoY3NzR3JpZExheW91dEVu YWJsZWQoKSAmJiAoaWQgPT0gQ1NTVmFsdWVXZWJraXRHcmlkIHx8IGlkID09IENTU1ZhbHVlV2Vi a2l0SW5saW5lR3JpZCkpCi0gICAgICAgICAgICB2YWxpZFByaW1pdGl2ZSA9IHRydWU7Ci0gICAg ICAgIGJyZWFrOwotCiAgICAgY2FzZSBDU1NQcm9wZXJ0eVNpemU6ICAgICAgICAgICAgICAgICAv LyA8bGVuZ3RoPnsxLDJ9IHwgYXV0byB8IFsgPHBhZ2Utc2l6ZT4gfHwgWyBwb3J0cmFpdCB8IGxh bmRzY2FwZV0gXQogICAgICAgICByZXR1cm4gcGFyc2VTaXplKHByb3BJZCwgaW1wb3J0YW50KTsK IApAQCAtMjQ3NCw2ICsyNDc1LDcgQEAgYm9vbCBDU1NQYXJzZXI6OnBhcnNlVmFsdWUoQ1NTUHJv cGVydHlJRCBwcm9wSWQsIGJvb2wgaW1wb3J0YW50KQogICAgIGNhc2UgQ1NTUHJvcGVydHlDYXB0 aW9uU2lkZToKICAgICBjYXNlIENTU1Byb3BlcnR5Q2xlYXI6CiAgICAgY2FzZSBDU1NQcm9wZXJ0 eURpcmVjdGlvbjoKKyAgICBjYXNlIENTU1Byb3BlcnR5RGlzcGxheToKICAgICBjYXNlIENTU1By b3BlcnR5RW1wdHlDZWxsczoKICAgICBjYXNlIENTU1Byb3BlcnR5RmxvYXQ6CiAgICAgY2FzZSBD U1NQcm9wZXJ0eUZvbnRTdHlsZToKQEAgLTQzODgsNyArNDM5MCw3IEBAIGJvb2wgQ1NTUGFyc2Vy OjpwYXJzZUZvbnQoYm9vbCBpbXBvcnRhbnQpCiAgICAgYm9vbCBmb250V2VpZ2h0UGFyc2VkID0g ZmFsc2U7CiAgICAgQ1NTUGFyc2VyVmFsdWUqIHZhbHVlOwogICAgIHdoaWxlICgodmFsdWUgPSBt X3ZhbHVlTGlzdC0+Y3VycmVudCgpKSkgewotICAgICAgICBpZiAoIWZvbnRTdHlsZVBhcnNlZCAm JiBpc1ZhbGlkS2V5d29yZFByb3BlcnR5QW5kVmFsdWUoQ1NTUHJvcGVydHlGb250U3R5bGUsIHZh bHVlLT5pZCkpIHsKKyAgICAgICAgaWYgKCFmb250U3R5bGVQYXJzZWQgJiYgaXNWYWxpZEtleXdv cmRQcm9wZXJ0eUFuZFZhbHVlKENTU1Byb3BlcnR5Rm9udFN0eWxlLCB2YWx1ZS0+aWQsIG1fY29u dGV4dCkpIHsKICAgICAgICAgICAgIGFkZFByb3BlcnR5KENTU1Byb3BlcnR5Rm9udFN0eWxlLCBj c3NWYWx1ZVBvb2woKS5jcmVhdGVJZGVudGlmaWVyVmFsdWUodmFsdWUtPmlkKSwgaW1wb3J0YW50 KTsKICAgICAgICAgICAgIGZvbnRTdHlsZVBhcnNlZCA9IHRydWU7CiAgICAgICAgIH0gZWxzZSBp ZiAoIWZvbnRWYXJpYW50UGFyc2VkICYmICh2YWx1ZS0+aWQgPT0gQ1NTVmFsdWVOb3JtYWwgfHwg dmFsdWUtPmlkID09IENTU1ZhbHVlU21hbGxDYXBzKSkgewo=