87125 2012-05-22 06:13:39 -0700 [BlackBerry] Remove unused/unimplemented methods from InspectorClientBlackberry 2012-05-22 09:31:44 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kpiascik kpiascik efidler tonikitoo webkit.review.bot oldest_to_newest 630312 0 kpiascik 2012-05-22 06:13:39 -0700 [BlackBerry] Remove unused/unimplemented methods from InspectorClientBlackberry 630319 1 143292 kpiascik 2012-05-22 06:20:13 -0700 Created attachment 143292 Patch 630394 2 143292 rwlbuis 2012-05-22 08:27:34 -0700 Comment on attachment 143292 Patch LGTM. 630406 3 143292 webkit.review.bot 2012-05-22 08:44:17 -0700 Comment on attachment 143292 Patch Rejecting attachment 143292 from commit-queue. kpiascik@rim.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 630445 4 143292 webkit.review.bot 2012-05-22 09:31:40 -0700 Comment on attachment 143292 Patch Clearing flags on attachment: 143292 Committed r117985: <http://trac.webkit.org/changeset/117985> 630446 5 webkit.review.bot 2012-05-22 09:31:44 -0700 All reviewed patches have been landed. Closing bug. 143292 2012-05-22 06:20:13 -0700 2012-05-22 09:31:40 -0700 Patch bug-87125-20120522092102.patch text/plain 5228 kpiascik U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3NjkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBhNjA0MWJmZTBmNTYwMzk3Y2YyYjhjOGMzYjdjMDU1MjU4MDY1MzU3Li5lOGRkMThiNWE2 OGJmNDAwZWJkOGZmMjc3OGE3ODFhNGMyYThlMGU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMi0wNS0yMiAgS29ucmFkIFBpYXNjaWsgIDxrcGFp c2Npa0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBSZW1vdmUgdW51c2VkL3VuaW1w bGVtZW50ZWQgbWV0aG9kcyBmcm9tIEluc3BlY3RvckNsaWVudEJsYWNrYmVycnkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3MTI1CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlZCB1bmltcGxlbWVu dGVkIG1ldGhvZHMgdGhhdCBhcmUgbm8gbG9uZ2VyIHBhcnQgb2YgSW5zcGVjdG9yQ2xpZW50IGFu ZCBhZGRlZAorICAgICAgICBhIG5ldyBzdHViIGZvciBJbnNwZWN0b3JTdGF0ZUNsaWVudDo6dXBk YXRlSW5zcGVjdG9yU3RhdGVDb29raWUKKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0luc3Bl Y3RvckNsaWVudEJsYWNrQmVycnkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yQ2xp ZW50QmxhY2tCZXJyeTo6dXBkYXRlSW5zcGVjdG9yU3RhdGVDb29raWUpOgorICAgICAgICAoV2Vi Q29yZSk6CisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvSW5zcGVjdG9yQ2xpZW50QmxhY2tCZXJy eS5oOgorICAgICAgICAoSW5zcGVjdG9yQ2xpZW50QmxhY2tCZXJyeSk6CisKIDIwMTItMDUtMTgg IE1pa2UgRmVudG9uICA8bWlmZW50b25AcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0g VmFsaWRhdGlvbiBvZiBMYXN0IEZhdCBGaW5nZXIgcmVzdWx0IGlzIG5lZWRlZCBmb3Igc2VsZWN0 aW9uLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0 L0luc3BlY3RvckNsaWVudEJsYWNrQmVycnkuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L1dlYkNvcmVTdXBwb3J0L0luc3BlY3RvckNsaWVudEJsYWNrQmVycnkuY3BwCmluZGV4IDBkNWNk ZjRkMWZmNTBmYzc4MWY4YWJkOWQ5NWY4M2M2MTkwMWZjN2IuLmQ5Njg4ZmY2YTA5YjlkNjVhZGFi YTg4MDFlYTZlZDZjYjc5Yjg1MjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9XZWJDb3JlU3VwcG9ydC9JbnNwZWN0b3JDbGllbnRCbGFja0JlcnJ5LmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvSW5zcGVjdG9yQ2xpZW50QmxhY2tC ZXJyeS5jcHAKQEAgLTQwLDQ5ICs0MCw2IEBAIHZvaWQgSW5zcGVjdG9yQ2xpZW50QmxhY2tCZXJy eTo6aW5zcGVjdG9yRGVzdHJveWVkKCkKICAgICBkZWxldGUgdGhpczsKIH0KIAotUGFnZSogSW5z cGVjdG9yQ2xpZW50QmxhY2tCZXJyeTo6Y3JlYXRlUGFnZSgpCi17Ci0gICAgbm90SW1wbGVtZW50 ZWQoKTsKLSAgICByZXR1cm4gMDsKLX0KLQotU3RyaW5nIEluc3BlY3RvckNsaWVudEJsYWNrQmVy cnk6OmxvY2FsaXplZFN0cmluZ3NVUkwoKQotewotICAgIG5vdEltcGxlbWVudGVkKCk7Ci0gICAg cmV0dXJuIFN0cmluZygpOwotfQotCi1TdHJpbmcgSW5zcGVjdG9yQ2xpZW50QmxhY2tCZXJyeTo6 aGlkZGVuUGFuZWxzKCkKLXsKLSAgICBub3RJbXBsZW1lbnRlZCgpOwotICAgIHJldHVybiBTdHJp bmcoKTsKLX0KLQotdm9pZCBJbnNwZWN0b3JDbGllbnRCbGFja0JlcnJ5OjpzaG93V2luZG93KCkK LXsKLSAgICBub3RJbXBsZW1lbnRlZCgpOwotfQotCi12b2lkIEluc3BlY3RvckNsaWVudEJsYWNr QmVycnk6OmNsb3NlV2luZG93KCkKLXsKLSAgICBub3RJbXBsZW1lbnRlZCgpOwotfQotCi12b2lk IEluc3BlY3RvckNsaWVudEJsYWNrQmVycnk6OmF0dGFjaFdpbmRvdygpCi17Ci0gICAgbm90SW1w bGVtZW50ZWQoKTsKLX0KLQotdm9pZCBJbnNwZWN0b3JDbGllbnRCbGFja0JlcnJ5OjpkZXRhY2hX aW5kb3coKQotewotICAgIG5vdEltcGxlbWVudGVkKCk7Ci19Ci0KLXZvaWQgSW5zcGVjdG9yQ2xp ZW50QmxhY2tCZXJyeTo6c2V0QXR0YWNoZWRXaW5kb3dIZWlnaHQodW5zaWduZWQpCi17Ci0gICAg bm90SW1wbGVtZW50ZWQoKTsKLX0KLQogdm9pZCBJbnNwZWN0b3JDbGllbnRCbGFja0JlcnJ5Ojpo aWdobGlnaHQoKQogewogICAgIGhpZGVIaWdobGlnaHQoKTsKQEAgLTk4LDI3ICs1NSw2IEBAIHZv aWQgSW5zcGVjdG9yQ2xpZW50QmxhY2tCZXJyeTo6aGlkZUhpZ2hsaWdodCgpCiAgICAgbV93ZWJQ YWdlUHJpdmF0ZS0+bWFpbkZyYW1lKCktPmRvY3VtZW50KCktPmRvY3VtZW50RWxlbWVudCgpLT5y ZW5kZXJlcigpLT5yZXBhaW50KHRydWUpOwogfQogCi12b2lkIEluc3BlY3RvckNsaWVudEJsYWNr QmVycnk6Omluc3BlY3RlZFVSTENoYW5nZWQoY29uc3QgU3RyaW5nJikKLXsKLSAgICBub3RJbXBs ZW1lbnRlZCgpOwotfQotCi12b2lkIEluc3BlY3RvckNsaWVudEJsYWNrQmVycnk6OnBvcHVsYXRl U2V0dGluZyhjb25zdCBTdHJpbmcmIGtleSwgU3RyaW5nKiB2YWx1ZSkKLXsKLSAgICBpZiAobV9p bnNwZWN0b3JTZXR0aW5nc01hcC0+Y29udGFpbnMoa2V5KSkKLSAgICAgICAgKnZhbHVlID0gbV9p bnNwZWN0b3JTZXR0aW5nc01hcC0+Z2V0KGtleSk7Ci19Ci0KLXZvaWQgSW5zcGVjdG9yQ2xpZW50 QmxhY2tCZXJyeTo6c3RvcmVTZXR0aW5nKGNvbnN0IFN0cmluZyYga2V5LCBjb25zdCBTdHJpbmcm IHZhbHVlKQotewotICAgIG1faW5zcGVjdG9yU2V0dGluZ3NNYXAtPnNldChrZXksIHZhbHVlKTsK LX0KLQotdm9pZCBJbnNwZWN0b3JDbGllbnRCbGFja0JlcnJ5OjppbnNwZWN0b3JXaW5kb3dPYmpl Y3RDbGVhcmVkKCkKLXsKLSAgICBub3RJbXBsZW1lbnRlZCgpOwotfQotCiB2b2lkIEluc3BlY3Rv ckNsaWVudEJsYWNrQmVycnk6Om9wZW5JbnNwZWN0b3JGcm9udGVuZChJbnNwZWN0b3JDb250cm9s bGVyKikKIHsKICAgICBub3RJbXBsZW1lbnRlZCgpOwpAQCAtMTUxLDQgKzg3LDkgQEAgdm9pZCBJ bnNwZWN0b3JDbGllbnRCbGFja0JlcnJ5OjpjbGVhckJyb3dzZXJDb29raWVzKCkKICAgICBtX3dl YlBhZ2VQcml2YXRlLT5tX2NsaWVudC0+Y2xlYXJDb29raWVzKCk7CiB9CiAKK3ZvaWQgSW5zcGVj dG9yQ2xpZW50QmxhY2tCZXJyeTo6dXBkYXRlSW5zcGVjdG9yU3RhdGVDb29raWUoY29uc3QgU3Ry aW5nJiBjb29raWUpCit7CisgICAgbm90SW1wbGVtZW50ZWQoKTsKK307CisKIH0gLy8gbmFtZXNw YWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3Jl U3VwcG9ydC9JbnNwZWN0b3JDbGllbnRCbGFja0JlcnJ5LmggYi9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvV2ViQ29yZVN1cHBvcnQvSW5zcGVjdG9yQ2xpZW50QmxhY2tCZXJyeS5oCmluZGV4IGQw Y2NjZWE0NThmOTNkYWEyMDk1ZTdmNjg4NDgxZTg0YjJhZmQyMGIuLmE2YTQwNGE3YTcxMzlhYjE4 MzVhNWZjODc2YjVkOGZiOGI2NjE0MjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9XZWJDb3JlU3VwcG9ydC9JbnNwZWN0b3JDbGllbnRCbGFja0JlcnJ5LmgKKysrIGIvU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0luc3BlY3RvckNsaWVudEJsYWNr QmVycnkuaApAQCAtMzYsMjkgKzM2LDIzIEBAIGNsYXNzIEluc3BlY3RvckNsaWVudEJsYWNrQmVy cnkgOiBwdWJsaWMgSW5zcGVjdG9yQ2xpZW50IHsKIHB1YmxpYzoKICAgICBJbnNwZWN0b3JDbGll bnRCbGFja0JlcnJ5KEJsYWNrQmVycnk6OldlYktpdDo6V2ViUGFnZVByaXZhdGUqKTsKICAgICB2 aXJ0dWFsIHZvaWQgaW5zcGVjdG9yRGVzdHJveWVkKCk7Ci0gICAgdmlydHVhbCBQYWdlKiBjcmVh dGVQYWdlKCk7Ci0gICAgdmlydHVhbCBTdHJpbmcgbG9jYWxpemVkU3RyaW5nc1VSTCgpOwotICAg IHZpcnR1YWwgU3RyaW5nIGhpZGRlblBhbmVscygpOwotICAgIHZpcnR1YWwgdm9pZCBzaG93V2lu ZG93KCk7Ci0gICAgdmlydHVhbCB2b2lkIGNsb3NlV2luZG93KCk7Ci0gICAgdmlydHVhbCB2b2lk IGF0dGFjaFdpbmRvdygpOwotICAgIHZpcnR1YWwgdm9pZCBkZXRhY2hXaW5kb3coKTsKLSAgICB2 aXJ0dWFsIHZvaWQgc2V0QXR0YWNoZWRXaW5kb3dIZWlnaHQodW5zaWduZWQpOworCiAgICAgdmly dHVhbCB2b2lkIGhpZ2hsaWdodCgpOwogICAgIHZpcnR1YWwgdm9pZCBoaWRlSGlnaGxpZ2h0KCk7 Ci0gICAgdmlydHVhbCB2b2lkIGluc3BlY3RlZFVSTENoYW5nZWQoY29uc3QgU3RyaW5nJik7Ci0g ICAgdmlydHVhbCB2b2lkIHBvcHVsYXRlU2V0dGluZyhjb25zdCBTdHJpbmcmIGtleSwgU3RyaW5n KiB2YWx1ZSk7Ci0gICAgdmlydHVhbCB2b2lkIHN0b3JlU2V0dGluZyhjb25zdCBTdHJpbmcmIGtl eSwgY29uc3QgU3RyaW5nJiB2YWx1ZSk7Ci0gICAgdmlydHVhbCB2b2lkIGluc3BlY3RvcldpbmRv d09iamVjdENsZWFyZWQoKTsKKwogICAgIHZpcnR1YWwgdm9pZCBvcGVuSW5zcGVjdG9yRnJvbnRl bmQoSW5zcGVjdG9yQ29udHJvbGxlciopOwogICAgIHZpcnR1YWwgdm9pZCBjbG9zZUluc3BlY3Rv ckZyb250ZW5kKCk7CiAgICAgdmlydHVhbCB2b2lkIGJyaW5nRnJvbnRlbmRUb0Zyb250KCk7CisK ICAgICB2aXJ0dWFsIGJvb2wgc2VuZE1lc3NhZ2VUb0Zyb250ZW5kKGNvbnN0IFN0cmluZyYpOwor CiAgICAgdmlydHVhbCB2b2lkIGNsZWFyQnJvd3NlckNhY2hlKCk7CiAgICAgdmlydHVhbCBib29s IGNhbkNsZWFyQnJvd3NlckNhY2hlKCkgeyByZXR1cm4gdHJ1ZTsgfQogICAgIHZpcnR1YWwgdm9p ZCBjbGVhckJyb3dzZXJDb29raWVzKCk7CiAgICAgdmlydHVhbCBib29sIGNhbkNsZWFyQnJvd3Nl ckNvb2tpZXMoKSB7IHJldHVybiB0cnVlOyB9CiAKKyAgICB2aXJ0dWFsIHZvaWQgdXBkYXRlSW5z cGVjdG9yU3RhdGVDb29raWUoY29uc3QgU3RyaW5nJik7CisKIHByaXZhdGU6CiAgICAgQmxhY2tC ZXJyeTo6V2ViS2l0OjpXZWJQYWdlUHJpdmF0ZSogbV93ZWJQYWdlUHJpdmF0ZTsKICAgICB0eXBl ZGVmIEhhc2hNYXA8U3RyaW5nLCBTdHJpbmc+IFNldHRpbmdzTWFwOwo=