87118 2012-05-22 04:53:50 -0700 [JSC] SerializedScriptValue.create() succeeds even if MessagePort object cannot be found in transferred ports 2012-05-31 03:14:30 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 86841 87384 86868 1 cdumez cdumez abarth barraclough dslomov haraken jianli jsbell levin oliver webkit.review.bot oldest_to_newest 630248 0 cdumez 2012-05-22 04:53:50 -0700 This is tested by webintents/web-intents-obj-constructor.html: // Ports, if present, must be put in |transfer|. var badchannel = new MessageChannel(); badchannel.port2.onMessage = function() { debug("* got message"); } badPortIntentObj = {"action":"action1", "type":"text/plain+badport", "data":badchannel.port1}; shouldThrow("new WebKitIntent(badPortIntentObj)", "'Error: DATA_CLONE_ERR: DOM Exception 25'"); Unfortunately, this check fails with JSC because the serialization will succeed. I can fix this as follows: --- a/Source/WebCore/bindings/js/SerializedScriptValue.cpp +++ b/Source/WebCore/bindings/js/SerializedScriptValue.cpp @@ -627,21 +627,22 @@ private: write(UString(flags, flagCount)); return true; } if (obj->inherits(&JSMessagePort::s_info)) { ObjectPool::iterator index = m_transferredMessagePorts.find(obj); if (index != m_transferredMessagePorts.end()) { write(MessagePortReferenceTag); write(index->second); return true; } - return false; + code = ValidationError; + return true; } However, I'm not 100% sure this is the right way to fix it. 630255 1 cdumez 2012-05-22 04:57:59 -0700 I added Dmitry Lomov in CC since this part of the code was added by him in Bug 70658 and I need guidance. 632720 2 143815 cdumez 2012-05-24 06:29:02 -0700 Created attachment 143815 Patch 632963 3 levin 2012-05-24 11:10:43 -0700 (In reply to comment #1) > I added Dmitry Lomov in CC since this part of the code was added by him in Bug 70658 and I need guidance. I think he is a lot less active these days. You/ll likely be better off finding someone else familiar with that area of the code. 636200 4 cdumez 2012-05-29 10:33:21 -0700 Any thought about this patch? 636542 5 abarth 2012-05-29 16:30:20 -0700 This looks plausible, but I don't know this code well enough to review it. Perhaps jsbell or haraken might be able to review your patch. 636559 6 143815 haraken 2012-05-29 16:46:38 -0700 Comment on attachment 143815 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143815&action=review > Source/WebCore/ChangeLog:11 > + matches the behavior of the V8 implementation. This behavior is tested > + by webintents/web-intents-obj-constructor.html. Would you add a test case for your change? I am afraid that the fact that there is no update in the test result of web-intents-obj-constructor.html indicates that the test is not testing your change. 636565 7 abarth 2012-05-29 16:53:08 -0700 > Would you add a test case for your change? I am afraid that the fact that there is no update in the test result of web-intents-obj-constructor.html indicates that the test is not testing your change. WebIntents is not yet enabled for JSC. This patch is part of a series to get it working in JSC. One its working, the test will exercise this patch. 636580 8 143815 haraken 2012-05-29 17:06:34 -0700 Comment on attachment 143815 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143815&action=review > Source/WebCore/bindings/js/SerializedScriptValue.cpp:638 > + code = ValidationError; It appears that v8/SerializedScriptValue.cpp returns DataCloneError in this case. 636861 9 cdumez 2012-05-29 22:31:48 -0700 (In reply to comment #7) > > Would you add a test case for your change? I am afraid that the fact that there is no update in the test result of web-intents-obj-constructor.html indicates that the test is not testing your change. > > WebIntents is not yet enabled for JSC. This patch is part of a series to get it working in JSC. One its working, the test will exercise this patch. Actually, Web Intents have been enabled by default on EFL port for a few days now, on top on JSC. The reason I cannot unskip the web-intents-obj-constructor.html test with this patch is because Bug 86841 is not closed yet. The web-intents-obj-constructor.html expects the number of MessagePorts in the Intent to be printed but our port does not support it yet. If you prefer, I can work on Bug 86841 first, and land this patch afterwards so that the web-intents-obj-constructor.html test case can be unskipped for EFL port at the same time. 636864 10 haraken 2012-05-29 22:38:32 -0700 (In reply to comment #9) > (In reply to comment #7) > If you prefer, I can work on Bug 86841 first, and land this patch afterwards so that the web-intents-obj-constructor.html test case can be unskipped for EFL port at the same time. If it is not difficult for you, that would be best. Otherwise, it would be OK to land this patch first without enabling the test (Now I understand your situation:-). 636875 11 cdumez 2012-05-29 22:51:58 -0700 (In reply to comment #8) > (From update of attachment 143815 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=143815&action=review > > > Source/WebCore/bindings/js/SerializedScriptValue.cpp:638 > > + code = ValidationError; > > It appears that v8/SerializedScriptValue.cpp returns DataCloneError in this case. JSC and V8 use different enums for error codes. JSC does not have a DataCloneError and it uses ValidationError instead for the cases where V8 uses DataCloneError. 637716 12 144927 cdumez 2012-05-30 14:49:03 -0700 Created attachment 144927 Patch Same patch but now I can actually unskip the test case (dependency patch has just landed). 637737 13 144932 cdumez 2012-05-30 15:04:15 -0700 Created attachment 144932 Patch Rebase on master. 637745 14 cdumez 2012-05-30 15:13:16 -0700 The ews-style bot apparently hasn't realized the dependency has landed yet because the patch applies cleanly on master. 637793 15 144932 abarth 2012-05-30 16:10:39 -0700 Comment on attachment 144932 Patch Yeah, the style bot runs quickly. Based on the discussion between you and Kentaro, it sounds like this patch is ready to go. 637955 16 144932 webkit.review.bot 2012-05-30 20:05:45 -0700 Comment on attachment 144932 Patch Clearing flags on attachment: 144932 Committed r119027: <http://trac.webkit.org/changeset/119027> 637956 17 webkit.review.bot 2012-05-30 20:05:53 -0700 All reviewed patches have been landed. Closing bug. 638185 18 cdumez 2012-05-31 03:14:30 -0700 fast/events/message-port-multi.html needs new baseline after this patch. I'll fix this in Bug 87949. 143815 2012-05-24 06:29:02 -0700 2012-05-30 14:49:03 -0700 Patch 87118_serialization_bug.patch text/plain 1682 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhNTMwOTA3Li5hZGM1ZDA1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMDUtMjQgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbSlNDXSBTZXJpYWxpemVkU2NyaXB0VmFsdWUuY3JlYXRlKCkgc3Vj Y2VlZHMgZXZlbiBpZiBNZXNzYWdlUG9ydCBvYmplY3QgY2Fubm90IGJlIGZvdW5kIGluIHRyYW5z ZmVycmVkIHBvcnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD04NzExOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE1ha2UgU2VyaWFsaXplZFNjcmlwdFZhbHVlLmNyZWF0ZSgpIHRocm93IGFuIGV4Y2VwdGlv biBpZiBvbmUgb2YgdGhlCisgICAgICAgIE1lc3NhZ2VQb3J0IG9iamVjdHMgY2Fubm90IGJlIGZv dW5kIGluIHRoZSB0cmFuc2ZlcnJlZCBwb3J0cy4gVGhpcworICAgICAgICBtYXRjaGVzIHRoZSBi ZWhhdmlvciBvZiB0aGUgVjggaW1wbGVtZW50YXRpb24uIFRoaXMgYmVoYXZpb3IgaXMgdGVzdGVk CisgICAgICAgIGJ5IHdlYmludGVudHMvd2ViLWludGVudHMtb2JqLWNvbnN0cnVjdG9yLmh0bWwu CisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9TZXJpYWxpemVkU2NyaXB0VmFsdWUuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6Q2xvbmVTZXJpYWxpemVyOjpkdW1wSWZUZXJtaW5hbCk6CisKIDIwMTIt MDUtMjQgIFNoaW55YSBLYXdhbmFrYSAgPHNoaW55YWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IEVsZW1lbnRzIGluIFNoYWRvdyBET00gYXJlIG5vdCByZXNpemFibGUuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TZXJpYWxpemVkU2NyaXB0VmFsdWUuY3BwIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2VyaWFsaXplZFNjcmlwdFZhbHVlLmNwcAppbmRleCA5 NzBjODUwLi5jMjVmNzY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9T ZXJpYWxpemVkU2NyaXB0VmFsdWUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pz L1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZS5jcHAKQEAgLTYzNCw3ICs2MzQsOSBAQCBwcml2YXRlOgog ICAgICAgICAgICAgICAgICAgICB3cml0ZShpbmRleC0+c2Vjb25kKTsKICAgICAgICAgICAgICAg ICAgICAgcmV0dXJuIHRydWU7CiAgICAgICAgICAgICAgICAgfQotICAgICAgICAgICAgICAgIHJl dHVybiBmYWxzZTsKKyAgICAgICAgICAgICAgICAvLyBNZXNzYWdlUG9ydCBvYmplY3QgY291bGQg bm90IGJlIGZvdW5kIGluIHRyYW5zZmVycmVkIG1lc3NhZ2UgcG9ydHMKKyAgICAgICAgICAgICAg ICBjb2RlID0gVmFsaWRhdGlvbkVycm9yOworICAgICAgICAgICAgICAgIHJldHVybiB0cnVlOwog ICAgICAgICAgICAgfQogICAgICAgICAgICAgaWYgKG9iai0+aW5oZXJpdHMoJkpTQXJyYXlCdWZm ZXI6OnNfaW5mbykpIHsKICAgICAgICAgICAgICAgICBSZWZQdHI8QXJyYXlCdWZmZXI+IGFycmF5 QnVmZmVyID0gdG9BcnJheUJ1ZmZlcihvYmopOwo= 144927 2012-05-30 14:49:03 -0700 2012-05-30 15:04:15 -0700 Patch 87118_serialization_bug.patch text/plain 3306 cdumez ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2Njk0ZDhiLi4wZWE2MGU5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIwMTItMDUt MzAgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KIAorICAg ICAgICBbSlNDXSBTZXJpYWxpemVkU2NyaXB0VmFsdWUuY3JlYXRlKCkgc3VjY2VlZHMgZXZlbiBp ZiBNZXNzYWdlUG9ydCBvYmplY3QgY2Fubm90IGJlIGZvdW5kIGluIHRyYW5zZmVycmVkIHBvcnRz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NzExOAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVuc2tpcCB3 ZWJpbnRlbnRzL3dlYi1pbnRlbnRzLW9iai1jb25zdHJ1Y3Rvci5odG1sIG5vdyB0aGF0IAorICAg ICAgICBTZXJpYWxpemVkU2NyaXB0VmFsdWUuY3JlYXRlKCkgdGhyb3dzIGFuIGV4Y2VwdGlvbiBp ZiBvbmUgb2YgdGhlCisgICAgICAgIE1lc3NhZ2VQb3J0IG9iamVjdHMgY2Fubm90IGJlIGZvdW5k IGluIHRoZSB0cmFuc2ZlcnJlZCBwb3J0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2VmbC90ZXN0 X2V4cGVjdGF0aW9ucy50eHQ6CisKKzIwMTItMDUtMzAgIENocmlzdG9waGUgRHVtZXogIDxjaHJp c3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKwogICAgICAgICBbRUZMXSBFRkwncyBEUlQgc2hvdWxk IHByaW50IHRoZSBudW1iZXIgb2YgTWVzc2FnZVBvcnRzIGZvciBuZXcgZWFjaCBuZXcgaW50ZW50 CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04Njg0MQog CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvdGVzdF9leHBlY3RhdGlvbnMu dHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAppbmRl eCA0NWI5ZWFkLi5lZjdhMGVlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwv dGVzdF9leHBlY3RhdGlvbnMudHh0CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC90ZXN0 X2V4cGVjdGF0aW9ucy50eHQKQEAgLTY1Myw3ICs2NTMsNiBAQCBCVUdXSzg0MTY3IDogdGFibGVz L21vemlsbGEvYnVncy9idWcyNDc5LTIuaHRtbCA9IElNQUdFK1RFWFQKIC8vIEluY29tcGxldGUg V2ViIEludGVudHMgc3VwcG9ydAogQlVHV0s4Njg2NiBTS0lQIDogd2ViaW50ZW50cy9pbnRlbnQt dGFnLmh0bWwgPSBURVhUCiBCVUdXSzg2ODY1IFNLSVAgOiB3ZWJpbnRlbnRzL3dlYi1pbnRlbnRz LWRlbGl2ZXJ5Lmh0bWwgPSBURVhUCi1CVUdXSzg3MTE4IDogd2ViaW50ZW50cy93ZWItaW50ZW50 cy1vYmotY29uc3RydWN0b3IuaHRtbCA9IFRFWFQKIAogLy8gRUZMJ3MgTGF5b3V0VGVzdENvbnRy b2xsZXIgZG9lcyBub3QgaW1wbGVtZW50IHNldEF1dG9tYXRpY0xpbmtEZXRlY3Rpb25FbmFibGVk CiBCVUdXSzg1NDYzIFNLSVAgOiBlZGl0aW5nL2luc2VydGluZy90eXBpbmctc3BhY2UtdG8tdHJp Z2dlci1zbWFydC1saW5rLmh0bWwgPSBGQUlMCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzI3NGQ0Ny4uMTliYjdj NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA1LTMwICBDaHJpc3RvcGhlIER1 bWV6ICA8Y2hyaXN0b3BoZS5kdW1lekBpbnRlbC5jb20+CisKKyAgICAgICAgW0pTQ10gU2VyaWFs aXplZFNjcmlwdFZhbHVlLmNyZWF0ZSgpIHN1Y2NlZWRzIGV2ZW4gaWYgTWVzc2FnZVBvcnQgb2Jq ZWN0IGNhbm5vdCBiZSBmb3VuZCBpbiB0cmFuc2ZlcnJlZCBwb3J0cworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODcxMTgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIFNlcmlhbGl6ZWRTY3JpcHRWYWx1 ZS5jcmVhdGUoKSB0aHJvdyBhbiBleGNlcHRpb24gaWYgb25lIG9mIHRoZQorICAgICAgICBNZXNz YWdlUG9ydCBvYmplY3RzIGNhbm5vdCBiZSBmb3VuZCBpbiB0aGUgdHJhbnNmZXJyZWQgcG9ydHMu IFRoaXMKKyAgICAgICAgbWF0Y2hlcyB0aGUgYmVoYXZpb3Igb2YgdGhlIFY4IGltcGxlbWVudGF0 aW9uLgorCisgICAgICAgIFRlc3Q6IHdlYmludGVudHMvd2ViLWludGVudHMtb2JqLWNvbnN0cnVj dG9yLmh0bWwKKworICAgICAgICAqIGJpbmRpbmdzL2pzL1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpDbG9uZVNlcmlhbGl6ZXI6OmR1bXBJZlRlcm1pbmFsKToK KwogMjAxMi0wNS0zMCAgU2hlemFuIEJhaWcgIDxzaGV6YmFpZy53a0BnbWFpbC5jb20+CiAKICAg ICAgICAgUmVuYW1lIG9mZnNldFRvcExlZnQgaW4gUmVuZGVyQm94TW9kZWxPYmplY3QgdG8gc29t ZXRoaW5nIGJldHRlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2Vy aWFsaXplZFNjcmlwdFZhbHVlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1Nlcmlh bGl6ZWRTY3JpcHRWYWx1ZS5jcHAKaW5kZXggOTcwYzg1MC4uYzI1Zjc2OCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2VyaWFsaXplZFNjcmlwdFZhbHVlLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TZXJpYWxpemVkU2NyaXB0VmFsdWUuY3BwCkBA IC02MzQsNyArNjM0LDkgQEAgcHJpdmF0ZToKICAgICAgICAgICAgICAgICAgICAgd3JpdGUoaW5k ZXgtPnNlY29uZCk7CiAgICAgICAgICAgICAgICAgICAgIHJldHVybiB0cnVlOwogICAgICAgICAg ICAgICAgIH0KLSAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgICAgICAgICAg Ly8gTWVzc2FnZVBvcnQgb2JqZWN0IGNvdWxkIG5vdCBiZSBmb3VuZCBpbiB0cmFuc2ZlcnJlZCBt ZXNzYWdlIHBvcnRzCisgICAgICAgICAgICAgICAgY29kZSA9IFZhbGlkYXRpb25FcnJvcjsKKyAg ICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICAgICAgICAgIH0KICAgICAgICAgICAgIGlm IChvYmotPmluaGVyaXRzKCZKU0FycmF5QnVmZmVyOjpzX2luZm8pKSB7CiAgICAgICAgICAgICAg ICAgUmVmUHRyPEFycmF5QnVmZmVyPiBhcnJheUJ1ZmZlciA9IHRvQXJyYXlCdWZmZXIob2JqKTsK 144932 2012-05-30 15:04:15 -0700 2012-05-30 20:05:45 -0700 Patch 87118_serialization_bug.patch text/plain 3305 cdumez ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0NzE1Yzg1Li41Yjk5NDJmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0zMiw2ICszMiwxOSBAQAogCiAyMDEy LTA1LTMwICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0b3BoZS5kdW1lekBpbnRlbC5jb20+CiAK KyAgICAgICAgW0pTQ10gU2VyaWFsaXplZFNjcmlwdFZhbHVlLmNyZWF0ZSgpIHN1Y2NlZWRzIGV2 ZW4gaWYgTWVzc2FnZVBvcnQgb2JqZWN0IGNhbm5vdCBiZSBmb3VuZCBpbiB0cmFuc2ZlcnJlZCBw b3J0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODcx MTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVbnNr aXAgd2ViaW50ZW50cy93ZWItaW50ZW50cy1vYmotY29uc3RydWN0b3IuaHRtbCBub3cgdGhhdCAK KyAgICAgICAgU2VyaWFsaXplZFNjcmlwdFZhbHVlLmNyZWF0ZSgpIHRocm93cyBhbiBleGNlcHRp b24gaWYgb25lIG9mIHRoZQorICAgICAgICBNZXNzYWdlUG9ydCBvYmplY3RzIGNhbm5vdCBiZSBm b3VuZCBpbiB0aGUgdHJhbnNmZXJyZWQgcG9ydHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwv dGVzdF9leHBlY3RhdGlvbnMudHh0OgorCisyMDEyLTA1LTMwICBDaHJpc3RvcGhlIER1bWV6ICA8 Y2hyaXN0b3BoZS5kdW1lekBpbnRlbC5jb20+CisKICAgICAgICAgW0VGTF0gRUZMJ3MgRFJUIHNo b3VsZCBwcmludCB0aGUgbnVtYmVyIG9mIE1lc3NhZ2VQb3J0cyBmb3IgbmV3IGVhY2ggbmV3IGlu dGVudAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODY4 NDEKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL3Rlc3RfZXhwZWN0YXRp b25zLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC90ZXN0X2V4cGVjdGF0aW9ucy50eHQK aW5kZXggZjdkODBhM2QuLjkyZThjNmUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3Jt L2VmbC90ZXN0X2V4cGVjdGF0aW9ucy50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZs L3Rlc3RfZXhwZWN0YXRpb25zLnR4dApAQCAtNjUzLDcgKzY1Myw2IEBAIEJVR1dLODQxNjcgOiB0 YWJsZXMvbW96aWxsYS9idWdzL2J1ZzI0NzktMi5odG1sID0gSU1BR0UrVEVYVAogLy8gSW5jb21w bGV0ZSBXZWIgSW50ZW50cyBzdXBwb3J0CiBCVUdXSzg2ODY2IFNLSVAgOiB3ZWJpbnRlbnRzL2lu dGVudC10YWcuaHRtbCA9IFRFWFQKIEJVR1dLODY4NjUgU0tJUCA6IHdlYmludGVudHMvd2ViLWlu dGVudHMtZGVsaXZlcnkuaHRtbCA9IFRFWFQKLUJVR1dLODcxMTggOiB3ZWJpbnRlbnRzL3dlYi1p bnRlbnRzLW9iai1jb25zdHJ1Y3Rvci5odG1sID0gVEVYVAogCiAvLyBFRkwncyBMYXlvdXRUZXN0 Q29udHJvbGxlciBkb2VzIG5vdCBpbXBsZW1lbnQgc2V0QXV0b21hdGljTGlua0RldGVjdGlvbkVu YWJsZWQKIEJVR1dLODU0NjMgU0tJUCA6IGVkaXRpbmcvaW5zZXJ0aW5nL3R5cGluZy1zcGFjZS10 by10cmlnZ2VyLXNtYXJ0LWxpbmsuaHRtbCA9IEZBSUwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3ZDc0NTQyLi5l ZmU5M2ViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTItMDUtMzAgIENocmlzdG9w aGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBbSlNDXSBT ZXJpYWxpemVkU2NyaXB0VmFsdWUuY3JlYXRlKCkgc3VjY2VlZHMgZXZlbiBpZiBNZXNzYWdlUG9y dCBvYmplY3QgY2Fubm90IGJlIGZvdW5kIGluIHRyYW5zZmVycmVkIHBvcnRzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NzExOAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2UgU2VyaWFsaXplZFNjcmlw dFZhbHVlLmNyZWF0ZSgpIHRocm93IGFuIGV4Y2VwdGlvbiBpZiBvbmUgb2YgdGhlCisgICAgICAg IE1lc3NhZ2VQb3J0IG9iamVjdHMgY2Fubm90IGJlIGZvdW5kIGluIHRoZSB0cmFuc2ZlcnJlZCBw b3J0cy4gVGhpcworICAgICAgICBtYXRjaGVzIHRoZSBiZWhhdmlvciBvZiB0aGUgVjggaW1wbGVt ZW50YXRpb24uCisKKyAgICAgICAgVGVzdDogd2ViaW50ZW50cy93ZWItaW50ZW50cy1vYmotY29u c3RydWN0b3IuaHRtbAorCisgICAgICAgICogYmluZGluZ3MvanMvU2VyaWFsaXplZFNjcmlwdFZh bHVlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNsb25lU2VyaWFsaXplcjo6ZHVtcElmVGVybWlu YWwpOgorCiAyMDEyLTA1LTMwICBFbWlsIEEgRWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBGbG9hdHMgd3JhcHMgaW5jb3JyZWN0bHkgd2hlbiB0b3AgZWRnZSBoYXMgc3VicGl4 ZWwgcHJlY2lzaW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TZXJp YWxpemVkU2NyaXB0VmFsdWUuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2VyaWFs aXplZFNjcmlwdFZhbHVlLmNwcAppbmRleCA5NzBjODUwLi5jMjVmNzY4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TZXJpYWxpemVkU2NyaXB0VmFsdWUuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZS5jcHAKQEAg LTYzNCw3ICs2MzQsOSBAQCBwcml2YXRlOgogICAgICAgICAgICAgICAgICAgICB3cml0ZShpbmRl eC0+c2Vjb25kKTsKICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgICAgICAg ICAgICAgfQotICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgICAgICAgICAv LyBNZXNzYWdlUG9ydCBvYmplY3QgY291bGQgbm90IGJlIGZvdW5kIGluIHRyYW5zZmVycmVkIG1l c3NhZ2UgcG9ydHMKKyAgICAgICAgICAgICAgICBjb2RlID0gVmFsaWRhdGlvbkVycm9yOworICAg ICAgICAgICAgICAgIHJldHVybiB0cnVlOwogICAgICAgICAgICAgfQogICAgICAgICAgICAgaWYg KG9iai0+aW5oZXJpdHMoJkpTQXJyYXlCdWZmZXI6OnNfaW5mbykpIHsKICAgICAgICAgICAgICAg ICBSZWZQdHI8QXJyYXlCdWZmZXI+IGFycmF5QnVmZmVyID0gdG9BcnJheUJ1ZmZlcihvYmopOwo=