87116 2012-05-22 04:27:36 -0700 [Blackberry]Pages contain video or audio tags should be in pageCache 2012-05-22 20:40:46 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 logingx webkit-unassigned logingx mfeil rwlbuis staikos tonikitoo webkit.review.bot oldest_to_newest 630228 0 logingx 2012-05-22 04:27:36 -0700 There is not any reason to disable pageCache for video/audio tags. 630235 1 143273 logingx 2012-05-22 04:40:10 -0700 Created attachment 143273 Patch 631115 2 143273 webkit.review.bot 2012-05-22 20:22:17 -0700 Comment on attachment 143273 Patch Clearing flags on attachment: 143273 Committed r118109: <http://trac.webkit.org/changeset/118109> 631116 3 webkit.review.bot 2012-05-22 20:22:22 -0700 All reviewed patches have been landed. Closing bug. 631130 4 tonikitoo 2012-05-22 20:40:46 -0700 (In reply to comment #0) > There is not any reason to disable pageCache for video/audio tags. there was a reason for sure :) 143273 2012-05-22 04:40:10 -0700 2012-05-22 20:22:17 -0700 Patch bug-87116-20120522194007.patch text/plain 2277 logingx U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3OTQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBhNjA0MWJmZTBmNTYwMzk3Y2YyYjhjOGMzYjdjMDU1MjU4MDY1MzU3Li4yMDgwNDNhOWVk NjA1NDZiMWRkZDA5ZjY5ZmNlNjBkOThmZjdhM2JiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0wNS0yMiAgQ2hyaXMgR3VhbiAgPGNocmlzLmd1 YW5AdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFtCbGFja2JlcnJ5XVBhZ2VzIGNvbnRh aW4gdmlkZW8gb3IgYXVkaW8gdGFncyBzaG91bGQgYmUgaW4gcGFnZUNhY2hlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NzExNgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgVGhlcmUgaXMgbm90 IGFueSByZWFzb24gdG8gZGlzYWJsZSBwYWdlQ2FjaGUgZm9yIHZpZGVvL2F1ZGlvIAorICAgICAg ICB0YWdzIHByb2JhYmx5LiBCeSBteSB0ZXN0aW5nLCBCYWNrIGFuZCBGb3J3YXJkIGFyZSB3b3Jr aW5nIGZvciAKKyAgICAgICAgdGhvc2UgcGFnZXMgY29udGFpbiB2aWRlbyBhbmQgYXVkaW8gdGFn cy4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJy eS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnk6OmNh bkNhY2hlUGFnZSk6CisKIDIwMTItMDUtMTggIE1pa2UgRmVudG9uICA8bWlmZW50b25AcmltLmNv bT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gVmFsaWRhdGlvbiBvZiBMYXN0IEZhdCBGaW5nZXIg cmVzdWx0IGlzIG5lZWRlZCBmb3Igc2VsZWN0aW9uLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5j cHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJD bGllbnRCbGFja0JlcnJ5LmNwcAppbmRleCA2ZWY0ZTQ0OTBiYzFkZjU2ZDkzOTQ3ZGM5MmZiMjA1 NDM2ZTM3Yjk4Li43NDc3NjMxZDYxMDZjMDVmY2YzZTU5MzA0OWIzNzliNTUyYzJmMGY5IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2Fk ZXJDbGllbnRCbGFja0JlcnJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2Vi Q29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5LmNwcApAQCAtMTE3MCwxNSAr MTE3MCw3IEBAIHZvaWQgRnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5OjpkaXNwYXRjaERpZFJl Y2VpdmVJY29uKCkKIAogYm9vbCBGcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnk6OmNhbkNhY2hl UGFnZSgpIGNvbnN0CiB7Ci0gICAgLy8gV2Ugd29uJ3QgY2FjaGUgcGFnZXMgY29udGFpbmluZyB2 aWRlbywgYXVkaW8gb3IgbXVsdGlwYXJ0IHdpdGggIm11bHRpcGFydC94LW1peGVkLXJlcGxhY2Ui LgotICAgIEFTU0VSVChtX2ZyYW1lLT5kb2N1bWVudCgpKTsKLSAgICBSZWZQdHI8Tm9kZUxpc3Q+ IG5vZGVMaXN0ID0gbV9mcmFtZS0+ZG9jdW1lbnQoKS0+Z2V0RWxlbWVudHNCeVRhZ05hbWUoSFRN TE5hbWVzOjp2aWRlb1RhZy5sb2NhbE5hbWUoKSk7Ci0gICAgaWYgKG5vZGVMaXN0LmdldCgpLT5s ZW5ndGgoKSA+IDApCi0gICAgICAgIHJldHVybiBmYWxzZTsKLSAgICBub2RlTGlzdCA9IG1fZnJh bWUtPmRvY3VtZW50KCktPmdldEVsZW1lbnRzQnlUYWdOYW1lKEhUTUxOYW1lczo6YXVkaW9UYWcu bG9jYWxOYW1lKCkpOwotICAgIGlmIChub2RlTGlzdC5nZXQoKS0+bGVuZ3RoKCkgPiAwKQotICAg ICAgICByZXR1cm4gZmFsc2U7Ci0KKyAgICAvLyBXZSB3b24ndCBjYWNoZSBwYWdlcyBjb250YWlu aW5nIG11bHRpcGFydCB3aXRoICJtdWx0aXBhcnQveC1taXhlZC1yZXBsYWNlIi4KICAgICBBU1NF UlQobV9mcmFtZS0+bG9hZGVyKCktPmRvY3VtZW50TG9hZGVyKCkpOwogICAgIGNvbnN0IFJlc3Bv bnNlVmVjdG9yJiByZXNwb25zZXMgPSBtX2ZyYW1lLT5sb2FkZXIoKS0+ZG9jdW1lbnRMb2FkZXIo KS0+cmVzcG9uc2VzKCk7CiAgICAgc2l6ZV90IGNvdW50ID0gcmVzcG9uc2VzLnNpemUoKTsK