87106 2012-05-22 02:14:31 -0700 [V8] Replace 'throwTypeError(); return Undefined();' with 'return throwTypeError();' 2012-05-22 15:58:33 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85330 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 630119 0 haraken 2012-05-22 02:14:31 -0700 We can replace throwTypeError(); return v8::Undefined(); with return throwTypeError(); This will be the final patch for a series of replacements. 630125 1 143239 haraken 2012-05-22 02:19:41 -0700 Created attachment 143239 Patch 630863 2 143239 webkit.review.bot 2012-05-22 15:58:15 -0700 Comment on attachment 143239 Patch Clearing flags on attachment: 143239 Committed r118075: <http://trac.webkit.org/changeset/118075> 630864 3 webkit.review.bot 2012-05-22 15:58:33 -0700 All reviewed patches have been landed. Closing bug. 143239 2012-05-22 02:19:41 -0700 2012-05-22 15:58:14 -0700 Patch bug-87106-20120522181940.patch text/plain 4380 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3OTM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTNlZmQ5MjJkNTVhZmZj YzU5Yzg2ZDc5ZDYyYTZlMTY2MjA2Njk2My4uMjdiYTcxYjdlYjVmNGIzYTZhODQ0MDg4NTA0ZmFi ZWU3MTA2NTE3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMwIEBACiAyMDEyLTA1LTIyICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbVjhdIFJlcGxhY2Ug J3Rocm93VHlwZUVycm9yKCk7IHJldHVybiBVbmRlZmluZWQoKTsnIHdpdGggJ3JldHVybiB0aHJv d1R5cGVFcnJvcigpOycKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTg3MTA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVGhpcyBwYXRjaCByZXBsYWNlcworCisgICAgICAgICAgICB0aHJvd1R5cGVFcnJvcigp OworICAgICAgICAgICAgcmV0dXJuIHY4OjpVbmRlZmluZWQoKTsKKworICAgICAgICB3aXRoCisK KyAgICAgICAgICAgIHJldHVybiB0aHJvd1R5cGVFcnJvcigpOworCisgICAgICAgIE5vIHRlc3Rz LiBObyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0Nv ZGVHZW5lcmF0b3JWOC5wbToKKyAgICAgICAgKEdlbmVyYXRlT3ZlcmxvYWRlZEZ1bmN0aW9uQ2Fs bGJhY2spOgorICAgICAgICAoR2VuZXJhdGVQYXJhbWV0ZXJzQ2hlY2spOgorICAgICAgICAqIGJp bmRpbmdzL3NjcmlwdHMvdGVzdC9WOC9WOFRlc3RPYmouY3BwOgorICAgICAgICAoV2ViQ29yZTo6 VGVzdE9ialY4SW50ZXJuYWw6Om92ZXJsb2FkZWRNZXRob2RDYWxsYmFjayk6CisgICAgICAgIChX ZWJDb3JlOjpUZXN0T2JqVjhJbnRlcm5hbDo6b3ZlcmxvYWRlZE1ldGhvZDFDYWxsYmFjayk6CisK KzIwMTItMDUtMjIgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgorCiAgICAg ICAgIFtWOF0gQWRkIGFuIG9wdGlvbmFsICdpc29sYXRlJyBhcmd1bWVudCB0byB0aHJvd1R5cGVF cnJvcigpCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04 NzA3MAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVH ZW5lcmF0b3JWOC5wbSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVy YXRvclY4LnBtCmluZGV4IGYzYmVkODM5MWQ0ZTg1NmU2ZjgyZDQxZDFkMDhhOWE0NGUxMjk5ZGIu LjFlOWNhY2Q4NjVhNzc3ZjY2NDk2ZjdkNzA1Y2ZkODY5NDRkNDQ2OTQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCkBAIC0xMzU0 LDggKzEzNTQsNyBAQCBFTkQKICAgICAgICAgcHVzaChAaW1wbENvbnRlbnREZWNscywgIiAgICAg ICAgcmV0dXJuICR7bmFtZX0kb3ZlcmxvYWQtPntvdmVybG9hZEluZGV4fUNhbGxiYWNrKGFyZ3Mp O1xuIik7CiAgICAgfQogICAgIHB1c2goQGltcGxDb250ZW50RGVjbHMsIDw8RU5EKTsKLSAgICBW OFByb3h5Ojp0aHJvd1R5cGVFcnJvcigwLCBhcmdzLkdldElzb2xhdGUoKSk7Ci0gICAgcmV0dXJu IHY4OjpIYW5kbGU8djg6OlZhbHVlPigpOworICAgIHJldHVybiBWOFByb3h5Ojp0aHJvd1R5cGVF cnJvcigwLCBhcmdzLkdldElzb2xhdGUoKSk7CiBFTkQKICAgICBwdXNoKEBpbXBsQ29udGVudERl Y2xzLCAifVxuXG4iKTsKICAgICBwdXNoKEBpbXBsQ29udGVudERlY2xzLCAiI2VuZGlmIC8vICR7 Y29uZGl0aW9uYWxTdHJpbmd9XG5cbiIpIGlmICRjb25kaXRpb25hbFN0cmluZzsKQEAgLTE2NjIs MTAgKzE2NjEsOCBAQCBzdWIgR2VuZXJhdGVQYXJhbWV0ZXJzQ2hlY2sKICAgICAgICAgICAgICAg ICBteSAkYXJnVmFsdWUgPSAiYXJnc1skcGFyYW1JbmRleF0iOwogICAgICAgICAgICAgICAgIG15 ICRhcmdUeXBlID0gR2V0VHlwZUZyb21TaWduYXR1cmUoJHBhcmFtZXRlcik7CiAgICAgICAgICAg ICAgICAgaWYgKElzV3JhcHBlclR5cGUoJGFyZ1R5cGUpKSB7Ci0gICAgICAgICAgICAgICAgICAg ICRwYXJhbWV0ZXJDaGVja1N0cmluZyAuPSAiICAgIGlmIChhcmdzLkxlbmd0aCgpID4gJHBhcmFt SW5kZXggJiYgIWlzVW5kZWZpbmVkT3JOdWxsKCRhcmdWYWx1ZSkgJiYgIVY4JHthcmdUeXBlfTo6 SGFzSW5zdGFuY2UoJGFyZ1ZhbHVlKSkge1xuIjsKLSAgICAgICAgICAgICAgICAgICAgJHBhcmFt ZXRlckNoZWNrU3RyaW5nIC49ICIgICAgICAgIFY4UHJveHk6OnRocm93VHlwZUVycm9yKDAsIGFy Z3MuR2V0SXNvbGF0ZSgpKTtcbiI7Ci0gICAgICAgICAgICAgICAgICAgICRwYXJhbWV0ZXJDaGVj a1N0cmluZyAuPSAiICAgICAgICByZXR1cm4gdjg6OkhhbmRsZTx2ODo6VmFsdWU+KCk7XG4iOwot ICAgICAgICAgICAgICAgICAgICAkcGFyYW1ldGVyQ2hlY2tTdHJpbmcgLj0gIiAgICB9XG4iOwor ICAgICAgICAgICAgICAgICAgICAkcGFyYW1ldGVyQ2hlY2tTdHJpbmcgLj0gIiAgICBpZiAoYXJn cy5MZW5ndGgoKSA+ICRwYXJhbUluZGV4ICYmICFpc1VuZGVmaW5lZE9yTnVsbCgkYXJnVmFsdWUp ICYmICFWOCR7YXJnVHlwZX06Okhhc0luc3RhbmNlKCRhcmdWYWx1ZSkpXG4iOworICAgICAgICAg ICAgICAgICAgICAkcGFyYW1ldGVyQ2hlY2tTdHJpbmcgLj0gIiAgICAgICAgcmV0dXJuIFY4UHJv eHk6OnRocm93VHlwZUVycm9yKDAsIGFyZ3MuR2V0SXNvbGF0ZSgpKTtcbiI7CiAgICAgICAgICAg ICAgICAgfQogICAgICAgICAgICAgfQogICAgICAgICAgICAgJHBhcmFtZXRlckNoZWNrU3RyaW5n IC49ICIgICAgRVhDRVBUSU9OX0JMT0NLKCRuYXRpdmVUeXBlLCAkcGFyYW1ldGVyTmFtZSwgIiAu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvVjgvVjhU ZXN0T2JqLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9WOC9WOFRl c3RPYmouY3BwCmluZGV4IDZlYzNiYjFhY2Y1N2VjOTIyZTJjNDhkYmRmMTYwNmMzNTY1YmU5NGMu LjIyYmI1N2E0MDc4OGMxMDI5NmZiZTgzYjIwYzA0MDkxYjc5Zjg1OTYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9WOC9WOFRlc3RPYmouY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9WOC9WOFRlc3RPYmouY3BwCkBA IC0xODEzLDggKzE4MTMsNyBAQCBzdGF0aWMgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IG92ZXJsb2Fk ZWRNZXRob2RDYWxsYmFjayhjb25zdCB2ODo6QXJndW1lbnRzJiBhcmdzKQogICAgICAgICByZXR1 cm4gb3ZlcmxvYWRlZE1ldGhvZDZDYWxsYmFjayhhcmdzKTsKICAgICBpZiAoKGFyZ3MuTGVuZ3Ro KCkgPT0gMSAmJiAoYXJnc1swXS0+SXNOdWxsKCkgfHwgYXJnc1swXS0+SXNBcnJheSgpKSkpCiAg ICAgICAgIHJldHVybiBvdmVybG9hZGVkTWV0aG9kN0NhbGxiYWNrKGFyZ3MpOwotICAgIFY4UHJv eHk6OnRocm93VHlwZUVycm9yKDAsIGFyZ3MuR2V0SXNvbGF0ZSgpKTsKLSAgICByZXR1cm4gdjg6 OkhhbmRsZTx2ODo6VmFsdWU+KCk7CisgICAgcmV0dXJuIFY4UHJveHk6OnRocm93VHlwZUVycm9y KDAsIGFyZ3MuR2V0SXNvbGF0ZSgpKTsKIH0KIAogc3RhdGljIHY4OjpIYW5kbGU8djg6OlZhbHVl PiBjbGFzc01ldGhvZENhbGxiYWNrKGNvbnN0IHY4OjpBcmd1bWVudHMmIGFyZ3MpCkBAIC0xODcx LDggKzE4NzAsNyBAQCBzdGF0aWMgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IG92ZXJsb2FkZWRNZXRo b2QxQ2FsbGJhY2soY29uc3Qgdjg6OkFyZ3VtZW50cyYgYXJncwogICAgICAgICByZXR1cm4gb3Zl cmxvYWRlZE1ldGhvZDExQ2FsbGJhY2soYXJncyk7CiAgICAgaWYgKChhcmdzLkxlbmd0aCgpID09 IDEgJiYgKGFyZ3NbMF0tPklzTnVsbCgpIHx8IGFyZ3NbMF0tPklzVW5kZWZpbmVkKCkgfHwgYXJn c1swXS0+SXNTdHJpbmcoKSB8fCBhcmdzWzBdLT5Jc09iamVjdCgpKSkpCiAgICAgICAgIHJldHVy biBvdmVybG9hZGVkTWV0aG9kMTJDYWxsYmFjayhhcmdzKTsKLSAgICBWOFByb3h5Ojp0aHJvd1R5 cGVFcnJvcigwLCBhcmdzLkdldElzb2xhdGUoKSk7Ci0gICAgcmV0dXJuIHY4OjpIYW5kbGU8djg6 OlZhbHVlPigpOworICAgIHJldHVybiBWOFByb3h5Ojp0aHJvd1R5cGVFcnJvcigwLCBhcmdzLkdl dElzb2xhdGUoKSk7CiB9CiAKICNlbmRpZiAvLyBFTkFCTEUoQ29uZGl0aW9uMSkK