87097 2012-05-22 01:29:11 -0700 [Chromium][API] Introduce WebPermissionClient::allowWebComponents() 2012-05-22 18:57:48 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 86984 1 morrita morrita abarth dglazkov fishd jamesr tkent tkent+wkapi webkit.review.bot oldest_to_newest 630072 0 morrita 2012-05-22 01:29:11 -0700 This is going to be an all-in-one API to turn on/off the web component features. 630110 1 143233 morrita 2012-05-22 01:59:45 -0700 Created attachment 143233 Patch 630111 2 webkit.review.bot 2012-05-22 02:01:13 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 630121 3 143233 tkent 2012-05-22 02:15:18 -0700 Comment on attachment 143233 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143233&action=review > Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp:248 > + return enabledAsRuntimeFeatures; Is it safe to use this value as a fallback? 630447 4 143233 dglazkov 2012-05-22 09:32:51 -0700 Comment on attachment 143233 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143233&action=review > Source/WebKit/chromium/public/WebPermissionClient.h:92 > + // Controls whether enabling Web Components API for this frame. "whether Web Components API are enabled for this frame." > Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp:242 > +bool FrameLoaderClientImpl::shadowDOMAllowed(bool enabledAsRuntimeFeatures) enabledAsRuntimeFeatures -> enabledAsRuntimeFeature 630561 5 143233 fishd 2012-05-22 11:15:02 -0700 Comment on attachment 143233 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143233&action=review > Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp:246 > + return webview->permissionClient()->allowWebComponents(m_webFrame, enabledAsRuntimeFeatures); why are we mapping shadowDOMAllowed to allowWebComponents? should the FrameLoaderClient method be renamed to allowWebComponents as well? or should the API one change to say "shadow DOM" instead? 630629 6 dglazkov 2012-05-22 12:02:16 -0700 (In reply to comment #5) > (From update of attachment 143233 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=143233&action=review > > > Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp:246 > > + return webview->permissionClient()->allowWebComponents(m_webFrame, enabledAsRuntimeFeatures); > > why are we mapping shadowDOMAllowed to allowWebComponents? should the FrameLoaderClient method be renamed to allowWebComponents as well? or should the API one change to say "shadow DOM" instead? This is a good question. Initially, I thought that we would make the decision on what flags substitute web Components at the chrome://flags UI level and check/uncheck boxes as a group. Morrita-san's patch attempts to move it to WebKit API layer, which seems on the short term, because we don't need to go and modify the chrome://flags UI. 630877 7 morrita 2012-05-22 16:10:10 -0700 (In reply to comment #6) > (In reply to comment #5) > > (From update of attachment 143233 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=143233&action=review > > > > > Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp:246 > > > + return webview->permissionClient()->allowWebComponents(m_webFrame, enabledAsRuntimeFeatures); > > > > why are we mapping shadowDOMAllowed to allowWebComponents? should the FrameLoaderClient method be renamed to allowWebComponents as well? or should the API one change to say "shadow DOM" instead? > > This is a good question. Initially, I thought that we would make the decision on what flags substitute web Components at the chrome://flags UI level and check/uncheck boxes as a group. > > Morrita-san's patch attempts to move it to WebKit API layer, which seems on the short term, because we don't need to go and modify the chrome://flags UI. Yeah, the intention here is to let allowWebComponents to cover several WebCore flags, like scoped stylesheet and upcoming other features. 630883 8 143233 morrita 2012-05-22 16:13:29 -0700 Comment on attachment 143233 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143233&action=review >> Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp:248 >> + return enabledAsRuntimeFeatures; > > Is it safe to use this value as a fallback? Yes. This API is to relax the restriction, not to limit it. This is going to return true for some frames even if the default is false. 630953 9 143405 morrita 2012-05-22 17:11:41 -0700 Created attachment 143405 Patch for landing 631066 10 143405 webkit.review.bot 2012-05-22 18:57:41 -0700 Comment on attachment 143405 Patch for landing Clearing flags on attachment: 143405 Committed r118097: <http://trac.webkit.org/changeset/118097> 631068 11 webkit.review.bot 2012-05-22 18:57:48 -0700 All reviewed patches have been landed. Closing bug. 143233 2012-05-22 01:59:45 -0700 2012-05-22 17:11:35 -0700 Patch bug-87097-20120522175944.patch text/plain 3706 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3OTI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDMzY2UwNTk0ZjY3OWFhMzcxMGQwMmEwZTNmZTFmMzMwMTQwMzI0YTQuLjJjZDU0YjMzYTYyNDNi NDE0NWZmMzMxNDMyN2Y3MmJlOTk4OGZhYjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTItMDUtMjIgIE1PUklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2ds ZS5jb20+CisKKyAgICAgICAgW0Nocm9taXVtXVtBUEldIEludHJvZHVjZSBXZWJQZXJtaXNzaW9u Q2xpZW50OjphbGxvd1dlYkNvbXBvbmVudHMoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODcwOTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAtIEFkZGVkIFdlYlBlcm1pc3Npb25DbGllbnQ6OmFsbG93V2Vi Q29tcG9uZW50cygpLCBhbmQKKyAgICAgICAgLSBJbXBsZW1lbnRlZCBGcmFtZUxvYWRlckNsaWVu dEltcGw6OnNoYWRvd0RPTUFsbG93ZWQoKSB1c2luZyBpdC4KKworICAgICAgICAqIHB1YmxpYy9X ZWJQZXJtaXNzaW9uQ2xpZW50Lmg6CisgICAgICAgIChXZWJQZXJtaXNzaW9uQ2xpZW50KToKKyAg ICAgICAgKFdlYktpdDo6V2ViUGVybWlzc2lvbkNsaWVudDo6YWxsb3dXZWJDb21wb25lbnRzKToK KyAgICAgICAgKiBzcmMvRnJhbWVMb2FkZXJDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktp dDo6RnJhbWVMb2FkZXJDbGllbnRJbXBsOjpzaGFkb3dET01BbGxvd2VkKToKKyAgICAgICAgKFdl YktpdCk6CisgICAgICAgICogc3JjL0ZyYW1lTG9hZGVyQ2xpZW50SW1wbC5oOgorICAgICAgICAo RnJhbWVMb2FkZXJDbGllbnRJbXBsKToKKwogMjAxMi0wNS0yMSAgQWxleGFuZHJlIEVsaWFzICA8 YWVsaWFzQGdvb2dsZS5jb20+CiAKICAgICAgICAgW2Nocm9taXVtXSBTaW1wbGlmeSBSVEwgcm9v dCBsYXllciBhZGp1c3RtZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy9XZWJQZXJtaXNzaW9uQ2xpZW50LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1Ymxp Yy9XZWJQZXJtaXNzaW9uQ2xpZW50LmgKaW5kZXggYmMyNTE4MjVjYzQyMzRlZjgzNmFhZDcwOWY3 NjI4NTZjOTA1YzVjMC4uMTE2YTM4M2NhOGMyOGI0Nzg5YWU3MzVmZjFlNDRjZDMyN2RkZWM4MyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViUGVybWlzc2lvbkNs aWVudC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlBlcm1pc3Npb25D bGllbnQuaApAQCAtODksNiArODksOSBAQCBwdWJsaWM6CiAgICAgLy8gQ29udHJvbHMgd2hldGhl ciBhY2Nlc3MgdG8gd3JpdGUgdGhlIGNsaXBib2FyZCBpcyBhbGxvd2VkIGZvciB0aGlzIGZyYW1l LgogICAgIHZpcnR1YWwgYm9vbCBhbGxvd1dyaXRlVG9DbGlwYm9hcmQoV2ViRnJhbWUqLCBib29s IGRlZmF1bHRWYWx1ZSkgeyByZXR1cm4gZGVmYXVsdFZhbHVlOyB9CiAKKyAgICAvLyBDb250cm9s cyB3aGV0aGVyIGVuYWJsaW5nIFdlYiBDb21wb25lbnRzIEFQSSBmb3IgdGhpcyBmcmFtZS4KKyAg ICB2aXJ0dWFsIGJvb2wgYWxsb3dXZWJDb21wb25lbnRzKFdlYkZyYW1lKiwgYm9vbCBkZWZhdWx0 VmFsdWUpIHsgcmV0dXJuIGRlZmF1bHRWYWx1ZTsgfQorCiAgICAgLy8gTm90aWZpZXMgdGhlIGNs aWVudCB0aGF0IHRoZSBmcmFtZSB3b3VsZCBoYXZlIGluc3RhbnRpYXRlZCBhIHBsdWctaW4gaWYg cGx1Zy1pbnMgd2VyZSBlbmFibGVkLgogICAgIHZpcnR1YWwgdm9pZCBkaWROb3RBbGxvd1BsdWdp bnMoV2ViRnJhbWUqKSB7IH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvRnJhbWVMb2FkZXJDbGllbnRJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3Jj L0ZyYW1lTG9hZGVyQ2xpZW50SW1wbC5jcHAKaW5kZXggZDA2MDJhOWEwZTcwNGVjZDkxMmY2ZGNh ZmMxY2NjNWY5YTJhZjlmYi4uOWNjNzk1YjBkNmEyMzE4YTA3NTQ3ZGU0ZjJjNDE3ODA5NzMwOTY1 OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvRnJhbWVMb2FkZXJDbGll bnRJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9GcmFtZUxvYWRlckNs aWVudEltcGwuY3BwCkBAIC0yMzksNiArMjM5LDE1IEBAIGJvb2wgRnJhbWVMb2FkZXJDbGllbnRJ bXBsOjphbGxvd1J1bm5pbmdJbnNlY3VyZUNvbnRlbnQoYm9vbCBlbmFibGVkUGVyU2V0dGluZ3Ms CiAgICAgcmV0dXJuIGVuYWJsZWRQZXJTZXR0aW5nczsKIH0KIAorYm9vbCBGcmFtZUxvYWRlckNs aWVudEltcGw6OnNoYWRvd0RPTUFsbG93ZWQoYm9vbCBlbmFibGVkQXNSdW50aW1lRmVhdHVyZXMp Cit7CisgICAgV2ViVmlld0ltcGwqIHdlYnZpZXcgPSBtX3dlYkZyYW1lLT52aWV3SW1wbCgpOwor ICAgIGlmICh3ZWJ2aWV3ICYmIHdlYnZpZXctPnBlcm1pc3Npb25DbGllbnQoKSkKKyAgICAgICAg cmV0dXJuIHdlYnZpZXctPnBlcm1pc3Npb25DbGllbnQoKS0+YWxsb3dXZWJDb21wb25lbnRzKG1f d2ViRnJhbWUsIGVuYWJsZWRBc1J1bnRpbWVGZWF0dXJlcyk7CisKKyAgICByZXR1cm4gZW5hYmxl ZEFzUnVudGltZUZlYXR1cmVzOworfQorCiB2b2lkIEZyYW1lTG9hZGVyQ2xpZW50SW1wbDo6ZGlk Tm90QWxsb3dTY3JpcHQoKQogewogICAgIFdlYlZpZXdJbXBsKiB3ZWJ2aWV3ID0gbV93ZWJGcmFt ZS0+dmlld0ltcGwoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0Zy YW1lTG9hZGVyQ2xpZW50SW1wbC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvRnJhbWVM b2FkZXJDbGllbnRJbXBsLmgKaW5kZXggZWNiMjBhMmZiMjVlZmU2NGFmZTYwZDQyNDZlNmM5OTNh ZjVmMzEyOS4uOWQwZTUwMDA1MDc0YzE4ZGU5ODM0YWQ4ZjgxOTJhNzhhOWM0ZGRjYSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvRnJhbWVMb2FkZXJDbGllbnRJbXBsLmgK KysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvRnJhbWVMb2FkZXJDbGllbnRJbXBsLmgK QEAgLTE5OSw2ICsxOTksNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBib29sIGFsbG93SW1hZ2Uo Ym9vbCBlbmFibGVkUGVyU2V0dGluZ3MsIGNvbnN0IFdlYkNvcmU6OktVUkwmIGltYWdlVVJMKTsK ICAgICB2aXJ0dWFsIGJvb2wgYWxsb3dEaXNwbGF5aW5nSW5zZWN1cmVDb250ZW50KGJvb2wgZW5h YmxlZFBlclNldHRpbmdzLCBXZWJDb3JlOjpTZWN1cml0eU9yaWdpbiosIGNvbnN0IFdlYkNvcmU6 OktVUkwmKTsKICAgICB2aXJ0dWFsIGJvb2wgYWxsb3dSdW5uaW5nSW5zZWN1cmVDb250ZW50KGJv b2wgZW5hYmxlZFBlclNldHRpbmdzLCBXZWJDb3JlOjpTZWN1cml0eU9yaWdpbiosIGNvbnN0IFdl YkNvcmU6OktVUkwmKTsKKyAgICB2aXJ0dWFsIGJvb2wgc2hhZG93RE9NQWxsb3dlZChib29sIGVu YWJsZWRBc1J1bnRpbWVGZWF0dXJlcykgT1ZFUlJJREU7CiAgICAgdmlydHVhbCB2b2lkIGRpZE5v dEFsbG93U2NyaXB0KCk7CiAgICAgdmlydHVhbCB2b2lkIGRpZE5vdEFsbG93UGx1Z2lucygpOwog Cg== 143405 2012-05-22 17:11:41 -0700 2012-05-22 18:57:41 -0700 Patch for landing bug-87097-20120523091140.patch text/plain 3693 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4MDgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGE1Y2RjZDgwODQ5OThjNzRlZDEyNGJjMDk3MWVmZGU2OWUwN2RkZjguLmVlMzUxMThlNjI3OGNj OTg5NTkzYjhjZmNjZDRiZGU1MzA0M2JkY2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTItMDUtMjIgIE1PUklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2ds ZS5jb20+CisKKyAgICAgICAgW0Nocm9taXVtXVtBUEldIEludHJvZHVjZSBXZWJQZXJtaXNzaW9u Q2xpZW50OjphbGxvd1dlYkNvbXBvbmVudHMoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODcwOTcKKworICAgICAgICBSZXZpZXdlZCBieSBLZW50IFRh bXVyYS4KKworICAgICAgICAtIEFkZGVkIFdlYlBlcm1pc3Npb25DbGllbnQ6OmFsbG93V2ViQ29t cG9uZW50cygpLCBhbmQKKyAgICAgICAgLSBJbXBsZW1lbnRlZCBGcmFtZUxvYWRlckNsaWVudElt cGw6OnNoYWRvd0RPTUFsbG93ZWQoKSB1c2luZyBpdC4KKworICAgICAgICAqIHB1YmxpYy9XZWJQ ZXJtaXNzaW9uQ2xpZW50Lmg6CisgICAgICAgIChXZWJQZXJtaXNzaW9uQ2xpZW50KToKKyAgICAg ICAgKFdlYktpdDo6V2ViUGVybWlzc2lvbkNsaWVudDo6YWxsb3dXZWJDb21wb25lbnRzKToKKyAg ICAgICAgKiBzcmMvRnJhbWVMb2FkZXJDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6 RnJhbWVMb2FkZXJDbGllbnRJbXBsOjpzaGFkb3dET01BbGxvd2VkKToKKyAgICAgICAgKFdlYktp dCk6CisgICAgICAgICogc3JjL0ZyYW1lTG9hZGVyQ2xpZW50SW1wbC5oOgorICAgICAgICAoRnJh bWVMb2FkZXJDbGllbnRJbXBsKToKKwogMjAxMi0wNS0yMiAgTWFyayBQaWxncmltICA8cGlsZ3Jp bUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBNb3ZlIGNvb2tpZUphciB0byBQ bGF0Zm9ybS5oCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJQ ZXJtaXNzaW9uQ2xpZW50LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJQZXJt aXNzaW9uQ2xpZW50LmgKaW5kZXggYmMyNTE4MjVjYzQyMzRlZjgzNmFhZDcwOWY3NjI4NTZjOTA1 YzVjMC4uMTE2YTM4M2NhOGMyOGI0Nzg5YWU3MzVmZjFlNDRjZDMyN2RkZWM4MyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViUGVybWlzc2lvbkNsaWVudC5oCisr KyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlBlcm1pc3Npb25DbGllbnQuaApA QCAtODksNiArODksOSBAQCBwdWJsaWM6CiAgICAgLy8gQ29udHJvbHMgd2hldGhlciBhY2Nlc3Mg dG8gd3JpdGUgdGhlIGNsaXBib2FyZCBpcyBhbGxvd2VkIGZvciB0aGlzIGZyYW1lLgogICAgIHZp cnR1YWwgYm9vbCBhbGxvd1dyaXRlVG9DbGlwYm9hcmQoV2ViRnJhbWUqLCBib29sIGRlZmF1bHRW YWx1ZSkgeyByZXR1cm4gZGVmYXVsdFZhbHVlOyB9CiAKKyAgICAvLyBDb250cm9scyB3aGV0aGVy IGVuYWJsaW5nIFdlYiBDb21wb25lbnRzIEFQSSBmb3IgdGhpcyBmcmFtZS4KKyAgICB2aXJ0dWFs IGJvb2wgYWxsb3dXZWJDb21wb25lbnRzKFdlYkZyYW1lKiwgYm9vbCBkZWZhdWx0VmFsdWUpIHsg cmV0dXJuIGRlZmF1bHRWYWx1ZTsgfQorCiAgICAgLy8gTm90aWZpZXMgdGhlIGNsaWVudCB0aGF0 IHRoZSBmcmFtZSB3b3VsZCBoYXZlIGluc3RhbnRpYXRlZCBhIHBsdWctaW4gaWYgcGx1Zy1pbnMg d2VyZSBlbmFibGVkLgogICAgIHZpcnR1YWwgdm9pZCBkaWROb3RBbGxvd1BsdWdpbnMoV2ViRnJh bWUqKSB7IH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvRnJhbWVM b2FkZXJDbGllbnRJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0ZyYW1lTG9h ZGVyQ2xpZW50SW1wbC5jcHAKaW5kZXggZDA2MDJhOWEwZTcwNGVjZDkxMmY2ZGNhZmMxY2NjNWY5 YTJhZjlmYi4uYzQyOTc5Y2EzN2I3NGFhZDg5YzdlYTJiMjM0ODcyMTk2OTIyMGZiMiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvRnJhbWVMb2FkZXJDbGllbnRJbXBsLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9GcmFtZUxvYWRlckNsaWVudEltcGwu Y3BwCkBAIC0yMzksNiArMjM5LDE1IEBAIGJvb2wgRnJhbWVMb2FkZXJDbGllbnRJbXBsOjphbGxv d1J1bm5pbmdJbnNlY3VyZUNvbnRlbnQoYm9vbCBlbmFibGVkUGVyU2V0dGluZ3MsCiAgICAgcmV0 dXJuIGVuYWJsZWRQZXJTZXR0aW5nczsKIH0KIAorYm9vbCBGcmFtZUxvYWRlckNsaWVudEltcGw6 OnNoYWRvd0RPTUFsbG93ZWQoYm9vbCBlbmFibGVkQXNSdW50aW1lRmVhdHVyZSkKK3sKKyAgICBX ZWJWaWV3SW1wbCogd2VidmlldyA9IG1fd2ViRnJhbWUtPnZpZXdJbXBsKCk7CisgICAgaWYgKHdl YnZpZXcgJiYgd2Vidmlldy0+cGVybWlzc2lvbkNsaWVudCgpKQorICAgICAgICByZXR1cm4gd2Vi dmlldy0+cGVybWlzc2lvbkNsaWVudCgpLT5hbGxvd1dlYkNvbXBvbmVudHMobV93ZWJGcmFtZSwg ZW5hYmxlZEFzUnVudGltZUZlYXR1cmUpOworCisgICAgcmV0dXJuIGVuYWJsZWRBc1J1bnRpbWVG ZWF0dXJlOworfQorCiB2b2lkIEZyYW1lTG9hZGVyQ2xpZW50SW1wbDo6ZGlkTm90QWxsb3dTY3Jp cHQoKQogewogICAgIFdlYlZpZXdJbXBsKiB3ZWJ2aWV3ID0gbV93ZWJGcmFtZS0+dmlld0ltcGwo KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0ZyYW1lTG9hZGVyQ2xp ZW50SW1wbC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvRnJhbWVMb2FkZXJDbGllbnRJ bXBsLmgKaW5kZXggZWNiMjBhMmZiMjVlZmU2NGFmZTYwZDQyNDZlNmM5OTNhZjVmMzEyOS4uZjc5 OGFjMmVmMDkwZjFlZjE1MTYzZmRmNTY0MjQyNGM0MWZmYmNiMyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvRnJhbWVMb2FkZXJDbGllbnRJbXBsLmgKKysrIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvRnJhbWVMb2FkZXJDbGllbnRJbXBsLmgKQEAgLTE5OSw2ICsx OTksNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBib29sIGFsbG93SW1hZ2UoYm9vbCBlbmFibGVk UGVyU2V0dGluZ3MsIGNvbnN0IFdlYkNvcmU6OktVUkwmIGltYWdlVVJMKTsKICAgICB2aXJ0dWFs IGJvb2wgYWxsb3dEaXNwbGF5aW5nSW5zZWN1cmVDb250ZW50KGJvb2wgZW5hYmxlZFBlclNldHRp bmdzLCBXZWJDb3JlOjpTZWN1cml0eU9yaWdpbiosIGNvbnN0IFdlYkNvcmU6OktVUkwmKTsKICAg ICB2aXJ0dWFsIGJvb2wgYWxsb3dSdW5uaW5nSW5zZWN1cmVDb250ZW50KGJvb2wgZW5hYmxlZFBl clNldHRpbmdzLCBXZWJDb3JlOjpTZWN1cml0eU9yaWdpbiosIGNvbnN0IFdlYkNvcmU6OktVUkwm KTsKKyAgICB2aXJ0dWFsIGJvb2wgc2hhZG93RE9NQWxsb3dlZChib29sIGVuYWJsZWRBc1J1bnRp bWVGZWF0dXJlKSBPVkVSUklERTsKICAgICB2aXJ0dWFsIHZvaWQgZGlkTm90QWxsb3dTY3JpcHQo KTsKICAgICB2aXJ0dWFsIHZvaWQgZGlkTm90QWxsb3dQbHVnaW5zKCk7CiAK