87093 2012-05-22 00:46:04 -0700 [EFL] Style issue due to tests duplicated in Skipped in test_expectations.txt 2012-05-22 04:04:32 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez gyuyoung.kim lucas.de.marchi rakuco tmpsantos webkit.review.bot oldest_to_newest 630051 0 cdumez 2012-05-22 00:46:04 -0700 The style script is complaining about the following tests: LayoutTests/platform/efl/test_expectations.txt:6: fast/dom/shadow/content-element-api.html is also in a Skipped file. [test/expectations] [5] LayoutTests/platform/efl/test_expectations.txt:7: fast/dom/shadow/content-element-outside-shadow.html is also in a Skipped file. [test/expectations] [5] LayoutTests/platform/efl/test_expectations.txt:38: editing/pasteboard/drag-files-to-editable-element.html is also in a Skipped file. [test/expectations] [5] LayoutTests/platform/efl/test_expectations.txt:42: fast/events/drop-handler-should-not-stop-navigate.html is also in a Skipped file. [test/expectations] [5] LayoutTests/platform/efl/test_expectations.txt:43: fast/events/drop-with-file-paths.html is also in a Skipped file. [test/expectations] [5] LayoutTests/platform/efl/test_expectations.txt:44: fast/files/file-reader-directory-crash.html is also in a Skipped file. [test/expectations] [5] LayoutTests/platform/efl/test_expectations.txt:119: fast/events/show-modal-dialog-onblur-onfocus.html is also in a Skipped file. [test/expectations] [5] LayoutTests/platform/efl/test_expectations.txt:120: fast/harness/show-modal-dialog.html is also in a Skipped file. [test/expectations] [5] LayoutTests/platform/efl/test_expectations.txt:286: fast/dom/title-directionality.html is also in a Skipped file. [test/expectations] [5] 630052 1 143216 cdumez 2012-05-22 00:47:45 -0700 Created attachment 143216 Patch Could someone please cq+ ? 630057 2 143216 g.czajkowski 2012-05-22 00:54:40 -0700 Comment on attachment 143216 Patch LGTM. Thanks. 630081 3 143216 webkit.review.bot 2012-05-22 01:35:34 -0700 Comment on attachment 143216 Patch Clearing flags on attachment: 143216 Committed r117932: <http://trac.webkit.org/changeset/117932> 630082 4 webkit.review.bot 2012-05-22 01:35:39 -0700 All reviewed patches have been landed. Closing bug. 630197 5 tmpsantos 2012-05-22 03:55:55 -0700 Two new failures after this patch: fast/events/drop-handler-should-not-stop-navigate.html = TEXT fast/files/file-reader-directory-crash.html = TEXT 630208 6 cdumez 2012-05-22 04:04:32 -0700 Will address the issue in Bug 87115. 143216 2012-05-22 00:47:45 -0700 2012-05-22 01:35:34 -0700 Patch 87093_gardening.patch text/plain 3607 cdumez ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA4YjQxYjJjLi41MDA1NjcxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMDUt MjIgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAg ICAgICBbRUZMXSBTdHlsZSBpc3N1ZSBkdWUgdG8gdGVzdHMgZHVwbGljYXRlZCBpbiBTa2lwcGVk IGluIHRlc3RfZXhwZWN0YXRpb25zLnR4dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODcwOTMKKworICAgICAgICBVbnJldmlld2VkIEVGTCBnYXJkZW5p bmcuIFJlbW92ZSBmcm9tIFNraXBwZWQgZmlsZSB0ZXN0cyB0aGF0IGFyZQorICAgICAgICBhbHJl YWR5IGluIHRlc3RfZXhwZWN0YXRpb25zLnR4dCB0byBtYWtlIHRoZSBzdHlsZSBzY3JpcHQgaGFw cHkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvU2tpcHBlZDoKKwogMjAxMi0wNS0yMiAgRW1p bCBBIEVrbHVuZCAgPGVhZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCByZWJh c2VsaW5lIG9mIGZhc3QvbG9hZGVyL3JlY3Vyc2l2ZS1iZWZvcmUtdW5sb2FkLWNyYXNoLmh0bWwK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVkIGIvTGF5b3V0VGVz dHMvcGxhdGZvcm0vZWZsL1NraXBwZWQKaW5kZXggYzQxMDk5OC4uMGMwYzQ3YyAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vZWZsL1NraXBwZWQKQEAgLTI1LDggKzI1LDYgQEAgZmFzdC9kb20vV2luZG93L3dpbmRv dy1wb3N0bWVzc2FnZS1jbG9uZS5odG1sCiBmYXN0L2V2ZW50cy9kcmFnLWRhdGFUcmFuc2Zlckl0 ZW1MaXN0LWZpbGUtaGFuZGxpbmcuaHRtbAogZmFzdC9ldmVudHMvZHJhZy1maWxlLWNyYXNoLmh0 bWwKIGZhc3QvZXZlbnRzL2RyYWctdG8tbmF2aWdhdGUuaHRtbAotZmFzdC9ldmVudHMvZHJvcC1o YW5kbGVyLXNob3VsZC1ub3Qtc3RvcC1uYXZpZ2F0ZS5odG1sCi1mYXN0L2V2ZW50cy9kcm9wLXdp dGgtZmlsZS1wYXRocy5odG1sCiBmYXN0L2V2ZW50cy9kcm9wem9uZS0wMDQuaHRtbAogZmFzdC9l dmVudHMvZmlsZS1pbnB1dC1oaWRkZW4taW4tb25kcm9wLmh0bWwKIGZhc3QvZXZlbnRzL2lucHV0 LWVsZW1lbnQtZGlzcGxheS1ub25lLWluLWRyYWdsZWF2ZS1jcmFzaC5odG1sCkBAIC0zNCw3ICsz Miw2IEBAIGZhc3QvZXZlbnRzL3ByZXZlbnQtZHJhZy10by1uYXZpZ2F0ZS5odG1sCiBmYXN0L2Zp bGVzL2FwcGx5LWJsb2ItdXJsLXRvLWltZy5odG1sCiBmYXN0L2ZpbGVzL2FwcGx5LWJsb2ItdXJs LXRvLXhoci5odG1sCiBmYXN0L2ZpbGVzL2ZpbGUtcmVhZGVyLWFib3J0Lmh0bWwKLWZhc3QvZmls ZXMvZmlsZS1yZWFkZXItZGlyZWN0b3J5LWNyYXNoLmh0bWwKIGZhc3QvZmlsZXMvZmlsZS1yZWFk ZXItZXZlbnQtbGlzdGVuZXIuaHRtbAogZmFzdC9maWxlcy9udWxsLW9yaWdpbi1zdHJpbmcuaHRt bAogZmFzdC9maWxlcy9yZWFkLWJsb2ItYXN5bmMuaHRtbApAQCAtMTgyLDcgKzE3OSw2IEBAIGVk aXRpbmcvc2VsZWN0aW9uL2NhcmV0LWFuZC1mb2N1cy1yaW5nLmh0bWwKIGVkaXRpbmcvc2VsZWN0 aW9uL3NlbGVjdGlvbi1iYWNrZ3JvdW5kLmh0bWwKIGZhc3QvZG9tL1dpbmRvdy93aW5kb3ctb25G b2N1cy5odG1sCiBmYXN0L2V2ZW50cy9ibHVyLWZvY3VzLXdpbmRvdy1zaG91bGQtYmx1ci1mb2N1 cy1lbGVtZW50Lmh0bWwKLWZhc3QvZXZlbnRzL3Nob3ctbW9kYWwtZGlhbG9nLW9uYmx1ci1vbmZv Y3VzLmh0bWwKIHBsdWdpbnMvbmV0c2NhcGUtcGx1Z2luLXNldHdpbmRvdy1zaXplLTIuaHRtbAog CiAjIEVGTCdzIExheW91dFRlc3RDb250cm9sbGVyIGRvZXMgbm90IGltcGxlbWVudCBzZXRBbGxv d1VuaXZlcnNhbEFjY2Vzc0Zyb21GaWxlVVJMcwpAQCAtMjQyLDcgKzIzOCw2IEBAIGh0dHAvdGVz dHMveG1saHR0cHJlcXVlc3QvY3Jvc3Mtb3JpZ2luLWF1dGhvcml6YXRpb24td2l0aC1lbWJlZGRl ci5odG1sCiAKICMgRUZMJ3MgTGF5b3V0VGVzdENvbnRyb2xsZXIgZG9lcyBub3QgaW1wbGVtZW50 IGFib3J0TW9kYWwKIGZhc3QvZXZlbnRzL3Nob3ctbW9kYWwtZGlhbG9nLW9uYmx1ci1vbmZvY3Vz Lmh0bWwKLWZhc3QvaGFybmVzcy9zaG93LW1vZGFsLWRpYWxvZy5odG1sCiAKICMgdmlld3BvcnQg bWV0YSB0YWcgdGVzdHMgdGhhdCBmYWlsIG9uIHRoZSBib3QgZm9yIHlldCB1bmtub3duIHJlYXNv bnMKIGZhc3Qvdmlld3BvcnQvdmlld3BvcnQtMTI1Lmh0bWwKQEAgLTM5Nyw5ICszOTIsNiBAQCBm YXN0L2ltYWdlcy9wZGYtYXMtaW1hZ2UuaHRtbAogZmFzdC9pbWFnZXMvcGRmLWFzLXRpbGVkLWJh Y2tncm91bmQuaHRtbAogZmFzdC9yZXBsYWNlZC9wZGYtYXMtaW1hZ2UuaHRtbAogCi0jIFRoZSBF RkwgcG9ydCBoYXMgbm8gc3VwcG9ydCBmb3IgdGl0bGUgZGlyZWN0aW9uYWxpdHkKLWZhc3QvZG9t L3RpdGxlLWRpcmVjdGlvbmFsaXR5Lmh0bWwKLQogIyBUaGUgRUZMIHBvcnQgaGFzIG5vIHN1cHBv cnQgZm9yIGRldGVjdGluZyBzbG93IHVubG9hZCBoYW5kbGVycwogZmFzdC9kb20vV2luZG93L3Ns b3ctdW5sb2FkLWhhbmRsZXIuaHRtbAogZmFzdC9kb20vV2luZG93L3Nsb3ctdW5sb2FkLWhhbmRs ZXItb25seS1mcmFtZS1pcy1zdG9wcGVkLmh0bWwKQEAgLTQwNyw5ICszOTksNiBAQCBmYXN0L2Rv bS9XaW5kb3cvc2xvdy11bmxvYWQtaGFuZGxlci1vbmx5LWZyYW1lLWlzLXN0b3BwZWQuaHRtbAog IyBUaGUgRUZMIHBvcnQgaGFzIG5vIGdsb2JhbCBoaXN0b3J5IGRlbGVnYXRlCiBodHRwL3Rlc3Rz L2dsb2JhbGhpc3RvcnkKIAotIyBQYXN0ZUJvYXJkOjpwbGFpblRleHQoKSBkb2VzIG5vdCBzdXBw b3J0IGZpbGUgbmFtZXMuCi1lZGl0aW5nL3Bhc3RlYm9hcmQvZHJhZy1maWxlcy10by1lZGl0YWJs ZS1lbGVtZW50Lmh0bWwKLQogIyBGYWlscyBiZWNhdXNlIG9mIHRoZSBzZWN1cml0eSBwb2xpY3kg b2YgdGhlIHVzZXIgYWdlbnQ/CiAjIGh0dHA6Ly93ZWJraXQub3JnL2IvNzk2MDQKIGZhc3QvbXV0 YXRpb24vZGF0YWJhc2UtY2FsbGJhY2stZGVsaXZlcnkuaHRtbApAQCAtOTczLDggKzk2Miw2IEBA IGh0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2hpeGllNzYvd29ya2Vycy9jbG9zZS1pbi1vbm1l c3NhZ2UtY3Jhc2guaHRtbAogIyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0K IAogIyBFTkFCTEUoU0hBRE9XX0RPTSkgaXMgZGlzYWJsZWQuCi1mYXN0L2RvbS9zaGFkb3cvY29u dGVudC1lbGVtZW50LWFwaS5odG1sCi1mYXN0L2RvbS9zaGFkb3cvY29udGVudC1lbGVtZW50LW91 dHNpZGUtc2hhZG93Lmh0bWwKIGZhc3QvZG9tL3NoYWRvdy9jb250ZW50LWVsZW1lbnQtb3V0c2lk ZS1zaGFkb3ctc3R5bGUuaHRtbAogZmFzdC9kb20vc2hhZG93L2NvbnRlbnQtZWxlbWVudC1pbi1t ZWRpYS1lbGVtZW50Lmh0bWwKIGZhc3QvZG9tL3NoYWRvdy9jb250ZW50LWVsZW1lbnQtaW4tbWV0 ZXItZWxlbWVudC5odG1sCg==