87092 2012-05-22 00:34:55 -0700 [EFL] webintents/web-intents-delivery-reuse.html is failing on EFL port 2012-05-23 13:58:09 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 86868 1 cdumez cdumez abarth gbillock gyuyoung.kim lucas.de.marchi ojan rakuco webkit.review.bot oldest_to_newest 630041 0 cdumez 2012-05-22 00:34:55 -0700 webkitIntent cannot be assigned for some reason and is always null after assignment. 631553 1 cdumez 2012-05-23 05:47:41 -0700 gbillock: In DOMWindowIntents.idl, should the webkitIntent attribute be really marked as readonly? Because of this, the JSC bindings generator does not generate a setter and does not do any shadowing. As a consequence, the webintents/web-intents-delivery-reuse.html test is failing for us. If I remove the "readonly" for the attribute, then the test is passing just fine. Is it really something that should be fixed in the JSC bindings generator? 631573 2 143551 cdumez 2012-05-23 06:05:03 -0700 Created attachment 143551 Patch Here is a patch which removes the "readonly" keyword from the webkitIntent attribute so that it becomes truly replaceable with JSC. The patch also unskips the corresponding test case for EFL port. Note that in the whole source tree, there is no other IDL attribute which is both readonly and [Replaceable]. 631670 3 gbillock 2012-05-23 08:06:01 -0700 (In reply to comment #1) > gbillock: In DOMWindowIntents.idl, should the webkitIntent attribute be really marked as readonly? Because of this, the JSC bindings generator does not generate a setter and does not do any shadowing. > > As a consequence, the webintents/web-intents-delivery-reuse.html test is failing for us. If I remove the "readonly" for the attribute, then the test is passing just fine. Is it really something that should be fixed in the JSC bindings generator? Seems fine to me, but Adam is a better person to ask. I put readonly because when the internal object is returned, JS shouldn't be altering it -- since it is replaceable, they can just write their own. It sounds like JSC uses another mechanism to accomplish that, though. 631964 4 143551 abarth 2012-05-23 13:20:35 -0700 Comment on attachment 143551 Patch Ok. 632021 5 143551 webkit.review.bot 2012-05-23 13:58:04 -0700 Comment on attachment 143551 Patch Clearing flags on attachment: 143551 Committed r118241: <http://trac.webkit.org/changeset/118241> 632022 6 webkit.review.bot 2012-05-23 13:58:09 -0700 All reviewed patches have been landed. Closing bug. 143551 2012-05-23 06:05:03 -0700 2012-05-23 13:58:04 -0700 Patch 87092_webkitIntent_replaceable.patch text/plain 2842 cdumez ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhMWU3NjQ5Li44ZjUwMTQ2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDUt MjMgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAg ICAgICBbRUZMXSB3ZWJpbnRlbnRzL3dlYi1pbnRlbnRzLWRlbGl2ZXJ5LXJldXNlLmh0bWwgaXMg ZmFpbGluZyBvbiBFRkwgcG9ydAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODcwOTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBSZW1vdmUgd2ViaW50ZW50cy93ZWItaW50ZW50cy1kZWxpdmVyeS1yZXVzZS5o dG1sIGZyb20gdGVzdAorICAgICAgICBleHBlY3RhdGlvbnMgbm93IHRoYXQgd2luZG93LndlYmtp dEludGVudCBpcyByZWFsbHkgcmVwbGFjZWFibGUgYW5kCisgICAgICAgIG5vdyB0aGF0IHRoZSB0 ZXN0IGlzIHBhc3NpbmcuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvdGVzdF9leHBlY3RhdGlv bnMudHh0OgorCiAyMDEyLTA1LTIzICBLcnp5c3p0b2YgQ3plY2ggIDxrLmN6ZWNoQHNhbXN1bmcu Y29tPgogCiAgICAgICAgIFtFRkxdIEdhcmRlbmluZyBlZGl0aW5nL3N0eWxlIHRlc3RzLCBtaXNz aW5nIGJhc2VsaW5lcy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC90ZXN0 X2V4cGVjdGF0aW9ucy50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvdGVzdF9leHBlY3Rh dGlvbnMudHh0CmluZGV4IGUzNjA5NDYuLjE4MmY3N2IgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L3BsYXRmb3JtL2VmbC90ZXN0X2V4cGVjdGF0aW9ucy50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vZWZsL3Rlc3RfZXhwZWN0YXRpb25zLnR4dApAQCAtNjEzLDcgKzYxMyw2IEBAIEJVR1dL ODQxNjcgOiB0YWJsZXMvbW96aWxsYS9idWdzL2J1ZzI0NzktMi5odG1sID0gSU1BR0UrVEVYVAog Ly8gSW5jb21wbGV0ZSBXZWIgSW50ZW50cyBzdXBwb3J0CiBCVUdXSzg2ODY2IFNLSVAgOiB3ZWJp bnRlbnRzL2ludGVudC10YWcuaHRtbCA9IFRFWFQKIEJVR1dLODY4NjUgU0tJUCA6IHdlYmludGVu dHMvd2ViLWludGVudHMtZGVsaXZlcnkuaHRtbCA9IFRFWFQKLUJVR1dLODcwOTIgU0tJUCA6IHdl YmludGVudHMvd2ViLWludGVudHMtZGVsaXZlcnktcmV1c2UuaHRtbCA9IFRFWFQKIEJVR1dLODY4 NjcgU0tJUCA6IHdlYmludGVudHMvd2ViLWludGVudHMtZmFpbHVyZS5odG1sID0gVEVYVAogQlVH V0s4Njg0MSBTS0lQIDogd2ViaW50ZW50cy93ZWItaW50ZW50cy1pbnZva2UtcG9ydC5odG1sID0g VEVYVAogQlVHV0s4Njg3MyBTS0lQIDogd2ViaW50ZW50cy93ZWItaW50ZW50cy1vYmotY29uc3Ry dWN0b3IuaHRtbCA9IFRFWFQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBi L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3ZjM4MTJlLi5hMmFlMzFjIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDUtMjMgIENocmlzdG9waGUgRHVtZXogIDxjaHJp c3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXSB3ZWJpbnRlbnRzL3dlYi1p bnRlbnRzLWRlbGl2ZXJ5LXJldXNlLmh0bWwgaXMgZmFpbGluZyBvbiBFRkwgcG9ydAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODcwOTIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgcmVhZG9ubHkg a2V5d29yZCBmcm9tIHRoZSB3ZWJraXRJbnRlbnQgYXR0cmlidXRlLiBUaGlzIGlzCisgICAgICAg IG5lZWRlZCBvdGhlcndpc2UgdGhlIFtSZXBsYWNlYWJsZV0gZXh0ZW5kZWQgYXR0cmlidXRlIGhh cyBub3QgZWZmZWN0CisgICAgICAgIHdpdGggSlNDLiBUaGlzIGlzIHRlc3RlZCBieSB3ZWJpbnRl bnRzL3dlYi1pbnRlbnRzLWRlbGl2ZXJ5LXJldXNlLmh0bWwKKyAgICAgICAgdGVzdCBjYXNlLgor CisgICAgICAgICogTW9kdWxlcy9pbnRlbnRzL0RPTVdpbmRvd0ludGVudHMuaWRsOgorCiAyMDEy LTA1LTIzICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5Abm9raWEuY29tPgog CiAgICAgICAgIFtRdF0gRmxvYXRTaXplIFF0IFN1cHBvcnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvaW50ZW50cy9ET01XaW5kb3dJbnRlbnRzLmlkbCBiL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvaW50ZW50cy9ET01XaW5kb3dJbnRlbnRzLmlkbAppbmRleCA0NTFhYWRmLi5k MzQ1MjA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2ludGVudHMvRE9NV2lu ZG93SW50ZW50cy5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbnRlbnRzL0RPTVdp bmRvd0ludGVudHMuaWRsCkBAIC0zMiw3ICszMiw3IEBAIG1vZHVsZSB3aW5kb3cgewogICAgIF0g RE9NV2luZG93SW50ZW50cyB7CiAgICAgICAgIGF0dHJpYnV0ZSBJbnRlbnRDb25zdHJ1Y3RvciBX ZWJLaXRJbnRlbnQ7CiAKLSAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIFtSZXBsYWNlYWJsZV0g RGVsaXZlcmVkSW50ZW50IHdlYmtpdEludGVudDsKKyAgICAgICAgYXR0cmlidXRlIFtSZXBsYWNl YWJsZV0gRGVsaXZlcmVkSW50ZW50IHdlYmtpdEludGVudDsKICAgICB9OwogCiB9Cg==