87087 2012-05-21 23:33:43 -0700 [chromium] WebViewHost should use ENABLE guards for some features. 2012-05-22 00:13:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66687 1 zhenghao zhenghao abarth tkent webkit.review.bot oldest_to_newest 629980 0 zhenghao 2012-05-21 23:33:43 -0700 [chromium] WebViewHost should use ENABLE guards for some features. 629981 1 143200 zhenghao 2012-05-21 23:35:40 -0700 Created attachment 143200 Patch 629985 2 143200 tkent 2012-05-21 23:39:38 -0700 Comment on attachment 143200 Patch Looks ok. 630000 3 abarth 2012-05-21 23:54:30 -0700 Thanks for the patch. 630023 4 143200 webkit.review.bot 2012-05-22 00:13:08 -0700 Comment on attachment 143200 Patch Clearing flags on attachment: 143200 Committed r117920: <http://trac.webkit.org/changeset/117920> 630024 5 webkit.review.bot 2012-05-22 00:13:20 -0700 All reviewed patches have been landed. Closing bug. 143200 2012-05-21 23:35:40 -0700 2012-05-22 00:13:08 -0700 Patch bug-87087-20120522143537.patch text/plain 4258 zhenghao U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3NzU0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDIwZTY2M2Y4YTg4NDM1NmNmYTZiNjQ4MGFmODQxNTBl MWZjZThkMi4uNTNjMmM2NDU3MjEyNDQ3YTAyYzFhYzdiOTA1Zjc1ZDYzYTY2NjU0OSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEyLTA1LTIxICBIYW8gWmhlbmcgIDx6aGVuZ2hhb0BjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgW2Nocm9taXVtXSBXZWJWaWV3SG9zdCBzaG91bGQgdXNlIEVOQUJMRSBndWFyZHMgZm9y IHNvbWUgZmVhdHVyZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD04NzA4NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoZXNlIGZlYXR1cmVzIGFyZSBkaXNhYmxlZCBvbiBPUyhBTkRST0lEKSBhbmQgc28g c2hvdWxkbid0IGJlCisgICAgICAgIGNvbXBpbGVkIHdoZW4gdGhlIGZlYXR1cmUgaXMgb2ZmLgor CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3QuY3BwOgorICAg ICAgICAoV2ViVmlld0hvc3Q6OnJlc2V0KToKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJv bWl1bS9XZWJWaWV3SG9zdC5oOgorICAgICAgICAoV2ViVmlld0hvc3QpOgorCiAyMDEyLTA1LTIx ICBNaWtoYWlsIFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgogCiAg ICAgICAgIFtFRkxdIFBsYXRmb3JtS2V5Ym9hcmRFdmVudEVmbCBpcyBtaXNzaW5nIEVTQyBrZXkg aGFuZGxpbmcuCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJW aWV3SG9zdC5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5j cHAKaW5kZXggMzY2NTQ2MDE1OWU3MzkzYmJmMzM3YWFhZmM0ZDljYzkyMTc2ZTQ4YS4uNTI2NDU5 Y2ZmZTI5ODk4OTBkM2RmMTE4N2IzMmU1NTUyZGMzMTQ2NSAxMDA2NDQKLS0tIGEvVG9vbHMvRHVt cFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3QuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5k ZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0LmNwcApAQCAtNjc2LDEwICs2NzYsMTIgQEAgdm9p ZCBXZWJWaWV3SG9zdDo6cG9zdEFjY2Vzc2liaWxpdHlOb3RpZmljYXRpb24oY29uc3QgV2ViQWNj ZXNzaWJpbGl0eU9iamVjdCYgb2IKICAgICB9CiB9CiAKKyNpZiBFTkFCTEUoTk9USUZJQ0FUSU9O UykKIFdlYk5vdGlmaWNhdGlvblByZXNlbnRlciogV2ViVmlld0hvc3Q6Om5vdGlmaWNhdGlvblBy ZXNlbnRlcigpCiB7CiAgICAgcmV0dXJuIG1fc2hlbGwtPm5vdGlmaWNhdGlvblByZXNlbnRlcigp OwogfQorI2VuZGlmCiAKIFdlYktpdDo6V2ViR2VvbG9jYXRpb25DbGllbnQqIFdlYlZpZXdIb3N0 OjpnZW9sb2NhdGlvbkNsaWVudCgpCiB7CkBAIC02OTMsMTIgKzY5NSwxNCBAQCBXZWJLaXQ6Oldl Ykdlb2xvY2F0aW9uQ2xpZW50TW9jayogV2ViVmlld0hvc3Q6Omdlb2xvY2F0aW9uQ2xpZW50TW9j aygpCiAgICAgcmV0dXJuIG1fZ2VvbG9jYXRpb25DbGllbnRNb2NrLmdldCgpOwogfQogCisjaWYg RU5BQkxFKElOUFVUX1NQRUVDSCkKIFdlYlNwZWVjaElucHV0Q29udHJvbGxlciogV2ViVmlld0hv c3Q6OnNwZWVjaElucHV0Q29udHJvbGxlcihXZWJLaXQ6OldlYlNwZWVjaElucHV0TGlzdGVuZXIq IGxpc3RlbmVyKQogewogICAgIGlmICghbV9zcGVlY2hJbnB1dENvbnRyb2xsZXJNb2NrKQogICAg ICAgICBtX3NwZWVjaElucHV0Q29udHJvbGxlck1vY2sgPSBNb2NrV2ViU3BlZWNoSW5wdXRDb250 cm9sbGVyOjpjcmVhdGUobGlzdGVuZXIpOwogICAgIHJldHVybiBtX3NwZWVjaElucHV0Q29udHJv bGxlck1vY2suZ2V0KCk7CiB9CisjZW5kaWYKIAogV2ViRGV2aWNlT3JpZW50YXRpb25DbGllbnRN b2NrKiBXZWJWaWV3SG9zdDo6ZGV2aWNlT3JpZW50YXRpb25DbGllbnRNb2NrKCkKIHsKQEAgLTE0 NTEsOCArMTQ1NSwxMCBAQCB2b2lkIFdlYlZpZXdIb3N0OjpyZXNldCgpCiAgICAgaWYgKG1fZ2Vv bG9jYXRpb25DbGllbnRNb2NrLmdldCgpKQogICAgICAgICBtX2dlb2xvY2F0aW9uQ2xpZW50TW9j ay0+cmVzZXRNb2NrKCk7CiAKKyNpZiBFTkFCTEUoSU5QVVRfU1BFRUNIKQogICAgIGlmIChtX3Nw ZWVjaElucHV0Q29udHJvbGxlck1vY2suZ2V0KCkpCiAgICAgICAgIG1fc3BlZWNoSW5wdXRDb250 cm9sbGVyTW9jay0+Y2xlYXJSZXN1bHRzKCk7CisjZW5kaWYKIAogICAgIG1fY3VycmVudEN1cnNv ciA9IFdlYkN1cnNvckluZm8oKTsKICAgICBtX3dpbmRvd1JlY3QgPSBXZWJSZWN0KCk7CmRpZmYg LS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5oIGIvVG9v bHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3QuaAppbmRleCBhODMwZjU5M2M2 ZDlmZTJkZTVjYmY1MzE0YmQ4MDZjNjQyOGFlYWZlLi5jNWY5MzAxMjdjMmE5NzQ2MDk4Y2JkNGNm NzkxMzMyNzA5YzU5OGZlIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1 bS9XZWJWaWV3SG9zdC5oCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZp ZXdIb3N0LmgKQEAgLTExMSw3ICsxMTEsOSBAQCBjbGFzcyBXZWJWaWV3SG9zdCA6IHB1YmxpYyBX ZWJLaXQ6OldlYlNwZWxsQ2hlY2tDbGllbnQsIHB1YmxpYyBXZWJLaXQ6OldlYlZpZXdDbAogICAg IFdlYktpdDo6V2ViQ29udGV4dE1lbnVEYXRhKiBsYXN0Q29udGV4dE1lbnVEYXRhKCkgY29uc3Q7 CiAgICAgdm9pZCBjbGVhckNvbnRleHRNZW51RGF0YSgpOwogCisjaWYgRU5BQkxFKElOUFVUX1NQ RUVDSCkKICAgICBNb2NrV2ViU3BlZWNoSW5wdXRDb250cm9sbGVyKiBzcGVlY2hJbnB1dENvbnRy b2xsZXJNb2NrKCkgeyByZXR1cm4gbV9zcGVlY2hJbnB1dENvbnRyb2xsZXJNb2NrLmdldCgpOyB9 CisjZW5kaWYKIAogI2lmIEVOQUJMRShQT0lOVEVSX0xPQ0spCiAgICAgdm9pZCBkaWRMb3NlUG9p bnRlckxvY2soKTsKQEAgLTE2Miw5ICsxNjQsMTMgQEAgY2xhc3MgV2ViVmlld0hvc3QgOiBwdWJs aWMgV2ViS2l0OjpXZWJTcGVsbENoZWNrQ2xpZW50LCBwdWJsaWMgV2ViS2l0OjpXZWJWaWV3Q2wK ICAgICB2aXJ0dWFsIGludCBoaXN0b3J5QmFja0xpc3RDb3VudCgpOwogICAgIHZpcnR1YWwgaW50 IGhpc3RvcnlGb3J3YXJkTGlzdENvdW50KCk7CiAgICAgdmlydHVhbCB2b2lkIHBvc3RBY2Nlc3Np YmlsaXR5Tm90aWZpY2F0aW9uKGNvbnN0IFdlYktpdDo6V2ViQWNjZXNzaWJpbGl0eU9iamVjdCYs IFdlYktpdDo6V2ViQWNjZXNzaWJpbGl0eU5vdGlmaWNhdGlvbik7CisjaWYgRU5BQkxFKE5PVElG SUNBVElPTlMpCiAgICAgdmlydHVhbCBXZWJLaXQ6OldlYk5vdGlmaWNhdGlvblByZXNlbnRlciog bm90aWZpY2F0aW9uUHJlc2VudGVyKCk7CisjZW5kaWYKICAgICB2aXJ0dWFsIFdlYktpdDo6V2Vi R2VvbG9jYXRpb25DbGllbnQqIGdlb2xvY2F0aW9uQ2xpZW50KCk7CisjaWYgRU5BQkxFKElOUFVU X1NQRUVDSCkKICAgICB2aXJ0dWFsIFdlYktpdDo6V2ViU3BlZWNoSW5wdXRDb250cm9sbGVyKiBz cGVlY2hJbnB1dENvbnRyb2xsZXIoV2ViS2l0OjpXZWJTcGVlY2hJbnB1dExpc3RlbmVyKik7Cisj ZW5kaWYKICAgICB2aXJ0dWFsIFdlYktpdDo6V2ViRGV2aWNlT3JpZW50YXRpb25DbGllbnQqIGRl dmljZU9yaWVudGF0aW9uQ2xpZW50KCk7CiAjaWYgRU5BQkxFKE1FRElBX1NUUkVBTSkKICAgICB2 aXJ0dWFsIFdlYktpdDo6V2ViVXNlck1lZGlhQ2xpZW50KiB1c2VyTWVkaWFDbGllbnQoKTsKQEAg LTM5Nyw3ICs0MDMsOSBAQCBwcml2YXRlOgogICAgIE93blB0cjxXZWJLaXQ6OldlYkdlb2xvY2F0 aW9uQ2xpZW50TW9jaz4gbV9nZW9sb2NhdGlvbkNsaWVudE1vY2s7CiAKICAgICBPd25QdHI8V2Vi S2l0OjpXZWJEZXZpY2VPcmllbnRhdGlvbkNsaWVudE1vY2s+IG1fZGV2aWNlT3JpZW50YXRpb25D bGllbnRNb2NrOworI2lmIEVOQUJMRShJTlBVVF9TUEVFQ0gpCiAgICAgT3duUHRyPE1vY2tXZWJT cGVlY2hJbnB1dENvbnRyb2xsZXI+IG1fc3BlZWNoSW5wdXRDb250cm9sbGVyTW9jazsKKyNlbmRp ZgogCiAjaWYgRU5BQkxFKE1FRElBX1NUUkVBTSkKICAgICBPd25QdHI8V2ViS2l0OjpXZWJVc2Vy TWVkaWFDbGllbnRNb2NrPiBtX3VzZXJNZWRpYUNsaWVudE1vY2s7Cg==