87076 2012-05-21 19:58:34 -0700 DOM Attr objects pointing to "style" attribute should force reification when read. 2012-05-22 05:05:52 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling koivisto oldest_to_newest 629882 0 kling 2012-05-21 19:58:34 -0700 DOM Attr needs to respect the lazy serialization strategy of the style attribute. 630037 1 143212 kling 2012-05-22 00:30:23 -0700 Created attachment 143212 Patch 630064 2 143212 koivisto 2012-05-22 01:14:19 -0700 Comment on attachment 143212 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143212&action=review r=me > Source/WebCore/dom/Attr.cpp:206 > if (m_element) > - return m_element->getAttributeItem(qualifiedName())->value(); > + return m_element->getAttribute(qualifiedName()); Could use a comment. 630262 3 143212 kling 2012-05-22 05:05:44 -0700 Comment on attachment 143212 Patch Clearing flags on attachment: 143212 Committed r117956: <http://trac.webkit.org/changeset/117956> 630263 4 kling 2012-05-22 05:05:52 -0700 All reviewed patches have been landed. Closing bug. 143212 2012-05-22 00:30:23 -0700 2012-05-22 05:05:44 -0700 Patch bug-87076.diff text/plain 3722 kling ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0MzI4ZDI3Li5jYjliNjgxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMDUt MjIgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAgICAgIERPTSBBdHRy IG9iamVjdHMgcG9pbnRpbmcgdG8gInN0eWxlIiBhdHRyaWJ1dGUgc2hvdWxkIGZvcmNlIHJlaWZp Y2F0aW9uIHdoZW4gcmVhZC4KKyAgICAgICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvODcwNzY+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2Rv bS9hdHRyLXN0eWxlLXRvby1sYXp5LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFz dC9kb20vYXR0ci1zdHlsZS10b28tbGF6eS5odG1sOiBBZGRlZC4KKwogMjAxMi0wNS0yMSAgRW1p bCBBIEVrbHVuZCAgPGVhZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBjaHJv bWl1bSByZWJhc2VsaW5lIGZvciBjb21wb3NpdGluZywgem9vbSBhbmQgYm9yZGVyIGNoYW5nZXMu CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9hdHRyLXN0eWxlLXRvby1sYXp5LWV4 cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL2F0dHItc3R5bGUtdG9vLWxhenktZXhw ZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmJhNTNjMmYKLS0t IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9hdHRyLXN0eWxlLXRvby1sYXp5 LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDExIEBACitUaGlzIHRlc3QgdmVyaWZpZXMgdGhhdCBh Y3F1aXJpbmcgdGhlICdzdHlsZScgYXR0cmlidXRlIHZpYSBhIERPTSBBdHRyIG5vZGUgc3RpbGwg d29ya3MgY29ycmVjdGx5IGFmdGVyIHRoZSBpbmxpbmUgc3R5bGUgaGFzIGJlZW4gbW9kaWZpZWQg dGhyb3VnaCB0aGUgQ1NTT00gQVBJLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJp ZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKwor UEFTUyBzdHlsZUF0dHIudmFsdWUgaXMgJ2JhY2tncm91bmQtY29sb3I6IHdoaXRlOyAnCitQQVNT IHN0eWxlQXR0ci52YWx1ZSBpcyAnYmFja2dyb3VuZC1jb2xvcjogZ3JlZW47ICcKK1BBU1Mgc3Vj Y2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9mYXN0L2RvbS9hdHRyLXN0eWxlLXRvby1sYXp5Lmh0bWwgYi9MYXlvdXRUZXN0 cy9mYXN0L2RvbS9hdHRyLXN0eWxlLXRvby1sYXp5Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMDAwMDAwMC4uNmQyMzMxMAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zh c3QvZG9tL2F0dHItc3R5bGUtdG9vLWxhenkuaHRtbApAQCAtMCwwICsxLDIyIEBACis8IURPQ1RZ UEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8bWV0YSBjaGFyc2V0PSJ1dGYtOCI+Cis8c2NyaXB0 IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4K Kzxib2R5PgorPHNjcmlwdD4KKworZGVzY3JpcHRpb24oIlRoaXMgdGVzdCB2ZXJpZmllcyB0aGF0 IGFjcXVpcmluZyB0aGUgJ3N0eWxlJyBhdHRyaWJ1dGUgdmlhIGEgRE9NIEF0dHIgbm9kZSBzdGls bCB3b3JrcyBjb3JyZWN0bHkgYWZ0ZXIgdGhlIGlubGluZSBzdHlsZSBoYXMgYmVlbiBtb2RpZmll ZCB0aHJvdWdoIHRoZSBDU1NPTSBBUEkuIik7CisKK3ZhciBlID0gZG9jdW1lbnQuY3JlYXRlRWxl bWVudCgic3BhbiIpOworZS5zZXRBdHRyaWJ1dGUoInN0eWxlIiwgImJhY2tncm91bmQtY29sb3I6 IHdoaXRlOyAiKTsKK3ZhciBzdHlsZUF0dHIgPSBlLmdldEF0dHJpYnV0ZU5vZGUoInN0eWxlIik7 CitzaG91bGRCZSgic3R5bGVBdHRyLnZhbHVlIiwgIidiYWNrZ3JvdW5kLWNvbG9yOiB3aGl0ZTsg JyIpOworZS5zdHlsZS5iYWNrZ3JvdW5kQ29sb3IgPSAnZ3JlZW4nOworc2hvdWxkQmUoInN0eWxl QXR0ci52YWx1ZSIsICInYmFja2dyb3VuZC1jb2xvcjogZ3JlZW47ICciKTsKKworPC9zY3JpcHQ+ Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+ Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cg Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmM1NzM1Zi4uOWE3MTE2ZiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA1LTIyICBBbmRyZWFzIEtsaW5nICA8a2xpbmdA d2Via2l0Lm9yZz4KKworICAgICAgICBET00gQXR0ciBvYmplY3RzIHBvaW50aW5nIHRvICJzdHls ZSIgYXR0cmlidXRlIHNob3VsZCBmb3JjZSByZWlmaWNhdGlvbiB3aGVuIHJlYWQuCisgICAgICAg IDxodHRwOi8vd2Via2l0Lm9yZy9iLzg3MDc2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE1ha2Ugc3VyZSB0aGF0IHRoZSAic3R5bGUiIGF0dHJpYnV0 ZSBpcyByZXNlcmlhbGl6ZWQgYXMgbmVlZGVkIHdoZW4gaXQgZ2V0cyByZXRyaWV2ZWQKKyAgICAg ICAgdGhyb3VnaCBhbiBBdHRyIG9iamVjdC4gVGhpcyBmaXhlcyBhIGJ1ZyB3aGVyZSB1cGRhdGlu ZyBhbiBlbGVtZW50J3MgaW5saW5lIHN0eWxlCisgICAgICAgIHRocm91Z2ggdGhlIENTU09NIEFQ SSwgYW5kIHRoZW4gcmV0cmlldmluZyB0aGUgc3R5bGUgYXR0cmlidXRlIHRocm91Z2ggYW4gQXR0 ciBub2RlCisgICAgICAgIHRoYXQgd2FzIHByZXZpb3VzbHkgY3JlYXRlZCBieSBlbGVtZW50Lmdl dEF0dHJpYnV0ZU5vZGUoKSB3b3VsZCByZXR1cm4gdGhlIG9sZCBzdHlsZQorICAgICAgICBhdHRy aWJ1dGUgdmFsdWUuCisKKyAgICAgICAgVGVzdDogZmFzdC9kb20vYXR0ci1zdHlsZS10b28tbGF6 eS5odG1sCisKKyAgICAgICAgKiBkb20vQXR0ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBdHRy Ojp2YWx1ZSk6CisKIDIwMTItMDUtMjEgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3Jn PgogCiAgICAgICAgIFVzZSBzdGFjay1hbGxvY2F0ZWQgQml0QXJyYXkgaW4gU3R5bGVQcm9wZXJ0 eVNldCBzZXJpYWxpemF0aW9uLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0F0dHIu Y3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0F0dHIuY3BwCmluZGV4IDM3MThlY2UuLmRlOWU0ZmYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9BdHRyLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9kb20vQXR0ci5jcHAKQEAgLTIwMyw3ICsyMDMsNyBAQCBDU1NTdHlsZURlY2xhcmF0aW9u KiBBdHRyOjpzdHlsZSgpCiBjb25zdCBBdG9taWNTdHJpbmcmIEF0dHI6OnZhbHVlKCkgY29uc3QK IHsKICAgICBpZiAobV9lbGVtZW50KQotICAgICAgICByZXR1cm4gbV9lbGVtZW50LT5nZXRBdHRy aWJ1dGVJdGVtKHF1YWxpZmllZE5hbWUoKSktPnZhbHVlKCk7CisgICAgICAgIHJldHVybiBtX2Vs ZW1lbnQtPmdldEF0dHJpYnV0ZShxdWFsaWZpZWROYW1lKCkpOwogICAgIHJldHVybiBtX3N0YW5k YWxvbmVWYWx1ZTsKIH0KIAo=