87073 2012-05-21 19:37:45 -0700 add OVERRIDE annotations to classes derived from CCAnimationCurve 2012-05-22 10:03:43 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 83645 1 guanqun.lu guanqun.lu cc-bugs jamesr webkit.review.bot oldest_to_newest 629869 0 guanqun.lu 2012-05-21 19:37:45 -0700 Some functions in classes derived from CCAnimationCurve don't have OVERRIDE annotations, we should add them too. 629872 1 143174 guanqun.lu 2012-05-21 19:40:25 -0700 Created attachment 143174 Patch 630465 2 143174 jamesr 2012-05-22 09:50:27 -0700 Comment on attachment 143174 Patch R=me 630480 3 143174 webkit.review.bot 2012-05-22 10:03:39 -0700 Comment on attachment 143174 Patch Clearing flags on attachment: 143174 Committed r117991: <http://trac.webkit.org/changeset/117991> 630481 4 webkit.review.bot 2012-05-22 10:03:43 -0700 All reviewed patches have been landed. Closing bug. 143174 2012-05-21 19:40:25 -0700 2012-05-22 10:03:39 -0700 Patch bug-87073-20120522104135.patch text/plain 1652 guanqun.lu U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3ODcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzY3MzY5Y2MxYjhhODZj OTllOWVlNTg2NDRkN2RmNmIwODlmZjcwOS4uNzNmN2FiY2M2MDc2NWYzOTQ1ZWY3N2M4ZTQ2ZDFj MDZkZDQ4NDg5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA1LTIxICBMdSBH dWFucXVuICA8Z3VhbnF1bi5sdUBpbnRlbC5jb20+CisKKyAgICAgICAgYWRkIE9WRVJSSURFIGFu bm90YXRpb25zIHRvIGNsYXNzZXMgZGVyaXZlZCBmcm9tIENDQW5pbWF0aW9uQ3VydmUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3MDczCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIHJl cXVpcmVkLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NBbmlt YXRpb25DdXJ2ZS5oOgorCiAyMDEyLTA1LTIxICBSb2IgQnVpcyAgPHJidWlzQHJpbS5jb20+CiAK ICAgICAgICAgU2hyaW5rIEZvbnREZXNjcmlwdGlvbiBvYmplY3Qgc2l6ZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NBbmltYXRpb25D dXJ2ZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NB bmltYXRpb25DdXJ2ZS5oCmluZGV4IDUzM2FiYWZlZjQ1NDdkNTQ5M2JhNTk3MTFiZTE1NTE2Njdl ZTI0ZjUuLjdmNTA2YTcwNmYyYTQzYWU2ZDM4YTVhZjYzYmQ3NWNmOGNiM2U3ZDUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDQW5pbWF0 aW9uQ3VydmUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1 bS9jYy9DQ0FuaW1hdGlvbkN1cnZlLmgKQEAgLTU4LDcgKzU4LDcgQEAgcHVibGljOgogICAgIHZp cnR1YWwgZmxvYXQgZ2V0VmFsdWUoZG91YmxlIHQpIGNvbnN0ID0gMDsKIAogICAgIC8vIFBhcnRp YWwgQ0NBbmltYXRpb24gaW1wbGVtZW50YXRpb24uCi0gICAgdmlydHVhbCBUeXBlIHR5cGUoKSBj b25zdCB7IHJldHVybiBGbG9hdDsgfQorICAgIHZpcnR1YWwgVHlwZSB0eXBlKCkgY29uc3QgT1ZF UlJJREUgeyByZXR1cm4gRmxvYXQ7IH0KIH07CiAKIGNsYXNzIENDVHJhbnNmb3JtQW5pbWF0aW9u Q3VydmUgOiBwdWJsaWMgQ0NBbmltYXRpb25DdXJ2ZSB7CkBAIC02OCw3ICs2OCw3IEBAIHB1Ymxp YzoKICAgICB2aXJ0dWFsIFRyYW5zZm9ybWF0aW9uTWF0cml4IGdldFZhbHVlKGRvdWJsZSB0LCBj b25zdCBJbnRTaXplJiBsYXllclNpemUpIGNvbnN0ID0gMDsKIAogICAgIC8vIFBhcnRpYWwgQ0NB bmltYXRpb24gaW1wbGVtZW50YXRpb24uCi0gICAgdmlydHVhbCBUeXBlIHR5cGUoKSBjb25zdCB7 IHJldHVybiBUcmFuc2Zvcm07IH0KKyAgICB2aXJ0dWFsIFR5cGUgdHlwZSgpIGNvbnN0IE9WRVJS SURFIHsgcmV0dXJuIFRyYW5zZm9ybTsgfQogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo=