87062 2012-05-21 18:00:28 -0700 [TextureMapper] [Cairo] Implement repaint counters 2012-05-22 15:09:08 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrobinson mrobinson alex noam webkit.review.bot oldest_to_newest 629796 0 mrobinson 2012-05-21 18:00:28 -0700 Repaint counters can be useful for debugging content that is composited with AC and AC implementations. 629820 1 143160 mrobinson 2012-05-21 18:29:47 -0700 Created attachment 143160 Patch 629824 2 mrobinson 2012-05-21 18:32:14 -0700 This code in Cairo only, but if the Qt port is interested in this feature, I'm willing to write it using QPainter. The reason I did not use generic GraphicsContext APIs it that it would require some interaction with the FontCache and using the toy platform interface seems simpler all around. 630011 3 143160 noam 2012-05-22 00:03:00 -0700 Comment on attachment 143160 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143160&action=review I'm ok with the texture-mapper changes, though I'm not qualified to review the cairo-specific code :) We'd love a QPainter implementation of this, though we'd have to do this in the LayerBackingStore code which is the proper place in WebKit2. > Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:573 > +#if USE(CAIRO) This would be more readable inside the function. 630534 4 143160 gustavo 2012-05-22 10:44:52 -0700 Comment on attachment 143160 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143160&action=review I'm just not sure about the border color, feels like you may want to have a border distinct from the background, but I guess it'll look readable like this anyway. >> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:573 >> +#if USE(CAIRO) > > This would be more readable inside the function. Hmm, I think it would be less readable with different implementations taking the whole function body. As it is now it's pretty obvious that each implementation has a completely different implementation. 630658 5 143160 webkit.review.bot 2012-05-22 12:22:27 -0700 Comment on attachment 143160 Patch Rejecting attachment 143160 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: webkit-commit-queue/Source/WebKit/chromium/webkit --revision 138079 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 48>At revision 138079. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/12763103 630806 6 mrobinson 2012-05-22 15:09:08 -0700 Committed r118061: <http://trac.webkit.org/changeset/118061> 143160 2012-05-21 18:29:47 -0700 2012-05-22 12:22:27 -0700 Patch bug-87062-20120521182946.patch text/plain 4628 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3ODAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDFmNjJiNjc3ZDc0ZDI4 MzFhMzdmNmVhZThmYjVkMDBjNDk5YzI3YS4uODgwZTc1MGI0ZWY1ZTY0ZTFiNjE1MWM4MTQ1MDAx YzVlZjM0YjdlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA1LTIxICBNYXJ0 aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAgICBbVGV4dHVyZU1h cHBlcl0gW0NhaXJvXSBJbXBsZW1lbnQgcmVwYWludCBjb3VudGVycworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODcwNjIKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIFRoaXMganVzdCBh ZGRzIGEgZGVidWdnaW5nIGZlYXR1cmUgdGhhdCBzaG91bGRuJ3QKKyAgICAgICAgYWZmZWN0IHRo ZSBub3JtYWwgZHJhd2luZyBvZiBhIHBhZ2UuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy90ZXhtYXAvVGV4dHVyZU1hcHBlckxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRleHR1 cmVNYXBwZXJMYXllcjo6dXBkYXRlQmFja2luZ1N0b3JlKTogTm93LCBpZiByZXBhaW50IGNvdW50 ZXJzIGFyZQorICAgICAgICBlbmFibGVkLCBpbmNyZW1lbnQgdGhlIHJlcGFpbnQgY291bnQgYW5k IGNhbGwgZHJhd1JlcGFpbnRDb3VudGVyLgorICAgICAgICAoV2ViQ29yZTo6VGV4dHVyZU1hcHBl ckxheWVyOjpkcmF3UmVwYWludENvdW50ZXIpOiBBZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckxheWVyLmg6CisgICAgICAgIChUZXh0dXJlTWFw cGVyTGF5ZXIpOiBBZGRlZCBkZWNsYXJhdGlvbiBmb3IgZHJhd1JlcGFpbnRDb3VudGVyLgorCiAy MDEyLTA1LTEwICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAg ICAgICBbR1RLXSBBZGQgYW4gYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcgaW1wbGVtZW50YXRpb24g Zm9yIFdlYktpdDIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3RleG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJMYXllci5jcHAKaW5kZXggNDBmMGM5ODM2MTNi MzNiNDc1ZTc4ZjM5NzllMzFkMTMxNjY2ZjYyMS4uOTZjYWZhYzQyZWJmZmMwN2RiYmMzZjZhZGU2 NWIzYzQyYjBmOWNhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvdGV4bWFwL1RleHR1cmVNYXBwZXJMYXllci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJMYXllci5jcHAKQEAgLTI2LDkgKzI2 LDEzIEBACiAKICNpbmNsdWRlICJHcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlci5oIgogI2luY2x1 ZGUgIkltYWdlQnVmZmVyLmgiCi0KKyNpbmNsdWRlICJOb3RJbXBsZW1lbnRlZC5oIgogI2luY2x1 ZGUgPHd0Zi9NYXRoRXh0cmFzLmg+CiAKKyNpZiBVU0UoQ0FJUk8pCisjaW5jbHVkZSAiQ2Fpcm9V dGlsaXRpZXMuaCIKKyNlbmRpZgorCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIFRleHR1cmVNYXBw ZXJMYXllciogdG9UZXh0dXJlTWFwcGVyTGF5ZXIoR3JhcGhpY3NMYXllciogbGF5ZXIpCkBAIC0x MjIsOCArMTI2LDEyIEBAIHZvaWQgVGV4dHVyZU1hcHBlckxheWVyOjp1cGRhdGVCYWNraW5nU3Rv cmUoVGV4dHVyZU1hcHBlciogdGV4dHVyZU1hcHBlciwgR3JhcGhpCiAgICAgY29udGV4dC0+dHJh bnNsYXRlKC1kaXJ0eVJlY3QueCgpLCAtZGlydHlSZWN0LnkoKSk7CiAgICAgbGF5ZXItPnBhaW50 R3JhcGhpY3NMYXllckNvbnRlbnRzKCpjb250ZXh0LCBkaXJ0eVJlY3QpOwogCi0gICAgUmVmUHRy PEltYWdlPiBpbWFnZSA9IGltYWdlQnVmZmVyLT5jb3B5SW1hZ2UoRG9udENvcHlCYWNraW5nU3Rv cmUpOworICAgIGlmIChsYXllci0+c2hvd1JlcGFpbnRDb3VudGVyKCkpIHsKKyAgICAgICAgbGF5 ZXItPmluY3JlbWVudFJlcGFpbnRDb3VudCgpOworICAgICAgICBkcmF3UmVwYWludENvdW50ZXIo Y29udGV4dCwgbGF5ZXIpOworICAgIH0KIAorICAgIFJlZlB0cjxJbWFnZT4gaW1hZ2UgPSBpbWFn ZUJ1ZmZlci0+Y29weUltYWdlKERvbnRDb3B5QmFja2luZ1N0b3JlKTsKICAgICBUZXh0dXJlTWFw cGVyVGlsZWRCYWNraW5nU3RvcmUqIGJhY2tpbmdTdG9yZSA9IHN0YXRpY19jYXN0PFRleHR1cmVN YXBwZXJUaWxlZEJhY2tpbmdTdG9yZSo+KG1fYmFja2luZ1N0b3JlLmdldCgpKTsKICAgICBiYWNr aW5nU3RvcmUtPnVwZGF0ZUNvbnRlbnRzKHRleHR1cmVNYXBwZXIsIGltYWdlLmdldCgpLCBtX3Np emUsIGRpcnR5UmVjdCk7CiAKQEAgLTU2Miw1ICs1NzAsNDAgQEAgdm9pZCBUZXh0dXJlTWFwcGVy TGF5ZXI6OnNldERlYnVnQm9yZGVyKGNvbnN0IENvbG9yJiBjb2xvciwgZmxvYXQgd2lkdGgpCiAg ICAgbV9kZWJ1Z0JvcmRlcldpZHRoID0gd2lkdGggKiAyOwogfQogCisjaWYgVVNFKENBSVJPKQor dm9pZCBUZXh0dXJlTWFwcGVyTGF5ZXI6OmRyYXdSZXBhaW50Q291bnRlcihHcmFwaGljc0NvbnRl eHQqIGNvbnRleHQsIEdyYXBoaWNzTGF5ZXIqIGxheWVyKQoreworCisgICAgY2Fpcm9fdCogY3Ig PSBjb250ZXh0LT5wbGF0Zm9ybUNvbnRleHQoKS0+Y3IoKTsKKyAgICBjYWlyb19zYXZlKGNyKTsK KworICAgIENTdHJpbmcgcmVwYWludENvdW50ID0gU3RyaW5nOjpmb3JtYXQoIiVpIiwgbGF5ZXIt PnJlcGFpbnRDb3VudCgpKS51dGY4KCk7CisgICAgY2Fpcm9fc2VsZWN0X2ZvbnRfZmFjZShjciwg InNhbnMtc2VyaWYiLCBDQUlST19GT05UX1NMQU5UX05PUk1BTCwgQ0FJUk9fRk9OVF9XRUlHSFRf Qk9MRCk7CisgICAgY2Fpcm9fc2V0X2ZvbnRfc2l6ZShjciwgMTgpOworCisgICAgY2Fpcm9fdGV4 dF9leHRlbnRzX3QgcmVwYWludFRleHRFeHRlbnRzOworICAgIGNhaXJvX3RleHRfZXh0ZW50cyhj ciwgcmVwYWludENvdW50LmRhdGEoKSwgJnJlcGFpbnRUZXh0RXh0ZW50cyk7CisKKyAgICBzdGF0 aWMgY29uc3QgaW50IHJlcGFpbnRDb3VudEJvcmRlcldpZHRoID0gMTA7CisgICAgc2V0U291cmNl UkdCQUZyb21Db2xvcihjciwgbGF5ZXItPnNob3dEZWJ1Z0JvcmRlcnMoKSA/IG1fZGVidWdCb3Jk ZXJDb2xvciA6IENvbG9yKDAsIDI1NSwgMCwgMTI3KSk7CisgICAgY2Fpcm9fcmVjdGFuZ2xlKGNy LCAwLCAwLAorICAgICAgICAgICAgICAgICAgICByZXBhaW50VGV4dEV4dGVudHMud2lkdGggKyAo cmVwYWludENvdW50Qm9yZGVyV2lkdGggKiAyKSwKKyAgICAgICAgICAgICAgICAgICAgcmVwYWlu dFRleHRFeHRlbnRzLmhlaWdodCArIChyZXBhaW50Q291bnRCb3JkZXJXaWR0aCAqIDIpKTsKKyAg ICBjYWlyb19maWxsKGNyKTsKKworICAgIGNhaXJvX3NldF9zb3VyY2VfcmdiKGNyLCAxLCAxLCAx KTsKKyAgICBjYWlyb19tb3ZlX3RvKGNyLCByZXBhaW50Q291bnRCb3JkZXJXaWR0aCwgcmVwYWlu dFRleHRFeHRlbnRzLmhlaWdodCArIHJlcGFpbnRDb3VudEJvcmRlcldpZHRoKTsKKyAgICBjYWly b19zaG93X3RleHQoY3IsIHJlcGFpbnRDb3VudC5kYXRhKCkpOworCisgICAgY2Fpcm9fcmVzdG9y ZShjcik7Cit9CisjZWxzZQordm9pZCBUZXh0dXJlTWFwcGVyTGF5ZXI6OmRyYXdSZXBhaW50Q291 bnRlcihHcmFwaGljc0NvbnRleHQqIGNvbnRleHQsIEdyYXBoaWNzTGF5ZXIqIGxheWVyKQorewor ICAgIG5vdEltcGxlbWVudGVkKCk7Cit9CisKKyNlbmRpZgorCiB9CiAjZW5kaWYKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVy TGF5ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJl TWFwcGVyTGF5ZXIuaAppbmRleCBkYTFhYzk5MTY3NDg4ZjI3ODAwMTFmNjg3Mjk0MWVkMGViYjJk MDNmLi42NDE3MmQxZDZmOTgwMDgzOTNhMWU4ZmE4ODYyM2M1ZmRlYzIwZjRjIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckxh eWVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1 cmVNYXBwZXJMYXllci5oCkBAIC0xNTcsNiArMTU3LDggQEAgcHJpdmF0ZToKICAgICB2b2lkIHBh aW50U2VsZkFuZENoaWxkcmVuV2l0aFJlcGxpY2EoY29uc3QgVGV4dHVyZU1hcHBlclBhaW50T3B0 aW9ucyYpOwogICAgIHZvaWQgdXBkYXRlQmFja2luZ1N0b3JlKFRleHR1cmVNYXBwZXIqLCBHcmFw aGljc0xheWVyVGV4dHVyZU1hcHBlciopOwogCisgICAgdm9pZCBkcmF3UmVwYWludENvdW50ZXIo R3JhcGhpY3NDb250ZXh0KiwgR3JhcGhpY3NMYXllciopOworCiAgICAgdm9pZCBzeW5jQW5pbWF0 aW9ucygpOwogICAgIGJvb2wgaXNWaXNpYmxlKCkgY29uc3Q7CiAgICAgZW51bSBDb250ZW50c0xh eWVyQ291bnQgewo=