87047 2012-05-21 14:40:45 -0700 [WK2] Remove a useless #if on Tools/WebKitTestRunner/TestController.cpp 2012-05-21 16:14:56 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 hugo.lima webkit-unassigned menard webkit.review.bot oldest_to_newest 629521 0 hugo.lima 2012-05-21 14:40:45 -0700 #if PLATFORM(MAC) || PLATFORM(QT) || PLATFORM(GTK) is inside another #if PLATFORM(MAC) || PLATFORM(QT) || PLATFORM(GTK) 629523 1 143100 hugo.lima 2012-05-21 14:42:36 -0700 Created attachment 143100 Patch 629532 2 143104 hugo.lima 2012-05-21 14:51:42 -0700 Created attachment 143104 Patch Now with a new title 629677 3 143104 webkit.review.bot 2012-05-21 16:14:49 -0700 Comment on attachment 143104 Patch Clearing flags on attachment: 143104 Committed r117827: <http://trac.webkit.org/changeset/117827> 629678 4 webkit.review.bot 2012-05-21 16:14:56 -0700 All reviewed patches have been landed. Closing bug. 143100 2012-05-21 14:42:36 -0700 2012-05-21 14:51:34 -0700 Patch bug-87047-20120521184229.patch text/plain 1989 hugo.lima U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3Nzc0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDc3ZjU2Y2NkODBlYTA5YmJjMzg4MWNmZjQzZDA5YWIw Njg0YWYxMy4uZWY4NDY5MzA0MzY1MTYyOGUzMzA5ZmY3YWJjYjVjMDIwOTE3YmNlMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1 IEBACiAyMDEyLTA1LTIxICBIdWdvIFBhcmVudGUgTGltYSAgPGh1Z28ubGltYUBvcGVuYm9zc2Eu b3JnPgogCisgICAgICAgIFtXSzJdIFRoZXJlJ3MgYSB1c2VsZXNzICNpZiBvbiBUb29scy9XZWJL aXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODcwNDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIu Y3BwOgorICAgICAgICAoV1RSOjpUZXN0Q29udHJvbGxlcjo6ZGlkUmVjZWl2ZVN5bmNocm9ub3Vz TWVzc2FnZUZyb21JbmplY3RlZEJ1bmRsZSk6CisKKzIwMTItMDUtMjEgIEh1Z28gUGFyZW50ZSBM aW1hICA8aHVnby5saW1hQG9wZW5ib3NzYS5vcmc+CisKICAgICAgICAgW1F0XVtXSzJdIEV2ZW50 U2VuZGVyUHJveHk6OmtleURvd24gZG9lc24ndCB1c2UgdGhlIGhlbHBlciBmdW5jdGlvbnMgdG8g c2VuZCBldmVudHMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTg3MDQ0CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRy b2xsZXIuY3BwIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAKaW5k ZXggMjE5ZTc0OTczYmNlNmQ2MjA4OGZjODdiNDg0ODJhZjJlNDc4MGU5Yi4uYmE3ZTA4YjllYmZk ZjBmYTA2ZDRiNTE2OTExNGVmMzQxMWE4OGVkMiAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVz dFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9U ZXN0Q29udHJvbGxlci5jcHAKQEAgLTYxOCw3ICs2MTgsNiBAQCBXS1JldGFpblB0cjxXS1R5cGVS ZWY+IFRlc3RDb250cm9sbGVyOjpkaWRSZWNlaXZlU3luY2hyb25vdXNNZXNzYWdlRnJvbUluamVj dGVkQgogICAgICAgICAgICAgcmV0dXJuIDA7CiAgICAgICAgIH0KIAotI2lmIFBMQVRGT1JNKE1B QykgfHwgUExBVEZPUk0oUVQpIHx8IFBMQVRGT1JNKEdUSykKICAgICAgICAgaWYgKFdLU3RyaW5n SXNFcXVhbFRvVVRGOENTdHJpbmcoc3ViTWVzc2FnZU5hbWUsICJNb3VzZURvd24iKSB8fCBXS1N0 cmluZ0lzRXF1YWxUb1VURjhDU3RyaW5nKHN1Yk1lc3NhZ2VOYW1lLCAiTW91c2VVcCIpKSB7CiAg ICAgICAgICAgICBXS1JldGFpblB0cjxXS1N0cmluZ1JlZj4gYnV0dG9uS2V5ID0gYWRvcHRXSyhX S1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZygiQnV0dG9uIikpOwogICAgICAgICAgICAgdW5z aWduZWQgYnV0dG9uID0gc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KFdLVUludDY0R2V0VmFsdWUoc3Rh dGljX2Nhc3Q8V0tVSW50NjRSZWY+KFdLRGljdGlvbmFyeUdldEl0ZW1Gb3JLZXkobWVzc2FnZUJv ZHlEaWN0aW9uYXJ5LCBidXR0b25LZXkuZ2V0KCkpKSkpOwpAQCAtNjcxLDcgKzY3MCw2IEBAIFdL UmV0YWluUHRyPFdLVHlwZVJlZj4gVGVzdENvbnRyb2xsZXI6OmRpZFJlY2VpdmVTeW5jaHJvbm91 c01lc3NhZ2VGcm9tSW5qZWN0ZWRCCiAgICAgICAgICAgICBtX2V2ZW50U2VuZGVyUHJveHktPmxl YXBGb3J3YXJkKHRpbWUpOwogICAgICAgICAgICAgcmV0dXJuIDA7CiAgICAgICAgIH0KLSNlbmRp ZgogCiAjaWYgRU5BQkxFKFRPVUNIX0VWRU5UUykKICAgICAgICAgaWYgKFdLU3RyaW5nSXNFcXVh bFRvVVRGOENTdHJpbmcoc3ViTWVzc2FnZU5hbWUsICJBZGRUb3VjaFBvaW50IikpIHsK 143104 2012-05-21 14:51:42 -0700 2012-05-21 16:14:49 -0700 Patch bug-87047-20120521185135.patch text/plain 1988 hugo.lima U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3ODE3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWQyZGJjMGRhMmMzMjBjYzlkNTIzMjhiZTM2YmYwYWNk NWUyYjE4Zi4uNzUxMjJlMTcwMmRkZTI0NmM0Nzk0MjYwNDY3MjNhOThjMGEyOTBlZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1 IEBACiAyMDEyLTA1LTIxICBIdWdvIFBhcmVudGUgTGltYSAgPGh1Z28ubGltYUBvcGVuYm9zc2Eu b3JnPgogCisgICAgICAgIFtXSzJdIFJlbW92ZSBhIHVzZWxlc3MgI2lmIG9uIFRvb2xzL1dlYktp dFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NzA0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5j cHA6CisgICAgICAgIChXVFI6OlRlc3RDb250cm9sbGVyOjpkaWRSZWNlaXZlU3luY2hyb25vdXNN ZXNzYWdlRnJvbUluamVjdGVkQnVuZGxlKToKKworMjAxMi0wNS0yMSAgSHVnbyBQYXJlbnRlIExp bWEgIDxodWdvLmxpbWFAb3BlbmJvc3NhLm9yZz4KKwogICAgICAgICBbUXRdW1dLMl0gRXZlbnRT ZW5kZXJQcm94eTo6a2V5RG93biBkb2Vzbid0IHVzZSB0aGUgaGVscGVyIGZ1bmN0aW9ucyB0byBz ZW5kIGV2ZW50cwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9ODcwNDQKIApkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJv bGxlci5jcHAgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcAppbmRl eCAyMTllNzQ5NzNiY2U2ZDYyMDg4ZmM4N2I0ODQ4MmFmMmU0NzgwZTliLi5iYTdlMDhiOWViZmRm MGZhMDZkNGI1MTY5MTE0ZWYzNDExYTg4ZWQyIDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0 UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcAorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rl c3RDb250cm9sbGVyLmNwcApAQCAtNjE4LDcgKzYxOCw2IEBAIFdLUmV0YWluUHRyPFdLVHlwZVJl Zj4gVGVzdENvbnRyb2xsZXI6OmRpZFJlY2VpdmVTeW5jaHJvbm91c01lc3NhZ2VGcm9tSW5qZWN0 ZWRCCiAgICAgICAgICAgICByZXR1cm4gMDsKICAgICAgICAgfQogCi0jaWYgUExBVEZPUk0oTUFD KSB8fCBQTEFURk9STShRVCkgfHwgUExBVEZPUk0oR1RLKQogICAgICAgICBpZiAoV0tTdHJpbmdJ c0VxdWFsVG9VVEY4Q1N0cmluZyhzdWJNZXNzYWdlTmFtZSwgIk1vdXNlRG93biIpIHx8IFdLU3Ry aW5nSXNFcXVhbFRvVVRGOENTdHJpbmcoc3ViTWVzc2FnZU5hbWUsICJNb3VzZVVwIikpIHsKICAg ICAgICAgICAgIFdLUmV0YWluUHRyPFdLU3RyaW5nUmVmPiBidXR0b25LZXkgPSBhZG9wdFdLKFdL U3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKCJCdXR0b24iKSk7CiAgICAgICAgICAgICB1bnNp Z25lZCBidXR0b24gPSBzdGF0aWNfY2FzdDx1bnNpZ25lZD4oV0tVSW50NjRHZXRWYWx1ZShzdGF0 aWNfY2FzdDxXS1VJbnQ2NFJlZj4oV0tEaWN0aW9uYXJ5R2V0SXRlbUZvcktleShtZXNzYWdlQm9k eURpY3Rpb25hcnksIGJ1dHRvbktleS5nZXQoKSkpKSk7CkBAIC02NzEsNyArNjcwLDYgQEAgV0tS ZXRhaW5QdHI8V0tUeXBlUmVmPiBUZXN0Q29udHJvbGxlcjo6ZGlkUmVjZWl2ZVN5bmNocm9ub3Vz TWVzc2FnZUZyb21JbmplY3RlZEIKICAgICAgICAgICAgIG1fZXZlbnRTZW5kZXJQcm94eS0+bGVh cEZvcndhcmQodGltZSk7CiAgICAgICAgICAgICByZXR1cm4gMDsKICAgICAgICAgfQotI2VuZGlm CiAKICNpZiBFTkFCTEUoVE9VQ0hfRVZFTlRTKQogICAgICAgICBpZiAoV0tTdHJpbmdJc0VxdWFs VG9VVEY4Q1N0cmluZyhzdWJNZXNzYWdlTmFtZSwgIkFkZFRvdWNoUG9pbnQiKSkgewo=