87043 2012-05-21 13:50:27 -0700 Style guide: Directly qualify uses of std:: 2012-05-21 18:44:43 -0700 1 1 1 Unclassified WebKit WebKit Website 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pkasting pkasting webkit.review.bot oldest_to_newest 629460 0 pkasting 2012-05-21 13:50:27 -0700 Per agreement on webkit-dev, change the style guide to say that for symbols in the std namespace, uses in implementation files should be explicitly qualified, instead of using a "using" directive. 629468 1 143092 pkasting 2012-05-21 13:56:28 -0700 Created attachment 143092 patch v1 629838 2 143092 webkit.review.bot 2012-05-21 18:44:39 -0700 Comment on attachment 143092 patch v1 Clearing flags on attachment: 143092 Committed r117866: <http://trac.webkit.org/changeset/117866> 629839 3 webkit.review.bot 2012-05-21 18:44:43 -0700 All reviewed patches have been landed. Closing bug. 143092 2012-05-21 13:56:28 -0700 2012-05-21 18:44:39 -0700 patch v1 patch text/plain 2245 pkasting SW5kZXg6IFdlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYnNp dGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMTc4MTIpCisrKyBXZWJzaXRlcy93 ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEy LTA1LTIxICBQZXRlciBLYXN0aW5nICA8cGthc3RpbmdAZ29vZ2xlLmNvbT4KKworICAgICAgICBT dHlsZSBndWlkZSBjaGFuZ2U6IFVzZXMgb2YgInN0ZDo6IiBzaG91bGQgYmUgZXhwbGljaXRseSBx dWFsaWZpZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD04NzA0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogY29kaW5nL2NvZGluZy1zdHlsZS5odG1sOgorCiAyMDEyLTA1LTExICBEYXJpbiBBZGxlciAg PGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgIFRyeSB0byBtYWtlIHNwYWNpbmcgb2YgZmluZSBw cmludCBpdGVtcyBpbiBsb3dlciBsZWZ0IG5pY2VyIGxvb2tpbmcuCkluZGV4OiBXZWJzaXRlcy93 ZWJraXQub3JnL2NvZGluZy9jb2Rpbmctc3R5bGUuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJzaXRl cy93ZWJraXQub3JnL2NvZGluZy9jb2Rpbmctc3R5bGUuaHRtbAkocmV2aXNpb24gMTE3NjYxKQor KysgV2Vic2l0ZXMvd2Via2l0Lm9yZy9jb2RpbmcvY29kaW5nLXN0eWxlLmh0bWwJKHdvcmtpbmcg Y29weSkKQEAgLTk1MSwyMSArOTUxLDIxIEBAIHVzaW5nIFdURjo6UGxhY2VtZW50TmV3QWRvcHQ7 CiA8L3ByZT4KIDwvbGk+CiAKLTxsaSBpZD0idXNpbmctaW4tY3BwIj5JbiBDKysgaW1wbGVtZW50 YXRpb24gZmlsZXMsIGRvIG5vdCB1c2Ugc3RhdGVtZW50cyBvZiB0aGUgZm9ybQotInVzaW5nIHN0 ZDo6Zm9vIiB0byBpbXBvcnQgbmFtZXMgaW4gdGhlIHN0YW5kYXJkIHRlbXBsYXRlIGxpYnJhcnku Ci1Vc2UgInVzaW5nIG5hbWVzcGFjZSBzdGQiIGluc3RlYWQuCis8bGkgaWQ9InVzaW5nLWluLWNw cCI+SW4gQysrIGltcGxlbWVudGF0aW9uIGZpbGVzLCBkbyBub3QgdXNlICJ1c2luZyIgZGVjbGFy YXRpb25zCitvZiBhbnkga2luZCB0byBpbXBvcnQgbmFtZXMgaW4gdGhlIHN0YW5kYXJkIHRlbXBs YXRlIGxpYnJhcnkuICBEaXJlY3RseSBxdWFsaWZ5Cit0aGUgbmFtZXMgYXQgdGhlIHBvaW50IHRo ZXkncmUgdXNlZCBpbnN0ZWFkLgogCiA8aDQgY2xhc3M9InJpZ2h0Ij5SaWdodDo8L2g0PgogPHBy ZSBjbGFzcz0iY29kZSI+CiAvLyBIVE1MQmFzZUVsZW1lbnQuY3BwCiAKLXVzaW5nIG5hbWVzcGFj ZSBzdGQ7Ci0KIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAorICBzdGQ6OnN3YXAoYSwgYik7CisgIGMg PSBzdGQ6Om51bWVyaWNfbGltaXRzJmx0O2ludCZndDs6Om1heCgpCisKIH0gLy8gbmFtZXNwYWNl IFdlYkNvcmUKIDwvcHJlPgotCiA8aDQgY2xhc3M9Indyb25nIj5Xcm9uZzo8L2g0PgogPHByZSBj bGFzcz0iY29kZSI+CiAvLyBIVE1MQmFzZUVsZW1lbnQuY3BwCkBAIC05NzQsNiArOTc0LDIwIEBA IHVzaW5nIHN0ZDo6c3dhcDsKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCisgIHN3YXAoYSwgYik7 CisKK30gLy8gbmFtZXNwYWNlIFdlYkNvcmUKKzwvcHJlPgorPGg0IGNsYXNzPSJ3cm9uZyI+V3Jv bmc6PC9oND4KKzxwcmUgY2xhc3M9ImNvZGUiPgorLy8gSFRNTEJhc2VFbGVtZW50LmNwcAorCit1 c2luZyBuYW1lc3BhY2Ugc3RkOworCituYW1lc3BhY2UgV2ViQ29yZSB7CisKKyAgc3dhcChhLCBi KTsKKwogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQogPC9wcmU+CiA8L2xpPgpAQCAtMTAxMyw3ICsx MDI3LDcgQEAgYWZ0ZXIgYW55ICJpbmNsdWRlIiBzdGF0ZW1lbnRzLgogPHByZSBjbGFzcz0iY29k ZSI+CiAvLyBIVE1MU2VsZWN0RWxlbWVudC5jcHAKIAotdXNpbmcgbmFtZXNwYWNlIHN0ZDsKK3Vz aW5nIG5hbWVzcGFjZSBvdGhlcjsKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCkBAIC0xMDI2LDcg KzEwNDAsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAot dXNpbmcgbmFtZXNwYWNlIHN0ZDsKK3VzaW5nIG5hbWVzcGFjZSBvdGhlcjsKIAogfSAvLyBuYW1l c3BhY2UgV2ViQ29yZQogPC9wcmU+Cg==