87020 2012-05-21 07:51:00 -0700 run-webkit-tests fails when svn is not installed 2012-06-19 07:20:00 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 76630 P2 Minor --- 1 lauro.neto webkit-unassigned abarth dpranke ojan rafael.lobo shezbaig.wk webkit.review.bot oldest_to_newest 629092 0 lauro.neto 2012-05-21 07:51:00 -0700 Revision 117643 added a call to the svn executable without a try/except guard to avoid raising the exception when svn is not installed. 629093 1 143033 lauro.neto 2012-05-21 07:56:02 -0700 Created attachment 143033 Adds try/except guard around the svn call 629161 2 143033 abarth 2012-05-21 09:11:31 -0700 Comment on attachment 143033 Adds try/except guard around the svn call Can we test this change? 629734 3 143033 rniwa 2012-05-21 17:04:17 -0700 Comment on attachment 143033 Adds try/except guard around the svn call View in context: https://bugs.webkit.org/attachment.cgi?id=143033&action=review > Tools/Scripts/webkitpy/common/checkout/scm/svn.py:97 > + try: > + exit_code = Executive().run_command(svn_info_args, cwd=path, return_exit_code=True) > + return (exit_code == 0) > + except OSError: > + return False We need a test for this. r- due to the lack of a test. 651745 4 rafael.lobo 2012-06-18 14:38:43 -0700 I confirm this bug (spent some time to figure out the lack of subversion). Could we at least print a more meaningful message when this error shows up? 651753 5 rafael.lobo 2012-06-18 14:48:37 -0700 On a side note, it also fails when xvfb is missing: (...) File "/opt/git/webkit/Tools/Scripts/webkitpy/layout_tests/port/driver.py", line 220, in run_test return self._running_drivers[cmd_line_key].run_test(driver_input) File "/opt/git/webkit/Tools/Scripts/webkitpy/layout_tests/port/webkit.py", line 558, in run_test self.start(driver_input.should_run_pixel_test, driver_input.args) File "/opt/git/webkit/Tools/Scripts/webkitpy/layout_tests/port/webkit.py", line 670, in start self._start(pixel_tests, per_test_args) File "/opt/git/webkit/Tools/Scripts/webkitpy/layout_tests/port/xvfbdriver.py", line 59, in _start self._xvfb_process = subprocess.Popen(run_xvfb, stderr=devnull) File "/usr/lib/python2.7/subprocess.py", line 679, in __init__ errread, errwrite) File "/usr/lib/python2.7/subprocess.py", line 1249, in _execute_child raise child_exception OSError: [Errno 2] No such file or directory 652423 6 rafael.lobo 2012-06-19 07:20:00 -0700 *** This bug has been marked as a duplicate of bug 76630 *** 143033 2012-05-21 07:56:02 -0700 2012-05-21 17:04:17 -0700 Adds try/except guard around the svn call bug-87020-20120521115600.patch text/plain 1726 lauro.neto U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3Nzc4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTUyODc5MTZkNGE2ZjM5ZjU2OTBmODYxNzU1MmM4NDA3 ZTUzOWZhZC4uZDhjNzZjYzBlNDYxYTJlZjRjYzc1MWQzM2I1NWEzODkwZmIxY2M5NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTA1LTIxICBMYXVybyBOZXRvICA8bGF1cm8ubmV0b0BvcGVuYm9zc2Eub3JnPgor CisgICAgICAgIHJ1bi13ZWJraXQtdGVzdHMgZmFpbHMgd2hlbiBzdm4gaXMgbm90IGluc3RhbGxl ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODcwMjAK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRzIGEg dHJ5L2V4Y2VwdCBndWFyZCBhcm91bmQgYSBjYWxsIHRvIHRoZSBzdm4gZXhjdXRhYmxlIHRvIGF2 b2lkCisgICAgICAgIHJhaXNpbmcgT1NFcnJvciB3aGVuIHN2biBpcyBub3QgaW5zdGFsbGVkLCBl LmcuIGluc2lkZSBhIGdpdAorICAgICAgICByZXBvc2l0b3J5LgorCisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2NtL3N2bi5weToKKyAgICAgICAgKFNWTi5pbl93 b3JraW5nX2RpcmVjdG9yeSk6CisKIDIwMTItMDUtMjEgIENhaW8gTWFyY2VsbyBkZSBPbGl2ZWly YSBGaWxobyAgPGNhaW8ub2xpdmVpcmFAb3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBNb3ZlIHNl dEVkaXRpbmdCZWhhdmlvcigpIGZyb20gbGF5b3V0VGVzdENvbnRyb2xsZXIgdG8gd2luZG93Lmlu dGVybmFscwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tv dXQvc2NtL3N2bi5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3Nj bS9zdm4ucHkKaW5kZXggNmEyZTEzMTliN2I5NDZhOTM0NDllNzI0MDRiYTg0MDU4YTJlNDM4Yi4u Yjc3YTVkMWM4ZmMxMTA4Mzc3OTk2MTJmYjY2ODBkZjg4ZThiY2U5OCAxMDA2NDQKLS0tIGEvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2NtL3N2bi5weQorKysgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9zY20vc3ZuLnB5CkBAIC05MCw4ICs5 MCwxMSBAQCBjbGFzcyBTVk4oU0NNLCBTVk5SZXBvc2l0b3J5KToKICAgICAgICAgICAgIHJldHVy biBUcnVlCiAKICAgICAgICAgc3ZuX2luZm9fYXJncyA9IFtjbHMuZXhlY3V0YWJsZV9uYW1lLCAn aW5mbyddCi0gICAgICAgIGV4aXRfY29kZSA9IEV4ZWN1dGl2ZSgpLnJ1bl9jb21tYW5kKHN2bl9p bmZvX2FyZ3MsIGN3ZD1wYXRoLCByZXR1cm5fZXhpdF9jb2RlPVRydWUpCi0gICAgICAgIHJldHVy biAoZXhpdF9jb2RlID09IDApCisgICAgICAgIHRyeToKKyAgICAgICAgICAgIGV4aXRfY29kZSA9 IEV4ZWN1dGl2ZSgpLnJ1bl9jb21tYW5kKHN2bl9pbmZvX2FyZ3MsIGN3ZD1wYXRoLCByZXR1cm5f ZXhpdF9jb2RlPVRydWUpCisgICAgICAgICAgICByZXR1cm4gKGV4aXRfY29kZSA9PSAwKQorICAg ICAgICBleGNlcHQgT1NFcnJvcjoKKyAgICAgICAgICAgIHJldHVybiBGYWxzZQogCiAgICAgZGVm IGZpbmRfdXVpZChzZWxmLCBwYXRoKToKICAgICAgICAgaWYgbm90IHNlbGYuaW5fd29ya2luZ19k aXJlY3RvcnkocGF0aCk6Cg==