87013 2012-05-21 06:15:36 -0700 [Qt] Mini clean ups in the interaction engine 2012-05-22 05:29:28 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kenneth kenneth hausmann menard webkit.review.bot zalan zoltan oldest_to_newest 629025 0 kenneth 2012-05-21 06:15:36 -0700 SSIA 629026 1 143017 kenneth 2012-05-21 06:16:51 -0700 Created attachment 143017 Patch 629072 2 zalan 2012-05-21 07:13:56 -0700 a little bit unrelated but since you are touching animateItemRectVisible(): it looks like after a few refactorings, it does not need to be public method anymore (neither it's pair setItemRectVisible()) Could you commit them as private, unless there's a good reason to still have them around as public? 630138 3 143017 hausmann 2012-05-22 02:43:39 -0700 Comment on attachment 143017 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143017&action=review I'll have to trust you on the logic and welcome any change that adds test coverage to those magic if statements ;-) > Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp:191 > + ASSERT(m_suspended); I bet Zalan is going to run into this one ;) > Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp:618 > + * FIXME: This is currently called twise if you concurrently change width and height. twise -> twice 630250 4 kenneth 2012-05-22 04:55:00 -0700 Landed in 117952 Sure Zalan will run into the assert :-) that is why we add them! 630282 5 zalan 2012-05-22 05:29:28 -0700 (In reply to comment #4) > Landed in 117952 > > Sure Zalan will run into the assert :-) that is why we add them! and i am so grateful for that. 143017 2012-05-21 06:16:51 -0700 2012-05-22 02:43:39 -0700 Patch bug-87013-20120521151616.patch text/plain 3252 kenneth U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3NzM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggM2ViYzgyNDhjYmRmYjA5 ZGE1OWY5MzQzZGVhODk1N2VlZGQ2ZjMxZi4uYjIxNmY0ZTY4Mzk1NGYyYmFkYTBkMGMzNmYwZTlj MDAxZDUwNzRlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA1LTIxICBLZW5u ZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4KKworICAgICAgICBb UXRdIE1pbmkgY2xlYW4gdXBzIGluIHRoZSBpbnRlcmFjdGlvbiBlbmdpbmUKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3MDEzCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvcXQvUXRWaWV3 cG9ydEludGVyYWN0aW9uRW5naW5lLmNwcDoKKyAgICAgICAgKFdlYktpdDo6UXRWaWV3cG9ydElu dGVyYWN0aW9uRW5naW5lOjphbmltYXRlSXRlbVJlY3RWaXNpYmxlKToKKyAgICAgICAgICAgIEFz c2VydCB0aGF0IHdlIGFyZSBzdXNwZW5kZWQuCisgICAgICAgIChXZWJLaXQ6OlF0Vmlld3BvcnRJ bnRlcmFjdGlvbkVuZ2luZTo6em9vbVRvQXJlYUdlc3R1cmVFbmRlZCk6CisgICAgICAgICAgICBO ZXZlciB6b29tIHRvIGFueSBhcmVhIGlmIHN1c3BlbmRlZCB3aGljaCBpbmRpY2F0ZXMgb3RoZXIK KyAgICAgICAgICAgIGFuaW1hdGlvbiBvciB1c2VyIGludGVyYWN0aW9uLgorICAgICAgICAoV2Vi S2l0OjpRdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmU6OmVuc3VyZUNvbnRlbnRXaXRoaW5WaWV3 cG9ydEJvdW5kYXJ5KToKKyAgICAgICAgICAgIElmIGltbWVkaWF0ZSBpcyBzZXQsIGlnbm9yZSBz dXNwZW5zaW9uLgorICAgICAgICAoV2ViS2l0OjpRdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmU6 Oml0ZW1TaXplQ2hhbmdlZCk6CisgICAgICAgICAgICBJbXByb3ZlIHRoZSBjb21tZW50LgorCiAy MDEyLTA1LTIwICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAog ICAgICAgICBbR1RLXSBBZGQgR0NhbmNlbGxhYmxlIHBhcmFtZXRlciB0byBhbGwgbWV0aG9kcyB1 c2luZyBnaW8gYXN5bmMgcGF0dGVybgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL3F0L1F0Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2luZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvcXQvUXRWaWV3cG9ydEludGVyYWN0aW9uRW5naW5lLmNwcAppbmRleCBlYjNjNWE4 ZDI2OTgyOGIzMzcyYjdmZWUyMmRlYjExN2QxYTVhZTQwLi5iMDQ5Y2ZlYTcxNWU2YThlY2M0ODMz ZDA5ODJkZWM1ZjM5N2RmNTRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv cXQvUXRWaWV3cG9ydEludGVyYWN0aW9uRW5naW5lLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvcXQvUXRWaWV3cG9ydEludGVyYWN0aW9uRW5naW5lLmNwcApAQCAtMTg4LDYgKzE4 OCw4IEBAIHZvaWQgUXRWaWV3cG9ydEludGVyYWN0aW9uRW5naW5lOjpzZXRJdGVtUmVjdFZpc2li bGUoY29uc3QgUVJlY3RGJiBpdGVtUmVjdCkKIAogYm9vbCBRdFZpZXdwb3J0SW50ZXJhY3Rpb25F bmdpbmU6OmFuaW1hdGVJdGVtUmVjdFZpc2libGUoY29uc3QgUVJlY3RGJiBpdGVtUmVjdCkKIHsK KyAgICBBU1NFUlQobV9zdXNwZW5kZWQpOworCiAgICAgUVJlY3RGIGN1cnJlbnRJdGVtUmVjdFZp c2libGUgPSBtX3ZpZXdwb3J0LT5tYXBSZWN0VG9XZWJDb250ZW50KG1fdmlld3BvcnQtPmJvdW5k aW5nUmVjdCgpKTsKICAgICBpZiAoaXRlbVJlY3QgPT0gY3VycmVudEl0ZW1SZWN0VmlzaWJsZSkK ICAgICAgICAgcmV0dXJuIGZhbHNlOwpAQCAtMzM5LDcgKzM0MSw3IEBAIHZvaWQgUXRWaWV3cG9y dEludGVyYWN0aW9uRW5naW5lOjp6b29tVG9BcmVhR2VzdHVyZUVuZGVkKGNvbnN0IFFQb2ludEYm IHRvdWNoUG9pCiAgICAgaWYgKCF0YXJnZXRBcmVhLmlzVmFsaWQoKSkKICAgICAgICAgcmV0dXJu OwogCi0gICAgaWYgKHNjcm9sbEFuaW1hdGlvbkFjdGl2ZSgpIHx8IHNjYWxlQW5pbWF0aW9uQWN0 aXZlKCkpCisgICAgaWYgKG1fc3VzcGVuZENvdW50KQogICAgICAgICByZXR1cm47CiAKICAgICBt X2hhZFVzZXJJbnRlcmFjdGlvbiA9IHRydWU7CkBAIC00MTksNyArNDIxLDcgQEAgdm9pZCBRdFZp ZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmU6Onpvb21Ub0FyZWFHZXN0dXJlRW5kZWQoY29uc3QgUVBv aW50RiYgdG91Y2hQb2kKIAogYm9vbCBRdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmU6OmVuc3Vy ZUNvbnRlbnRXaXRoaW5WaWV3cG9ydEJvdW5kYXJ5KGJvb2wgaW1tZWRpYXRlKQogewotICAgIGlm IChzY3JvbGxBbmltYXRpb25BY3RpdmUoKSB8fCBzY2FsZUFuaW1hdGlvbkFjdGl2ZSgpKQorICAg IGlmICghaW1tZWRpYXRlICYmIChzY3JvbGxBbmltYXRpb25BY3RpdmUoKSB8fCBzY2FsZUFuaW1h dGlvbkFjdGl2ZSgpKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgcXJlYWwgZW5kSXRl bVNjYWxlID0gaXRlbVNjYWxlRnJvbUNTUyhpbm5lckJvdW5kZWRDU1NTY2FsZShjdXJyZW50Q1NT U2NhbGUoKSkpOwpAQCAtNjA5LDkgKzYxMSwxNCBAQCB2b2lkIFF0Vmlld3BvcnRJbnRlcmFjdGlv bkVuZ2luZTo6cGluY2hHZXN0dXJlQ2FuY2VsbGVkKCkKICAgICBtX3NjYWxlVXBkYXRlRGVmZXJy ZXIuY2xlYXIoKTsKIH0KIAorLyoKKyAqIFRoaXMgaXMgY2FsbGVkIGZvciBhbGwgY2hhbmdlcyBv ZiBpdGVtIHNjYWxlLCB3aWR0aCBvciBoZWlnaHQuCisgKiBUaGlzIGlzIGNhbGxlZCB3aGVuIGlu dGVyYWN0aW5nLCBpZS4gZHVyaW5nIGZvciBpbnN0YW5jZSBwaW5jaC16b29taW5nLgorICoKKyAq IEZJWE1FOiBUaGlzIGlzIGN1cnJlbnRseSBjYWxsZWQgdHdpc2UgaWYgeW91IGNvbmN1cnJlbnRs eSBjaGFuZ2Ugd2lkdGggYW5kIGhlaWdodC4KKyAqLwogdm9pZCBRdFZpZXdwb3J0SW50ZXJhY3Rp b25FbmdpbmU6Oml0ZW1TaXplQ2hhbmdlZCgpCiB7Ci0gICAgLy8gRklYTUU6IFRoaXMgbmVlZHMg dG8gYmUgZG9uZSBzbWFydGVyLiBXaGF0IGhhcHBlbnMgaWYgaXQgcmVzaXplcyB3aGVuIHdlIHdl cmUgaW50ZXJhY3Rpbmc/CiAgICAgaWYgKG1fc3VzcGVuZENvdW50KQogICAgICAgICByZXR1cm47 CiAK