86998 2012-05-21 02:18:43 -0700 Web Inspector: expand only neighbors of the highlighted node when revealing it in heap snapshot 2012-05-21 02:49:10 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 yurys yurys apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 628898 0 yurys 2012-05-21 02:18:43 -0700 When a node is being revealed in the summary view of heap snapshot there is no need to populate first N children of the parent element. 628900 1 142973 yurys 2012-05-21 02:20:37 -0700 Created attachment 142973 Patch 628907 2 142973 loislo 2012-05-21 02:38:02 -0700 Comment on attachment 142973 Patch lgtm 628914 3 yurys 2012-05-21 02:49:10 -0700 Committed r117753: <http://trac.webkit.org/changeset/117753> 142973 2012-05-21 02:20:37 -0700 2012-05-21 02:44:21 -0700 Patch bug-86998-20120521132035.patch text/plain 5451 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3NzQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDlhYjE2YWIwOWUwNmJl YzdkMWVlNjQxYTVkNmQ3ZWUzZDc3Y2E2OC4uNjY5ZDg3YWExNTJkMGIwZDIyYWZkNjJlY2Y1M2Zl Y2Y3Y2ZlNWJjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA1LTIxICBZdXJ5 IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGV4cGFuZCBvbmx5IG5laWdoYm9ycyBvZiB0aGUgaGlnaGxpZ2h0ZWQgbm9kZSB3aGVuIHJl dmVhbGluZyBpdCBpbiBoZWFwIHNuYXBzaG90CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD04Njk5OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIE9ubHkgbmVhcmVzdCBub2RlcyBhcmUgZXhwYW5kZWQgd2hlbiBh IG5vZGUgaXMgcmV2ZWFsZWQgaW4gaGVhcCBzbmFwc2hvdAorICAgICAgICBzdW1tYXJ5IHZpZXcu CisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hvdERhdGFHcmlkcy5q czoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3RTb3J0YWJsZURhdGFHcmlkLnBy b3RvdHlwZS5oaWdobGlnaHROb2RlKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5IZWFwU25hcHNo b3RWaWV3cG9ydERhdGFHcmlkLnByb3RvdHlwZS5oaWdobGlnaHROb2RlKToKKyAgICAgICAgKFdl Ykluc3BlY3Rvci5IZWFwU25hcHNob3RWaWV3cG9ydERhdGFHcmlkLnByb3RvdHlwZS5faXNTY3Jv bGxlZEludG9WaWV3KToKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hv dEdyaWROb2Rlcy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3RDb25zdHJ1 Y3Rvck5vZGUucHJvdG90eXBlLnJldmVhbE5vZGVCeVNuYXBzaG90T2JqZWN0SWQpOgorICAgICAg ICAoV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdENvbnN0cnVjdG9yTm9kZS5wcm90b3R5cGUucmV2 ZWFsTm9kZUJ5U25hcHNob3RPYmplY3RJZC5kaWRHZXROb2RlUG9zaXRpb24pOgorICAgICAgICAq IGluc3BlY3Rvci9mcm9udC1lbmQvUHJvZmlsZXNQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3Bl Y3Rvci5Qcm9maWxlc1BhbmVsLnByb3RvdHlwZS5zaG93UHJvZmlsZSk6CisKIDIwMTItMDUtMjEg IEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQs IGJ1aWxkIGZpeC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvSGVhcFNuYXBzaG90RGF0YUdyaWRzLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9IZWFwU25hcHNob3REYXRhR3JpZHMuanMKaW5kZXggYjc3OWU2ZWI0ZmU4OWU3YTRk Y2VjZDliMmZiNmJmMGU0OWY4ODBkMy4uNTIwNDQ5ZTBlNDMzMmE2ODBiZWM0NGEzMzhlYWNkZDg0 NTM0MDliMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9I ZWFwU25hcHNob3REYXRhR3JpZHMuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9IZWFwU25hcHNob3REYXRhR3JpZHMuanMKQEAgLTg2LDkgKzg2LDE4IEBAIFdlYklu c3BlY3Rvci5IZWFwU25hcHNob3RTb3J0YWJsZURhdGFHcmlkLnByb3RvdHlwZSA9IHsKICAgICAg Ki8KICAgICBoaWdobGlnaHROb2RlOiBmdW5jdGlvbihub2RlKQogICAgIHsKKyAgICAgICAgdmFy IHByZXZOb2RlID0gdGhpcy5faGlnaGxpZ2h0ZWROb2RlOwogICAgICAgICB0aGlzLl9jbGVhckN1 cnJlbnRIaWdobGlnaHQoKTsKICAgICAgICAgdGhpcy5faGlnaGxpZ2h0ZWROb2RlID0gbm9kZTsK ICAgICAgICAgdGhpcy5faGlnaGxpZ2h0ZWROb2RlLmVsZW1lbnQuYWRkU3R5bGVDbGFzcygiaGln aGxpZ2h0ZWQtcm93Iik7CisgICAgICAgIC8vIElmIGhpZ2hsaWdodGVkIG5vZGUgaGFzbid0IGNo YW5nZWQgcmVpbnNlcnQgaXQgdG8gbWFrZSB0aGUgaGlnaGxpZ2h0IGFuaW1hdGlvbiByZXN0YXJ0 LgorICAgICAgICBpZiAobm9kZSA9PT0gcHJldk5vZGUpIHsKKyAgICAgICAgICAgIHZhciBlbGVt ZW50ID0gbm9kZS5lbGVtZW50OworICAgICAgICAgICAgdmFyIHBhcmVudCA9IGVsZW1lbnQucGFy ZW50RWxlbWVudDsKKyAgICAgICAgICAgIHZhciBuZXh0U2libGluZyA9IGVsZW1lbnQubmV4dFNp Ymxpbmc7CisgICAgICAgICAgICBwYXJlbnQucmVtb3ZlQ2hpbGQoZWxlbWVudCk7CisgICAgICAg ICAgICBwYXJlbnQuaW5zZXJ0QmVmb3JlKGVsZW1lbnQsIG5leHRTaWJsaW5nKTsKKyAgICAgICAg fQogICAgIH0sCiAKICAgICBub2RlV2FzRGV0YWNoZWQ6IGZ1bmN0aW9uKG5vZGUpCkBAIC0yNzgs OCArMjg3LDIxIEBAIFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3RWaWV3cG9ydERhdGFHcmlkLnBy b3RvdHlwZSA9IHsKICAgICAgKi8KICAgICBoaWdobGlnaHROb2RlOiBmdW5jdGlvbihub2RlKQog ICAgIHsKLSAgICAgICAgbm9kZS5lbGVtZW50LnNjcm9sbEludG9WaWV3SWZOZWVkZWQodHJ1ZSk7 Ci0gICAgICAgIHRoaXMuX25vZGVUb0hpZ2hsaWdodEFmdGVyU2Nyb2xsID0gbm9kZTsKKyAgICAg ICAgaWYgKHRoaXMuX2lzU2Nyb2xsZWRJbnRvVmlldyhub2RlLmVsZW1lbnQpKQorICAgICAgICAg ICAgV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdFNvcnRhYmxlRGF0YUdyaWQucHJvdG90eXBlLmhp Z2hsaWdodE5vZGUuY2FsbCh0aGlzLCBub2RlKTsKKyAgICAgICAgZWxzZSB7CisgICAgICAgICAg ICBub2RlLmVsZW1lbnQuc2Nyb2xsSW50b1ZpZXdJZk5lZWRlZCh0cnVlKTsKKyAgICAgICAgICAg IHRoaXMuX25vZGVUb0hpZ2hsaWdodEFmdGVyU2Nyb2xsID0gbm9kZTsKKyAgICAgICAgfQorICAg IH0sCisKKyAgICBfaXNTY3JvbGxlZEludG9WaWV3OiBmdW5jdGlvbihlbGVtZW50KQorICAgIHsK KyAgICAgICAgdmFyIHZpZXdwb3J0VG9wID0gdGhpcy5zY3JvbGxDb250YWluZXIuc2Nyb2xsVG9w OworICAgICAgICB2YXIgdmlld3BvcnRCb3R0b20gPSB2aWV3cG9ydFRvcCArIHRoaXMuc2Nyb2xs Q29udGFpbmVyLmNsaWVudEhlaWdodDsKKyAgICAgICAgdmFyIGVsZW1Ub3AgPSBlbGVtZW50Lm9m ZnNldFRvcAorICAgICAgICB2YXIgZWxlbUJvdHRvbSA9IGVsZW1Ub3AgKyBlbGVtZW50Lm9mZnNl dEhlaWdodDsKKyAgICAgICAgcmV0dXJuIGVsZW1Cb3R0b20gPD0gdmlld3BvcnRCb3R0b20gJiYg ZWxlbVRvcCA+PSB2aWV3cG9ydFRvcDsKICAgICB9LAogCiAgICAgX2FkZFBhZGRpbmdSb3dzOiBm dW5jdGlvbih0b3AsIGJvdHRvbSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvSGVhcFNuYXBzaG90R3JpZE5vZGVzLmpzIGIvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9IZWFwU25hcHNob3RHcmlkTm9kZXMuanMKaW5kZXggZWYyNjBiY2Q5 MGE5YzgwNTNhMjY5MWFjZTU0OWEyZWM3OTdmMzUwYS4uNDQ4YTFlOTBkYjYxOTMzYWVmYzlmY2Qw NmY1YzQ4MWQ1MTFkNDM2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9IZWFwU25hcHNob3RHcmlkTm9kZXMuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9IZWFwU25hcHNob3RHcmlkTm9kZXMuanMKQEAgLTcyOCw5ICs3Mjgs MTcgQEAgV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdENvbnN0cnVjdG9yTm9kZS5wcm90b3R5cGUg PSB7CiAgICAgICovCiAgICAgcmV2ZWFsTm9kZUJ5U25hcHNob3RPYmplY3RJZDogZnVuY3Rpb24o c25hcHNob3RPYmplY3RJZCkKICAgICB7CisgICAgICAgIGZ1bmN0aW9uIGRpZEV4cGFuZCgpCisg ICAgICAgIHsKKyAgICAgICAgICAgIHRoaXMuX3Byb3ZpZGVyLm5vZGVQb3NpdGlvbihzbmFwc2hv dE9iamVjdElkLCBkaWRHZXROb2RlUG9zaXRpb24uYmluZCh0aGlzKSk7CisgICAgICAgIH0KKwog ICAgICAgICBmdW5jdGlvbiBkaWRHZXROb2RlUG9zaXRpb24obm9kZVBvc2l0aW9uKQogICAgICAg ICB7Ci0gICAgICAgICAgICBpZiAobm9kZVBvc2l0aW9uICE9PSAtMSkKKyAgICAgICAgICAgIGlm IChub2RlUG9zaXRpb24gPT09IC0xKSB7CisgICAgICAgICAgICAgICAgdGhpcy5jb2xsYXBzZSgp OworICAgICAgICAgICAgICAgIGNhbGxiYWNrKG51bGwpOworICAgICAgICAgICAgfSBlbHNlCiAg ICAgICAgICAgICAgICAgdGhpcy5fcG9wdWxhdGVDaGlsZHJlbihub2RlUG9zaXRpb24sIG51bGws IGRpZFBvcHVsYXRlQ2hpbGRyZW4uYmluZCh0aGlzLCBub2RlUG9zaXRpb24pKTsKICAgICAgICAg fQogCkBAIC03NDksOCArNzU3LDcgQEAgV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdENvbnN0cnVj dG9yTm9kZS5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KIAotICAgICAg ICB0aGlzLmV4cGFuZCgpOwotICAgICAgICB0aGlzLl9wcm92aWRlci5ub2RlUG9zaXRpb24oc25h cHNob3RPYmplY3RJZCwgZGlkR2V0Tm9kZVBvc2l0aW9uLmJpbmQodGhpcykpOworICAgICAgICB0 aGlzLmV4cGFuZFdpdGhvdXRQb3B1bGF0ZShkaWRFeHBhbmQuYmluZCh0aGlzKSk7CiAgICAgfSwK IAogICAgIGNyZWF0ZUNlbGw6IGZ1bmN0aW9uKGNvbHVtbklkZW50aWZpZXIpCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Byb2ZpbGVzUGFuZWwuanMgYi9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Byb2ZpbGVzUGFuZWwuanMKaW5kZXgg YzZiNTE4ODVkMDc2ZDY0NWNiYTVjYmQ4Mzk1NTk1Y2JjNjg0N2NiMi4uMjA1MjRmMTE5ZjMzY2Vl ZWRhZjUxYTRkNzliM2RkZDM2NjE2MGE1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9Qcm9maWxlc1BhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvUHJvZmlsZXNQYW5lbC5qcwpAQCAtNTU4LDkgKzU1OCwxMSBAQCBX ZWJJbnNwZWN0b3IuUHJvZmlsZXNQYW5lbC5wcm90b3R5cGUgPSB7CiAgICAgICAgIGlmICghcHJv ZmlsZSB8fCBwcm9maWxlLmlzVGVtcG9yYXJ5KQogICAgICAgICAgICAgcmV0dXJuOwogCi0gICAg ICAgIHRoaXMuY2xvc2VWaXNpYmxlVmlldygpOwotCiAgICAgICAgIHZhciB2aWV3ID0gcHJvZmls ZS52aWV3KCk7CisgICAgICAgIGlmICh2aWV3ID09PSB0aGlzLnZpc2libGVWaWV3KQorICAgICAg ICAgICAgcmV0dXJuOworCisgICAgICAgIHRoaXMuY2xvc2VWaXNpYmxlVmlldygpOwogCiAgICAg ICAgIHZpZXcuc2hvdyh0aGlzLnByb2ZpbGVWaWV3cyk7CiAK