86982 2012-05-20 20:22:51 -0700 [EFL] Do not enable Web Audio support by default at build time. 2012-05-21 12:23:58 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rakuco rakuco dbates dw.im gyuyoung.kim lucas.de.marchi pnormand s.choi webkit.review.bot oldest_to_newest 628734 0 rakuco 2012-05-20 20:22:51 -0700 [EFL] Do not enable Web Audio support by default at build time. 628735 1 142937 rakuco 2012-05-20 20:25:44 -0700 Created attachment 142937 Patch 628956 2 142937 gyuyoung.kim 2012-05-21 04:30:08 -0700 Comment on attachment 142937 Patch Looks fine. 629320 3 142937 pnormand 2012-05-21 11:45:02 -0700 Comment on attachment 142937 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142937&action=review > ChangeLog:13 > + Since Web Audio support for the EFL port does not seem to be fully > + working yet, it is better to disable it in all cases. I'm curious, what' s missing? AFAIK only the DRT support is missing on mac and gtk for this, see bug 67187 629343 4 rakuco 2012-05-21 11:57:07 -0700 (In reply to comment #3) > (From update of attachment 142937 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=142937&action=review > > > ChangeLog:13 > > + Since Web Audio support for the EFL port does not seem to be fully > > + working yet, it is better to disable it in all cases. > > I'm curious, what' s missing? AFAIK only the DRT support is missing on mac and gtk for this, see bug 67187 Probably that. I tried running the webaudio/ layout tests with web audio support enabled and they did not work. Then looking at the commit which added web audio support for the EFL port I noticed this build system inconsistency. 629379 5 142937 webkit.review.bot 2012-05-21 12:23:53 -0700 Comment on attachment 142937 Patch Clearing flags on attachment: 142937 Committed r117807: <http://trac.webkit.org/changeset/117807> 629380 6 webkit.review.bot 2012-05-21 12:23:58 -0700 All reviewed patches have been landed. Closing bug. 142937 2012-05-20 20:25:44 -0700 2012-05-21 12:23:53 -0700 Patch bug-86982-20120521002541.patch text/plain 1698 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3NzE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0VmbC5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCmluZGV4IGQ4NDhj OThlZGQ5YzYxMzA2ZGRlMTVkMjhkNDEzOGI0NDY5YmFlNjkuLjc4Y2EzZGE1N2I5NzBiNzYwN2Ew N2ZkOTJjODk2NGMxNmFkNDA0OWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZs LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCkBAIC04MCw3ICs4MCw2 IEBAIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9TSEFSRURfV09SS0VS UyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9WSUJSQVRJT04g T04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfVklERU8gT04pCiBX RUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfVklERU9fVFJBQ0sgT04pCi1X RUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfV0VCX0FVRElPIE9OKQogV0VC S0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1dFQl9USU1JTkcgT04pCiBXRUJL SVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfV09SS0VSUyBPTikKIFdFQktJVF9P UFRJT05fRU5EKCkKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAwNjIy OTk5MjQyNjhmYWM2ZWNkMDRlY2ZjYTA2ZmY3MTdjNmUzNjcxLi45NDczMGNhYjc1Yjc1NGZjNmY0 ODMzMjVmMDAwN2Y2MDIxNzhkN2Q5IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTItMDUtMjAgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAg PHJha3Vjb0B3ZWJraXQub3JnPgorCisgICAgICAgIFtFRkxdIERvIG5vdCBlbmFibGUgV2ViIEF1 ZGlvIHN1cHBvcnQgYnkgZGVmYXVsdCBhdCBidWlsZCB0aW1lLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODY5ODIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGb2xsb3ctdXAgdG8gcjExNTgwMC4gRXZlbiB0 aG91Z2ggV2ViIEF1ZGlvIHN1cHBvcnQgaXMgZGlzYWJsZWQgYnkKKyAgICAgICAgZGVmYXVsdCBp biBidWlsZC13ZWJraXQsIGVuYWJsaW5nIGl0IGluIE9wdGlvbnNFZmwuY21ha2Ugd2lsbCB0dXJu CisgICAgICAgIGl0IG9uIHdoZW4gYnVpbGRpbmcgdGhlIHBvcnQgd2l0aG91dCBidWlsZC13ZWJr aXQuCisKKyAgICAgICAgU2luY2UgV2ViIEF1ZGlvIHN1cHBvcnQgZm9yIHRoZSBFRkwgcG9ydCBk b2VzIG5vdCBzZWVtIHRvIGJlIGZ1bGx5CisgICAgICAgIHdvcmtpbmcgeWV0LCBpdCBpcyBiZXR0 ZXIgdG8gZGlzYWJsZSBpdCBpbiBhbGwgY2FzZXMuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2Uv T3B0aW9uc0VmbC5jbWFrZTogUmVtb3ZlIG9wdGlvbiBvdmVycmlkZSBmb3IKKyAgICAgICAgRU5B QkxFX1dFQl9BVURJTy4KKwogMjAxMi0wNS0yMCAgS2V2aW4gT2xsaXZpZXIgIDxrZXZpbm9AdGhl b2xsaXZpZXJzLmNvbT4KIAogICAgICAgICBbd3hdIFVucmV2aWV3ZWQgYnVpbGQgZml4LiBDbGVh biB1cCBubyBsb25nZXIgdXNlZCBmaWxlcyBpbiBEZXJpdmVkU291cmNlcy4K