86978 2012-05-20 18:47:07 -0700 [V8] Pass Isolate to V8Utilities::createFunctionCallback() 2012-05-20 22:53:05 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 84074 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 628708 0 haraken 2012-05-20 18:47:07 -0700 The objective is to pass Isolate around in V8 bindings. In this bug we pass Isolate to V8Utilities::createFunctionCallback(). 628710 1 142933 haraken 2012-05-20 18:48:36 -0700 Created attachment 142933 Patch 628790 2 142933 webkit.review.bot 2012-05-20 22:53:00 -0700 Comment on attachment 142933 Patch Clearing flags on attachment: 142933 Committed r117730: <http://trac.webkit.org/changeset/117730> 628791 3 webkit.review.bot 2012-05-20 22:53:05 -0700 All reviewed patches have been landed. Closing bug. 142933 2012-05-20 18:48:36 -0700 2012-05-20 22:53:00 -0700 Patch bug-86978-20120521104835.patch text/plain 6505 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3NzE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTZiZWE0YWZiZDFlZjhk MTY2ZjY2MzU1YmZlMDJiNDdhZWMzMjg1OC4uMjdjNDc5ZDFmODQ3NDQyZmRmMTYwYjkwMTNlM2M5 ZWIxZjFlN2M1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTA1LTIwICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFBhc3MgSXNv bGF0ZSB0byBWOFV0aWxpdGllczo6Y3JlYXRlRnVuY3Rpb25DYWxsYmFjaygpCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04Njk3OAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBvYmplY3RpdmUgaXMgdG8g cGFzcyBJc29sYXRlIGFyb3VuZCBpbiBWOCBiaW5kaW5ncy4KKyAgICAgICAgVGhpcyBwYXRjaCBw YXNzZXMgSXNvbGF0ZSB0byBWOFV0aWxpdGllczo6Y3JlYXRlRnVuY3Rpb25DYWxsYmFjaygpLgor CisgICAgICAgIE5vIHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBi aW5kaW5ncy92OC9WOFV0aWxpdGllcy5jcHA6CisgICAgICAgIChXZWJDb3JlOjp0aHJvd1R5cGVN aXNtYXRjaEV4Y2VwdGlvbik6CisgICAgICAgICogYmluZGluZ3MvdjgvVjhVdGlsaXRpZXMuaDoK KyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6Y3JlYXRlRnVuY3Rpb25Pbmx5 Q2FsbGJhY2spOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOEdlb2xvY2F0aW9uQ3Vz dG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4R2VvbG9jYXRpb246OmdldEN1cnJlbnRQb3Np dGlvbkNhbGxiYWNrKToKKyAgICAgICAgKFdlYkNvcmU6OlY4R2VvbG9jYXRpb246OndhdGNoUG9z aXRpb25DYWxsYmFjayk6CisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4Tm90aWZpY2F0 aW9uQ3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4Tm90aWZpY2F0aW9uOjpyZXF1ZXN0 UGVybWlzc2lvbkNhbGxiYWNrKToKKwogMjAxMi0wNS0yMCAgR2VvcmdlIFN0YWlrb3MgIDxzdGFp a29zQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVXNlIHJlaW50ZXJwcmV0X2Nhc3RfcHRyPD4gdG8g Zml4IGFuIGFsaWdubWVudCB3YXJuaW5nLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvdjgvVjhVdGlsaXRpZXMuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhV dGlsaXRpZXMuY3BwCmluZGV4IDYzNjRlZmM2YTc0ZjMzMjc2N2VjOTQxOGNjOTJhMzBlNDgyYWMx N2UuLmM4MzJjOTllZDNmM2U1ZTQ0M2Y1ZjhhZjlmMjA2ZTI0YzRmMGViNmUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4VXRpbGl0aWVzLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy92OC9WOFV0aWxpdGllcy5jcHAKQEAgLTIwMiw5ICsyMDIsOSBAQCBT Y3JpcHRFeGVjdXRpb25Db250ZXh0KiBnZXRTY3JpcHRFeGVjdXRpb25Db250ZXh0KCkKICAgICBy ZXR1cm4gMDsKIH0KIAotdm9pZCB0aHJvd1R5cGVNaXNtYXRjaEV4Y2VwdGlvbigpCit2b2lkIHRo cm93VHlwZU1pc21hdGNoRXhjZXB0aW9uKHY4OjpJc29sYXRlKiBpc29sYXRlKQogewotICAgIFY4 UHJveHk6OnRocm93RXJyb3IoVjhQcm94eTo6R2VuZXJhbEVycm9yLCAiVFlQRV9NSVNNQVRDSF9F UlI6IERPTSBFeGNlcHRpb24gMTciKTsKKyAgICBWOFByb3h5Ojp0aHJvd0Vycm9yKFY4UHJveHk6 OkdlbmVyYWxFcnJvciwgIlRZUEVfTUlTTUFUQ0hfRVJSOiBET00gRXhjZXB0aW9uIDE3IiwgaXNv bGF0ZSk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4VXRpbGl0aWVzLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy92OC9WOFV0aWxpdGllcy5oCmluZGV4IDQ2ZGEzMTkzNDQ5MjAxZjQ4NmQzY2ZiOWM3MzExYjZm N2I3ZGE3MmQuLjRjMTEwOTA5ZmM4MTVjNzIzZjMwZjNmNzE3ZTczNjdmZjE5NTUzMTcgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4VXRpbGl0aWVzLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhVdGlsaXRpZXMuaApAQCAtNjAsNyArNjAsNyBAQCBu YW1lc3BhY2UgV2ViQ29yZSB7CiAKICAgICBTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBnZXRTY3Jp cHRFeGVjdXRpb25Db250ZXh0KCk7CiAKLSAgICB2b2lkIHRocm93VHlwZU1pc21hdGNoRXhjZXB0 aW9uKCk7CisgICAgdm9pZCB0aHJvd1R5cGVNaXNtYXRjaEV4Y2VwdGlvbih2ODo6SXNvbGF0ZSop OwogCiAgICAgZW51bSBDYWxsYmFja0FsbG93ZWRWYWx1ZUZsYWcgewogICAgICAgICBDYWxsYmFj a0FsbG93VW5kZWZpbmVkID0gMSwKQEAgLTkwLDcgKzkwLDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUg ewogCiAgICAgLy8gJ0Z1bmN0aW9uT25seScgaXMgYXNzdW1lZCBmb3IgdGhlIGNyZWF0ZWQgY2Fs bGJhY2suCiAgICAgdGVtcGxhdGUgPHR5cGVuYW1lIFY4Q2FsbGJhY2tUeXBlPgotICAgIFBhc3NS ZWZQdHI8VjhDYWxsYmFja1R5cGU+IGNyZWF0ZUZ1bmN0aW9uT25seUNhbGxiYWNrKHY4OjpMb2Nh bDx2ODo6VmFsdWU+IHZhbHVlLCBib29sJiBzdWNjZWVkZWQsIENhbGxiYWNrQWxsb3dlZFZhbHVl RmxhZ3MgYWNjZXB0ZWRWYWx1ZXMgPSAwKQorICAgIFBhc3NSZWZQdHI8VjhDYWxsYmFja1R5cGU+ IGNyZWF0ZUZ1bmN0aW9uT25seUNhbGxiYWNrKHY4OjpMb2NhbDx2ODo6VmFsdWU+IHZhbHVlLCBi b29sJiBzdWNjZWVkZWQsIHY4OjpJc29sYXRlKiBpc29sYXRlLCBDYWxsYmFja0FsbG93ZWRWYWx1 ZUZsYWdzIGFjY2VwdGVkVmFsdWVzID0gMCkKICAgICB7CiAgICAgICAgIHN1Y2NlZWRlZCA9IHRy dWU7CiAKQEAgLTEwMiw3ICsxMDIsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICAgICAgICAg aWYgKCF2YWx1ZS0+SXNGdW5jdGlvbigpKSB7CiAgICAgICAgICAgICBzdWNjZWVkZWQgPSBmYWxz ZTsKLSAgICAgICAgICAgIHRocm93VHlwZU1pc21hdGNoRXhjZXB0aW9uKCk7CisgICAgICAgICAg ICB0aHJvd1R5cGVNaXNtYXRjaEV4Y2VwdGlvbihpc29sYXRlKTsKICAgICAgICAgICAgIHJldHVy biAwOwogICAgICAgICB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L2N1c3RvbS9WOEdlb2xvY2F0aW9uQ3VzdG9tLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3Y4L2N1c3RvbS9WOEdlb2xvY2F0aW9uQ3VzdG9tLmNwcAppbmRleCA4MjdjYzNkNjUzZTA2NmFi MDhlNTQ3YzViMDZlMmFlMTRkNzg3NWY4Li4zNzM0YTIzZDVhYjQ2M2U1YWVhZWQ4N2NmYWQ0YWJj NDc3ZjVkYTc2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20v VjhHZW9sb2NhdGlvbkN1c3RvbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvdjgv Y3VzdG9tL1Y4R2VvbG9jYXRpb25DdXN0b20uY3BwCkBAIC0xMzMsMTMgKzEzMywxMyBAQCB2ODo6 SGFuZGxlPHY4OjpWYWx1ZT4gVjhHZW9sb2NhdGlvbjo6Z2V0Q3VycmVudFBvc2l0aW9uQ2FsbGJh Y2soY29uc3Qgdjg6OkFyZ3VtZQogCiAgICAgYm9vbCBzdWNjZWVkZWQgPSBmYWxzZTsKIAotICAg IFJlZlB0cjxQb3NpdGlvbkNhbGxiYWNrPiBwb3NpdGlvbkNhbGxiYWNrID0gY3JlYXRlRnVuY3Rp b25Pbmx5Q2FsbGJhY2s8VjhQb3NpdGlvbkNhbGxiYWNrPihhcmdzWzBdLCBzdWNjZWVkZWQpOwor ICAgIFJlZlB0cjxQb3NpdGlvbkNhbGxiYWNrPiBwb3NpdGlvbkNhbGxiYWNrID0gY3JlYXRlRnVu Y3Rpb25Pbmx5Q2FsbGJhY2s8VjhQb3NpdGlvbkNhbGxiYWNrPihhcmdzWzBdLCBzdWNjZWVkZWQs IGFyZ3MuR2V0SXNvbGF0ZSgpKTsKICAgICBpZiAoIXN1Y2NlZWRlZCkKICAgICAgICAgcmV0dXJu IHY4OjpVbmRlZmluZWQoKTsKICAgICBBU1NFUlQocG9zaXRpb25DYWxsYmFjayk7CiAKICAgICAv LyBBcmd1bWVudCBpcyBvcHRpb25hbCAoaGVuY2UgdW5kZWZpbmVkIGlzIGFsbG93ZWQpLCBhbmQg bnVsbCBpcyBhbGxvd2VkLgotICAgIFJlZlB0cjxQb3NpdGlvbkVycm9yQ2FsbGJhY2s+IHBvc2l0 aW9uRXJyb3JDYWxsYmFjayA9IGNyZWF0ZUZ1bmN0aW9uT25seUNhbGxiYWNrPFY4UG9zaXRpb25F cnJvckNhbGxiYWNrPihhcmdzWzFdLCBzdWNjZWVkZWQsIENhbGxiYWNrQWxsb3dVbmRlZmluZWQg fCBDYWxsYmFja0FsbG93TnVsbCk7CisgICAgUmVmUHRyPFBvc2l0aW9uRXJyb3JDYWxsYmFjaz4g cG9zaXRpb25FcnJvckNhbGxiYWNrID0gY3JlYXRlRnVuY3Rpb25Pbmx5Q2FsbGJhY2s8VjhQb3Np dGlvbkVycm9yQ2FsbGJhY2s+KGFyZ3NbMV0sIHN1Y2NlZWRlZCwgYXJncy5HZXRJc29sYXRlKCks IENhbGxiYWNrQWxsb3dVbmRlZmluZWQgfCBDYWxsYmFja0FsbG93TnVsbCk7CiAgICAgaWYgKCFz dWNjZWVkZWQpCiAgICAgICAgIHJldHVybiB2ODo6VW5kZWZpbmVkKCk7CiAKQEAgLTE1OSwxMyAr MTU5LDEzIEBAIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBWOEdlb2xvY2F0aW9uOjp3YXRjaFBvc2l0 aW9uQ2FsbGJhY2soY29uc3Qgdjg6OkFyZ3VtZW50cyYKIAogICAgIGJvb2wgc3VjY2VlZGVkID0g ZmFsc2U7CiAKLSAgICBSZWZQdHI8UG9zaXRpb25DYWxsYmFjaz4gcG9zaXRpb25DYWxsYmFjayA9 IGNyZWF0ZUZ1bmN0aW9uT25seUNhbGxiYWNrPFY4UG9zaXRpb25DYWxsYmFjaz4oYXJnc1swXSwg c3VjY2VlZGVkKTsKKyAgICBSZWZQdHI8UG9zaXRpb25DYWxsYmFjaz4gcG9zaXRpb25DYWxsYmFj ayA9IGNyZWF0ZUZ1bmN0aW9uT25seUNhbGxiYWNrPFY4UG9zaXRpb25DYWxsYmFjaz4oYXJnc1sw XSwgc3VjY2VlZGVkLCBhcmdzLkdldElzb2xhdGUoKSk7CiAgICAgaWYgKCFzdWNjZWVkZWQpCiAg ICAgICAgIHJldHVybiB2ODo6VW5kZWZpbmVkKCk7CiAgICAgQVNTRVJUKHBvc2l0aW9uQ2FsbGJh Y2spOwogCiAgICAgLy8gQXJndW1lbnQgaXMgb3B0aW9uYWwgKGhlbmNlIHVuZGVmaW5lZCBpcyBh bGxvd2VkKSwgYW5kIG51bGwgaXMgYWxsb3dlZC4KLSAgICBSZWZQdHI8UG9zaXRpb25FcnJvckNh bGxiYWNrPiBwb3NpdGlvbkVycm9yQ2FsbGJhY2sgPSBjcmVhdGVGdW5jdGlvbk9ubHlDYWxsYmFj azxWOFBvc2l0aW9uRXJyb3JDYWxsYmFjaz4oYXJnc1sxXSwgc3VjY2VlZGVkLCBDYWxsYmFja0Fs bG93VW5kZWZpbmVkIHwgQ2FsbGJhY2tBbGxvd051bGwpOworICAgIFJlZlB0cjxQb3NpdGlvbkVy cm9yQ2FsbGJhY2s+IHBvc2l0aW9uRXJyb3JDYWxsYmFjayA9IGNyZWF0ZUZ1bmN0aW9uT25seUNh bGxiYWNrPFY4UG9zaXRpb25FcnJvckNhbGxiYWNrPihhcmdzWzFdLCBzdWNjZWVkZWQsIGFyZ3Mu R2V0SXNvbGF0ZSgpLCBDYWxsYmFja0FsbG93VW5kZWZpbmVkIHwgQ2FsbGJhY2tBbGxvd051bGwp OwogICAgIGlmICghc3VjY2VlZGVkKQogICAgICAgICByZXR1cm4gdjg6OlVuZGVmaW5lZCgpOwog CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhOb3RpZmlj YXRpb25DdXN0b20uY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4Tm90 aWZpY2F0aW9uQ3VzdG9tLmNwcAppbmRleCA5ZTRhZGQ3YThmMWM5NjlkMWUyOGNmMzRhZjdlMmI2 YTVmMjk0NmNkLi5mZmMzOGFhNzJmOTg4MDJiMjI1ZWRkMjIzNTFiZDc0N2UwZjI2MWNjIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhOb3RpZmljYXRpb25D dXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOE5vdGlm aWNhdGlvbkN1c3RvbS5jcHAKQEAgLTM5LDcgKzM5LDcgQEAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+ IFY4Tm90aWZpY2F0aW9uOjpyZXF1ZXN0UGVybWlzc2lvbkNhbGxiYWNrKGNvbnN0IHY4OjpBcmd1 bWUKICAgICBJTkNfU1RBVFMoTCJET00uTm90aWZpY2F0aW9uLnJlcXVlc3RQZXJtaXNzaW9uIik7 CiAKICAgICBib29sIHN1Y2NlZWRlZCA9IGZhbHNlOwotICAgIFJlZlB0cjxWOE5vdGlmaWNhdGlv blBlcm1pc3Npb25DYWxsYmFjaz4gY2FsbGJhY2sgPSBjcmVhdGVGdW5jdGlvbk9ubHlDYWxsYmFj azxWOE5vdGlmaWNhdGlvblBlcm1pc3Npb25DYWxsYmFjaz4oYXJnc1swXSwgc3VjY2VlZGVkKTsK KyAgICBSZWZQdHI8VjhOb3RpZmljYXRpb25QZXJtaXNzaW9uQ2FsbGJhY2s+IGNhbGxiYWNrID0g Y3JlYXRlRnVuY3Rpb25Pbmx5Q2FsbGJhY2s8VjhOb3RpZmljYXRpb25QZXJtaXNzaW9uQ2FsbGJh Y2s+KGFyZ3NbMF0sIHN1Y2NlZWRlZCwgYXJncy5HZXRJc29sYXRlKCkpOwogICAgIGlmICghc3Vj Y2VlZGVkKQogICAgICAgICByZXR1cm4gdjg6OlVuZGVmaW5lZCgpOwogICAgIEFTU0VSVChjYWxs YmFjayk7Cg==