86974 2012-05-20 16:13:19 -0700 [Qt][Wk2] Assertion failure when selecting an option in select list with size attribute greater than one 2012-05-23 12:43:17 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dinu.jacob webkit-unassigned cmarcelo menard webkit.review.bot zoltan oldest_to_newest 628651 0 dinu.jacob 2012-05-20 16:13:19 -0700 Assertion failure when selecting an option from a select list that has the size attribute set to a value greater than one: <select id="sel" name="cars" size=2 > <option value="volvo" selected="selected">Volvo</option> <option value="ford" >Ford</option> <option value="toyota">Toyota </option> </select> ASSERTION FAILED: i < size() Source/WTF/wtf/Vector.h(527) : T& WTF::Vector<T, inlineCapacity>::at(size_t) [with T = WebKit::PopupMenuItemModel::Item, unsigned int inlineCapacity = 0u, size_t = unsigned int] 1 0xb72398e4 WebKitBuild/Debug/lib/libWebKit2.so.1(_ZN3WTF6VectorIN6WebKit18PopupMenuItemModel4ItemELj0EE2atEj+0x56) [0xb72398e4] 2 0xb723942c WebKitBuild/Debug/lib/libWebKit2.so.1(_ZN3WTF6VectorIN6WebKit18PopupMenuItemModel4ItemELj0EEixEj+0x24) [0xb723942c] 3 0xb7237f1c WebKitBuild/Debug/lib/libWebKit2.so.1(_ZN6WebKit18PopupMenuItemModel6selectEi+0x98) [0xb7237f1c] 4 0xb7237a3b WebKitBuild/Debug/lib/libWebKit2.so.1(_ZN6WebKit25ItemSelectorContextObject6acceptEi+0x2d) [0xb7237a3b] 5 0xb7238db9 WebKitBuild/Debug/lib/libWebKit2.so.1(+0x6cddb9) [0xb7238db9] 6 0xb7238f66 WebKitBuild/Debug/lib/libWebKit2.so.1(_ZN6WebKit25ItemSelectorContextObject11qt_metacallEN11QMetaObject4CallEiPPv+0x70) [0xb7238f66] 628655 1 dinu.jacob 2012-05-20 16:30:15 -0700 Select list with size attribute value of greater than one and no option pre-selected will not have any option in selected state initially. This will cause m_selectedModelIndex to be -1. On selecting an option from the list will result in accessing an item from the list of options with this invalid index resulting in the assertion. 628658 2 142925 dinu.jacob 2012-05-20 16:33:22 -0700 Created attachment 142925 Patch 631079 3 142925 cmarcelo 2012-05-22 19:11:26 -0700 Comment on attachment 142925 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142925&action=review Nice catch! Looks good to me, with a comment. > Source/WebKit2/UIProcess/qt/WebPopupMenuProxyQt.cpp:192 > + emit dataChanged(this->index(oldIndex), this->index(oldIndex)); I think is better to keep the signal emission where it was, after we update the new selected item. This way, if someone reacts to the dataChanged, our model will be in a consistent state. 631633 4 143562 dinu.jacob 2012-05-23 07:04:27 -0700 Created attachment 143562 Patch 631635 5 dinu.jacob 2012-05-23 07:06:12 -0700 (In reply to comment #3) > (From update of attachment 142925 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=142925&action=review > > Nice catch! Looks good to me, with a comment. > > > Source/WebKit2/UIProcess/qt/WebPopupMenuProxyQt.cpp:192 > > + emit dataChanged(this->index(oldIndex), this->index(oldIndex)); > > I think is better to keep the signal emission where it was, after we update the new selected item. This way, if someone reacts to the dataChanged, our model will be in a consistent state. Changed to emit the signals after updating the states. 631919 6 143562 webkit.review.bot 2012-05-23 12:43:12 -0700 Comment on attachment 143562 Patch Clearing flags on attachment: 143562 Committed r118228: <http://trac.webkit.org/changeset/118228> 631920 7 webkit.review.bot 2012-05-23 12:43:17 -0700 All reviewed patches have been landed. Closing bug. 142925 2012-05-20 16:33:22 -0700 2012-05-23 07:04:27 -0700 Patch 86974.patch text/plain 3769 dinu.jacob ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA1NTRmNWVmLi4yMGQ0ZGM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTItMDUtMjAgIERpbnUgSmFjb2IgIDxkaW51LmphY29iQG5va2lhLmNvbT4KKworICAg ICAgICBbUXRdW1drMl0gQXNzZXJ0aW9uIGZhaWx1cmUgd2hlbiBzZWxlY3RpbmcgYW4gb3B0aW9u IGluIHNlbGVjdCBsaXN0IHdpdGggc2l6ZSBhdHRyaWJ1dGUgZ3JlYXRlciB0aGFuIG9uZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODY5NzQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTZWxlY3QgbGlzdCB3 aXRoIHNpemUgYXR0cmlidXRlIGdyZWF0ZXIgdGhhbiBvbmUgd2lsbCBub3QgaW5pdGlhbGx5IGhh dmUgYW55IAorICAgICAgICBpdGVtIGluIHNlbGVjdGVkIHN0YXRlIChpZiBubyBvcHRpb24gaGFz ICdzZWxlY3RlZCcgdGFnKSwgcmVzdWx0aW5nIGluIAorICAgICAgICBtX3NlbGVjdGVkTW9kZWxJ bmRleCBpbiBXZWJQb3B1cE1lbnVQcm94eVF0IHRvIGJlIGludmFsaWQuIEhlbmNlLCBuZWVkIHRv IGNoZWNrIAorICAgICAgICB3aGV0aGVyIHRoZSBvbGQgaW5kZXggaXMgaW52YWxpZCBiZWZvcmUg YWNjZXNzaW5nIHRoZSBpdGVtIGF0IHRoYXQgaW5kZXguCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL3F0L3Rlc3RzL3FtbHRlc3RzL0Rlc2t0b3BCZWhhdmlvci90c3RfaXRlbVNlbGVjdG9yLnFt bDogQWRkZWQgbmV3IHRlc3QgdGhhdAorICAgICAgICAgIHRlc3RzIHNlbGVjdGlvbiBpbiBhIHNl bGVjdCBsaXN0IHdpdGggc2l6ZSBhdHRyaWJ1dGUgdmFsdWUgb2YgMi4KKyAgICAgICAgKiBVSVBy b2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL2NvbW1vbi9zZWxlY3R3aXRoc2l6ZS5odG1sOiBB ZGRlZC4KKyAgICAgICAgKiBVSVByb2Nlc3MvcXQvV2ViUG9wdXBNZW51UHJveHlRdC5jcHA6IENo ZWNrIHdoZXRoZXIgb2xkIGluZGV4IGlzIHZhbGlkIGJlZm9yZSBhY2Nlc3NpbmcKKyAgICAgICAg ICB0aGUgaXRlbSBhdCB0aGF0IGluZGV4LgorICAgICAgICAoV2ViS2l0OjpQb3B1cE1lbnVJdGVt TW9kZWw6OnNlbGVjdCk6CisKIDIwMTItMDUtMTkgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUu Y29tPgogCiAgICAgICAgIFVzZSBVU0VfQVBQS0lUIGFuZCBVU0VfU0VDVVJJVFlfRlJBTUVXT1JL IGluIGEgZmV3IG1vcmUgcGxhY2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL0Rlc2t0b3BCZWhhdmlvci90c3RfaXRlbVNlbGVjdG9y LnFtbCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMvRGVz a3RvcEJlaGF2aW9yL3RzdF9pdGVtU2VsZWN0b3IucW1sCmluZGV4IDE4NzYzYmYuLmQzZDc3ODYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVz dHMvRGVza3RvcEJlaGF2aW9yL3RzdF9pdGVtU2VsZWN0b3IucW1sCisrKyBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMvRGVza3RvcEJlaGF2aW9yL3RzdF9p dGVtU2VsZWN0b3IucW1sCkBAIC0xMDcsNSArMTA3LDEzIEBAIFRlc3RXZWJWaWV3IHsKICAgICAg ICAgICAgIHRyeUNvbXBhcmUod2ViVmlldywgInNlbGVjdG9yTG9hZGVkIiwgdHJ1ZSkKICAgICAg ICAgICAgIGNvbXBhcmUod2ViVmlldy50aXRsZSwgIk5vIG5ldyBzZWxlY3Rpb24gd2FzIG1hZGUi KQogICAgICAgICB9CisKKyAgICAgICAgZnVuY3Rpb24gdGVzdF9zZWxlY3RXaXRoU2l6ZSgpIHsK KyAgICAgICAgICAgIHdlYlZpZXcudXJsID0gUXQucmVzb2x2ZWRVcmwoIi4uL2NvbW1vbi9zZWxl Y3R3aXRoc2l6ZS5odG1sIikKKyAgICAgICAgICAgIHZlcmlmeSh3ZWJWaWV3LndhaXRGb3JMb2Fk U3VjY2VlZGVkKCkpCisgICAgICAgICAgICB0aXRsZVNweS5jbGVhcigpCisKKyAgICAgICAgICAg IHRlc3Rfc2VsZWN0Rmlyc3RUaGVuQWNjZXB0RGlyZWN0bHkoKQorICAgICAgICB9CiAgICAgfQog fQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0 ZXN0cy9jb21tb24vc2VsZWN0d2l0aHNpemUuaHRtbCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMvY29tbW9uL3NlbGVjdHdpdGhzaXplLmh0bWwKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uZjUxNGM0NgotLS0gL2Rldi9udWxsCisrKyBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMvY29tbW9uL3Nl bGVjdHdpdGhzaXplLmh0bWwKQEAgLTAsMCArMSwxOCBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRt bD4KKzxoZWFkPgorPHRpdGxlPk5vIG5ldyBzZWxlY3Rpb24gd2FzIG1hZGU8L3RpdGxlPgorPHNj cmlwdD4KK2Z1bmN0aW9uIHVwZGF0ZVRpdGxlKHNlbGVjdEVsZW1lbnQpIHsKKyAgICB2YXIgaW5k ZXggPSBzZWxlY3RFbGVtZW50LnNlbGVjdGVkSW5kZXg7CisgICAgZG9jdW1lbnQudGl0bGUgPSBz ZWxlY3RFbGVtZW50Lm9wdGlvbnNbaW5kZXhdLnZhbHVlOworfQorPC9zY3JpcHQ+Cis8L2hlYWQ+ Cis8Ym9keT4KKzxzZWxlY3Qgc2l6ZT0yIG9uY2hhbmdlPSJ1cGRhdGVUaXRsZSh0aGlzKSI+Cis8 b3B0aW9uIHZhbHVlPSJfX29wZW5fXyIgPk9wZW48L29wdGlvbj4KKzxvcHRpb24gdmFsdWU9Il9f Y2xvc2VkX18iID5DbG9zZWQ8L29wdGlvbj4KKzxvcHRpb24gdmFsdWU9Il9fYWxsX18iID5BbGw8 L29wdGlvbj4KKzwvc2VsZWN0PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL3F0L1dlYlBvcHVwTWVudVByb3h5UXQuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL3F0L1dlYlBvcHVwTWVudVByb3h5UXQuY3BwCmluZGV4IDY0ODM5NGIuLjNhY2Q2MGYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9XZWJQb3B1cE1lbnVQcm94 eVF0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvV2ViUG9wdXBNZW51UHJv eHlRdC5jcHAKQEAgLTE4NiwxMiArMTg2LDE0IEBAIHZvaWQgUG9wdXBNZW51SXRlbU1vZGVsOjpz ZWxlY3QoaW50IGluZGV4KQogICAgIGlmICghaXRlbS5lbmFibGVkKQogICAgICAgICByZXR1cm47 CiAKLSAgICBJdGVtJiBvbGRJdGVtID0gbV9pdGVtc1tvbGRJbmRleF07Ci0gICAgb2xkSXRlbS5z ZWxlY3RlZCA9IGZhbHNlOworICAgIGlmIChvbGRJbmRleCAhPSAtMSkgeworICAgICAgICBJdGVt JiBvbGRJdGVtID0gbV9pdGVtc1tvbGRJbmRleF07CisgICAgICAgIG9sZEl0ZW0uc2VsZWN0ZWQg PSBmYWxzZTsKKyAgICAgICAgZW1pdCBkYXRhQ2hhbmdlZCh0aGlzLT5pbmRleChvbGRJbmRleCks IHRoaXMtPmluZGV4KG9sZEluZGV4KSk7CisgICAgfQorCiAgICAgaXRlbS5zZWxlY3RlZCA9IHRy dWU7CiAgICAgbV9zZWxlY3RlZE1vZGVsSW5kZXggPSBpbmRleDsKLQotICAgIGVtaXQgZGF0YUNo YW5nZWQodGhpcy0+aW5kZXgob2xkSW5kZXgpLCB0aGlzLT5pbmRleChvbGRJbmRleCkpOwogICAg IGVtaXQgZGF0YUNoYW5nZWQodGhpcy0+aW5kZXgoaW5kZXgpLCB0aGlzLT5pbmRleChpbmRleCkp OwogfQogCg== 143562 2012-05-23 07:04:27 -0700 2012-05-23 12:43:12 -0700 Patch 86974_1.patch text/plain 3775 dinu.jacob ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4OWU5NzdmLi4wMGJiZjI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTItMDUtMjMgIERpbnUgSmFjb2IgIDxkaW51LmphY29iQG5va2lhLmNvbT4KKworICAg ICAgICBbUXRdW1drMl0gQXNzZXJ0aW9uIGZhaWx1cmUgd2hlbiBzZWxlY3RpbmcgYW4gb3B0aW9u IGluIHNlbGVjdCBsaXN0IHdpdGggc2l6ZSBhdHRyaWJ1dGUgZ3JlYXRlciB0aGFuIG9uZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODY5NzQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTZWxlY3QgbGlzdCB3 aXRoIHNpemUgYXR0cmlidXRlIGdyZWF0ZXIgdGhhbiBvbmUgd2lsbCBub3QgaW5pdGlhbGx5IGhh dmUgYW55CisgICAgICAgIGl0ZW0gaW4gc2VsZWN0ZWQgc3RhdGUgKGlmIG5vIG9wdGlvbiBoYXMg J3NlbGVjdGVkJyB0YWcpLCByZXN1bHRpbmcgaW4KKyAgICAgICAgbV9zZWxlY3RlZE1vZGVsSW5k ZXggaW4gV2ViUG9wdXBNZW51UHJveHlRdCB0byBiZSBpbnZhbGlkLiBIZW5jZSwgbmVlZCB0byBj aGVjaworICAgICAgICB3aGV0aGVyIHRoZSBvbGQgaW5kZXggaXMgaW52YWxpZCBiZWZvcmUgYWNj ZXNzaW5nIHRoZSBpdGVtIGF0IHRoYXQgaW5kZXguCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L3F0L3Rlc3RzL3FtbHRlc3RzL0Rlc2t0b3BCZWhhdmlvci90c3RfaXRlbVNlbGVjdG9yLnFtbDog QWRkZWQgbmV3IHRlc3QgdGhhdAorICAgICAgICAgIHRlc3RzIHNlbGVjdGlvbiBpbiBhIHNlbGVj dCBsaXN0IHdpdGggc2l6ZSBhdHRyaWJ1dGUgdmFsdWUgb2YgMi4KKyAgICAgICAgKiBVSVByb2Nl c3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL2NvbW1vbi9zZWxlY3R3aXRoc2l6ZS5odG1sOiBBZGRl ZC4KKyAgICAgICAgKiBVSVByb2Nlc3MvcXQvV2ViUG9wdXBNZW51UHJveHlRdC5jcHA6CisgICAg ICAgIChXZWJLaXQ6OlBvcHVwTWVudUl0ZW1Nb2RlbDo6c2VsZWN0KTogQ2hlY2sgd2hldGhlciBv bGQgaW5kZXggaXMgdmFsaWQgYmVmb3JlIGFjY2Vzc2luZworICAgICAgICAgIHRoZSBpdGVtIGF0 IHRoYXQgaW5kZXguCisKIDIwMTItMDUtMjMgIE1pY2hhZWwgQnLDvG5pbmcgIDxtaWNoYWVsLmJy dW5pbmdAbm9raWEuY29tPgogCiAgICAgICAgIFtRdF1bV0syXSBTbWFsbCByZWZhY3RvcmluZyBX ZWJQYWdlOjpjb25maXJtQ29tcG9zaXRpb24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL0Rlc2t0b3BCZWhhdmlvci90c3RfaXRlbVNl bGVjdG9yLnFtbCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVz dHMvRGVza3RvcEJlaGF2aW9yL3RzdF9pdGVtU2VsZWN0b3IucW1sCmluZGV4IDE4NzYzYmYuLmQz ZDc3ODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMv cW1sdGVzdHMvRGVza3RvcEJlaGF2aW9yL3RzdF9pdGVtU2VsZWN0b3IucW1sCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMvRGVza3RvcEJlaGF2aW9y L3RzdF9pdGVtU2VsZWN0b3IucW1sCkBAIC0xMDcsNSArMTA3LDEzIEBAIFRlc3RXZWJWaWV3IHsK ICAgICAgICAgICAgIHRyeUNvbXBhcmUod2ViVmlldywgInNlbGVjdG9yTG9hZGVkIiwgdHJ1ZSkK ICAgICAgICAgICAgIGNvbXBhcmUod2ViVmlldy50aXRsZSwgIk5vIG5ldyBzZWxlY3Rpb24gd2Fz IG1hZGUiKQogICAgICAgICB9CisKKyAgICAgICAgZnVuY3Rpb24gdGVzdF9zZWxlY3RXaXRoU2l6 ZSgpIHsKKyAgICAgICAgICAgIHdlYlZpZXcudXJsID0gUXQucmVzb2x2ZWRVcmwoIi4uL2NvbW1v bi9zZWxlY3R3aXRoc2l6ZS5odG1sIikKKyAgICAgICAgICAgIHZlcmlmeSh3ZWJWaWV3LndhaXRG b3JMb2FkU3VjY2VlZGVkKCkpCisgICAgICAgICAgICB0aXRsZVNweS5jbGVhcigpCisKKyAgICAg ICAgICAgIHRlc3Rfc2VsZWN0Rmlyc3RUaGVuQWNjZXB0RGlyZWN0bHkoKQorICAgICAgICB9CiAg ICAgfQogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0 cy9xbWx0ZXN0cy9jb21tb24vc2VsZWN0d2l0aHNpemUuaHRtbCBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMvY29tbW9uL3NlbGVjdHdpdGhzaXplLmh0bWwK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uZjUxNGM0NgotLS0gL2Rldi9udWxs CisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMvY29t bW9uL3NlbGVjdHdpdGhzaXplLmh0bWwKQEAgLTAsMCArMSwxOCBAQAorPCFET0NUWVBFIGh0bWw+ Cis8aHRtbD4KKzxoZWFkPgorPHRpdGxlPk5vIG5ldyBzZWxlY3Rpb24gd2FzIG1hZGU8L3RpdGxl PgorPHNjcmlwdD4KK2Z1bmN0aW9uIHVwZGF0ZVRpdGxlKHNlbGVjdEVsZW1lbnQpIHsKKyAgICB2 YXIgaW5kZXggPSBzZWxlY3RFbGVtZW50LnNlbGVjdGVkSW5kZXg7CisgICAgZG9jdW1lbnQudGl0 bGUgPSBzZWxlY3RFbGVtZW50Lm9wdGlvbnNbaW5kZXhdLnZhbHVlOworfQorPC9zY3JpcHQ+Cis8 L2hlYWQ+Cis8Ym9keT4KKzxzZWxlY3Qgc2l6ZT0yIG9uY2hhbmdlPSJ1cGRhdGVUaXRsZSh0aGlz KSI+Cis8b3B0aW9uIHZhbHVlPSJfX29wZW5fXyIgPk9wZW48L29wdGlvbj4KKzxvcHRpb24gdmFs dWU9Il9fY2xvc2VkX18iID5DbG9zZWQ8L29wdGlvbj4KKzxvcHRpb24gdmFsdWU9Il9fYWxsX18i ID5BbGw8L29wdGlvbj4KKzwvc2VsZWN0PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL3F0L1dlYlBvcHVwTWVudVByb3h5UXQuY3BwIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL3F0L1dlYlBvcHVwTWVudVByb3h5UXQuY3BwCmluZGV4IDY0ODM5NGIuLjJm OTIwOTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9XZWJQb3B1cE1l bnVQcm94eVF0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvV2ViUG9wdXBN ZW51UHJveHlRdC5jcHAKQEAgLTE4NiwxMiArMTg2LDE1IEBAIHZvaWQgUG9wdXBNZW51SXRlbU1v ZGVsOjpzZWxlY3QoaW50IGluZGV4KQogICAgIGlmICghaXRlbS5lbmFibGVkKQogICAgICAgICBy ZXR1cm47CiAKLSAgICBJdGVtJiBvbGRJdGVtID0gbV9pdGVtc1tvbGRJbmRleF07Ci0gICAgb2xk SXRlbS5zZWxlY3RlZCA9IGZhbHNlOwogICAgIGl0ZW0uc2VsZWN0ZWQgPSB0cnVlOwogICAgIG1f c2VsZWN0ZWRNb2RlbEluZGV4ID0gaW5kZXg7CiAKLSAgICBlbWl0IGRhdGFDaGFuZ2VkKHRoaXMt PmluZGV4KG9sZEluZGV4KSwgdGhpcy0+aW5kZXgob2xkSW5kZXgpKTsKKyAgICBpZiAob2xkSW5k ZXggIT0gLTEpIHsKKyAgICAgICAgSXRlbSYgb2xkSXRlbSA9IG1faXRlbXNbb2xkSW5kZXhdOwor ICAgICAgICBvbGRJdGVtLnNlbGVjdGVkID0gZmFsc2U7CisgICAgICAgIGVtaXQgZGF0YUNoYW5n ZWQodGhpcy0+aW5kZXgob2xkSW5kZXgpLCB0aGlzLT5pbmRleChvbGRJbmRleCkpOworICAgIH0K KwogICAgIGVtaXQgZGF0YUNoYW5nZWQodGhpcy0+aW5kZXgoaW5kZXgpLCB0aGlzLT5pbmRleChp bmRleCkpOwogfQogCg==