86965 2012-05-20 08:19:08 -0700 [Chromium] Print layout test result on buildbot 2012-05-20 12:09:50 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim abarth dpranke eric jochen rniwa webkit.review.bot oldest_to_newest 628583 0 gyuyoung.kim 2012-05-20 08:19:08 -0700 Chrome build bot doesn't print layout test result unlike other ports. If chrome buildbot prints result of layout test, it will help to check layout test status for chromium port. 628584 1 142904 gyuyoung.kim 2012-05-20 08:22:45 -0700 Created attachment 142904 Patch 628591 2 jochen 2012-05-20 11:00:08 -0700 The user chrome-bot is correct Adding Adam and Eric as they run our bots 628592 3 eric 2012-05-20 11:07:31 -0700 I thought we had moved all the buildbots to modern NRWT-aware configurations? Lame that we're depending on this wrapper hack. 628593 4 eric 2012-05-20 11:10:09 -0700 It looks like we still have a separate NRWT rule: http://trac.webkit.org/browser/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg#L405 but the RWT rule is generic: http://trac.webkit.org/browser/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg#L279 628594 5 jochen 2012-05-20 11:12:29 -0700 (In reply to comment #4) > It looks like we still have a separate NRWT rule: > http://trac.webkit.org/browser/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg#L405 > > but the RWT rule is generic: > http://trac.webkit.org/browser/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg#L279 The bots definitely run RWT: http://build.webkit.org/builders/Chromium%20Linux%20Release%20%28Tests%29/builds/32799/steps/layout-test/logs/stdio 628597 6 142904 eric 2012-05-20 11:44:09 -0700 Comment on attachment 142904 Patch Some of this confusion is all tied up in the fact that we have only one port which still use ORWT (AppleWin). This is not the "Right" fix. But this is totally fine. THanks. 628607 7 142904 webkit.review.bot 2012-05-20 12:09:45 -0700 Comment on attachment 142904 Patch Clearing flags on attachment: 142904 Committed r117708: <http://trac.webkit.org/changeset/117708> 628608 8 webkit.review.bot 2012-05-20 12:09:50 -0700 All reviewed patches have been landed. Closing bug. 142904 2012-05-20 08:22:45 -0700 2012-05-20 12:09:45 -0700 Patch bug-86965-20120521002236.patch text/plain 1517 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3NzA3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjk3YTZiYjI1MGM5YTA3MGQ2MGI1NDk1ZjgxYWRiMTA4 N2U1MzY1OS4uZGYzN2FmM2JmODRhMjIxNWViYmNhODE3ZmFiMGVlMzUzMmNiZjM0MSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDEyLTA1LTIwICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+ CisKKyAgICAgICAgW0Nocm9taXVtXSBQcmludCBsYXlvdXQgdGVzdCByZXN1bHQgb24gYnVpbGRi b3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2OTY1 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3Jp cHRzL3J1bi13ZWJraXQtdGVzdHM6IEFkZCBjaHJvbWUtYm90IHRvIGJ1aWxkYm90IHVzZXIgbGlz dC4KKyAgICAgICAgKHJ1bm5pbmdPbkJ1aWxkQm90KToKKwogMjAxMi0wNS0xOSAgS2V2aW4gT2xs aXZpZXIgIDxrZXZpbm9AdGhlb2xsaXZpZXJzLmNvbT4KIAogICAgICAgICBbd3hdIFVucmV2aWV3 ZWQgYnVpbGQgZml4LiBEb24ndCBzdG9wIHRoZSBidWlsZCBpZiBhIGJ1aWxkIHN5c3RlbSB1cGRh dGUgY2hlY2sgZmFpbHMuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVz dHMgYi9Ub29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVzdHMKaW5kZXggYjYyNzMyYTg3ZDU5YTA0 YzIzNTFlYmU4NjExMTkyNDJlNzRiZjM1OC4uOGQ5NmYzZjk0MTZjZjNmN2IwNWY5YWMxODQyNDRm MzU5ZjMyYWZkMiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzCisr KyBiL1Rvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cwpAQCAtNTEsNyArNTEsNyBAQCBzdWIg cnVubmluZ09uQnVpbGRCb3QoKQogICAgICMgVGhpcyBpcyBhIGhhY2sgdG8gZGV0ZWN0IGlmIHdl J3JlIHJ1bm5pbmcgb24gdGhlIGJ1aWxkYm90IHNvIHdlIGNhbgogICAgICMgcGFzcyAtLXZlcmJv c2UgdG8gbmV3LXJ1bi13ZWJraXQtdGVzdHMuICBUaGlzIHdpbGwgYmUgcmVtb3ZlZCB3aGVuIHdl CiAgICAgIyB1cGRhdGUgdGhlIGJ1aWxkYm90IGNvbmZpZyB0byBjYWxsIG5ldy1ydW4td2Via2l0 LXRlc3RzIGV4cGxpY2l0bHkuCi0gICAgbXkgJWlzQnVpbGRCb3RVc2VyID0gKCJhcHBsZSIgPT4g MSwgImJ1aWxkYm90IiA9PiAxLCAid2Via2l0YnVpbGRib3QiID0+IDEsICJzbGF2ZSIgPT4gMSwg ImJ1aWxkc2xhdmUtMSIgPT4gMSk7CisgICAgbXkgJWlzQnVpbGRCb3RVc2VyID0gKCJhcHBsZSIg PT4gMSwgImJ1aWxkYm90IiA9PiAxLCAid2Via2l0YnVpbGRib3QiID0+IDEsICJzbGF2ZSIgPT4g MSwgImJ1aWxkc2xhdmUtMSIgPT4gMSwgImNocm9tZS1ib3QiID0+IDEpOwogICAgIHJldHVybiAk aXNCdWlsZEJvdFVzZXJ7JEVOVnsiVVNFUiJ9fTsKIH0KIAo=