86964 2012-05-20 07:58:06 -0700 Unsupported commands should have queryCommandValue() = "", not false 2012-05-20 20:16:49 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ayg webkit-unassigned abarth ap joethomas ojan rniwa webkit.review.bot oldest_to_newest 628581 0 ayg 2012-05-20 07:58:06 -0700 Test-case: data:text/html,<!doctype html> <script> var val = document.queryCommandValue("quasit"); alert(typeof val + ' "' + val + '"'); </script> Chrome 20 dev alerts 'boolean "false"'. This means queryCommandValue() is returning a boolean, when it's specced to always return a string. Gecko now returns the empty string, per spec <https://bugzilla.mozilla.org/show_bug.cgi?id=742240#c18>. IE throws, which we decided in bug 83993 was not acceptable. WebKit should return the empty string here. This probably doesn't have big compat impact, because false == "" in JavaScript. 628626 1 joethomas 2012-05-20 14:25:07 -0700 I will create a patch for this 628646 2 142923 joethomas 2012-05-20 15:53:39 -0700 Created attachment 142923 ProposedPatch 628660 3 142923 rniwa 2012-05-20 17:01:55 -0700 Comment on attachment 142923 ProposedPatch View in context: https://bugs.webkit.org/attachment.cgi?id=142923&action=review > LayoutTests/editing/execCommand/use-css.html:51 > testFailed("queryCommandValue('useCSS') should return boolean false"); Please update this comment as well. 628668 4 142928 joethomas 2012-05-20 17:22:53 -0700 Created attachment 142928 Patch-Updated 628670 5 joethomas 2012-05-20 17:23:44 -0700 (In reply to comment #3) > (From update of attachment 142923 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=142923&action=review > > > LayoutTests/editing/execCommand/use-css.html:51 > > testFailed("queryCommandValue('useCSS') should return boolean false"); > > Please update this comment as well. Done. I missed it. 628706 6 142928 webkit.review.bot 2012-05-20 18:46:33 -0700 Comment on attachment 142928 Patch-Updated Clearing flags on attachment: 142928 Committed r117721: <http://trac.webkit.org/changeset/117721> 628707 7 webkit.review.bot 2012-05-20 18:46:38 -0700 All reviewed patches have been landed. Closing bug. 628733 8 joethomas 2012-05-20 20:16:49 -0700 Thanks for the review :) 142923 2012-05-20 15:53:39 -0700 2012-05-20 17:22:53 -0700 ProposedPatch patch text/plain 6005 joethomas SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNzcxMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA1LTIwICBKb2UgVGhv bWFzICA8am9ldGhvbWFzQG1vdG9yb2xhLmNvbT4KKworICAgICAgICBVbnN1cHBvcnRlZCBjb21t YW5kcyBzaG91bGQgaGF2ZSBxdWVyeUNvbW1hbmRWYWx1ZSgpID0gIiIsIG5vdCBmYWxzZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODY5NjQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBxdWVyeUNvbW1hbmRW YWx1ZSBmb3IgdW5zdXBwb3J0ZWQgY29tbWFuZHMgc2hvdWxkIHJldHVybiBlbXB0eSBzdHJpbmcu CisgICAgICAgIFRoZSBzcGVjaWZpY2F0aW9uIHJlbGF0ZWQgdG8gdGhpcyBjYW4gYmUgbG9jYXRl ZCBhdCBodHRwOi8vZHZjcy53My5vcmcvaGcvZWRpdGluZy9yYXctZmlsZS90aXAvZWRpdGluZy5o dG1sI21ldGhvZHMtdG8tcXVlcnktYW5kLWV4ZWN1dGUtY29tbWFuZHMKKworICAgICAgICBUZXN0 OiBlZGl0aW5nL2V4ZWNDb21tYW5kL3F1ZXJ5Q29tbWFuZFZhbHVlLXVuc3VwcG9ydGVkLWNvbW1h bmRzLmh0bWwKKworICAgICAgICAqIGRvbS9Eb2N1bWVudC5pZGw6CisKIDIwMTItMDUtMjAgIFBo aWxpcCBSb2dlcnMgIDxwZHJAZ29vZ2xlLmNvbT4KIAogICAgICAgICBBY2N1bXVsYXRlIFNWRyBh bmltYXRpb25zIGludG8gZmlyc3QgY29udHJpYnV0aW5nIGVsZW1lbnQKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL2RvbS9Eb2N1bWVudC5pZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9t L0RvY3VtZW50LmlkbAkocmV2aXNpb24gMTE3NzA4KQorKysgU291cmNlL1dlYkNvcmUvZG9tL0Rv Y3VtZW50LmlkbAkod29ya2luZyBjb3B5KQpAQCAtMTQxLDcgKzE0MSw3IEBAIG1vZHVsZSBjb3Jl IHsKICAgICAgICAgYm9vbGVhbiAgICAgICAgICAgIHF1ZXJ5Q29tbWFuZEluZGV0ZXJtKGluIFtP cHRpb25hbD1EZWZhdWx0SXNVbmRlZmluZWRdIERPTVN0cmluZyBjb21tYW5kKTsKICAgICAgICAg Ym9vbGVhbiAgICAgICAgICAgIHF1ZXJ5Q29tbWFuZFN0YXRlKGluIFtPcHRpb25hbD1EZWZhdWx0 SXNVbmRlZmluZWRdIERPTVN0cmluZyBjb21tYW5kKTsKICAgICAgICAgYm9vbGVhbiAgICAgICAg ICAgIHF1ZXJ5Q29tbWFuZFN1cHBvcnRlZChpbiBbT3B0aW9uYWw9RGVmYXVsdElzVW5kZWZpbmVk XSBET01TdHJpbmcgY29tbWFuZCk7Ci0gICAgICAgIFtUcmVhdFJldHVybmVkTnVsbFN0cmluZ0Fz PUZhbHNlXSBET01TdHJpbmcgcXVlcnlDb21tYW5kVmFsdWUoaW4gW09wdGlvbmFsPURlZmF1bHRJ c1VuZGVmaW5lZF0gRE9NU3RyaW5nIGNvbW1hbmQpOworICAgICAgICBET01TdHJpbmcgICAgICAg ICAgcXVlcnlDb21tYW5kVmFsdWUoaW4gW09wdGlvbmFsPURlZmF1bHRJc1VuZGVmaW5lZF0gRE9N U3RyaW5nIGNvbW1hbmQpOwogCiAgICAgICAgIC8vIE1vdmVkIGRvd24gZnJvbSBIVE1MRG9jdW1l bnQKIApJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTE3NzEyKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTItMDUtMjAgIEpvZSBUaG9tYXMg IDxqb2V0aG9tYXNAbW90b3JvbGEuY29tPgorCisgICAgICAgIFVuc3VwcG9ydGVkIGNvbW1hbmRz IHNob3VsZCBoYXZlIHF1ZXJ5Q29tbWFuZFZhbHVlKCkgPSAiIiwgbm90IGZhbHNlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04Njk2NAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHF1ZXJ5Q29tbWFuZFZhbHVl IGZvciB1bnN1cHBvcnRlZCBjb21tYW5kcyBzaG91bGQgcmV0dXJuIGVtcHR5IHN0cmluZy4KKyAg ICAgICAgVGhlIHNwZWNpZmljYXRpb24gcmVsYXRlZCB0byB0aGlzIGNhbiBiZSBsb2NhdGVkIGF0 IGh0dHA6Ly9kdmNzLnczLm9yZy9oZy9lZGl0aW5nL3Jhdy1maWxlL3RpcC9lZGl0aW5nLmh0bWwj bWV0aG9kcy10by1xdWVyeS1hbmQtZXhlY3V0ZS1jb21tYW5kcworCisgICAgICAgICogZWRpdGlu Zy9leGVjQ29tbWFuZC9xdWVyeUNvbW1hbmRWYWx1ZS11bnN1cHBvcnRlZC1jb21tYW5kcy1leHBl Y3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGVkaXRpbmcvZXhlY0NvbW1hbmQvcXVlcnlDb21t YW5kVmFsdWUtdW5zdXBwb3J0ZWQtY29tbWFuZHMuaHRtbDogQWRkZWQuCisgICAgICAgICogZWRp dGluZy9leGVjQ29tbWFuZC91c2UtY3NzLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBlZGl0aW5n L2V4ZWNDb21tYW5kL3VzZS1jc3MuaHRtbDoKKwogMjAxMi0wNS0yMCAgUmFwaGFlbCBLdWJvIGRh IENvc3RhICA8cmFrdWNvQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW0VGTF0gVW5za2lwIHBhc3Np bmcgdGVzdCBhZnRlciByMTE3NzA5LgpJbmRleDogTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29t bWFuZC9xdWVyeUNvbW1hbmRWYWx1ZS11bnN1cHBvcnRlZC1jb21tYW5kcy1leHBlY3RlZC50eHQK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC9xdWVyeUNvbW1h bmRWYWx1ZS11bnN1cHBvcnRlZC1jb21tYW5kcy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisr KyBMYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL3F1ZXJ5Q29tbWFuZFZhbHVlLXVuc3Vw cG9ydGVkLWNvbW1hbmRzLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMyBA QAorVGVzdHMgcXVlcnlDb21tYW5kVmFsdWUgcmV0dXJucyBlbXB0eSBzdHJpbmcgZm9yIHVuc3Vw cG9ydGVkIGNvbW1hbmRzCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAi UEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIGRv Y3VtZW50LnF1ZXJ5Q29tbWFuZFZhbHVlKCdmb29mb28nKSBpcyAnJworUEFTUyB0eXBlb2YgZG9j dW1lbnQucXVlcnlDb21tYW5kVmFsdWUoJ2Zvb2ZvbycpIGlzICdzdHJpbmcnCitQQVNTIGRvY3Vt ZW50LnF1ZXJ5Q29tbWFuZFZhbHVlKCdmb250U2l6ZScpIGlzICc1JworUEFTUyB0eXBlb2YgZG9j dW1lbnQucXVlcnlDb21tYW5kVmFsdWUoJ2ZvbnRTaXplJykgaXMgJ3N0cmluZycKK1BBU1Mgc3Vj Y2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlvdXRU ZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL3F1ZXJ5Q29tbWFuZFZhbHVlLXVuc3VwcG9ydGVkLWNv bW1hbmRzLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFu ZC9xdWVyeUNvbW1hbmRWYWx1ZS11bnN1cHBvcnRlZC1jb21tYW5kcy5odG1sCShyZXZpc2lvbiAw KQorKysgTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC9xdWVyeUNvbW1hbmRWYWx1ZS11 bnN1cHBvcnRlZC1jb21tYW5kcy5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDE3IEBACis8 IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPHNjcmlwdCBzcmM9Ii4uLy4uL2Zhc3QvanMvcmVzb3Vy Y2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzxkaXYgaWQ9InRlc3QiIGNvbnRlbnRlZGl0 YWJsZT48L2Rpdj4KKzxzY3JpcHQ+CitkZXNjcmlwdGlvbigiVGVzdHMgcXVlcnlDb21tYW5kVmFs dWUgcmV0dXJucyBlbXB0eSBzdHJpbmcgZm9yIHVuc3VwcG9ydGVkIGNvbW1hbmRzIik7CisKK3Zh ciB0ZXN0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3Rlc3QnKTsKK3Rlc3QuZm9jdXMoKTsK K2RvY3VtZW50LmV4ZWNDb21tYW5kKCdmb250U2l6ZScsIGZhbHNlLCA1KTsKK3Nob3VsZEJlKCJk b2N1bWVudC5xdWVyeUNvbW1hbmRWYWx1ZSgnZm9vZm9vJykiLCAiJyciKTsKK3Nob3VsZEJlKCJ0 eXBlb2YgZG9jdW1lbnQucXVlcnlDb21tYW5kVmFsdWUoJ2Zvb2ZvbycpIiwgIidzdHJpbmcnIik7 CitzaG91bGRCZSgiZG9jdW1lbnQucXVlcnlDb21tYW5kVmFsdWUoJ2ZvbnRTaXplJykiLCAiJzUn Iik7CitzaG91bGRCZSgidHlwZW9mIGRvY3VtZW50LnF1ZXJ5Q29tbWFuZFZhbHVlKCdmb250U2l6 ZScpIiwgIidzdHJpbmcnIik7Cis8L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9mYXN0L2pz L3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9odG1sPgpJbmRleDogTGF5 b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC91c2UtY3NzLWV4cGVjdGVkLnR4dAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL3VzZS1jc3MtZXhwZWN0ZWQu dHh0CShyZXZpc2lvbiAxMTc3MDgpCisrKyBMYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5k L3VzZS1jc3MtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC05LDcgKzksNyBAQCBQQVNT IHVzZUNTUyBjaGFuZ2VkIHRoZSBzdGF0ZSBzdWNjZXNzZnVsCiBQQVNTIHVzZUNTUyBjaGFuZ2Vk IHRoZSBzdGF0ZSBzdWNjZXNzZnVsbHkKIFBBU1MgdXNlQ1NTIGNoYW5nZWQgdGhlIHN0YXRlIHN1 Y2Nlc3NmdWxseQogUEFTUyBxdWVyeUNvbW1hbmRTdGF0ZSgndXNlQ1NTJykgcmV0dXJucyBmYWxz ZQotUEFTUyBxdWVyeUNvbW1hbmRWYWx1ZSgndXNlQ1NTJykgcmV0dXJucyBmYWxzZQorUEFTUyBx dWVyeUNvbW1hbmRWYWx1ZSgndXNlQ1NTJykgcmV0dXJucyAnJwogUEFTUyBvbmUgdW5kZXJsaW5l IGNvbW1hbmQgY29udmVydGVkIHRlc3QgdG8gPHNwYW4gc3R5bGU9InRleHQtZGVjb3JhdGlvbjog dW5kZXJsaW5lOyI+dGVzdDwvc3Bhbj4KIFBBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUK IApJbmRleDogTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC91c2UtY3NzLmh0bWwKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC91c2UtY3NzLmh0bWwJ KHJldmlzaW9uIDExNzcwOCkKKysrIExheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvdXNl LWNzcy5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC00NSw4ICs0NSw4IEBAIGlmIChkb2N1bWVudC5x dWVyeUNvbW1hbmRTdGF0ZSgndXNlQ1NTJykKIGVsc2UKICAgICB0ZXN0RmFpbGVkKCJxdWVyeUNv bW1hbmRTdGF0ZSgndXNlQ1NTJykgc2hvdWxkIHJldHVybiBib29sZWFuIGZhbHNlIik7CiAKLWlm IChkb2N1bWVudC5xdWVyeUNvbW1hbmRWYWx1ZSgndXNlQ1NTJykgPT09IGZhbHNlKQotICAgIHRl c3RQYXNzZWQoInF1ZXJ5Q29tbWFuZFZhbHVlKCd1c2VDU1MnKSByZXR1cm5zIGZhbHNlIik7Citp ZiAoZG9jdW1lbnQucXVlcnlDb21tYW5kVmFsdWUoJ3VzZUNTUycpID09PSAiIikKKyAgICB0ZXN0 UGFzc2VkKCJxdWVyeUNvbW1hbmRWYWx1ZSgndXNlQ1NTJykgcmV0dXJucyAnJyIpOwogZWxzZQog ICAgIHRlc3RGYWlsZWQoInF1ZXJ5Q29tbWFuZFZhbHVlKCd1c2VDU1MnKSBzaG91bGQgcmV0dXJu IGJvb2xlYW4gZmFsc2UiKTsKIAo= 142928 2012-05-20 17:22:53 -0700 2012-05-20 18:46:33 -0700 Patch-Updated patch text/plain 6180 joethomas SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNzcxMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA1LTIwICBKb2UgVGhv bWFzICA8am9ldGhvbWFzQG1vdG9yb2xhLmNvbT4KKworICAgICAgICBVbnN1cHBvcnRlZCBjb21t YW5kcyBzaG91bGQgaGF2ZSBxdWVyeUNvbW1hbmRWYWx1ZSgpID0gIiIsIG5vdCBmYWxzZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODY5NjQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBxdWVyeUNvbW1hbmRW YWx1ZSBmb3IgdW5zdXBwb3J0ZWQgY29tbWFuZHMgc2hvdWxkIHJldHVybiBlbXB0eSBzdHJpbmcu CisgICAgICAgIFRoZSBzcGVjaWZpY2F0aW9uIHJlbGF0ZWQgdG8gdGhpcyBjYW4gYmUgbG9jYXRl ZCBhdCBodHRwOi8vZHZjcy53My5vcmcvaGcvZWRpdGluZy9yYXctZmlsZS90aXAvZWRpdGluZy5o dG1sI21ldGhvZHMtdG8tcXVlcnktYW5kLWV4ZWN1dGUtY29tbWFuZHMKKworICAgICAgICBUZXN0 OiBlZGl0aW5nL2V4ZWNDb21tYW5kL3F1ZXJ5Q29tbWFuZFZhbHVlLXVuc3VwcG9ydGVkLWNvbW1h bmRzLmh0bWwKKworICAgICAgICAqIGRvbS9Eb2N1bWVudC5pZGw6CisKIDIwMTItMDUtMjAgIFBo aWxpcCBSb2dlcnMgIDxwZHJAZ29vZ2xlLmNvbT4KIAogICAgICAgICBBY2N1bXVsYXRlIFNWRyBh bmltYXRpb25zIGludG8gZmlyc3QgY29udHJpYnV0aW5nIGVsZW1lbnQKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL2RvbS9Eb2N1bWVudC5pZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9t L0RvY3VtZW50LmlkbAkocmV2aXNpb24gMTE3NzA4KQorKysgU291cmNlL1dlYkNvcmUvZG9tL0Rv Y3VtZW50LmlkbAkod29ya2luZyBjb3B5KQpAQCAtMTQxLDcgKzE0MSw3IEBAIG1vZHVsZSBjb3Jl IHsKICAgICAgICAgYm9vbGVhbiAgICAgICAgICAgIHF1ZXJ5Q29tbWFuZEluZGV0ZXJtKGluIFtP cHRpb25hbD1EZWZhdWx0SXNVbmRlZmluZWRdIERPTVN0cmluZyBjb21tYW5kKTsKICAgICAgICAg Ym9vbGVhbiAgICAgICAgICAgIHF1ZXJ5Q29tbWFuZFN0YXRlKGluIFtPcHRpb25hbD1EZWZhdWx0 SXNVbmRlZmluZWRdIERPTVN0cmluZyBjb21tYW5kKTsKICAgICAgICAgYm9vbGVhbiAgICAgICAg ICAgIHF1ZXJ5Q29tbWFuZFN1cHBvcnRlZChpbiBbT3B0aW9uYWw9RGVmYXVsdElzVW5kZWZpbmVk XSBET01TdHJpbmcgY29tbWFuZCk7Ci0gICAgICAgIFtUcmVhdFJldHVybmVkTnVsbFN0cmluZ0Fz PUZhbHNlXSBET01TdHJpbmcgcXVlcnlDb21tYW5kVmFsdWUoaW4gW09wdGlvbmFsPURlZmF1bHRJ c1VuZGVmaW5lZF0gRE9NU3RyaW5nIGNvbW1hbmQpOworICAgICAgICBET01TdHJpbmcgICAgICAg ICAgcXVlcnlDb21tYW5kVmFsdWUoaW4gW09wdGlvbmFsPURlZmF1bHRJc1VuZGVmaW5lZF0gRE9N U3RyaW5nIGNvbW1hbmQpOwogCiAgICAgICAgIC8vIE1vdmVkIGRvd24gZnJvbSBIVE1MRG9jdW1l bnQKIApJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTE3NzEyKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTItMDUtMjAgIEpvZSBUaG9tYXMg IDxqb2V0aG9tYXNAbW90b3JvbGEuY29tPgorCisgICAgICAgIFVuc3VwcG9ydGVkIGNvbW1hbmRz IHNob3VsZCBoYXZlIHF1ZXJ5Q29tbWFuZFZhbHVlKCkgPSAiIiwgbm90IGZhbHNlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04Njk2NAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHF1ZXJ5Q29tbWFuZFZhbHVl IGZvciB1bnN1cHBvcnRlZCBjb21tYW5kcyBzaG91bGQgcmV0dXJuIGVtcHR5IHN0cmluZy4KKyAg ICAgICAgVGhlIHNwZWNpZmljYXRpb24gcmVsYXRlZCB0byB0aGlzIGNhbiBiZSBsb2NhdGVkIGF0 IGh0dHA6Ly9kdmNzLnczLm9yZy9oZy9lZGl0aW5nL3Jhdy1maWxlL3RpcC9lZGl0aW5nLmh0bWwj bWV0aG9kcy10by1xdWVyeS1hbmQtZXhlY3V0ZS1jb21tYW5kcworCisgICAgICAgICogZWRpdGlu Zy9leGVjQ29tbWFuZC9xdWVyeUNvbW1hbmRWYWx1ZS11bnN1cHBvcnRlZC1jb21tYW5kcy1leHBl Y3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGVkaXRpbmcvZXhlY0NvbW1hbmQvcXVlcnlDb21t YW5kVmFsdWUtdW5zdXBwb3J0ZWQtY29tbWFuZHMuaHRtbDogQWRkZWQuCisgICAgICAgICogZWRp dGluZy9leGVjQ29tbWFuZC91c2UtY3NzLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBlZGl0aW5n L2V4ZWNDb21tYW5kL3VzZS1jc3MuaHRtbDoKKwogMjAxMi0wNS0yMCAgUmFwaGFlbCBLdWJvIGRh IENvc3RhICA8cmFrdWNvQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW0VGTF0gVW5za2lwIHBhc3Np bmcgdGVzdCBhZnRlciByMTE3NzA5LgpJbmRleDogTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29t bWFuZC9xdWVyeUNvbW1hbmRWYWx1ZS11bnN1cHBvcnRlZC1jb21tYW5kcy1leHBlY3RlZC50eHQK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC9xdWVyeUNvbW1h bmRWYWx1ZS11bnN1cHBvcnRlZC1jb21tYW5kcy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisr KyBMYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL3F1ZXJ5Q29tbWFuZFZhbHVlLXVuc3Vw cG9ydGVkLWNvbW1hbmRzLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMyBA QAorVGVzdHMgcXVlcnlDb21tYW5kVmFsdWUgcmV0dXJucyBlbXB0eSBzdHJpbmcgZm9yIHVuc3Vw cG9ydGVkIGNvbW1hbmRzCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAi UEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIGRv Y3VtZW50LnF1ZXJ5Q29tbWFuZFZhbHVlKCdmb29mb28nKSBpcyAnJworUEFTUyB0eXBlb2YgZG9j dW1lbnQucXVlcnlDb21tYW5kVmFsdWUoJ2Zvb2ZvbycpIGlzICdzdHJpbmcnCitQQVNTIGRvY3Vt ZW50LnF1ZXJ5Q29tbWFuZFZhbHVlKCdmb250U2l6ZScpIGlzICc1JworUEFTUyB0eXBlb2YgZG9j dW1lbnQucXVlcnlDb21tYW5kVmFsdWUoJ2ZvbnRTaXplJykgaXMgJ3N0cmluZycKK1BBU1Mgc3Vj Y2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlvdXRU ZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL3F1ZXJ5Q29tbWFuZFZhbHVlLXVuc3VwcG9ydGVkLWNv bW1hbmRzLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFu ZC9xdWVyeUNvbW1hbmRWYWx1ZS11bnN1cHBvcnRlZC1jb21tYW5kcy5odG1sCShyZXZpc2lvbiAw KQorKysgTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC9xdWVyeUNvbW1hbmRWYWx1ZS11 bnN1cHBvcnRlZC1jb21tYW5kcy5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDE3IEBACis8 IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPHNjcmlwdCBzcmM9Ii4uLy4uL2Zhc3QvanMvcmVzb3Vy Y2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzxkaXYgaWQ9InRlc3QiIGNvbnRlbnRlZGl0 YWJsZT48L2Rpdj4KKzxzY3JpcHQ+CitkZXNjcmlwdGlvbigiVGVzdHMgcXVlcnlDb21tYW5kVmFs dWUgcmV0dXJucyBlbXB0eSBzdHJpbmcgZm9yIHVuc3VwcG9ydGVkIGNvbW1hbmRzIik7CisKK3Zh ciB0ZXN0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3Rlc3QnKTsKK3Rlc3QuZm9jdXMoKTsK K2RvY3VtZW50LmV4ZWNDb21tYW5kKCdmb250U2l6ZScsIGZhbHNlLCA1KTsKK3Nob3VsZEJlKCJk b2N1bWVudC5xdWVyeUNvbW1hbmRWYWx1ZSgnZm9vZm9vJykiLCAiJyciKTsKK3Nob3VsZEJlKCJ0 eXBlb2YgZG9jdW1lbnQucXVlcnlDb21tYW5kVmFsdWUoJ2Zvb2ZvbycpIiwgIidzdHJpbmcnIik7 CitzaG91bGRCZSgiZG9jdW1lbnQucXVlcnlDb21tYW5kVmFsdWUoJ2ZvbnRTaXplJykiLCAiJzUn Iik7CitzaG91bGRCZSgidHlwZW9mIGRvY3VtZW50LnF1ZXJ5Q29tbWFuZFZhbHVlKCdmb250U2l6 ZScpIiwgIidzdHJpbmcnIik7Cis8L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9mYXN0L2pz L3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9odG1sPgpJbmRleDogTGF5 b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC91c2UtY3NzLWV4cGVjdGVkLnR4dAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL3VzZS1jc3MtZXhwZWN0ZWQu dHh0CShyZXZpc2lvbiAxMTc3MDgpCisrKyBMYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5k L3VzZS1jc3MtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC05LDcgKzksNyBAQCBQQVNT IHVzZUNTUyBjaGFuZ2VkIHRoZSBzdGF0ZSBzdWNjZXNzZnVsCiBQQVNTIHVzZUNTUyBjaGFuZ2Vk IHRoZSBzdGF0ZSBzdWNjZXNzZnVsbHkKIFBBU1MgdXNlQ1NTIGNoYW5nZWQgdGhlIHN0YXRlIHN1 Y2Nlc3NmdWxseQogUEFTUyBxdWVyeUNvbW1hbmRTdGF0ZSgndXNlQ1NTJykgcmV0dXJucyBmYWxz ZQotUEFTUyBxdWVyeUNvbW1hbmRWYWx1ZSgndXNlQ1NTJykgcmV0dXJucyBmYWxzZQorUEFTUyBx dWVyeUNvbW1hbmRWYWx1ZSgndXNlQ1NTJykgcmV0dXJucyAnJwogUEFTUyBvbmUgdW5kZXJsaW5l IGNvbW1hbmQgY29udmVydGVkIHRlc3QgdG8gPHNwYW4gc3R5bGU9InRleHQtZGVjb3JhdGlvbjog dW5kZXJsaW5lOyI+dGVzdDwvc3Bhbj4KIFBBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUK IApJbmRleDogTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC91c2UtY3NzLmh0bWwKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC91c2UtY3NzLmh0bWwJ KHJldmlzaW9uIDExNzcwOCkKKysrIExheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvdXNl LWNzcy5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC00NSwxMCArNDUsMTAgQEAgaWYgKGRvY3VtZW50 LnF1ZXJ5Q29tbWFuZFN0YXRlKCd1c2VDU1MnKQogZWxzZQogICAgIHRlc3RGYWlsZWQoInF1ZXJ5 Q29tbWFuZFN0YXRlKCd1c2VDU1MnKSBzaG91bGQgcmV0dXJuIGJvb2xlYW4gZmFsc2UiKTsKIAot aWYgKGRvY3VtZW50LnF1ZXJ5Q29tbWFuZFZhbHVlKCd1c2VDU1MnKSA9PT0gZmFsc2UpCi0gICAg dGVzdFBhc3NlZCgicXVlcnlDb21tYW5kVmFsdWUoJ3VzZUNTUycpIHJldHVybnMgZmFsc2UiKTsK K2lmIChkb2N1bWVudC5xdWVyeUNvbW1hbmRWYWx1ZSgndXNlQ1NTJykgPT09ICIiKQorICAgIHRl c3RQYXNzZWQoInF1ZXJ5Q29tbWFuZFZhbHVlKCd1c2VDU1MnKSByZXR1cm5zICcnIik7CiBlbHNl Ci0gICAgdGVzdEZhaWxlZCgicXVlcnlDb21tYW5kVmFsdWUoJ3VzZUNTUycpIHNob3VsZCByZXR1 cm4gYm9vbGVhbiBmYWxzZSIpOworICAgIHRlc3RGYWlsZWQoInF1ZXJ5Q29tbWFuZFZhbHVlKCd1 c2VDU1MnKSBzaG91bGQgcmV0dXJuIHN0cmluZyAnJyIpOwogCiB0ZXN0U2luZ2xlVG9nZ2xlKCJ1 bmRlcmxpbmUiLCAidGVzdCIsICI8c3BhbiBzdHlsZT1cInRleHQtZGVjb3JhdGlvbjogdW5kZXJs aW5lO1wiPnRlc3Q8L3NwYW4+Iik7CiAK