86962 2012-05-20 04:29:57 -0700 [GTK][DRT] Wrong cache model is taken in LayoutTestController's setCacheModel() 2012-05-22 11:17:44 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 mikhail.pozdnyakov mikhail.pozdnyakov gustavo webkit.review.bot oldest_to_newest 628570 0 mikhail.pozdnyakov 2012-05-20 04:29:57 -0700 In order to be consistent with other Webkit ports GTK's LayoutTestController::setCacheModel(int cacheModel) should set WEBKIT_CACHE_MODEL_WEB_BROWSER if cacheModel is equal to 3, currently sets WEBKIT_CACHE_MODEL_DOCUMENT_BROWSER. 628571 1 142897 mikhail.pozdnyakov 2012-05-20 04:37:22 -0700 Created attachment 142897 patch 628572 2 142898 mikhail.pozdnyakov 2012-05-20 04:43:14 -0700 Created attachment 142898 patch v2 (fixed bug title changelog) 629333 3 142898 gustavo 2012-05-21 11:51:50 -0700 Comment on attachment 142898 patch v2 (fixed bug title changelog) View in context: https://bugs.webkit.org/attachment.cgi?id=142898&action=review > Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:655 > case 3: > - webkit_set_cache_model(WEBKIT_CACHE_MODEL_DOCUMENT_BROWSER); > + webkit_set_cache_model(WEBKIT_CACHE_MODEL_WEB_BROWSER); Your change looks right to me, but... that case should be 2 not 3, and 2 should be falling down to the ASSERT_NOT_REACHED(), so I'm wondering if this is used at all. Hah, it's not used indeed: kov@goiaba ~/s/W/LayoutTests> git grep setCacheModel fast/dom/HTMLScriptElement/nested-execution.html: layoutTestController.setCacheModel(0); // WebCacheModelDocumentViewer platform/chromium/test_expectations.txt:// This test requires LayoutTestController.setCacheModel, which we don't platform/efl/Skipped:# EFL's LayoutTestController does not implement setCacheModel platform/wk2/Skipped:# WebKitTestRunner needs layoutTestController.setCacheModel Please fix the case too. 630033 4 143211 mikhail.pozdnyakov 2012-05-22 00:27:35 -0700 Created attachment 143211 patch v3 (fixed case also) 630036 5 mikhail.pozdnyakov 2012-05-22 00:29:58 -0700 (In reply to comment #3) > Please fix the case too. Wow! I did not noticed that issue.. Thanks for review. 630568 6 143211 webkit.review.bot 2012-05-22 11:17:39 -0700 Comment on attachment 143211 patch v3 (fixed case also) Clearing flags on attachment: 143211 Committed r118007: <http://trac.webkit.org/changeset/118007> 630569 7 webkit.review.bot 2012-05-22 11:17:44 -0700 All reviewed patches have been landed. Closing bug. 142897 2012-05-20 04:37:22 -0700 2012-05-20 04:40:25 -0700 patch bug86962 text/plain 1505 mikhail.pozdnyakov Y29tbWl0IGVmZjA4NzgyODU5ZTkxNmQyZjQ3NTlkYzVhMDA3OTNlODU2YjVhZjQKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPHBvemRueWFrb3YubWlraGFpbEBnbWFpbC5jb20+CkRhdGU6ICAg U3VuIE1heSAyMCAxNDozMzo0NSAyMDEyICswMzAwCgogICAgYnVnODY5NjIKCmRpZmYgLS1naXQg YS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjk3YTZiYi4uNzllMTIz NyAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAt MSwzICsxLDEzIEBACisyMDEyLTA1LTIwICBNaWtoYWlsIFBvemRueWFrb3YgIDxtaWtoYWlsLnBv emRueWFrb3ZAaW50ZWwuY29tPgorCisgICAgICAgIFtHVEtdW0RSVF0gV3JvbmcgdGVzdCBwb2xp Y3kgaXMgdGFrZW4gaW4gTGF5b3V0VGVzdENvbnRyb2xsZXIncyBzZXRDYWNoZU1vZGVsKCkKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2OTYyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVy VHJlZS9ndGsvTGF5b3V0VGVzdENvbnRyb2xsZXJHdGsuY3BwOgorICAgICAgICAoTGF5b3V0VGVz dENvbnRyb2xsZXI6OnNldENhY2hlTW9kZWwpOiBTZXRzIFdFQktJVF9DQUNIRV9NT0RFTF9XRUJf QlJPV1NFUiBpZiBhcmd1bWVudCBpcyAzLgorCiAyMDEyLTA1LTE5ICBLZXZpbiBPbGxpdmllciAg PGtldmlub0B0aGVvbGxpdmllcnMuY29tPgogCiAgICAgICAgIFt3eF0gVW5yZXZpZXdlZCBidWls ZCBmaXguIERvbid0IHN0b3AgdGhlIGJ1aWxkIGlmIGEgYnVpbGQgc3lzdGVtIHVwZGF0ZSBjaGVj ayBmYWlscy4KZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9MYXlvdXRUZXN0 Q29udHJvbGxlckd0ay5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsvTGF5b3V0VGVzdENv bnRyb2xsZXJHdGsuY3BwCmluZGV4IDJlOWQ3ZmMuLmU4MDJhM2YgMTAwNjQ0Ci0tLSBhL1Rvb2xz L0R1bXBSZW5kZXJUcmVlL2d0ay9MYXlvdXRUZXN0Q29udHJvbGxlckd0ay5jcHAKKysrIGIvVG9v bHMvRHVtcFJlbmRlclRyZWUvZ3RrL0xheW91dFRlc3RDb250cm9sbGVyR3RrLmNwcApAQCAtNjUy LDcgKzY1Miw3IEBAIHZvaWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6OnNldENhY2hlTW9kZWwoaW50 IGNhY2hlTW9kZWwpCiAgICAgICAgIHdlYmtpdF9zZXRfY2FjaGVfbW9kZWwoV0VCS0lUX0NBQ0hF X01PREVMX0RPQ1VNRU5UX0JST1dTRVIpOwogICAgICAgICBicmVhazsKICAgICBjYXNlIDM6Ci0g ICAgICAgIHdlYmtpdF9zZXRfY2FjaGVfbW9kZWwoV0VCS0lUX0NBQ0hFX01PREVMX0RPQ1VNRU5U X0JST1dTRVIpOworICAgICAgICB3ZWJraXRfc2V0X2NhY2hlX21vZGVsKFdFQktJVF9DQUNIRV9N T0RFTF9XRUJfQlJPV1NFUik7CiAgICAgICAgIGJyZWFrOwogICAgIGRlZmF1bHQ6CiAgICAgICAg IEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwo= 142898 2012-05-20 04:43:14 -0700 2012-05-22 00:27:35 -0700 patch v2 (fixed bug title changelog) bug86962_v2 text/plain 1505 mikhail.pozdnyakov Y29tbWl0IGMwYjFlN2U3MTMwM2RmZjk2ZmVkOThjMWQxYmQ5YmY4YzBkYWRjNzEKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPHBvemRueWFrb3YubWlraGFpbEBnbWFpbC5jb20+CkRhdGU6ICAg U3VuIE1heSAyMCAxNDozMzo0NSAyMDEyICswMzAwCgogICAgYnVnODY5NjIKCmRpZmYgLS1naXQg YS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjk3YTZiYi4uZDE1Mzgy NiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAt MSwzICsxLDEzIEBACisyMDEyLTA1LTIwICBNaWtoYWlsIFBvemRueWFrb3YgIDxtaWtoYWlsLnBv emRueWFrb3ZAaW50ZWwuY29tPgorCisgICAgICAgIFtHVEtdW0RSVF0gV3JvbmcgY2FjaGUgbW9k ZWwgaXMgdGFrZW4gaW4gTGF5b3V0VGVzdENvbnRyb2xsZXIncyBzZXRDYWNoZU1vZGVsKCkKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2OTYyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVy VHJlZS9ndGsvTGF5b3V0VGVzdENvbnRyb2xsZXJHdGsuY3BwOgorICAgICAgICAoTGF5b3V0VGVz dENvbnRyb2xsZXI6OnNldENhY2hlTW9kZWwpOiBTZXRzIFdFQktJVF9DQUNIRV9NT0RFTF9XRUJf QlJPV1NFUiBpZiBhcmd1bWVudCBpcyAzLgorCiAyMDEyLTA1LTE5ICBLZXZpbiBPbGxpdmllciAg PGtldmlub0B0aGVvbGxpdmllcnMuY29tPgogCiAgICAgICAgIFt3eF0gVW5yZXZpZXdlZCBidWls ZCBmaXguIERvbid0IHN0b3AgdGhlIGJ1aWxkIGlmIGEgYnVpbGQgc3lzdGVtIHVwZGF0ZSBjaGVj ayBmYWlscy4KZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9MYXlvdXRUZXN0 Q29udHJvbGxlckd0ay5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsvTGF5b3V0VGVzdENv bnRyb2xsZXJHdGsuY3BwCmluZGV4IDJlOWQ3ZmMuLmU4MDJhM2YgMTAwNjQ0Ci0tLSBhL1Rvb2xz L0R1bXBSZW5kZXJUcmVlL2d0ay9MYXlvdXRUZXN0Q29udHJvbGxlckd0ay5jcHAKKysrIGIvVG9v bHMvRHVtcFJlbmRlclRyZWUvZ3RrL0xheW91dFRlc3RDb250cm9sbGVyR3RrLmNwcApAQCAtNjUy LDcgKzY1Miw3IEBAIHZvaWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6OnNldENhY2hlTW9kZWwoaW50 IGNhY2hlTW9kZWwpCiAgICAgICAgIHdlYmtpdF9zZXRfY2FjaGVfbW9kZWwoV0VCS0lUX0NBQ0hF X01PREVMX0RPQ1VNRU5UX0JST1dTRVIpOwogICAgICAgICBicmVhazsKICAgICBjYXNlIDM6Ci0g ICAgICAgIHdlYmtpdF9zZXRfY2FjaGVfbW9kZWwoV0VCS0lUX0NBQ0hFX01PREVMX0RPQ1VNRU5U X0JST1dTRVIpOworICAgICAgICB3ZWJraXRfc2V0X2NhY2hlX21vZGVsKFdFQktJVF9DQUNIRV9N T0RFTF9XRUJfQlJPV1NFUik7CiAgICAgICAgIGJyZWFrOwogICAgIGRlZmF1bHQ6CiAgICAgICAg IEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwo= 143211 2012-05-22 00:27:35 -0700 2012-05-22 11:17:39 -0700 patch v3 (fixed case also) bug86962_v3 text/plain 1517 mikhail.pozdnyakov Y29tbWl0IDU5NzQ0MmUzNjFhODQxNGFhZWVkNGU4MzBmZTUyYzc2OGE5ZDI2NTMKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPHBvemRueWFrb3YubWlraGFpbEBnbWFpbC5jb20+CkRhdGU6ICAg U3VuIE1heSAyMCAxNDozMzo0NSAyMDEyICswMzAwCgogICAgYnVnODY5NjIKCmRpZmYgLS1naXQg YS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzMyZmFhNC4uNDYwNTFj NCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAt MSwzICsxLDEzIEBACisyMDEyLTA1LTIwICBNaWtoYWlsIFBvemRueWFrb3YgIDxtaWtoYWlsLnBv emRueWFrb3ZAaW50ZWwuY29tPgorCisgICAgICAgIFtHVEtdW0RSVF0gV3JvbmcgY2FjaGUgbW9k ZWwgaXMgdGFrZW4gaW4gTGF5b3V0VGVzdENvbnRyb2xsZXIncyBzZXRDYWNoZU1vZGVsKCkKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2OTYyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVy VHJlZS9ndGsvTGF5b3V0VGVzdENvbnRyb2xsZXJHdGsuY3BwOgorICAgICAgICAoTGF5b3V0VGVz dENvbnRyb2xsZXI6OnNldENhY2hlTW9kZWwpOiBTZXRzIFdFQktJVF9DQUNIRV9NT0RFTF9XRUJf QlJPV1NFUiBpZiBhcmd1bWVudCBpcyAyLgorCiAyMDEyLTA1LTIxICBDaHJpc3RvcGhlIER1bWV6 ICA8Y2hyaXN0b3BoZS5kdW1lekBpbnRlbC5jb20+CiAKICAgICAgICAgW0VGTF0gRUZMJ3MgRHVt cFJlbmRlclRyZWUgZG9lcyBub3QgcHJpbnQgZGlkUmVjZWl2ZVRpdGxlIG1lc3NhZ2VzCmRpZmYg LS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsvTGF5b3V0VGVzdENvbnRyb2xsZXJHdGsu Y3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0xheW91dFRlc3RDb250cm9sbGVyR3RrLmNw cAppbmRleCBkNTc4NzVkLi45NTFkMmJlIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJl ZS9ndGsvTGF5b3V0VGVzdENvbnRyb2xsZXJHdGsuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJU cmVlL2d0ay9MYXlvdXRUZXN0Q29udHJvbGxlckd0ay5jcHAKQEAgLTY1MSw4ICs2NTEsOCBAQCB2 b2lkIExheW91dFRlc3RDb250cm9sbGVyOjpzZXRDYWNoZU1vZGVsKGludCBjYWNoZU1vZGVsKQog ICAgIGNhc2UgMToKICAgICAgICAgd2Via2l0X3NldF9jYWNoZV9tb2RlbChXRUJLSVRfQ0FDSEVf TU9ERUxfRE9DVU1FTlRfQlJPV1NFUik7CiAgICAgICAgIGJyZWFrOwotICAgIGNhc2UgMzoKLSAg ICAgICAgd2Via2l0X3NldF9jYWNoZV9tb2RlbChXRUJLSVRfQ0FDSEVfTU9ERUxfRE9DVU1FTlRf QlJPV1NFUik7CisgICAgY2FzZSAyOgorICAgICAgICB3ZWJraXRfc2V0X2NhY2hlX21vZGVsKFdF QktJVF9DQUNIRV9NT0RFTF9XRUJfQlJPV1NFUik7CiAgICAgICAgIGJyZWFrOwogICAgIGRlZmF1 bHQ6CiAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwo=