<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>86961</bug_id>
          
          <creation_ts>2012-05-20 04:22:24 -0700</creation_ts>
          <short_desc>[EFL] Check if ecore_x is initialised before calling ecore_x_bell to avoid crash</short_desc>
          <delta_ts>2012-09-04 06:32:13 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit EFL</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>88098</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Sudarsana Nagineni (babu)">naginenis</reporter>
          <assigned_to name="Alexander Shalamov">alexander.shalamov</assigned_to>
          <cc>abarth</cc>
    
    <cc>alexander.shalamov</cc>
    
    <cc>cdumez</cc>
    
    <cc>dpranke</cc>
    
    <cc>d-r</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>lucas.de.marchi</cc>
    
    <cc>ojan</cc>
    
    <cc>ossy</cc>
    
    <cc>rakuco</cc>
    
    <cc>tmpsantos</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>628568</commentid>
    <comment_count>0</comment_count>
    <who name="Sudarsana Nagineni (babu)">naginenis</who>
    <bug_when>2012-05-20 04:22:24 -0700</bug_when>
    <thetext>editing/execCommand/paste-and-match-style-event.html crashes on EFL port

#0  XBell (dpy=0x0, percent=0) at ../../src/Bell.c:39
39      ../../src/Bell.c: No such file or directory.
(gdb) bt
#0  XBell (dpy=0x0, percent=0) at ../../src/Bell.c:39
#1  0x00007ffe09f69e45 in ecore_x_bell (percent=&lt;optimized out&gt;) at ecore_x.c:987
#2  0x00007ffe0f27313e in WebCore::systemBeep () at /WebKit/Source/WebCore/platform/efl/SoundEfl.cpp:42
#3  0x00007ffe0e514a6f in WebCore::Editor::copy (this=0x24c0c20) at /WebKit/Source/WebCore/editing/Editor.cpp:1002
#4  0x00007ffe0e524118 in WebCore::executeCopy (frame=0x24c06c0) at /WebKit/Source/WebCore/editing/EditorCommand.cpp:287
#5  0x00007ffe0e5282d1 in WebCore::Editor::Command::execute (this=0x7ffff81e2620, parameter=&quot;(null)&quot;, triggeringEvent=0x0)
    at /WebKit/Source/WebCore/editing/EditorCommand.cpp:1690
#6  0x00007ffe0e3f42ac in WebCore::Document::execCommand (this=0x25d1c00, commandName=&quot;Copy&quot;, userInterface=false, value=&quot;(null)&quot;)
    at /WebKit/Source/WebCore/dom/Document.cpp:4472
#7  0x00007ffe0ef3c91b in WebCore::jsDocumentPrototypeFunctionExecCommand (exec=0x7ffdbecd9108)
    at /WebKit/WebKitBuild/Debug/DerivedSources/WebCore/JSDocument.cpp:2504
#8  0x00007ffdc0362265 in ?? ()
#9  0x00007ffff81e27e0 in ?? ()
#10 0x00007ffdc0362f23 in ?? ()
#11 0x00007ffff81e2760 in ?? ()
#12 0x00007ffdbe44f6a0 in ?? ()
#13 0x00000000025cae40 in ?? ()
#14 0x00007ffff81e27b0 in ?? ()
#15 0x00007ffdbe3ccdc0 in ?? ()
#16 0x00007ffe122a6c8d in JSC::Register::Register (this=0x7ffe0a0cd960) at /WebKit/Source/JavaScriptCore/interpreter/Register.h:105
#17 0x00007ffe1240990a in JSC::JITCode::execute (this=0x7ffdbe389558, registerFile=0x25ac518, callFrame=0x7ffdbecd9040, globalData=0x25b5af0)
    at /WebKit/Source/JavaScriptCore/jit/JITCode.h:127
#18 0x00007ffe12406346 in JSC::Interpreter::executeCall (this=0x25ac500, callFrame=0x7ffdbe42fae0, function=0x7ffdbe3ccdc0, callType=JSC::CallTypeJS,
    callData=..., thisValue=..., args=...) at /WebKit/Source/JavaScriptCore/interpreter/Interpreter.cpp:1304
#19 0x00007ffe124ba54c in JSC::call (exec=0x7ffdbe42fae0, functionObject=..., callType=JSC::CallTypeJS, callData=..., thisValue=..., args=...)
    at /WebKit/Source/JavaScriptCore/runtime/CallData.cpp:39
#20 0x00007ffe0ee4b520 in WebCore::JSMainThreadExecState::call (exec=0x7ffdbe42fae0, functionObject=..., callType=JSC::CallTypeJS, callData=...,
    thisValue=..., args=...) at /WebKit/Source/WebCore/bindings/js/JSMainThreadExecState.h:56
#21 0x00007ffe0ee70baa in WebCore::JSEventListener::handleEvent (this=0x294e940, scriptExecutionContext=0x25d1d30, event=0x250b880)
    at /WebKit/Source/WebCore/bindings/js/JSEventListener.cpp:133
#22 0x00007ffe0e45fa5a in WebCore::EventTarget::fireEventListeners (this=0x24fdaf0, event=0x250b880, d=0x24fdc28,
    entry=WTF::Vector of length 1, capacity 1 = {...}) at /WebKit/Source/WebCore/dom/EventTarget.cpp:231
#23 0x00007ffe0e45f8b4 in WebCore::EventTarget::fireEventListeners (this=0x24fdaf0, event=0x250b880)
    at /WebKit/Source/WebCore/dom/EventTarget.cpp:198
#24 0x00007ffe0e82ce8c in WebCore::DOMWindow::dispatchEvent (this=0x24fdaf0, prpEvent=..., prpTarget=...)
    at /WebKit/Source/WebCore/page/DOMWindow.cpp:1642
#25 0x00007ffe0e82cc03 in WebCore::DOMWindow::dispatchLoadEvent (this=0x24fdaf0) at /WebKit/Source/WebCore/page/DOMWindow.cpp:1616
---Type &lt;return&gt; to continue, or q &lt;return&gt; to quit---
#26 0x00007ffe0e3f28bf in WebCore::Document::dispatchWindowLoadEvent (this=0x25d1c00) at /WebKit/Source/WebCore/dom/Document.cpp:3983
#27 0x00007ffe0e3ecdfb in WebCore::Document::implicitClose (this=0x25d1c00) at /WebKit/Source/WebCore/dom/Document.cpp:2445
#28 0x00007ffe0e77d583 in WebCore::FrameLoader::checkCallImplicitClose (this=0x24c0758) at /WebKit/Source/WebCore/loader/FrameLoader.cpp:761
#29 0x00007ffe0e77d339 in WebCore::FrameLoader::checkCompleted (this=0x24c0758) at /WebKit/Source/WebCore/loader/FrameLoader.cpp:707
#30 0x00007ffe0e77d11c in WebCore::FrameLoader::loadDone (this=0x24c0758) at /WebKit/Source/WebCore/loader/FrameLoader.cpp:653
#31 0x00007ffe0e7eed43 in WebCore::CachedResourceLoader::loadDone (this=0x250c620)
    at /WebKit/Source/WebCore/loader/cache/CachedResourceLoader.cpp:663
#32 0x00007ffe0e7aea5c in WebCore::SubresourceLoader::releaseResources (this=0x25df550)
    at /WebKit/Source/WebCore/loader/SubresourceLoader.cpp:317
#33 0x00007ffe0e7aa1f2 in WebCore::ResourceLoader::didFinishLoading (this=0x25df550, finishTime=0)
    at /WebKit/Source/WebCore/loader/ResourceLoader.cpp:298
#34 0x00007ffe0e7ae649 in WebCore::SubresourceLoader::didFinishLoading (this=0x25df550, finishTime=0)
    at /WebKit/Source/WebCore/loader/SubresourceLoader.cpp:278
#35 0x00007ffe0e7aa967 in WebCore::ResourceLoader::didFinishLoading (this=0x25df550, finishTime=0)
    at /WebKit/Source/WebCore/loader/ResourceLoader.cpp:435
#36 0x00007ffe0f28b43f in WebCore::readCallback (source=0x24a5ea0, asyncResult=0x24a0920, data=0x25c6960)
    at /WebKit/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:864
#37 0x00007ffe08996a99 in async_ready_callback_wrapper (source_object=0x24a5ea0, res=0x24a0920, user_data=0x25c6960) at ginputstream.c:470
#38 0x00007ffe089a90e7 in g_simple_async_result_complete (simple=0x24a0920) at gsimpleasyncresult.c:767
#39 0x00007ffe089a9168 in complete_in_idle_cb_for_thread (_data=0x24d13c0) at gsimpleasyncresult.c:835
#40 0x00007ffe09ff5623 in g_main_dispatch (context=0xffff000000000002) at gmain.c:2539
#41 g_main_context_dispatch (context=0xffff000000000002) at gmain.c:3075
#42 0x00007ffe12b275e1 in _ecore_glib_select__locked (ecore_timeout=0x25f5110, efds=&lt;optimized out&gt;, wfds=&lt;optimized out&gt;, rfds=&lt;optimized out&gt;,
    ecore_fds=1, ctx=&lt;optimized out&gt;) at ecore_glib.c:171
#43 _ecore_glib_select (ecore_fds=1, rfds=&lt;optimized out&gt;, wfds=&lt;optimized out&gt;, efds=&lt;optimized out&gt;, ecore_timeout=0x25f5110) at ecore_glib.c:205
#44 0x00007ffe12b219ad in _ecore_main_select (timeout=&lt;optimized out&gt;) at ecore_main.c:1419
#45 0x00007ffe12b22445 in _ecore_main_loop_iterate_internal (once_only=0) at ecore_main.c:1835
#46 0x00007ffe12b22727 in ecore_main_loop_begin () at ecore_main.c:906
#47 0x00000000004620c5 in runTest (cTestPathOrURL=0x7ffff81e3770 &quot;/WebKit/LayoutTests/editing/execCommand/paste-and-match-style-event.html&quot;)
    at /WebKit/Tools/DumpRenderTree/efl/DumpRenderTree.cpp:249
#48 0x000000000046223e in runTestingServerLoop () at /WebKit/Tools/DumpRenderTree/efl/DumpRenderTree.cpp:275
#49 0x000000000046288e in main (argc=2, argv=0x7ffff81e48c8) at /WebKit/Tools/DumpRenderTree/efl/DumpRenderTree.cpp:411
(gdb)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>638177</commentid>
    <comment_count>1</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-05-31 03:05:48 -0700</bug_when>
    <thetext>*** Bug 87945 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>638179</commentid>
    <comment_count>2</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-05-31 03:07:16 -0700</bug_when>
    <thetext>ecore_x_init() needs to be called in the ewk_main. Will upload a patch for this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>638195</commentid>
    <comment_count>3</comment_count>
      <attachid>145041</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-05-31 03:32:46 -0700</bug_when>
    <thetext>Created attachment 145041
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>638201</commentid>
    <comment_count>4</comment_count>
      <attachid>145041</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2012-05-31 03:43:16 -0700</bug_when>
    <thetext>Comment on attachment 145041
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145041&amp;action=review

&gt; Source/WebKit/efl/ewk/ewk_main.cpp:40
&gt; +#ifdef HAVE_ECORE_X

Generally, WebKit doesn&apos;t puts #ifdef ~ #endif statement in include file list.

- http://trac.webkit.org/browser/trunk/Source/WebCore/platform/efl/WidgetEfl.cpp#L49
- http://trac.webkit.org/browser/trunk/Source/WebCore/platform/efl/EflScreenUtilities.cpp#L22</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>638204</commentid>
    <comment_count>5</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-05-31 03:53:01 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; (From update of attachment 145041 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=145041&amp;action=review
&gt; 
&gt; &gt; Source/WebKit/efl/ewk/ewk_main.cpp:40
&gt; &gt; +#ifdef HAVE_ECORE_X
&gt; 
&gt; Generally, WebKit doesn&apos;t puts #ifdef ~ #endif statement in include file list.
&gt; 
&gt; - http://trac.webkit.org/browser/trunk/Source/WebCore/platform/efl/WidgetEfl.cpp#L49
&gt; - http://trac.webkit.org/browser/trunk/Source/WebCore/platform/efl/EflScreenUtilities.cpp#L22

Gyuyoung, I don&apos;t understand because in the 2 examples you provide, #ifdef is used for includes and this is not my code. For the record, I used Source/WebCore/platform/efl/SoundEfl.cpp as reference which does the following:

#ifdef HAVE_ECORE_X
#include &lt;Ecore_X.h&gt;
#endif</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>638205</commentid>
    <comment_count>6</comment_count>
      <attachid>145042</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-05-31 03:57:05 -0700</bug_when>
    <thetext>Created attachment 145042
Patch

Small fix in #ifdef placement. I&apos;m still keeping the #ifdef for the include though. This is a header that is external to WebKit.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>638211</commentid>
    <comment_count>7</comment_count>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2012-05-31 04:10:03 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; (In reply to comment #4)
&gt; &gt; (From update of attachment 145041 [details] [details])
&gt; &gt; View in context: https://bugs.webkit.org/attachment.cgi?id=145041&amp;action=review
&gt; &gt; 
&gt; &gt; &gt; Source/WebKit/efl/ewk/ewk_main.cpp:40
&gt; &gt; &gt; +#ifdef HAVE_ECORE_X
&gt; &gt; 
&gt; &gt; Generally, WebKit doesn&apos;t puts #ifdef ~ #endif statement in include file list.
&gt; &gt; 
&gt; &gt; - http://trac.webkit.org/browser/trunk/Source/WebCore/platform/efl/WidgetEfl.cpp#L49
&gt; &gt; - http://trac.webkit.org/browser/trunk/Source/WebCore/platform/efl/EflScreenUtilities.cpp#L22
&gt; 
&gt; Gyuyoung, I don&apos;t understand because in the 2 examples you provide, #ifdef is used for includes and this is not my code. For the record, I used Source/WebCore/platform/efl/SoundEfl.cpp as reference which does the following:
&gt; 
&gt; #ifdef HAVE_ECORE_X
&gt; #include &lt;Ecore_X.h&gt;
&gt; #endif

Look at Internals.cpp file or webkitwebview.cpp.  #ifdef ~ #else in include list is independently placed.

 - http://trac.webkit.org/browser/trunk/Source/WebCore/testing/Internals.cpp#L66
 - http://trac.webkit.org/browser/trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp#L117

Though it seems this is not rule, I prefer this to mix #ifdef. In addition, it seems to me WebKit tends to use my suggestion. Of course, this is trivial issue.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>638220</commentid>
    <comment_count>8</comment_count>
      <attachid>145046</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-05-31 04:23:19 -0700</bug_when>
    <thetext>Created attachment 145046
Patch

Ok, I think I understood what you meant now. Hopefully, this new patch is what you wanted.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>638226</commentid>
    <comment_count>9</comment_count>
      <attachid>145046</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2012-05-31 04:30:00 -0700</bug_when>
    <thetext>Comment on attachment 145046
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145046&amp;action=review

&gt; Source/WebKit/efl/ewk/ewk_main.cpp:50
&gt; +#ifdef HAVE_ECORE_X

Sorry for my poor comment. This is what I want exactly.

&gt; Source/WebKit/efl/ewk/ewk_main.cpp:115
&gt; +error_ecore_x:

BTW, doesn&apos;t ecore_x_shutdown() needs to be called in *error_ecore_x* case instead of *error_edje* case?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>638231</commentid>
    <comment_count>10</comment_count>
      <attachid>145046</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-05-31 04:36:03 -0700</bug_when>
    <thetext>Comment on attachment 145046
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145046&amp;action=review

&gt;&gt; Source/WebKit/efl/ewk/ewk_main.cpp:115
&gt;&gt; +error_ecore_x:
&gt; 
&gt; BTW, doesn&apos;t ecore_x_shutdown() needs to be called in *error_ecore_x* case instead of *error_edje* case?

No, I believe this is correct. Look at the other labels under, they do the same. There is no need to shutdown ecore x if it did not init.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>638239</commentid>
    <comment_count>11</comment_count>
      <attachid>145046</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2012-05-31 04:50:36 -0700</bug_when>
    <thetext>Comment on attachment 145046
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145046&amp;action=review

&gt;&gt;&gt; Source/WebKit/efl/ewk/ewk_main.cpp:115
&gt;&gt;&gt; +error_ecore_x:
&gt;&gt; 
&gt;&gt; BTW, doesn&apos;t ecore_x_shutdown() needs to be called in *error_ecore_x* case instead of *error_edje* case?
&gt; 
&gt; No, I believe this is correct. Look at the other labels under, they do the same. There is no need to shutdown ecore x if it did not init.

I don&apos;t understand yet. If ecore_x_init(0) fails to initialize, go to error_ecore_x label, right? Then, It seems to me error_ecore_x label needs to invoke ecore_x_shutdown() as below,

error_ecore_x:
    ecore_x_shutdown();

But, current patch calls ecore_evas_shutdown() instead of ecore_x_shutdown() when HAVE_ECORE_X is enabled. 

Let&apos;s assume there is no #ifdef HAVE_ECORE_X,

error_edje:
    ecore_x_shutdown();
error_ecore_x:
    ecore_evas_shutdown();

Is above correct ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>638318</commentid>
    <comment_count>12</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-05-31 06:18:24 -0700</bug_when>
    <thetext>(In reply to comment #11)
&gt; (From update of attachment 145046 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=145046&amp;action=review
&gt; 
&gt; &gt;&gt;&gt; Source/WebKit/efl/ewk/ewk_main.cpp:115
&gt; &gt;&gt;&gt; +error_ecore_x:
&gt; &gt;&gt; 
&gt; &gt;&gt; BTW, doesn&apos;t ecore_x_shutdown() needs to be called in *error_ecore_x* case instead of *error_edje* case?
&gt; &gt; 
&gt; &gt; No, I believe this is correct. Look at the other labels under, they do the same. There is no need to shutdown ecore x if it did not init.
&gt; 
&gt; I don&apos;t understand yet. If ecore_x_init(0) fails to initialize, go to error_ecore_x label, right? Then, It seems to me error_ecore_x label needs to invoke ecore_x_shutdown() as below,
&gt; 
&gt; error_ecore_x:
&gt;     ecore_x_shutdown();
&gt; 
&gt; But, current patch calls ecore_evas_shutdown() instead of ecore_x_shutdown() when HAVE_ECORE_X is enabled. 
&gt; 
&gt; Let&apos;s assume there is no #ifdef HAVE_ECORE_X,
&gt; 
&gt; error_edje:
&gt;     ecore_x_shutdown();
&gt; error_ecore_x:
&gt;     ecore_evas_shutdown();
&gt; 
&gt; Is above correct ?

Yes, it is.

Looks at other labels:
error_ecore:
    evas_shutdown();
error_evas: // NOT evas_shutdown()
    eina_log_domain_unregister(_ewk_log_dom);
    _ewk_log_dom = -1;
error_log_domain:
    eina_shutdown(); // NOT eina_log_domain_unregister()
error_eina:
    return 0; // NOT eina_shutdown().

All the cleanup functions are shifted by 1 compared the the labels.  The reason for that is:
If the code jumps to &quot;error_evas&quot; label, this means that evas_init() failed. As a consequence, there is no point in calling evas_shutdown(). However, we need to call the shutdown functions for all the previous init calls (i.e. eina_log_domain_register and eina init.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>638340</commentid>
    <comment_count>13</comment_count>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2012-05-31 06:36:43 -0700</bug_when>
    <thetext>(In reply to comment #12)

&gt; All the cleanup functions are shifted by 1 compared the the labels.  The reason for that is:
&gt; If the code jumps to &quot;error_evas&quot; label, this means that evas_init() failed. As a consequence, there is no point in calling evas_shutdown(). However, we need to call the shutdown functions for all the previous init calls (i.e. eina_log_domain_register and eina init.

Ok, I understand this. Thank you for your explanation. But, I don&apos;t like to goto ~ case statement. As in this case, it is a little difficult to understand algorithm logic. I would like to remove this goto statement in future. Anyway, looks good to me now. Thanks.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>639199</commentid>
    <comment_count>14</comment_count>
    <who name="Thiago Marcos P. Santos">tmpsantos</who>
    <bug_when>2012-06-01 04:41:22 -0700</bug_when>
    <thetext>LGTM but might introduce a crash here PluginViewEfl.cpp:238.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>639207</commentid>
    <comment_count>15</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-06-01 04:57:14 -0700</bug_when>
    <thetext>(In reply to comment #14)
&gt; LGTM but might introduce a crash here PluginViewEfl.cpp:238.

Would you care to elaborate? How could initializing ecore_x library cause a crash in a file I&apos;m not touching?

PluginViewEfl.cpp:238 *would* likely crash *without* without my patch since the ecore_x library was not initialized before calling ecore_x_display_get().

Also note that in ecore_x_init(0), 0 mean default display according to the doc. In case this is related to your comment.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>639245</commentid>
    <comment_count>16</comment_count>
    <who name="Thiago Marcos P. Santos">tmpsantos</who>
    <bug_when>2012-06-01 05:56:28 -0700</bug_when>
    <thetext>(In reply to comment #15)
&gt; (In reply to comment #14)
&gt; &gt; LGTM but might introduce a crash here PluginViewEfl.cpp:238.
&gt; 
&gt; Would you care to elaborate? How could initializing ecore_x library cause a crash in a file I&apos;m not touching?
&gt; 
&gt; PluginViewEfl.cpp:238 *would* likely crash *without* without my patch since the ecore_x library was not initialized before calling ecore_x_display_get().
&gt; 
&gt; Also note that in ecore_x_init(0), 0 mean default display according to the doc. In case this is related to your comment.

Sorry, I thought that you were conditioning the ecore_x initialization to HAVE_ECORE_X flag. But it is not being initialized at all.

PluginViewEfl.cpp:238 is a separated bug then.

LGTM with no remarks. :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>639269</commentid>
    <comment_count>17</comment_count>
      <attachid>145046</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-06-01 06:21:05 -0700</bug_when>
    <thetext>Comment on attachment 145046
Patch

rs=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>639319</commentid>
    <comment_count>18</comment_count>
      <attachid>145046</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-06-01 07:23:18 -0700</bug_when>
    <thetext>Comment on attachment 145046
Patch

Clearing flags on attachment: 145046

Committed r119228: &lt;http://trac.webkit.org/changeset/119228&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>639320</commentid>
    <comment_count>19</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-06-01 07:23:24 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>639354</commentid>
    <comment_count>20</comment_count>
    <who name="Sudarsana Nagineni (babu)">naginenis</who>
    <bug_when>2012-06-01 08:14:08 -0700</bug_when>
    <thetext>DRT crashes on the test startup with this patch. The EFL Buildbots are red exiting early after 20 crashes.

crash log for DumpRenderTree (pid 24858):
STDOUT: &lt;empty&gt;
STDERR: CRI&lt;24918&gt;:ewebkit /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Source/WebKit/efl/ewk/ewk_main.cpp:96 ewk_init() could not init ecore_x</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>639359</commentid>
    <comment_count>21</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-06-01 08:22:16 -0700</bug_when>
    <thetext>Re-opened since this is blocked by 88098</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>640334</commentid>
    <comment_count>22</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-06-03 22:49:48 -0700</bug_when>
    <thetext>Dominik, gyuyoung: This patch seems valid but it causes crashes on the build bot. The reason for that is that calling &quot;ecore_x_init(0)&quot; on a machine which does not have X running causes a crash :(

I believe we have 2 possible solutions:
1. Make sure the ecore_x library is not build on the build bot. This way, the ECORE_X flag will not be set and ecore_x_init(0) will never be called.
2. Install a headless X on the build bots

I think 1. is probably easier however, 2. would allow to enable/run the same tests as on a regular desktop machine.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>642355</commentid>
    <comment_count>23</comment_count>
      <attachid>145987</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-06-06 04:02:44 -0700</bug_when>
    <thetext>Created attachment 145987
Patch

Improved patch which runs each DRT in its own xfvb. This will avoid crashes on the bot due to X not running and the ecore_x library being used.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>642375</commentid>
    <comment_count>24</comment_count>
      <attachid>145987</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-06-06 04:39:06 -0700</bug_when>
    <thetext>Comment on attachment 145987
Patch

Clearing flags for now as it seems to cause trouble on my machine.
The tests run fine for a while but then I get this message:

stopping ImageDiff timed out, killing it
killed
Can not get image diff. ImageDiff program might not work correctly.

After that, it keeps going but extremely slowly and apparently with a single Xvfb running. I&apos;m not sure what&apos;s going on yet.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>710962</commentid>
    <comment_count>25</comment_count>
      <attachid>162007</attachid>
    <who name="Alexander Shalamov">alexander.shalamov</who>
    <bug_when>2012-09-04 04:29:05 -0700</bug_when>
    <thetext>Created attachment 162007
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>710967</commentid>
    <comment_count>26</comment_count>
      <attachid>162007</attachid>
    <who name="Dominik Röttsches (drott)">d-r</who>
    <bug_when>2012-09-04 04:35:02 -0700</bug_when>
    <thetext>Comment on attachment 162007
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162007&amp;action=review

Did you test this with DISPLAY unset?

&gt; Source/WebCore/platform/efl/SoundEfl.cpp:42
&gt; +    if (ecore_x_init(0)) {

This potentially initializes ecoreX multiple times, right? How about a function level static variable here to remember whether initialization completed?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>710968</commentid>
    <comment_count>27</comment_count>
      <attachid>162007</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-09-04 04:36:08 -0700</bug_when>
    <thetext>Comment on attachment 162007
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162007&amp;action=review

LGTM. Thanks.

&gt;&gt; Source/WebCore/platform/efl/SoundEfl.cpp:42
&gt;&gt; +    if (ecore_x_init(0)) {
&gt; 
&gt; This potentially initializes ecoreX multiple times, right? How about a function level static variable here to remember whether initialization completed?

No it does not. It increments a ref count.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>710972</commentid>
    <comment_count>28</comment_count>
    <who name="Alexander Shalamov">alexander.shalamov</who>
    <bug_when>2012-09-04 04:38:41 -0700</bug_when>
    <thetext>(In reply to comment #26)
&gt; (From update of attachment 162007 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=162007&amp;action=review
&gt; 
&gt; Did you test this with DISPLAY unset?

Yes, I tested with DISPLAY unset.


&gt; &gt; Source/WebCore/platform/efl/SoundEfl.cpp:42
&gt; &gt; +    if (ecore_x_init(0)) {
&gt; 
&gt; This potentially initializes ecoreX multiple times, right? How about a function level static variable here to remember whether initialization completed?

ecore_x_* has static variable for ref counting, all init / shutdown calls would increment / decrement ref count value.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>710976</commentid>
    <comment_count>29</comment_count>
      <attachid>162007</attachid>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2012-09-04 04:42:21 -0700</bug_when>
    <thetext>Comment on attachment 162007
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162007&amp;action=review

&gt;&gt;&gt;&gt; Source/WebCore/platform/efl/SoundEfl.cpp:42
&gt;&gt;&gt;&gt; +    if (ecore_x_init(0)) {
&gt;&gt;&gt; 
&gt;&gt;&gt; This potentially initializes ecoreX multiple times, right? How about a function level static variable here to remember whether initialization completed?
&gt;&gt; 
&gt;&gt; No it does not. It increments a ref count.
&gt; 
&gt; ecore_x_* has static variable for ref counting, all init / shutdown calls would increment / decrement ref count value.

why not use the new WITH_ECORE_X ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>710983</commentid>
    <comment_count>30</comment_count>
    <who name="Alexander Shalamov">alexander.shalamov</who>
    <bug_when>2012-09-04 04:48:57 -0700</bug_when>
    <thetext>(In reply to comment #29)
&gt; (From update of attachment 162007 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=162007&amp;action=review
&gt; 
&gt; &gt;&gt;&gt;&gt; Source/WebCore/platform/efl/SoundEfl.cpp:42
&gt; &gt;&gt;&gt;&gt; +    if (ecore_x_init(0)) {
&gt; &gt;&gt;&gt; 
&gt; &gt;&gt;&gt; This potentially initializes ecoreX multiple times, right? How about a function level static variable here to remember whether initialization completed?
&gt; &gt;&gt; 
&gt; &gt;&gt; No it does not. It increments a ref count.
&gt; &gt; 
&gt; &gt; ecore_x_* has static variable for ref counting, all init / shutdown calls would increment / decrement ref count value.
&gt; 
&gt; why not use the new WITH_ECORE_X ?

The macro was fetching screen to get UI related properties.
Screen or display is not needed to call a bell (ecore_x_bell).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>710989</commentid>
    <comment_count>31</comment_count>
      <attachid>162007</attachid>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2012-09-04 04:59:17 -0700</bug_when>
    <thetext>Comment on attachment 162007
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162007&amp;action=review

&gt;&gt;&gt;&gt;&gt;&gt; Source/WebCore/platform/efl/SoundEfl.cpp:42
&gt;&gt;&gt;&gt;&gt;&gt; +    if (ecore_x_init(0)) {
&gt;&gt;&gt;&gt;&gt; 
&gt;&gt;&gt;&gt;&gt; This potentially initializes ecoreX multiple times, right? How about a function level static variable here to remember whether initialization completed?
&gt;&gt;&gt;&gt; 
&gt;&gt;&gt;&gt; No it does not. It increments a ref count.
&gt;&gt;&gt; 
&gt;&gt;&gt; ecore_x_* has static variable for ref counting, all init / shutdown calls would increment / decrement ref count value.
&gt;&gt; 
&gt;&gt; why not use the new WITH_ECORE_X ?
&gt; 
&gt; The macro was fetching screen to get UI related properties.
&gt; Screen or display is not needed to call a bell (ecore_x_bell).

I guess it should be renamed then to ECORE_X_CALL_WITH_DISPLAY or so then to make that more clear</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>711058</commentid>
    <comment_count>32</comment_count>
      <attachid>162007</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-09-04 06:32:07 -0700</bug_when>
    <thetext>Comment on attachment 162007
Patch

Clearing flags on attachment: 162007

Committed r127464: &lt;http://trac.webkit.org/changeset/127464&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>711059</commentid>
    <comment_count>33</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-09-04 06:32:13 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>145041</attachid>
            <date>2012-05-31 03:32:46 -0700</date>
            <delta_ts>2012-05-31 03:57:05 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>86961_ecore_x_init.patch</filename>
            <type>text/plain</type>
            <size>3177</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCBlZTUzYWJmLi45MzlhMTBhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM
b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDUt
MzEgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAg
ICAgICBbRUZMXSBbRFJUXSBlZGl0aW5nL2V4ZWNDb21tYW5kL3Bhc3RlLWFuZC1tYXRjaC1zdHls
ZS1ldmVudC5odG1sIGNyYXNoZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTg2OTYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgVW5za2lwIGVkaXRpbmcvZXhlY0NvbW1hbmQvcGFzdGUtYW5kLW1hdGNoLXN0
eWxlLWV2ZW50Lmh0bWwgbm93IHRoYXQKKyAgICAgICAgaXQgaXMgbm8gbG9uZ2VyIGNyYXNoaW5n
IHRoYW5rcyB0byBlY29yZV94IGxpYnJhcnkgaW5pdC4KKworICAgICAgICAqIHBsYXRmb3JtL2Vm
bC90ZXN0X2V4cGVjdGF0aW9ucy50eHQ6CisKIDIwMTItMDUtMzEgIE1pa2hhaWwgUG96ZG55YWtv
diAgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CiAKICAgICAgICAgW0VGTF0gR2FyZGVu
aW5nIGFmdGVyIHIxMTg5NTcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC90
ZXN0X2V4cGVjdGF0aW9ucy50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvdGVzdF9leHBl
Y3RhdGlvbnMudHh0CmluZGV4IDI4MDAzNWYuLmQ1MDc3NTcgMTAwNjQ0Ci0tLSBhL0xheW91dFRl
c3RzL3BsYXRmb3JtL2VmbC90ZXN0X2V4cGVjdGF0aW9ucy50eHQKKysrIGIvTGF5b3V0VGVzdHMv
cGxhdGZvcm0vZWZsL3Rlc3RfZXhwZWN0YXRpb25zLnR4dApAQCAtNTU3LDggKzU1Nyw2IEBAIEJV
R1dLODQ4MzUgOiBlZGl0aW5nL2V4ZWNDb21tYW5kL2NvcHktd2l0aG91dC1zZWxlY3Rpb24uaHRt
bCA9IFRFWFQKIEJVR1dLODQ4MzUgOiBlZGl0aW5nL2V4ZWNDb21tYW5kL2ZpbmRTdHJpbmctZGlh
Y3JpdGljYWxzLmh0bWwgPSBURVhUCiBCVUdXSzg0ODM1IDogZWRpdGluZy9leGVjQ29tbWFuZC9p
bmRlbnQtcGFyYWdyYXBocy5odG1sID0gVEVYVAogCi1CVUdXSzg2OTYxIDogZWRpdGluZy9leGVj
Q29tbWFuZC9wYXN0ZS1hbmQtbWF0Y2gtc3R5bGUtZXZlbnQuaHRtbCA9IENSQVNICi0KIC8vIERS
VCBkb2Vzbid0IGNoZWNrIGZvciBpc1ByaW50aW5nKCkuCiBCVUdXSzg3MjI2IDogcHJpbnRpbmcv
aWZyYW1lLXByaW50Lmh0bWwgPSBURVhUCiBCVUdXSzg3MjI2IDogcHJpbnRpbmcvbWVkaWEtcXVl
cmllcy1wcmludC5odG1sID0gTUlTU0lORwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwv
Q2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCmluZGV4IDBkYTY4MzQuLjJm
MDAzZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZworKysgYi9Tb3Vy
Y2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0wNS0zMSAgQ2hy
aXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVtZXpAaW50ZWwuY29tPgorCisgICAgICAgIFtF
RkxdIFtEUlRdIGVkaXRpbmcvZXhlY0NvbW1hbmQvcGFzdGUtYW5kLW1hdGNoLXN0eWxlLWV2ZW50
Lmh0bWwgY3Jhc2hlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9ODY5NjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg
ICAgICBDYWxsIGVjb3JlX3hfaW5pdCgpIGluIGV3a19pbml0KCkgdG8gaW5pdGlhbGl6ZSB0aGUg
ZWNvcmVfeCBsaWJyYXJ5LgorICAgICAgICBUaGlzIGF2b2lkcyBjcmFzaGluZyB1cG9uZyBjYWxs
aW5nIFdlYkNvcmU6OnN5c3RlbUJlZXAoKSB3aGljaCB1c2VzCisgICAgICAgIGVjb3JlX3hfYmVs
bCgpIGludGVybmFsbHkuCisKKyAgICAgICAgKiBld2svZXdrX21haW4uY3BwOgorICAgICAgICAo
ZXdrX2luaXQpOgorCiAyMDEyLTA1LTMwICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0b3BoZS5k
dW1lekBpbnRlbC5jb20+CiAKICAgICAgICAgW0VGTF0gRUZMJ3MgRFJUIHNob3VsZCBwcmludCB0
aGUgbnVtYmVyIG9mIE1lc3NhZ2VQb3J0cyBmb3IgbmV3IGVhY2ggbmV3IGludGVudApkaWZmIC0t
Z2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19tYWluLmNwcCBiL1NvdXJjZS9XZWJLaXQv
ZWZsL2V3ay9ld2tfbWFpbi5jcHAKaW5kZXggYzIwNWRiNS4uODEwODNlMSAxMDA2NDQKLS0tIGEv
U291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19tYWluLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Vm
bC9ld2svZXdrX21haW4uY3BwCkBAIC0zNyw2ICszNyw5IEBACiAjaW5jbHVkZSAicnVudGltZS9J
bml0aWFsaXplVGhyZWFkaW5nLmgiCiAjaW5jbHVkZSA8RWNvcmUuaD4KICNpbmNsdWRlIDxFY29y
ZV9FdmFzLmg+CisjaWZkZWYgSEFWRV9FQ09SRV9YCisjaW5jbHVkZSA8RWNvcmVfWC5oPgorI2Vu
ZGlmCiAjaW5jbHVkZSA8RWRqZS5oPgogI2luY2x1ZGUgPEVpbmEuaD4KICNpbmNsdWRlIDxFdmFz
Lmg+CkBAIC04Niw2ICs4OSwxMyBAQCBpbnQgZXdrX2luaXQodm9pZCkKICAgICAgICAgZ290byBl
cnJvcl9lY29yZV9ldmFzOwogICAgIH0KIAorI2lmZGVmIEhBVkVfRUNPUkVfWAorICAgIGlmICgh
ZWNvcmVfeF9pbml0KDApKSB7CisgICAgICAgIENSSVRJQ0FMKCJjb3VsZCBub3QgaW5pdCBlY29y
ZV94Iik7CisgICAgICAgIGdvdG8gZXJyb3JfZWNvcmVfeDsKKyAgICB9CisjZW5kaWYKKwogICAg
IGlmICghZWRqZV9pbml0KCkpIHsKICAgICAgICAgQ1JJVElDQUwoImNvdWxkIG5vdCBpbml0IGVk
amUuIik7CiAgICAgICAgIGdvdG8gZXJyb3JfZWRqZTsKQEAgLTk5LDcgKzEwOSwxMSBAQCBpbnQg
ZXdrX2luaXQodm9pZCkKICAgICByZXR1cm4gKytfZXdrSW5pdENvdW50OwogCiBlcnJvcl9lZGpl
OgorICAgIGVjb3JlX3hfc2h1dGRvd24oKTsKKyNpZmRlZiBIQVZFX0VDT1JFX1gKK2Vycm9yX2Vj
b3JlX3g6CiAgICAgZWNvcmVfZXZhc19zaHV0ZG93bigpOworI2VuZGlmCiBlcnJvcl9lY29yZV9l
dmFzOgogICAgIGVjb3JlX3NodXRkb3duKCk7CiBlcnJvcl9lY29yZToK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>145042</attachid>
            <date>2012-05-31 03:57:05 -0700</date>
            <delta_ts>2012-05-31 04:23:19 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>86961_ecore_x_init.patch</filename>
            <type>text/plain</type>
            <size>3163</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCBlZTUzYWJmLi45MzlhMTBhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM
b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDUt
MzEgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAg
ICAgICBbRUZMXSBbRFJUXSBlZGl0aW5nL2V4ZWNDb21tYW5kL3Bhc3RlLWFuZC1tYXRjaC1zdHls
ZS1ldmVudC5odG1sIGNyYXNoZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTg2OTYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgVW5za2lwIGVkaXRpbmcvZXhlY0NvbW1hbmQvcGFzdGUtYW5kLW1hdGNoLXN0
eWxlLWV2ZW50Lmh0bWwgbm93IHRoYXQKKyAgICAgICAgaXQgaXMgbm8gbG9uZ2VyIGNyYXNoaW5n
IHRoYW5rcyB0byBlY29yZV94IGxpYnJhcnkgaW5pdC4KKworICAgICAgICAqIHBsYXRmb3JtL2Vm
bC90ZXN0X2V4cGVjdGF0aW9ucy50eHQ6CisKIDIwMTItMDUtMzEgIE1pa2hhaWwgUG96ZG55YWtv
diAgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CiAKICAgICAgICAgW0VGTF0gR2FyZGVu
aW5nIGFmdGVyIHIxMTg5NTcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC90
ZXN0X2V4cGVjdGF0aW9ucy50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvdGVzdF9leHBl
Y3RhdGlvbnMudHh0CmluZGV4IDI4MDAzNWYuLmQ1MDc3NTcgMTAwNjQ0Ci0tLSBhL0xheW91dFRl
c3RzL3BsYXRmb3JtL2VmbC90ZXN0X2V4cGVjdGF0aW9ucy50eHQKKysrIGIvTGF5b3V0VGVzdHMv
cGxhdGZvcm0vZWZsL3Rlc3RfZXhwZWN0YXRpb25zLnR4dApAQCAtNTU3LDggKzU1Nyw2IEBAIEJV
R1dLODQ4MzUgOiBlZGl0aW5nL2V4ZWNDb21tYW5kL2NvcHktd2l0aG91dC1zZWxlY3Rpb24uaHRt
bCA9IFRFWFQKIEJVR1dLODQ4MzUgOiBlZGl0aW5nL2V4ZWNDb21tYW5kL2ZpbmRTdHJpbmctZGlh
Y3JpdGljYWxzLmh0bWwgPSBURVhUCiBCVUdXSzg0ODM1IDogZWRpdGluZy9leGVjQ29tbWFuZC9p
bmRlbnQtcGFyYWdyYXBocy5odG1sID0gVEVYVAogCi1CVUdXSzg2OTYxIDogZWRpdGluZy9leGVj
Q29tbWFuZC9wYXN0ZS1hbmQtbWF0Y2gtc3R5bGUtZXZlbnQuaHRtbCA9IENSQVNICi0KIC8vIERS
VCBkb2Vzbid0IGNoZWNrIGZvciBpc1ByaW50aW5nKCkuCiBCVUdXSzg3MjI2IDogcHJpbnRpbmcv
aWZyYW1lLXByaW50Lmh0bWwgPSBURVhUCiBCVUdXSzg3MjI2IDogcHJpbnRpbmcvbWVkaWEtcXVl
cmllcy1wcmludC5odG1sID0gTUlTU0lORwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwv
Q2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCmluZGV4IDBkYTY4MzQuLjJm
MDAzZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZworKysgYi9Tb3Vy
Y2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0wNS0zMSAgQ2hy
aXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVtZXpAaW50ZWwuY29tPgorCisgICAgICAgIFtF
RkxdIFtEUlRdIGVkaXRpbmcvZXhlY0NvbW1hbmQvcGFzdGUtYW5kLW1hdGNoLXN0eWxlLWV2ZW50
Lmh0bWwgY3Jhc2hlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9ODY5NjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg
ICAgICBDYWxsIGVjb3JlX3hfaW5pdCgpIGluIGV3a19pbml0KCkgdG8gaW5pdGlhbGl6ZSB0aGUg
ZWNvcmVfeCBsaWJyYXJ5LgorICAgICAgICBUaGlzIGF2b2lkcyBjcmFzaGluZyB1cG9uZyBjYWxs
aW5nIFdlYkNvcmU6OnN5c3RlbUJlZXAoKSB3aGljaCB1c2VzCisgICAgICAgIGVjb3JlX3hfYmVs
bCgpIGludGVybmFsbHkuCisKKyAgICAgICAgKiBld2svZXdrX21haW4uY3BwOgorICAgICAgICAo
ZXdrX2luaXQpOgorCiAyMDEyLTA1LTMwICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0b3BoZS5k
dW1lekBpbnRlbC5jb20+CiAKICAgICAgICAgW0VGTF0gRUZMJ3MgRFJUIHNob3VsZCBwcmludCB0
aGUgbnVtYmVyIG9mIE1lc3NhZ2VQb3J0cyBmb3IgbmV3IGVhY2ggbmV3IGludGVudApkaWZmIC0t
Z2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19tYWluLmNwcCBiL1NvdXJjZS9XZWJLaXQv
ZWZsL2V3ay9ld2tfbWFpbi5jcHAKaW5kZXggYzIwNWRiNS4uMWNjNDRhYyAxMDA2NDQKLS0tIGEv
U291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19tYWluLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Vm
bC9ld2svZXdrX21haW4uY3BwCkBAIC0zNyw2ICszNyw5IEBACiAjaW5jbHVkZSAicnVudGltZS9J
bml0aWFsaXplVGhyZWFkaW5nLmgiCiAjaW5jbHVkZSA8RWNvcmUuaD4KICNpbmNsdWRlIDxFY29y
ZV9FdmFzLmg+CisjaWZkZWYgSEFWRV9FQ09SRV9YCisjaW5jbHVkZSA8RWNvcmVfWC5oPgorI2Vu
ZGlmCiAjaW5jbHVkZSA8RWRqZS5oPgogI2luY2x1ZGUgPEVpbmEuaD4KICNpbmNsdWRlIDxFdmFz
Lmg+CkBAIC04Niw2ICs4OSwxMyBAQCBpbnQgZXdrX2luaXQodm9pZCkKICAgICAgICAgZ290byBl
cnJvcl9lY29yZV9ldmFzOwogICAgIH0KIAorI2lmZGVmIEhBVkVfRUNPUkVfWAorICAgIGlmICgh
ZWNvcmVfeF9pbml0KDApKSB7CisgICAgICAgIENSSVRJQ0FMKCJjb3VsZCBub3QgaW5pdCBlY29y
ZV94Iik7CisgICAgICAgIGdvdG8gZXJyb3JfZWNvcmVfeDsKKyAgICB9CisjZW5kaWYKKwogICAg
IGlmICghZWRqZV9pbml0KCkpIHsKICAgICAgICAgQ1JJVElDQUwoImNvdWxkIG5vdCBpbml0IGVk
amUuIik7CiAgICAgICAgIGdvdG8gZXJyb3JfZWRqZTsKQEAgLTk5LDYgKzEwOSwxMCBAQCBpbnQg
ZXdrX2luaXQodm9pZCkKICAgICByZXR1cm4gKytfZXdrSW5pdENvdW50OwogCiBlcnJvcl9lZGpl
OgorI2lmZGVmIEhBVkVfRUNPUkVfWAorICAgIGVjb3JlX3hfc2h1dGRvd24oKTsKK2Vycm9yX2Vj
b3JlX3g6CisjZW5kaWYKICAgICBlY29yZV9ldmFzX3NodXRkb3duKCk7CiBlcnJvcl9lY29yZV9l
dmFzOgogICAgIGVjb3JlX3NodXRkb3duKCk7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>145046</attachid>
            <date>2012-05-31 04:23:19 -0700</date>
            <delta_ts>2012-06-06 04:02:44 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>86961_ecore_x_init.patch</filename>
            <type>text/plain</type>
            <size>3113</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCBlZTUzYWJmLi45MzlhMTBhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM
b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDUt
MzEgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAg
ICAgICBbRUZMXSBbRFJUXSBlZGl0aW5nL2V4ZWNDb21tYW5kL3Bhc3RlLWFuZC1tYXRjaC1zdHls
ZS1ldmVudC5odG1sIGNyYXNoZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTg2OTYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgVW5za2lwIGVkaXRpbmcvZXhlY0NvbW1hbmQvcGFzdGUtYW5kLW1hdGNoLXN0
eWxlLWV2ZW50Lmh0bWwgbm93IHRoYXQKKyAgICAgICAgaXQgaXMgbm8gbG9uZ2VyIGNyYXNoaW5n
IHRoYW5rcyB0byBlY29yZV94IGxpYnJhcnkgaW5pdC4KKworICAgICAgICAqIHBsYXRmb3JtL2Vm
bC90ZXN0X2V4cGVjdGF0aW9ucy50eHQ6CisKIDIwMTItMDUtMzEgIE1pa2hhaWwgUG96ZG55YWtv
diAgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CiAKICAgICAgICAgW0VGTF0gR2FyZGVu
aW5nIGFmdGVyIHIxMTg5NTcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC90
ZXN0X2V4cGVjdGF0aW9ucy50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvdGVzdF9leHBl
Y3RhdGlvbnMudHh0CmluZGV4IDI4MDAzNWYuLmQ1MDc3NTcgMTAwNjQ0Ci0tLSBhL0xheW91dFRl
c3RzL3BsYXRmb3JtL2VmbC90ZXN0X2V4cGVjdGF0aW9ucy50eHQKKysrIGIvTGF5b3V0VGVzdHMv
cGxhdGZvcm0vZWZsL3Rlc3RfZXhwZWN0YXRpb25zLnR4dApAQCAtNTU3LDggKzU1Nyw2IEBAIEJV
R1dLODQ4MzUgOiBlZGl0aW5nL2V4ZWNDb21tYW5kL2NvcHktd2l0aG91dC1zZWxlY3Rpb24uaHRt
bCA9IFRFWFQKIEJVR1dLODQ4MzUgOiBlZGl0aW5nL2V4ZWNDb21tYW5kL2ZpbmRTdHJpbmctZGlh
Y3JpdGljYWxzLmh0bWwgPSBURVhUCiBCVUdXSzg0ODM1IDogZWRpdGluZy9leGVjQ29tbWFuZC9p
bmRlbnQtcGFyYWdyYXBocy5odG1sID0gVEVYVAogCi1CVUdXSzg2OTYxIDogZWRpdGluZy9leGVj
Q29tbWFuZC9wYXN0ZS1hbmQtbWF0Y2gtc3R5bGUtZXZlbnQuaHRtbCA9IENSQVNICi0KIC8vIERS
VCBkb2Vzbid0IGNoZWNrIGZvciBpc1ByaW50aW5nKCkuCiBCVUdXSzg3MjI2IDogcHJpbnRpbmcv
aWZyYW1lLXByaW50Lmh0bWwgPSBURVhUCiBCVUdXSzg3MjI2IDogcHJpbnRpbmcvbWVkaWEtcXVl
cmllcy1wcmludC5odG1sID0gTUlTU0lORwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwv
Q2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCmluZGV4IDBkYTY4MzQuLjJm
MDAzZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZworKysgYi9Tb3Vy
Y2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0wNS0zMSAgQ2hy
aXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVtZXpAaW50ZWwuY29tPgorCisgICAgICAgIFtF
RkxdIFtEUlRdIGVkaXRpbmcvZXhlY0NvbW1hbmQvcGFzdGUtYW5kLW1hdGNoLXN0eWxlLWV2ZW50
Lmh0bWwgY3Jhc2hlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9ODY5NjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg
ICAgICBDYWxsIGVjb3JlX3hfaW5pdCgpIGluIGV3a19pbml0KCkgdG8gaW5pdGlhbGl6ZSB0aGUg
ZWNvcmVfeCBsaWJyYXJ5LgorICAgICAgICBUaGlzIGF2b2lkcyBjcmFzaGluZyB1cG9uZyBjYWxs
aW5nIFdlYkNvcmU6OnN5c3RlbUJlZXAoKSB3aGljaCB1c2VzCisgICAgICAgIGVjb3JlX3hfYmVs
bCgpIGludGVybmFsbHkuCisKKyAgICAgICAgKiBld2svZXdrX21haW4uY3BwOgorICAgICAgICAo
ZXdrX2luaXQpOgorCiAyMDEyLTA1LTMwICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0b3BoZS5k
dW1lekBpbnRlbC5jb20+CiAKICAgICAgICAgW0VGTF0gRUZMJ3MgRFJUIHNob3VsZCBwcmludCB0
aGUgbnVtYmVyIG9mIE1lc3NhZ2VQb3J0cyBmb3IgbmV3IGVhY2ggbmV3IGludGVudApkaWZmIC0t
Z2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19tYWluLmNwcCBiL1NvdXJjZS9XZWJLaXQv
ZWZsL2V3ay9ld2tfbWFpbi5jcHAKaW5kZXggYzIwNWRiNS4uOThiYWUxNCAxMDA2NDQKLS0tIGEv
U291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19tYWluLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Vm
bC9ld2svZXdrX21haW4uY3BwCkBAIC00Nyw2ICs0NywxMCBAQAogI2luY2x1ZGUgPHN5cy9zdGF0
Lmg+CiAjaW5jbHVkZSA8d3RmL1RocmVhZGluZy5oPgogCisjaWZkZWYgSEFWRV9FQ09SRV9YCisj
aW5jbHVkZSA8RWNvcmVfWC5oPgorI2VuZGlmCisKIHN0YXRpYyBpbnQgX2V3a0luaXRDb3VudCA9
IDA7CiAKIC8qKgpAQCAtODYsNiArOTAsMTMgQEAgaW50IGV3a19pbml0KHZvaWQpCiAgICAgICAg
IGdvdG8gZXJyb3JfZWNvcmVfZXZhczsKICAgICB9CiAKKyNpZmRlZiBIQVZFX0VDT1JFX1gKKyAg
ICBpZiAoIWVjb3JlX3hfaW5pdCgwKSkgeworICAgICAgICBDUklUSUNBTCgiY291bGQgbm90IGlu
aXQgZWNvcmVfeCIpOworICAgICAgICBnb3RvIGVycm9yX2Vjb3JlX3g7CisgICAgfQorI2VuZGlm
CisKICAgICBpZiAoIWVkamVfaW5pdCgpKSB7CiAgICAgICAgIENSSVRJQ0FMKCJjb3VsZCBub3Qg
aW5pdCBlZGplLiIpOwogICAgICAgICBnb3RvIGVycm9yX2VkamU7CkBAIC05OSw2ICsxMTAsMTAg
QEAgaW50IGV3a19pbml0KHZvaWQpCiAgICAgcmV0dXJuICsrX2V3a0luaXRDb3VudDsKIAogZXJy
b3JfZWRqZToKKyNpZmRlZiBIQVZFX0VDT1JFX1gKKyAgICBlY29yZV94X3NodXRkb3duKCk7Citl
cnJvcl9lY29yZV94OgorI2VuZGlmCiAgICAgZWNvcmVfZXZhc19zaHV0ZG93bigpOwogZXJyb3Jf
ZWNvcmVfZXZhczoKICAgICBlY29yZV9zaHV0ZG93bigpOwo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>145987</attachid>
            <date>2012-06-06 04:02:44 -0700</date>
            <delta_ts>2012-09-04 04:29:05 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>86961_ecore_x_init.patch</filename>
            <type>text/plain</type>
            <size>4682</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCA0OGQzODBlLi4wOWIzNDViIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM
b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDYt
MDYgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAg
ICAgICBbRUZMXSBJbml0aWFsaXplIGVjb3JlX3ggbGlicmFyeSB0byBhdm9pZCBjcmFzaGVzCisg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04Njk2MQorCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVuc2tpcCBlZGl0
aW5nL2V4ZWNDb21tYW5kL3Bhc3RlLWFuZC1tYXRjaC1zdHlsZS1ldmVudC5odG1sIG5vdyB0aGF0
CisgICAgICAgIGl0IGlzIG5vIGxvbmdlciBjcmFzaGluZyB0aGFua3MgdG8gZWNvcmVfeCBsaWJy
YXJ5IGluaXRpYWxpemF0aW9uLgorCisgICAgICAgICogcGxhdGZvcm0vZWZsL1Rlc3RFeHBlY3Rh
dGlvbnM6CisKIDIwMTItMDYtMDYgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxp
YS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgdXBkYXRlZCBUZXN0RXhwZWN0YXRpb25zIGFm
dGVyIHNldmVyYWwgdGVzdHMgaGF2ZSBiZWVuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0
Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9UZXN0
RXhwZWN0YXRpb25zCmluZGV4IDUzMWQ5NjkuLjFhYTQ1ZmQgMTAwNjQ0Ci0tLSBhL0xheW91dFRl
c3RzL3BsYXRmb3JtL2VmbC9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRm
b3JtL2VmbC9UZXN0RXhwZWN0YXRpb25zCkBAIC01NjQsOCArNTY0LDYgQEAgQlVHV0s4NDgzNSA6
IGVkaXRpbmcvZXhlY0NvbW1hbmQvY29weS13aXRob3V0LXNlbGVjdGlvbi5odG1sID0gVEVYVAog
QlVHV0s4NDgzNSA6IGVkaXRpbmcvZXhlY0NvbW1hbmQvZmluZFN0cmluZy1kaWFjcml0aWNhbHMu
aHRtbCA9IFRFWFQKIEJVR1dLODQ4MzUgOiBlZGl0aW5nL2V4ZWNDb21tYW5kL2luZGVudC1wYXJh
Z3JhcGhzLmh0bWwgPSBURVhUCiAKLUJVR1dLODY5NjEgOiBlZGl0aW5nL2V4ZWNDb21tYW5kL3Bh
c3RlLWFuZC1tYXRjaC1zdHlsZS1ldmVudC5odG1sID0gQ1JBU0gKLQogLy8gRFJUIGRvZXNuJ3Qg
Y2hlY2sgZm9yIGlzUHJpbnRpbmcoKS4KIEJVR1dLODcyMjYgOiBwcmludGluZy9pZnJhbWUtcHJp
bnQuaHRtbCA9IFRFWFQKIEJVR1dLODcyMjYgOiBwcmludGluZy9tZWRpYS1xdWVyaWVzLXByaW50
Lmh0bWwgPSBNSVNTSU5HCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cg
Yi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggODk3MDEwZS4uNzRjODZkOSAxMDA2
NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQv
ZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA2LTA2ICBDaHJpc3RvcGhlIER1
bWV6ICA8Y2hyaXN0b3BoZS5kdW1lekBpbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF0gSW5pdGlh
bGl6ZSBlY29yZV94IGxpYnJhcnkgdG8gYXZvaWQgY3Jhc2hlcworICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODY5NjEKKworICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDYWxsIGVjb3JlX3hfaW5pdCgpIGluIGV3a19p
bml0KCkgdG8gaW5pdGlhbGl6ZSB0aGUgZWNvcmVfeCBsaWJyYXJ5LgorICAgICAgICBUaGlzIGF2
b2lkcyBjcmFzaGluZyB1cG9uZyBjYWxsaW5nIFdlYkNvcmU6OnN5c3RlbUJlZXAoKSB3aGljaCB1
c2VzCisgICAgICAgIGVjb3JlX3hfYmVsbCgpIGludGVybmFsbHkuCisKKyAgICAgICAgKiBld2sv
ZXdrX21haW4uY3BwOgorICAgICAgICAoZXdrX2luaXQpOgorCiAyMDEyLTA2LTA1ICBBZGFtIEJh
cnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVtb3ZlIHN1cHBvcnQgZm9yIHRh
cmdldC1kZW5zaXR5ZHBpIGluIHRoZSB2aWV3cG9ydCBtZXRhIHRhZwpkaWZmIC0tZ2l0IGEvU291
cmNlL1dlYktpdC9lZmwvZXdrL2V3a19tYWluLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9l
d2tfbWFpbi5jcHAKaW5kZXggODRkMmI1MC4uNGI1MmE0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YktpdC9lZmwvZXdrL2V3a19tYWluLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdr
X21haW4uY3BwCkBAIC00OCw2ICs0OCwxMCBAQAogI2luY2x1ZGUgPHN5cy9zdGF0Lmg+CiAjaW5j
bHVkZSA8d3RmL1RocmVhZGluZy5oPgogCisjaWZkZWYgSEFWRV9FQ09SRV9YCisjaW5jbHVkZSA8
RWNvcmVfWC5oPgorI2VuZGlmCisKIHN0YXRpYyBpbnQgX2V3a0luaXRDb3VudCA9IDA7CiAKIC8q
KgpAQCAtODcsNiArOTEsMTMgQEAgaW50IGV3a19pbml0KHZvaWQpCiAgICAgICAgIGdvdG8gZXJy
b3JfZWNvcmVfZXZhczsKICAgICB9CiAKKyNpZmRlZiBIQVZFX0VDT1JFX1gKKyAgICBpZiAoIWVj
b3JlX3hfaW5pdCgwKSkgeworICAgICAgICBDUklUSUNBTCgiY291bGQgbm90IGluaXQgZWNvcmVf
eCIpOworICAgICAgICBnb3RvIGVycm9yX2Vjb3JlX3g7CisgICAgfQorI2VuZGlmCisKICAgICBp
ZiAoIWVkamVfaW5pdCgpKSB7CiAgICAgICAgIENSSVRJQ0FMKCJjb3VsZCBub3QgaW5pdCBlZGpl
LiIpOwogICAgICAgICBnb3RvIGVycm9yX2VkamU7CkBAIC0xMDAsNiArMTExLDEwIEBAIGludCBl
d2tfaW5pdCh2b2lkKQogICAgIHJldHVybiArK19ld2tJbml0Q291bnQ7CiAKIGVycm9yX2VkamU6
CisjaWZkZWYgSEFWRV9FQ09SRV9YCisgICAgZWNvcmVfeF9zaHV0ZG93bigpOworZXJyb3JfZWNv
cmVfeDoKKyNlbmRpZgogICAgIGVjb3JlX2V2YXNfc2h1dGRvd24oKTsKIGVycm9yX2Vjb3JlX2V2
YXM6CiAgICAgZWNvcmVfc2h1dGRvd24oKTsKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi
L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwOWJlM2Y4Li4wOTc3NDczIDEwMDY0NAotLS0gYS9Ub29s
cy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTIt
MDYtMDYgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKwor
ICAgICAgICBbRUZMXSBJbml0aWFsaXplIGVjb3JlX3ggbGlicmFyeSB0byBhdm9pZCBjcmFzaGVz
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04Njk2MQor
CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJ1biBlYWNo
IERSVCBpbiBpdCdzIG93biB4dmZiIGFzIGZvciBHVEsgYW5kIFF0IHBvcnRzLgorICAgICAgICBU
aGlzIGFsbG93cyB1cyB0byBjYWxsIGVjb3JlX3ggZnVuY3Rpb25zIG9uIHRoZSBFRkwgYm90Lgor
CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9lZmwucHk6Cisg
ICAgICAgIChFZmxQb3J0Ll9kcml2ZXJfY2xhc3MpOgorCiAyMDEyLTA2LTA2ICBNaWNoYWVsIEJy
w7xuaW5nICA8bWljaGFlbC5icnVuaW5nQG5va2lhLmNvbT4KIAogICAgICAgICBbUXRdW1dLMl0g
QWRkIHByZWZlcnJlZE1pbmltdW1Db250ZW50c1dpZHRoIHRvIHRoZSB2aWV3cG9ydCBpbmZvIGlu
IE1pbmlCcm93c2VyLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf
dGVzdHMvcG9ydC9lZmwucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9w
b3J0L2VmbC5weQppbmRleCA4ZWE4YTEyLi4wZDVmZTY4IDEwMDY0NAotLS0gYS9Ub29scy9TY3Jp
cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2VmbC5weQorKysgYi9Ub29scy9TY3JpcHRz
L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2VmbC5weQpAQCAtMzQsNyArMzQsNyBAQCBpbXBv
cnQgc3VicHJvY2VzcwogZnJvbSB3ZWJraXRweS5sYXlvdXRfdGVzdHMubW9kZWxzLnRlc3RfY29u
ZmlndXJhdGlvbiBpbXBvcnQgVGVzdENvbmZpZ3VyYXRpb24KIGZyb20gd2Via2l0cHkubGF5b3V0
X3Rlc3RzLnBvcnQud2Via2l0IGltcG9ydCBXZWJLaXRQb3J0CiBmcm9tIHdlYmtpdHB5LmxheW91
dF90ZXN0cy5wb3J0LnB1bHNlYXVkaW9fc2FuaXRpemVyIGltcG9ydCBQdWxzZUF1ZGlvU2FuaXRp
emVyCi0KK2Zyb20gd2Via2l0cHkubGF5b3V0X3Rlc3RzLnBvcnQueHZmYmRyaXZlciBpbXBvcnQg
WHZmYkRyaXZlcgogCiBjbGFzcyBFZmxQb3J0KFdlYktpdFBvcnQsIFB1bHNlQXVkaW9TYW5pdGl6
ZXIpOgogICAgIHBvcnRfbmFtZSA9ICdlZmwnCkBAIC00OSw2ICs0OSw5IEBAIGNsYXNzIEVmbFBv
cnQoV2ViS2l0UG9ydCwgUHVsc2VBdWRpb1Nhbml0aXplcik6CiAgICAgZGVmIF9wb3J0X2ZsYWdf
Zm9yX3NjcmlwdHMoc2VsZik6CiAgICAgICAgIHJldHVybiAiLS1lZmwiCiAKKyAgICBkZWYgX2Ry
aXZlcl9jbGFzcyhzZWxmKToKKyAgICAgICAgcmV0dXJuIFh2ZmJEcml2ZXIKKwogICAgIGRlZiBz
ZXR1cF90ZXN0X3J1bihzZWxmKToKICAgICAgICAgc2VsZi5fdW5sb2FkX3B1bHNlYXVkaW9fbW9k
dWxlKCkKIAo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>162007</attachid>
            <date>2012-09-04 04:29:05 -0700</date>
            <delta_ts>2012-09-04 06:32:07 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>efl_fix_bell_crash_1.patch</filename>
            <type>text/plain</type>
            <size>2701</size>
            <attacher name="Alexander Shalamov">alexander.shalamov</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCA1NzBiYTZmLi4xYTg5ODAyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM
b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAKIDIwMTItMDkt
MDQgIEFsZXhhbmRlciBTaGFsYW1vdiAgPGFsZXhhbmRlci5zaGFsYW1vdkBpbnRlbC5jb20+CiAK
KyAgICAgICAgW0VGTF0gQ2hlY2sgaWYgZWNvcmVfeCBpcyBpbml0aWFsaXNlZCBiZWZvcmUgY2Fs
bGluZyBlY29yZV94X2JlbGwgdG8gYXZvaWQgY3Jhc2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2OTYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCisKKyAgICAgICAgVW5za2lwcGVkIHR3byBsYXlvdXQgdGVzdHMgdGhhdCB3
ZXJlIGNyYXNoaW5nLgorCisgICAgICAgICogcGxhdGZvcm0vZWZsL1Rlc3RFeHBlY3RhdGlvbnM6
CisKKzIwMTItMDktMDQgIEFsZXhhbmRlciBTaGFsYW1vdiAgPGFsZXhhbmRlci5zaGFsYW1vdkBp
bnRlbC5jb20+CisKICAgICAgICAgW0VGTF1bV0syXSBDU1MzIE1lZGlhIFF1ZXJpZXMgZnVuY3Rp
b25hbGl0eSBpcyBicm9rZW4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTk1NjgwCiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9U
ZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1Rlc3RFeHBlY3RhdGlv
bnMKaW5kZXggMzdiNmRlMC4uOGUyM2NiNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZv
cm0vZWZsL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1Rl
c3RFeHBlY3RhdGlvbnMKQEAgLTc1OSwxMCArNzU5LDYgQEAgQlVHV0s4NjU5NyA6IGZ1bGxzY3Jl
ZW4vdmlkZW8tY29udHJvbHMtZHJhZy5odG1sID0gVEVYVAogQlVHV0s4NjE4NyA6IG1lZGlhL21l
ZGlhLWZ1bGxzY3JlZW4tbm90LWluLWRvY3VtZW50Lmh0bWwgPSBURVhUCiBCVUdXSzg2MTg3IFNL
SVAgOiBtZWRpYS9tZWRpYS1mdWxsc2NyZWVuLWlubGluZS5odG1sID0gUEFTUwogCi0vLyBlY29y
ZV94IGxpYnJhcnkgaXMgbm90IGluaXRpYWxpemVkIGFuZCBjYWxscyB0byBpdCBjYXVzZSBjcmFz
aGVzCi1CVUdXSzg2OTYxIDogZWRpdGluZy9leGVjQ29tbWFuZC9wYXN0ZS1hbmQtbWF0Y2gtc3R5
bGUtZXZlbnQuaHRtbCA9IENSQVNICi1CVUdXSzg2OTYxIDogZmFzdC9kb20vc2hhZG93L2NwcGV2
ZW50LWluLXNoYWRvdy5odG1sID0gQ1JBU0gKLQogLy8gU2VsZWN0aW9uIHByb2JsZW0gaW4gU2hh
ZG93IERPTSB0ZXN0IChwYXNzZXMgb24gR1RLKQogQlVHV0tFRkwgOiBmYXN0L2RvbS9zaGFkb3cv
c2VsZWN0aW9ucy1pbi1zaGFkb3cuaHRtbCA9IFRFWFQKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl
YkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGVjNTRlM2Qu
LmU2MTE5MGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3Vy
Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOCBAQAogMjAxMi0wOS0wNCAgQWxleGFu
ZGVyIFNoYWxhbW92ICA8YWxleGFuZGVyLnNoYWxhbW92QGludGVsLmNvbT4KIAorICAgICAgICBb
RUZMXSBDaGVjayBpZiBlY29yZV94IGlzIGluaXRpYWxpc2VkIGJlZm9yZSBjYWxsaW5nIGVjb3Jl
X3hfYmVsbCB0byBhdm9pZCBjcmFzaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9ODY5NjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh
KS4KKworICAgICAgICBBZGQgZWNvcmVfeCBpbml0aWFsaXNhdGlvbiBjaGVjayBiZWZvcmUgY2Fs
bGluZyBlY29yZV94X2JlbGwKKyAgICAgICAgdG8gYXZvaWQgY3Jhc2hlcyB3aGVuIFggc2VydmVy
IGlzIG5vdCBydW5uaW5nLgorCisgICAgICAgICogcGxhdGZvcm0vZWZsL1NvdW5kRWZsLmNwcDoK
KyAgICAgICAgKFdlYkNvcmU6OnN5c3RlbUJlZXApOgorCisyMDEyLTA5LTA0ICBBbGV4YW5kZXIg
U2hhbGFtb3YgIDxhbGV4YW5kZXIuc2hhbGFtb3ZAaW50ZWwuY29tPgorCiAgICAgICAgIFtFRkxd
W1dLMl0gQ1NTMyBNZWRpYSBRdWVyaWVzIGZ1bmN0aW9uYWxpdHkgaXMgYnJva2VuCiAgICAgICAg
IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTY4MAogCmRpZmYgLS1n
aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvU291bmRFZmwuY3BwIGIvU291cmNlL1dl
YkNvcmUvcGxhdGZvcm0vZWZsL1NvdW5kRWZsLmNwcAppbmRleCAwOTFkZTdhLi5jM2Q4M2JjNSAx
MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1NvdW5kRWZsLmNwcAorKysg
Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvU291bmRFZmwuY3BwCkBAIC0zOSw3ICszOSwx
MCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiB2b2lkIHN5c3RlbUJlZXAoKQogewogI2lmZGVmIEhB
VkVfRUNPUkVfWAotICAgIGVjb3JlX3hfYmVsbCgwKTsKKyAgICBpZiAoZWNvcmVfeF9pbml0KDAp
KSB7CisgICAgICAgIGVjb3JlX3hfYmVsbCgwKTsKKyAgICAgICAgZWNvcmVfeF9zaHV0ZG93bigp
OworICAgIH0KICNlbmRpZgogfQogCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>