86950 2012-05-19 15:59:54 -0700 Shrink FontDescription object size 2012-05-22 07:45:22 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rwlbuis rwlbuis oldest_to_newest 628500 0 rwlbuis 2012-05-19 15:59:54 -0700 Through bit packing we can shrink the size of this class. Note that this means Font, StyleInheritedData and RenderSVGInlineText shrink too. 628501 1 142884 rwlbuis 2012-05-19 16:09:20 -0700 Created attachment 142884 Patch 629332 2 142884 ap 2012-05-21 11:51:01 -0700 Comment on attachment 142884 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142884&action=review > Source/WebCore/platform/graphics/FontDescription.cpp:-37 > - void* settings; This is weird - there is no member names settings, is there? 629718 3 rwlbuis 2012-05-21 16:53:24 -0700 Hi Alexey, Thanks for the r+! I'll land later tonight. (In reply to comment #2) > (From update of attachment 142884 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=142884&action=review > > > Source/WebCore/platform/graphics/FontDescription.cpp:-37 > > - void* settings; > > This is weird - there is no member names settings, is there? Yes, that had me puzzled for a while too. Maybe m_featureSettings was once called settings? After my patch we get rid of exactly this amount of bytes, and it should make SameSizeAsFontDescription actually accurate this time. 630359 4 rwlbuis 2012-05-22 07:45:22 -0700 Committed r117971: <http://trac.webkit.org/changeset/117971> 142884 2012-05-19 16:09:20 -0700 2012-05-21 11:51:01 -0700 Patch bug-86950-20120519190908.patch text/plain 2942 rwlbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3Njk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGE5NTMyYWY0NTRjZDU3 NmM5NDIwY2ZiMjQyMDkwZjc4MWRjNzcwNi4uNGY2NDlhNTY0ODFkNzAyN2RiOGQ3MzU2YTliNzll ZmFiYzk3ZmM0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEyLTA1LTE5ICBSb2Ig QnVpcyAgPHJidWlzQHJpbS5jb20+CiAKKyAgICAgICAgU2hyaW5rIEZvbnREZXNjcmlwdGlvbiBv YmplY3Qgc2l6ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9ODY5NTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBSZWR1Y2Ugb2JqZWN0IHNpemUgb2YgRm9udERlc2NyaXB0aW9uIGJ5IDggYnl0ZXMgb24gNjQt Yml0LCA0IGJ5dGVzIG9uIDMyLWJpdCBzeXN0ZW1zLgorICAgICAgICBOb3RlIHRoYXQgdGhpcyBt ZWFucyBGb250LCBTdHlsZUluaGVyaXRlZERhdGEgYW5kIFJlbmRlclNWR0lubGluZVRleHQgc2hy aW5rIHRvby4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ZvbnREZXNjcmlwdGlvbi5j cHA6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvRm9udERlc2NyaXB0aW9uLmg6CisgICAg ICAgIChXZWJDb3JlOjpGb250RGVzY3JpcHRpb246OnNjcmlwdCk6CisgICAgICAgIChGb250RGVz Y3JpcHRpb24pOgorCisyMDEyLTA1LTE5ICBSb2IgQnVpcyAgPHJidWlzQHJpbS5jb20+CisKICAg ICAgICAgUmVtb3ZlIGJib3ggY2FjaGluZyBmcm9tIFNWR1BhdGhFbGVtZW50CiAgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjIzMwogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250RGVzY3JpcHRpb24uY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udERlc2NyaXB0aW9uLmNwcAppbmRl eCA3YzNiYzY1YTU1ZGM1ZTkwYjAwZjA3MTlhY2RlOTA0MTFiZGM0ZTI2Li5lODIyYzAxYWRkZmE3 ZWExYWVhNDhlNTA4MzM5ZjY3YTFhOGRlNDJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9Gb250RGVzY3JpcHRpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnREZXNjcmlwdGlvbi5jcHAKQEAgLTM0LDcgKzM0LDYgQEAg bmFtZXNwYWNlIFdlYkNvcmUgewogCiBzdHJ1Y3QgU2FtZVNpemVBc0ZvbnREZXNjcmlwdGlvbiB7 CiAgICAgRm9udEZhbWlseSBmYW1pbHlMaXN0OwotICAgIHZvaWQqIHNldHRpbmdzOwogICAgIFJl ZlB0cjxGb250RmVhdHVyZVNldHRpbmdzPiBtX2ZlYXR1cmVTZXR0aW5nczsKICAgICBmbG9hdCBz aXplc1syXTsKICAgICAvLyBGWElNRTogTWFrZSB0aGVtIGZpdCBpbnRvIG9uZSB3b3JkLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udERlc2NyaXB0aW9u LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250RGVzY3JpcHRpb24uaApp bmRleCA1MzRmNDYwNTc1ZDk5OGJhOGJmNjMzNjgwMDFkNjFiMDc2MjA3MjI0Li40NDM2ODc1OWQw ZDZhZTYxNGEzOGQ3YmNhOGU3YTBiM2NmOTdiMDQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250RGVzY3JpcHRpb24uaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250RGVzY3JpcHRpb24uaApAQCAtMTI3LDcgKzEyNyw3IEBA IHB1YmxpYzoKICAgICB1bnNpZ25lZCBrZXl3b3JkU2l6ZSgpIGNvbnN0IHsgcmV0dXJuIG1fa2V5 d29yZFNpemU7IH0KICAgICBGb250U21vb3RoaW5nTW9kZSBmb250U21vb3RoaW5nKCkgY29uc3Qg eyByZXR1cm4gc3RhdGljX2Nhc3Q8Rm9udFNtb290aGluZ01vZGU+KG1fZm9udFNtb290aGluZyk7 IH0KICAgICBUZXh0UmVuZGVyaW5nTW9kZSB0ZXh0UmVuZGVyaW5nTW9kZSgpIGNvbnN0IHsgcmV0 dXJuIHN0YXRpY19jYXN0PFRleHRSZW5kZXJpbmdNb2RlPihtX3RleHRSZW5kZXJpbmcpOyB9Ci0g ICAgVVNjcmlwdENvZGUgc2NyaXB0KCkgY29uc3QgeyByZXR1cm4gbV9zY3JpcHQ7IH0KKyAgICBV U2NyaXB0Q29kZSBzY3JpcHQoKSBjb25zdCB7IHJldHVybiBzdGF0aWNfY2FzdDxVU2NyaXB0Q29k ZT4obV9zY3JpcHQpOyB9CiAKICAgICBGb250VHJhaXRzTWFzayB0cmFpdHNNYXNrKCkgY29uc3Q7 CiAgICAgYm9vbCBpc1NwZWNpZmllZEZvbnQoKSBjb25zdCB7IHJldHVybiBtX2lzU3BlY2lmaWVk Rm9udDsgfQpAQCAtMjAyLDcgKzIwMiw3IEBAIHByaXZhdGU6CiAgICAgdW5zaWduZWQgbV9mb250 U21vb3RoaW5nIDogMjsgLy8gRm9udFNtb290aGluZ01vZGUKICAgICB1bnNpZ25lZCBtX3RleHRS ZW5kZXJpbmcgOiAyOyAvLyBUZXh0UmVuZGVyaW5nTW9kZQogICAgIHVuc2lnbmVkIG1faXNTcGVj aWZpZWRGb250IDogMTsgLy8gVHJ1ZSBpZiBhIHdlYiBwYWdlIHNwZWNpZmllcyBhIG5vbi1nZW5l cmljIGZvbnQgZmFtaWx5IGFzIHRoZSBmaXJzdCBmb250IGZhbWlseS4KLSAgICBVU2NyaXB0Q29k ZSBtX3NjcmlwdDsgLy8gVXNlZCB0byBoZWxwIGNob29zZSBhbiBhcHByb3ByaWF0ZSBmb250IGZv ciBnZW5lcmljIGZvbnQgZmFtaWxpZXMuCisgICAgdW5zaWduZWQgbV9zY3JpcHQgOiA3OyAvLyBV c2VkIHRvIGhlbHAgY2hvb3NlIGFuIGFwcHJvcHJpYXRlIGZvbnQgZm9yIGdlbmVyaWMgZm9udCBm YW1pbGllcy4KIH07CiAKIGlubGluZSBib29sIEZvbnREZXNjcmlwdGlvbjo6b3BlcmF0b3I9PShj b25zdCBGb250RGVzY3JpcHRpb24mIG90aGVyKSBjb25zdAo=