86940 2012-05-19 03:59:57 -0700 [EFL] Massive rebaselining needed after r117672 2012-05-19 07:32:47 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez gyuyoung.kim leandro lucas.de.marchi naginenis rakuco rniwa webkit.review.bot zan oldest_to_newest 628392 0 cdumez 2012-05-19 03:59:57 -0700 A massive rebaselining is needed after r117672 (Bug 86784). In many tests, contents in input element are shifted to the start (left in LTR and right in RTL) by 1px, and widths of input elements are shrunk by 2px. 628397 1 142861 cdumez 2012-05-19 04:52:48 -0700 Created attachment 142861 Patch Could someone please double check and cq+ ? 628405 2 zan 2012-05-19 06:47:03 -0700 (In reply to comment #1) > Created an attachment (id=142861) [details] > Patch > > Could someone please double check and cq+ ? Looks good. 628406 3 leandro 2012-05-19 06:48:23 -0700 (In reply to comment #2) > (In reply to comment #1) > > Created an attachment (id=142861) [details] [details] > > Patch > > > > Could someone please double check and cq+ ? > > Looks good. > Yes, LGTM. 628408 4 142861 webkit.review.bot 2012-05-19 07:00:33 -0700 Comment on attachment 142861 Patch Clearing flags on attachment: 142861 Committed r117690: <http://trac.webkit.org/changeset/117690> 628409 5 webkit.review.bot 2012-05-19 07:00:39 -0700 All reviewed patches have been landed. Closing bug. 628411 6 cdumez 2012-05-19 07:32:47 -0700 Apparently my patch was incomplete and the following tests still need rebaseline: css3/selectors3/html/css3-modsel-23.html = TEXT css3/selectors3/html/css3-modsel-24.html = TEXT css3/selectors3/html/css3-modsel-68.html = TEXT css3/selectors3/html/css3-modsel-69.html = TEXT css3/selectors3/xhtml/css3-modsel-23.xml = TEXT css3/selectors3/xhtml/css3-modsel-24.xml = TEXT css3/selectors3/xhtml/css3-modsel-68.xml = TEXT css3/selectors3/xhtml/css3-modsel-69.xml = TEXT css3/selectors3/xml/css3-modsel-23.xml = TEXT css3/selectors3/xml/css3-modsel-24.xml = TEXT css3/selectors3/xml/css3-modsel-68.xml = TEXT css3/selectors3/xml/css3-modsel-69.xml = TEXT fast/forms/input-appearance-bkcolor.html = TEXT fast/forms/textfield-outline.html = TEXT I'll look into it later. 142861 2012-05-19 04:52:48 -0700 2012-05-19 07:00:33 -0700 Patch 86940_gardening.patch text/plain 0 cdumez