86939 2012-05-19 01:57:02 -0700 Windows build broken due to changes in the http://trac.webkit.org/changeset/117646 2012-05-19 04:17:34 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Blocker --- 84553 1 vivekgalatage vivekgalatage eric fpizlo oliver rniwa webkit.review.bot oldest_to_newest 628384 0 vivekgalatage 2012-05-19 01:57:02 -0700 The bug https://bugs.webkit.org/show_bug.cgi?id=84553 changes the definition of JSString::toBoolean This should be also changed in the def file for JavascriptCore.def 628385 1 142858 vivekgalatage 2012-05-19 02:33:56 -0700 Created attachment 142858 Patch 628394 2 142858 webkit.review.bot 2012-05-19 04:17:29 -0700 Comment on attachment 142858 Patch Clearing flags on attachment: 142858 Committed r117688: <http://trac.webkit.org/changeset/117688> 628395 3 webkit.review.bot 2012-05-19 04:17:34 -0700 All reviewed patches have been landed. Closing bug. 142858 2012-05-19 02:33:56 -0700 2012-05-19 04:17:29 -0700 Patch bug-86939-20120519150303.patch text/plain 1537 vivekgalatage SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTE3Njg2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEyLTA1LTE5ICBWaXZlayBHYWxhdGFnZSAgPHZpdmVrZ2FsYXRhZ2VAZ21haWwuY29tPgor CisgICAgICAgIFdpbmRvd3MgYnVpbGQgYnJva2VuIGR1ZSB0byBjaGFuZ2VzIGluIHRoZSBodHRw Oi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8xMTc2NDYKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2OTM5CisKKyAgICAgICAgVGhlIGNoYW5nZXNl dCAxMTc2NDYgY2hhbmdlZCB0aGUgSlNTdHJpbmc6OnRvQm9vbGVhbiBzaWduYXR1cmUuIFRoaXMK KyAgICAgICAgY2hhbmdlIGlzIGZvciBmaXhpbmcgdGhlIHdpbmRvd3MgYnVpbGQgYnJlYWsuCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBKYXZhU2Ny aXB0Q29yZS52Y3Byb2ovSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUuZGVmOgorCiAyMDEy LTA1LTE4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVT U0lPTigxMTc2NDYpOiBmYXN0L2NhbnZhcy93ZWJnbC9nbHNsLWNvbmZvcm1hbmNlLmh0bWwgaXMg Y3Jhc2hpbmcgaW4gdGhlIERGRwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3Jp cHRDb3JlLnZjcHJvai9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5kZWYKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnZjcHJvai9KYXZhU2Ny aXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5kZWYJKHJldmlzaW9uIDExNzY4MykKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS52Y3Byb2ovSmF2YVNjcmlwdENvcmUvSmF2YVNj cmlwdENvcmUuZGVmCSh3b3JraW5nIGNvcHkpCkBAIC0zMzAsNyArMzMwLDcgQEAgRVhQT1JUUwog ICAgID90aW1lZFdhaXRAVGhyZWFkQ29uZGl0aW9uQFdURkBAUUFFX05BQVZNdXRleEAyQE5AWgog ICAgID90bHNLZXlDb3VudEBXVEZAQFlBQUFKWFoKICAgICA/dGxzS2V5c0BXVEZAQFlBUEFLWFoK LSAgICA/dG9Cb29sZWFuQEpTU3RyaW5nQEpTQ0BAUUJFX05QQVZFeGVjU3RhdGVAMkBAWgorICAg ID90b0Jvb2xlYW5ASlNTdHJpbmdASlNDQEBRQkVfTlhaCiAgICAgP3RvSW50MzJASlNDQEBZQUhO QFoKICAgICA/dG9JbnRlZ2VyQEpTVmFsdWVASlNDQEBRQkVOUEFWRXhlY1N0YXRlQDJAQFoKICAg ICA/dG9OdW1iZXJTbG93Q2FzZUBKU1ZhbHVlQEpTQ0BAQUJFTlBBVkV4ZWNTdGF0ZUAyQEBaCg==