<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>8690</bug_id>
          
          <creation_ts>2006-05-02 03:20:48 -0700</creation_ts>
          <short_desc>Contributing code doesn&apos;t mention what to do with new files</short_desc>
          <delta_ts>2007-03-20 18:02:06 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Website</component>
          <version>420+</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.4</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc>http://webkit.org/coding/contributing.html</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Matt Gough">matt</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>mrowe</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>40835</commentid>
    <comment_count>0</comment_count>
    <who name="Matt Gough">matt</who>
    <bug_when>2006-05-02 03:20:48 -0700</bug_when>
    <thetext>This page doesn&apos;t mention what to do with new files that are added to the project (e.g test cases) Apparently you should do &apos;svn add&apos; on them so that the get noticed by svn-create-patch.

Also, although it mentions &apos;Make sure that your patch includes a ChangeLog entry&apos; it doesn&apos;t mention using &apos;prepare-ChangeLog&apos;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>18266</commentid>
    <comment_count>1</comment_count>
    <who name="Mark Rowe (bdash)">mrowe</who>
    <bug_when>2007-03-19 03:07:56 -0700</bug_when>
    <thetext>prepare-ChangeLog is now mentioned.  The &apos;svn add&apos; issue still stands.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>18087</commentid>
    <comment_count>2</comment_count>
    <who name="Mark Rowe (bdash)">mrowe</who>
    <bug_when>2007-03-20 18:02:06 -0700</bug_when>
    <thetext>Fixed by r20354.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>