86887 2012-05-18 12:53:08 -0700 [chromium] remove obsolete WebViewClient::startDragging version 2012-05-18 23:12:42 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jochen jochen abarth dglazkov fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 627950 0 jochen 2012-05-18 12:53:08 -0700 [chromium] remove obsolete WebViewClient::startDragging version 627956 1 142769 jochen 2012-05-18 12:57:37 -0700 Created attachment 142769 Patch 627965 2 webkit.review.bot 2012-05-18 13:00:39 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 627968 3 142769 abarth 2012-05-18 13:04:12 -0700 Comment on attachment 142769 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142769&action=review > Source/WebKit/chromium/DEPS:35 > - 'chromium_rev': '136942' > + 'chromium_rev': '137932' We had trouble with rolling the chromium_rev in a previous bug. Please makes sure this compiles before landing. > Source/WebKit/chromium/public/WebViewClient.h:253 > + virtual void startDragging(WebFrame*, const WebDragData&, WebDragOperationsMask, const WebImage&, const WebPoint&) { } I'd leave the dragImageOffset name in since that's not obvious (at least to me). 627969 4 142771 jochen 2012-05-18 13:08:53 -0700 Created attachment 142771 Patch 628048 5 142771 webkit.review.bot 2012-05-18 14:05:20 -0700 Comment on attachment 142771 Patch Attachment 142771 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12722897 628359 6 142851 jochen 2012-05-18 22:45:06 -0700 Created attachment 142851 Patch 628364 7 142851 webkit.review.bot 2012-05-18 23:12:37 -0700 Comment on attachment 142851 Patch Clearing flags on attachment: 142851 Committed r117678: <http://trac.webkit.org/changeset/117678> 628365 8 webkit.review.bot 2012-05-18 23:12:42 -0700 All reviewed patches have been landed. Closing bug. 142769 2012-05-18 12:57:37 -0700 2012-05-18 13:08:47 -0700 Patch bug-86887-20120518215735.patch text/plain 2248 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3NjEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGNlOGMzYzAxNGQ4MWI5M2ZmNmNlNzZkZmUyZDg5ZjAxNmJmOTE0YTEuLmM3ZTMxYzQwOWZmZDE0 MjQwZjllNDI2ZGYxOWJkNDZjMmFiMWZhZmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTItMDUtMTggIEpvY2hlbiBFaXNpbmdlciAgPGpvY2hlbkBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSByZW1vdmUgb2Jzb2xldGUgV2ViVmlld0Ns aWVudDo6c3RhcnREcmFnZ2luZyB2ZXJzaW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD04Njg4NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogREVQUzoKKyAgICAgICAgKiBwdWJsaWMvV2ViVmlld0NsaWVu dC5oOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3Q2xpZW50OjpzdGFydERyYWdnaW5nKToKKwog MjAxMi0wNS0xOCAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIHJl bW92ZSB0aGUgQ1NTX0dSSURfTEFZT1VUIGNvbXBpbGVyIGRlZmluZSwgYnV0IGRlZmF1bHQgZ3Jp ZCBsYXlvdXQgdG8gb2ZmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0RFUFMg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0RFUFMKaW5kZXggMjRlZjRmNTI2Mzk0MDgzMjM4MmVm ZTljYTU5NDE1YzU3NzJhYWY1Ni4uODk5MzcyODlkZWZkZTdhZmFhZWVkMmFmNzYxNDk2M2Y1Mjc1 YWJhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9ERVBTCisrKyBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vREVQUwpAQCAtMzIsNyArMzIsNyBAQAogCiB2YXJzID0gewogICAn Y2hyb21pdW1fc3ZuJzogJ2h0dHA6Ly9zcmMuY2hyb21pdW0ub3JnL3N2bi90cnVuay9zcmMnLAot ICAnY2hyb21pdW1fcmV2JzogJzEzNjk0MicKKyAgJ2Nocm9taXVtX3Jldic6ICcxMzc5MzInCiB9 CiAKIGRlcHMgPSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9X ZWJWaWV3Q2xpZW50LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3Q2xp ZW50LmgKaW5kZXggMjFkYzI1MGE5YTBiNjRmZTVmOTlhZDQwOTc5ZmJhZjMzNDc4NjQxZS4uMDBi OTNhMzlmZGMwNmZmZmIwM2Y4NWRhODM1Yjc3YzNjZGVlNjJiMyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVmlld0NsaWVudC5oCisrKyBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXdDbGllbnQuaApAQCAtMjUwLDEwICsyNTAsNyBAQCBw dWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHNob3dDb250ZXh0TWVudShXZWJGcmFtZSosIGNvbnN0 IFdlYkNvbnRleHRNZW51RGF0YSYpIHsgfQogCiAgICAgLy8gQ2FsbGVkIHdoZW4gYSBkcmFnLW4t ZHJvcCBvcGVyYXRpb24gc2hvdWxkIGJlZ2luLgotICAgIHZpcnR1YWwgdm9pZCBzdGFydERyYWdn aW5nKFdlYkZyYW1lKiwgY29uc3QgV2ViRHJhZ0RhdGEmIGRyYWdEYXRhLCBXZWJEcmFnT3BlcmF0 aW9uc01hc2sgbWFzaywgY29uc3QgV2ViSW1hZ2UmIGRyYWdJbWFnZSwgY29uc3QgV2ViUG9pbnQm IGRyYWdJbWFnZU9mZnNldCkgeyBzdGFydERyYWdnaW5nKGRyYWdEYXRhLCBtYXNrLCBkcmFnSW1h Z2UsIGRyYWdJbWFnZU9mZnNldCk7IH0KLSAgICAvLyBGSVhNRTogUmVtb3ZlIG9uY2UgdGhlIGNo cm9taXVtIHNpZGUgaGFzIGxhbmRlZC4KLSAgICB2aXJ0dWFsIHZvaWQgc3RhcnREcmFnZ2luZygK LSAgICAgICAgY29uc3QgV2ViRHJhZ0RhdGEmLCBXZWJEcmFnT3BlcmF0aW9uc01hc2ssIGNvbnN0 IFdlYkltYWdlJiwgY29uc3QgV2ViUG9pbnQmKSB7IH0KKyAgICB2aXJ0dWFsIHZvaWQgc3RhcnRE cmFnZ2luZyhXZWJGcmFtZSosIGNvbnN0IFdlYkRyYWdEYXRhJiwgV2ViRHJhZ09wZXJhdGlvbnNN YXNrLCBjb25zdCBXZWJJbWFnZSYsIGNvbnN0IFdlYlBvaW50JikgeyB9CiAKICAgICAvLyBDYWxs ZWQgdG8gZGV0ZXJtaW5lIGlmIGRyYWctbi1kcm9wIG9wZXJhdGlvbnMgbWF5IGluaXRpYXRlIGEg cGFnZQogICAgIC8vIG5hdmlnYXRpb24uCg== 142771 2012-05-18 13:08:53 -0700 2012-05-18 22:45:01 -0700 Patch bug-86887-20120518220851.patch text/plain 2260 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3NjEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGNlOGMzYzAxNGQ4MWI5M2ZmNmNlNzZkZmUyZDg5ZjAxNmJmOTE0YTEuLjI0MTQ2ZmY3MzNjM2Ey ZmNmNGQyOTAyNmNjYjkxNDJlNDhkOGMzYmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTItMDUtMTggIEpvY2hlbiBFaXNpbmdlciAgPGpvY2hlbkBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSByZW1vdmUgb2Jzb2xldGUgV2ViVmlld0Ns aWVudDo6c3RhcnREcmFnZ2luZyB2ZXJzaW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD04Njg4NworCisgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFy dGguCisKKyAgICAgICAgKiBERVBTOgorICAgICAgICAqIHB1YmxpYy9XZWJWaWV3Q2xpZW50Lmg6 CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdDbGllbnQ6OnN0YXJ0RHJhZ2dpbmcpOgorCiAyMDEy LTA1LTE4ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgcmVtb3Zl IHRoZSBDU1NfR1JJRF9MQVlPVVQgY29tcGlsZXIgZGVmaW5lLCBidXQgZGVmYXVsdCBncmlkIGxh eW91dCB0byBvZmYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vREVQUyBiL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vREVQUwppbmRleCAyNGVmNGY1MjYzOTQwODMyMzgyZWZlOWNh NTk0MTVjNTc3MmFhZjU2Li44OTkzNzI4OWRlZmRlN2FmYWFlZWQyYWY3NjE0OTYzZjUyNzVhYmEy IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0RFUFMKKysrIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9ERVBTCkBAIC0zMiw3ICszMiw3IEBACiAKIHZhcnMgPSB7CiAgICdjaHJv bWl1bV9zdm4nOiAnaHR0cDovL3NyYy5jaHJvbWl1bS5vcmcvc3ZuL3RydW5rL3NyYycsCi0gICdj aHJvbWl1bV9yZXYnOiAnMTM2OTQyJworICAnY2hyb21pdW1fcmV2JzogJzEzNzkzMicKIH0KIAog ZGVwcyA9IHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlZp ZXdDbGllbnQuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXdDbGllbnQu aAppbmRleCAyMWRjMjUwYTlhMGI2NGZlNWY5OWFkNDA5NzlmYmFmMzM0Nzg2NDFlLi45YThhZDA1 YjI0ZDY4YjY3MDdhOWIxOTNiZjk1MzllZDg0MDU5NTcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3Q2xpZW50LmgKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9wdWJsaWMvV2ViVmlld0NsaWVudC5oCkBAIC0yNTAsMTAgKzI1MCw3IEBAIHB1Ymxp YzoKICAgICB2aXJ0dWFsIHZvaWQgc2hvd0NvbnRleHRNZW51KFdlYkZyYW1lKiwgY29uc3QgV2Vi Q29udGV4dE1lbnVEYXRhJikgeyB9CiAKICAgICAvLyBDYWxsZWQgd2hlbiBhIGRyYWctbi1kcm9w IG9wZXJhdGlvbiBzaG91bGQgYmVnaW4uCi0gICAgdmlydHVhbCB2b2lkIHN0YXJ0RHJhZ2dpbmco V2ViRnJhbWUqLCBjb25zdCBXZWJEcmFnRGF0YSYgZHJhZ0RhdGEsIFdlYkRyYWdPcGVyYXRpb25z TWFzayBtYXNrLCBjb25zdCBXZWJJbWFnZSYgZHJhZ0ltYWdlLCBjb25zdCBXZWJQb2ludCYgZHJh Z0ltYWdlT2Zmc2V0KSB7IHN0YXJ0RHJhZ2dpbmcoZHJhZ0RhdGEsIG1hc2ssIGRyYWdJbWFnZSwg ZHJhZ0ltYWdlT2Zmc2V0KTsgfQotICAgIC8vIEZJWE1FOiBSZW1vdmUgb25jZSB0aGUgY2hyb21p dW0gc2lkZSBoYXMgbGFuZGVkLgotICAgIHZpcnR1YWwgdm9pZCBzdGFydERyYWdnaW5nKAotICAg ICAgICBjb25zdCBXZWJEcmFnRGF0YSYsIFdlYkRyYWdPcGVyYXRpb25zTWFzaywgY29uc3QgV2Vi SW1hZ2UmLCBjb25zdCBXZWJQb2ludCYpIHsgfQorICAgIHZpcnR1YWwgdm9pZCBzdGFydERyYWdn aW5nKFdlYkZyYW1lKiwgY29uc3QgV2ViRHJhZ0RhdGEmLCBXZWJEcmFnT3BlcmF0aW9uc01hc2ss IGNvbnN0IFdlYkltYWdlJiwgY29uc3QgV2ViUG9pbnQmIGRyYWdJbWFnZU9mZnNldCkgeyB9CiAK ICAgICAvLyBDYWxsZWQgdG8gZGV0ZXJtaW5lIGlmIGRyYWctbi1kcm9wIG9wZXJhdGlvbnMgbWF5 IGluaXRpYXRlIGEgcGFnZQogICAgIC8vIG5hdmlnYXRpb24uCg== 142851 2012-05-18 22:45:06 -0700 2012-05-18 23:12:37 -0700 Patch bug-86887-20120519074504.patch text/plain 1847 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3NjEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGNlOGMzYzAxNGQ4MWI5M2ZmNmNlNzZkZmUyZDg5ZjAxNmJmOTE0YTEuLjJhOGVlYjViYTA2ZGJl NDUxOGU2ODgzYzMzNzgzYzhkYmZhMWNlODMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTItMDUtMTggIEpvY2hlbiBFaXNpbmdlciAgPGpvY2hlbkBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSByZW1vdmUgb2Jzb2xldGUgV2ViVmlld0Ns aWVudDo6c3RhcnREcmFnZ2luZyB2ZXJzaW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD04Njg4NworCisgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFy dGguCisKKyAgICAgICAgKiBwdWJsaWMvV2ViVmlld0NsaWVudC5oOgorICAgICAgICAoV2ViS2l0 OjpXZWJWaWV3Q2xpZW50OjpzdGFydERyYWdnaW5nKToKKwogMjAxMi0wNS0xOCAgVG9ueSBDaGFu ZyAgPHRvbnlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIHJlbW92ZSB0aGUgQ1NTX0dSSURfTEFZ T1VUIGNvbXBpbGVyIGRlZmluZSwgYnV0IGRlZmF1bHQgZ3JpZCBsYXlvdXQgdG8gb2ZmCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3Q2xpZW50LmggYi9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3Q2xpZW50LmgKaW5kZXggMjFkYzI1 MGE5YTBiNjRmZTVmOTlhZDQwOTc5ZmJhZjMzNDc4NjQxZS4uOWE4YWQwNWIyNGQ2OGI2NzA3YTli MTkzYmY5NTM5ZWQ4NDA1OTU3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9w dWJsaWMvV2ViVmlld0NsaWVudC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGlj L1dlYlZpZXdDbGllbnQuaApAQCAtMjUwLDEwICsyNTAsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVh bCB2b2lkIHNob3dDb250ZXh0TWVudShXZWJGcmFtZSosIGNvbnN0IFdlYkNvbnRleHRNZW51RGF0 YSYpIHsgfQogCiAgICAgLy8gQ2FsbGVkIHdoZW4gYSBkcmFnLW4tZHJvcCBvcGVyYXRpb24gc2hv dWxkIGJlZ2luLgotICAgIHZpcnR1YWwgdm9pZCBzdGFydERyYWdnaW5nKFdlYkZyYW1lKiwgY29u c3QgV2ViRHJhZ0RhdGEmIGRyYWdEYXRhLCBXZWJEcmFnT3BlcmF0aW9uc01hc2sgbWFzaywgY29u c3QgV2ViSW1hZ2UmIGRyYWdJbWFnZSwgY29uc3QgV2ViUG9pbnQmIGRyYWdJbWFnZU9mZnNldCkg eyBzdGFydERyYWdnaW5nKGRyYWdEYXRhLCBtYXNrLCBkcmFnSW1hZ2UsIGRyYWdJbWFnZU9mZnNl dCk7IH0KLSAgICAvLyBGSVhNRTogUmVtb3ZlIG9uY2UgdGhlIGNocm9taXVtIHNpZGUgaGFzIGxh bmRlZC4KLSAgICB2aXJ0dWFsIHZvaWQgc3RhcnREcmFnZ2luZygKLSAgICAgICAgY29uc3QgV2Vi RHJhZ0RhdGEmLCBXZWJEcmFnT3BlcmF0aW9uc01hc2ssIGNvbnN0IFdlYkltYWdlJiwgY29uc3Qg V2ViUG9pbnQmKSB7IH0KKyAgICB2aXJ0dWFsIHZvaWQgc3RhcnREcmFnZ2luZyhXZWJGcmFtZSos IGNvbnN0IFdlYkRyYWdEYXRhJiwgV2ViRHJhZ09wZXJhdGlvbnNNYXNrLCBjb25zdCBXZWJJbWFn ZSYsIGNvbnN0IFdlYlBvaW50JiBkcmFnSW1hZ2VPZmZzZXQpIHsgfQogCiAgICAgLy8gQ2FsbGVk IHRvIGRldGVybWluZSBpZiBkcmFnLW4tZHJvcCBvcGVyYXRpb25zIG1heSBpbml0aWF0ZSBhIHBh Z2UKICAgICAvLyBuYXZpZ2F0aW9uLgo=