86886 2012-05-18 12:51:11 -0700 [chromium] Don't force the visibleLayerRect to be empty for animating layers whose front face is not visible 2012-05-22 18:01:43 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 danakj danakj cc-bugs enne jamesr piman shawnsingh webkit.review.bot wjmaclean oldest_to_newest 627948 0 danakj 2012-05-18 12:51:11 -0700 [chromium] Don't force the visibleLayerRect to be empty for animating layers whose front face is not visible 627958 1 danakj 2012-05-18 12:57:48 -0700 Some context discussion on https://bugs.webkit.org/show_bug.cgi?id=82571 627959 2 142770 danakj 2012-05-18 12:58:02 -0700 Created attachment 142770 Patch 629211 3 142770 enne 2012-05-21 09:57:11 -0700 Comment on attachment 142770 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142770&action=review Hmm. This assumes that the current visible rect (flipped) is a good proxy for the final visible rect when the animation is done. There are certainly edge cases where that's not true, but I guess this is just as much as heuristic as "paint everything only if it's a small layer". I think overall that this is an improvement, and I'm happy to get rid of the empty IntRect special case. > Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp:-1325 > - > - // But if the back face is visible, then the visibleLayerRect should be empty. > - EXPECT_TRUE(animatingChild->visibleLayerRect().isEmpty()); > - EXPECT_TRUE(animatingSurface->visibleLayerRect().isEmpty()); > - // And any layers in the subtree should not be considered visible either. > - EXPECT_TRUE(childOfAnimatingSurface->visibleLayerRect().isEmpty()); Can you verify that the visible layer rect for these animating layers is the whole layer (assuming it's not clipped)? 630814 4 142770 danakj 2012-05-22 15:20:28 -0700 Comment on attachment 142770 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142770&action=review >> Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp:-1325 >> - EXPECT_TRUE(childOfAnimatingSurface->visibleLayerRect().isEmpty()); > > Can you verify that the visible layer rect for these animating layers is the whole layer (assuming it's not clipped)? yup! 630820 5 143376 danakj 2012-05-22 15:22:48 -0700 Created attachment 143376 Patch I removed the change in the prepainting code. While the flipped case we should now have a non-empty rect, for animating layers that are not flipped but transitioning into the viewport from outside, we should still prepaint them when they are small. 630962 6 143376 enne 2012-05-22 17:20:56 -0700 Comment on attachment 143376 Patch R=me. Leaving the prepainting code makes sense. 631011 7 143376 webkit.review.bot 2012-05-22 18:01:35 -0700 Comment on attachment 143376 Patch Clearing flags on attachment: 143376 Committed r118090: <http://trac.webkit.org/changeset/118090> 631012 8 webkit.review.bot 2012-05-22 18:01:43 -0700 All reviewed patches have been landed. Closing bug. 142770 2012-05-18 12:58:02 -0700 2012-05-22 15:22:29 -0700 Patch bug-86886-20120518155800.patch text/plain 5658 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3NTI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDNmYmI5MjM5OTdkMTkz ZDhkMzVlMjQyYzg0YzdjYTA1YWYxMjZlOC4uMDE0MTk3NGRiNGM2NTlmZTQyNGQxNzAzNWI0ODNm ZjRlMzNiNGYyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEyLTA1LTE4ICBEYW5h IEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gRG9u J3QgZm9yY2UgdGhlIHZpc2libGVMYXllclJlY3QgdG8gYmUgZW1wdHkgZm9yIGFuaW1hdGluZyBs YXllcnMgd2hvc2UgZnJvbnQgZmFjZSBpcyBub3QgdmlzaWJsZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODY4ODYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQcmV2aW91c2x5IHdlIHdvdWxkIGZvcmNlIHRo ZSB2aXNpYmxlTGF5ZXJSZWN0IHRvIGJlIGVtcHR5IGZvciB0aGVzZQorICAgICAgICBhbmltYXRp bmcgbGF5ZXJzLCBhbmQgdGhlbiBzcGVjaWFsIGNhc2UgdGhlIHByZS1wYWludGluZyBjb2RlIHRv CisgICAgICAgIHBhaW50IHRoZW0gaWYgdGhleSB3ZXJlIHdpdGhpbiBzb21lIHNpemUgbGltaXQs IHRvIGF2b2lkIGhhdmluZyB0aGUKKyAgICAgICAgbGF5ZXIgc3RlYWwgdG9vIG11Y2ggbWVtb3J5 LgorCisgICAgICAgIEluc3RlYWQsIGp1c3QgdXNlIHRoZSB2aXNpYmxlTGF5ZXJSZWN0IGdpdmVu IHRvIHRoZSBsYXllci4gU2luY2UgdGhlCisgICAgICAgIHRyYW5zZm9ybSBmbGlwcyB0aGUgbGF5 ZXIgc3VjaCB0aGF0IGl0cyBiYWNrIGZhY2UgaXMgdmlzaWJsZSwgaXQgd2lsbAorICAgICAgICBh bHNvIGNvbXB1dGUgYSB2aXNpYmxlTGF5ZXJSZWN0IGluIHRoZSBmcm9udCBmYWNlIG9mIHRoZSBs YXllciwgYW5kCisgICAgICAgIGl0cyBzaXplIHdpbGwgYmUgYm91bmRlZCBieSB0aGUgdmlld3Bv cnQuIFRoaXMgd2lsbCBjYXVzZSB0aGUKKyAgICAgICAgbGF5ZXIgdG8gYmUgcGFpbnRlZCB3aXRo IHZpc2libGUgcHJpb3JpdHkgaW5zdGVhZCBvZiBwcmVwYWludGVkLCBidXQKKyAgICAgICAgZW5z dXJlcyB0aGUgdmlzaWJsZSBwYXJ0cyBvZiB0aGUgbGF5ZXIgaXMgcGFpbnRlZCBhbmQgcmVhZHkg dG8gZ28gd2hlbgorICAgICAgICB0aGUgYW5pbWF0aW9uIGZsaXBzIHRoZSBsYXllciBhcm91bmQu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9UaWxlZExheWVyQ2hyb21p dW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGlsZWRMYXllckNocm9taXVtOjppZGxlUGFpbnRS ZWN0KToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJl ZUhvc3RDb21tb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y2FsY3VsYXRlVmlzaWJsZUxheWVy UmVjdCk6CisKIDIwMTItMDUtMTcgIE1pY2hhZWwgTW9zcyAgPG1tb3NzQGNocm9taXVtLm9yZz4K IAogICAgICAgICBMaW51eCBhbWQ2NCBwbGF0Zm9ybSByZXBvcnRlZCBhcyBpNjg2CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCmluZGV4IDk5MjRmNGQxMThhODlkOTYyZTAzYTMzNTRmMGEzYTQ2NTQ3 ZTI2N2QuLjUzYzU3MmNjM2YzY2E5NjI3NTQ3ZTM0MDFiOTE4YmM4MDA4YTg0ZjkgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMDUtMTggIERhbmEgSmFu c2VucyAgPGRhbmFrakBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBEb24ndCBm b3JjZSB0aGUgdmlzaWJsZUxheWVyUmVjdCB0byBiZSBlbXB0eSBmb3IgYW5pbWF0aW5nIGxheWVy cyB3aG9zZSBmcm9udCBmYWNlIGlzIG5vdCB2aXNpYmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04Njg4NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogdGVzdHMvQ0NMYXllclRyZWVIb3N0Q29tbW9uVGVz dC5jcHA6CisgICAgICAgIChXZWJLaXRUZXN0czo6VEVTVCk6CisKIDIwMTItMDUtMTcgIFZhbmdl bGlzIEtva2tldmlzICA8dmFuZ2VsaXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEV4cG9zZSBs YXllciB0aWxpbmcgc2l6ZSBvcHRpb25zIHRvIFdlYlNldHRpbmdzLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vVGlsZWRMYXllckNocm9taXVt LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1RpbGVkTGF5 ZXJDaHJvbWl1bS5jcHAKaW5kZXggNmMyNzM1OGNjMzY2YmRlMDFlNGEyMTI4ZTZlYzQwNDZlNjM5 YjhiNy4uZjRkYjk5MTI5NTE5ODVjMDY1ZDlmZjgxMTY3NWEzYmU1NDBkZjFlOSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vVGlsZWRMYXllckNo cm9taXVtLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1 bS9UaWxlZExheWVyQ2hyb21pdW0uY3BwCkBAIC02ODMsMTUgKzY4Myw4IEBAIGJvb2wgVGlsZWRM YXllckNocm9taXVtOjpuZWVkc0lkbGVQYWludChjb25zdCBJbnRSZWN0JiBsYXllclJlY3QpCiAK IEludFJlY3QgVGlsZWRMYXllckNocm9taXVtOjppZGxlUGFpbnRSZWN0KGNvbnN0IEludFJlY3Qm IHZpc2libGVMYXllclJlY3QpCiB7Ci0gICAgLy8gRm9yIGxheWVycyB0aGF0IGFyZSBhbmltYXRp bmcgdHJhbnNmb3JtcyBidXQgbm90IHZpc2libGUgYXQgYWxsLCB3ZSBkb24ndCBrbm93IHdoYXQg cGFydAotICAgIC8vIG9mIHRoZW0gaXMgZ29pbmcgdG8gYmVjb21lIHZpc2libGUuIEZvciBzbWFs bCBsYXllcnMgd2UgcmV0dXJuIHRoZSBlbnRpcmUgbGF5ZXIsIGZvciBsYXJnZXIKLSAgICAvLyBv bmVzIHdlIGF2b2lkIHByZXBhaW50aW5nIHRoZSBsYXllciBhdCBhbGwuCi0gICAgaWYgKHZpc2li bGVMYXllclJlY3QuaXNFbXB0eSgpKSB7Ci0gICAgICAgIGJvb2wgaXNTbWFsbExheWVyID0gbV90 aWxlci0+bnVtVGlsZXNYKCkgPD0gOSAmJiBtX3RpbGVyLT5udW1UaWxlc1koKSA8PSA5ICYmIG1f dGlsZXItPm51bVRpbGVzWCgpICogbV90aWxlci0+bnVtVGlsZXNZKCkgPD0gOTsKLSAgICAgICAg aWYgKChkcmF3VHJhbnNmb3JtSXNBbmltYXRpbmcoKSB8fCBzY3JlZW5TcGFjZVRyYW5zZm9ybUlz QW5pbWF0aW5nKCkpICYmIGlzU21hbGxMYXllcikKLSAgICAgICAgICAgIHJldHVybiBJbnRSZWN0 KEludFBvaW50KCksIGNvbnRlbnRCb3VuZHMoKSk7Ci0gICAgICAgIHJldHVybiBJbnRSZWN0KCk7 Ci0gICAgfQorICAgIGlmICh2aXNpYmxlTGF5ZXJSZWN0LmlzRW1wdHkoKSkKKyAgICAgICAgcmV0 dXJuIHZpc2libGVMYXllclJlY3Q7CiAKICAgICBJbnRSZWN0IHByZXBhaW50UmVjdCA9IHZpc2li bGVMYXllclJlY3Q7CiAgICAgLy8gRklYTUU6IFRoaXMgY2FuIGJlIG1hZGUgYSBsb3QgbGFyZ2Vy IGlmIHdlIGNhbjoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdENvbW1vbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3RDb21tb24uY3BwCmlu ZGV4IDUxMWU4MzdkYzhkYWJjM2M1YzkxMTZiZjMzZTUyZjA0YWU2YWI1MzYuLmE1MGFkZmQwMWVk MGZjZjM1MjlhMzVjOWRmMTFmOTczYjJkOTdmNjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdENvbW1vbi5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXll clRyZWVIb3N0Q29tbW9uLmNwcApAQCAtNzAsMTEgKzcwLDYgQEAgc3RhdGljIEludFJlY3QgY2Fs Y3VsYXRlVmlzaWJsZUxheWVyUmVjdChMYXllclR5cGUqIGxheWVyKQogewogICAgIEFTU0VSVChs YXllci0+dGFyZ2V0UmVuZGVyU3VyZmFjZSgpKTsKIAotICAgIC8vIEFuaW1hdGVkIGxheWVycyBj YW4gZXhpc3QgaW4gdGhlIHJlbmRlciBzdXJmYWNlIHRyZWUgdGhhdCBhcmUgbm90IHZpc2libGUg Y3VycmVudGx5Ci0gICAgLy8gYW5kIGhhdmUgdGhlaXIgYmFjayBmYWNlIHNob3dpbmcuIEluIHRo aXMgY2FzZSwgdGhlaXIgdmlzaWJsZSByZWN0IHNob3VsZCBiZSBlbXB0eS4KLSAgICBpZiAoIWxh eWVyLT5kb3VibGVTaWRlZCgpICYmIGxheWVyLT5zY3JlZW5TcGFjZVRyYW5zZm9ybSgpLmlzQmFj a0ZhY2VWaXNpYmxlKCkpCi0gICAgICAgIHJldHVybiBJbnRSZWN0KCk7Ci0KICAgICBJbnRSZWN0 IHRhcmdldFN1cmZhY2VSZWN0ID0gbGF5ZXItPnRhcmdldFJlbmRlclN1cmZhY2UoKS0+Y29udGVu dFJlY3QoKTsKIAogICAgIGlmIChsYXllci0+dXNlc0xheWVyQ2xpcHBpbmcoKSkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ0NMYXllclRyZWVIb3N0Q29tbW9uVGVz dC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NDTGF5ZXJUcmVlSG9zdENvbW1v blRlc3QuY3BwCmluZGV4IGQyNDNhZWU0YWYxNjY0YjA1OTg5NWI2NjZkNmM4NTI5NWM4OGJmOWEu LmEyZjhhZDdmNmE0YjAyMTNjZjhmNjNhNmI0YmM5MGE4Mzk2ZGQ0NTMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ0NMYXllclRyZWVIb3N0Q29tbW9uVGVzdC5jcHAK KysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9DQ0xheWVyVHJlZUhvc3RDb21tb25U ZXN0LmNwcApAQCAtMTMxNywxMiArMTMxNyw2IEBAIFRFU1QoQ0NMYXllclRyZWVIb3N0Q29tbW9u VGVzdCwgdmVyaWZ5QmFja0ZhY2VDdWxsaW5nKQogICAgIEVYUEVDVF9FUShjaGlsZE9mQW5pbWF0 aW5nU3VyZmFjZS0+aWQoKSwgcmVuZGVyU3VyZmFjZUxheWVyTGlzdFsxXS0+cmVuZGVyU3VyZmFj ZSgpLT5sYXllckxpc3QoKVsxXS0+aWQoKSk7CiAKICAgICBFWFBFQ1RfRkFMU0UoY2hpbGQyLT52 aXNpYmxlTGF5ZXJSZWN0KCkuaXNFbXB0eSgpKTsKLQotICAgIC8vIEJ1dCBpZiB0aGUgYmFjayBm YWNlIGlzIHZpc2libGUsIHRoZW4gdGhlIHZpc2libGVMYXllclJlY3Qgc2hvdWxkIGJlIGVtcHR5 LgotICAgIEVYUEVDVF9UUlVFKGFuaW1hdGluZ0NoaWxkLT52aXNpYmxlTGF5ZXJSZWN0KCkuaXNF bXB0eSgpKTsKLSAgICBFWFBFQ1RfVFJVRShhbmltYXRpbmdTdXJmYWNlLT52aXNpYmxlTGF5ZXJS ZWN0KCkuaXNFbXB0eSgpKTsKLSAgICAvLyBBbmQgYW55IGxheWVycyBpbiB0aGUgc3VidHJlZSBz aG91bGQgbm90IGJlIGNvbnNpZGVyZWQgdmlzaWJsZSBlaXRoZXIuCi0gICAgRVhQRUNUX1RSVUUo Y2hpbGRPZkFuaW1hdGluZ1N1cmZhY2UtPnZpc2libGVMYXllclJlY3QoKS5pc0VtcHR5KCkpOwog fQogCiAvLyBGSVhNRToK 143376 2012-05-22 15:22:48 -0700 2012-05-22 18:01:34 -0700 Patch bug-86886-20120522182247.patch text/plain 4759 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3OTg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGQ3YWRmMTA2NWJjYzVi MmRlYWYxZGZkN2JiMDMwNGZjZWZkZjNkMi4uNzdmYzVhZTBlYzZlZWNhMmVlMGE2YzM4ZjI5YzNk YWZiMzY1NzIwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTA1LTE4ICBEYW5h IEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gRG9u J3QgZm9yY2UgdGhlIHZpc2libGVMYXllclJlY3QgdG8gYmUgZW1wdHkgZm9yIGFuaW1hdGluZyBs YXllcnMgd2hvc2UgZnJvbnQgZmFjZSBpcyBub3QgdmlzaWJsZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODY4ODYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQcmV2aW91c2x5IHdlIHdvdWxkIGZvcmNlIHRo ZSB2aXNpYmxlTGF5ZXJSZWN0IHRvIGJlIGVtcHR5IGZvciB0aGVzZQorICAgICAgICBhbmltYXRp bmcgbGF5ZXJzLCBhbmQgdGhlbiBzcGVjaWFsIGNhc2UgdGhlIHByZS1wYWludGluZyBjb2RlIHRv CisgICAgICAgIHBhaW50IHRoZW0gaWYgdGhleSB3ZXJlIHdpdGhpbiBzb21lIHNpemUgbGltaXQs IHRvIGF2b2lkIGhhdmluZyB0aGUKKyAgICAgICAgbGF5ZXIgc3RlYWwgdG9vIG11Y2ggbWVtb3J5 LgorCisgICAgICAgIEluc3RlYWQsIGp1c3QgdXNlIHRoZSB2aXNpYmxlTGF5ZXJSZWN0IGdpdmVu IHRvIHRoZSBsYXllci4gU2luY2UgdGhlCisgICAgICAgIHRyYW5zZm9ybSBmbGlwcyB0aGUgbGF5 ZXIgc3VjaCB0aGF0IGl0cyBiYWNrIGZhY2UgaXMgdmlzaWJsZSwgaXQgd2lsbAorICAgICAgICBh bHNvIGNvbXB1dGUgYSB2aXNpYmxlTGF5ZXJSZWN0IGluIHRoZSBmcm9udCBmYWNlIG9mIHRoZSBs YXllciwgYW5kCisgICAgICAgIGl0cyBzaXplIHdpbGwgYmUgYm91bmRlZCBieSB0aGUgdmlld3Bv cnQuIFRoaXMgd2lsbCBjYXVzZSB0aGUKKyAgICAgICAgbGF5ZXIgdG8gYmUgcGFpbnRlZCB3aXRo IHZpc2libGUgcHJpb3JpdHkgaW5zdGVhZCBvZiBwcmVwYWludGVkLCBidXQKKyAgICAgICAgZW5z dXJlcyB0aGUgdmlzaWJsZSBwYXJ0cyBvZiB0aGUgbGF5ZXIgaXMgcGFpbnRlZCBhbmQgcmVhZHkg dG8gZ28gd2hlbgorICAgICAgICB0aGUgYW5pbWF0aW9uIGZsaXBzIHRoZSBsYXllciBhcm91bmQu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhv c3RDb21tb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y2FsY3VsYXRlVmlzaWJsZUxheWVyUmVj dCk6CisKIDIwMTItMDUtMjIgIEp1bGllbiBDaGFmZnJhaXggIDxqY2hhZmZyYWl4QHdlYmtpdC5v cmc+CiAKICAgICAgICAgQ2VudHJhbGl6ZSBhbmQgY2xlYW4tdXAgdGFibGUgY29sdW1uIGl0ZXJh dGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwppbmRleCBjZTJlNDI4ZmE0NzczYzI1Zjk3NWVh ZjA4YjMzMjhjNzdhMDU2NjllLi5jNzNlMTY1NmM2NTQ5MmU0YjY4OTk5MWI0ZjM4NWUzZmFiMjNi N2Q1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZworKysgYi9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA1 LTE4ICBEYW5hIEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJv bWl1bV0gRG9uJ3QgZm9yY2UgdGhlIHZpc2libGVMYXllclJlY3QgdG8gYmUgZW1wdHkgZm9yIGFu aW1hdGluZyBsYXllcnMgd2hvc2UgZnJvbnQgZmFjZSBpcyBub3QgdmlzaWJsZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODY4ODYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHRlc3RzL0NDTGF5ZXJUcmVl SG9zdENvbW1vblRlc3QuY3BwOgorICAgICAgICAoV2ViS2l0VGVzdHM6OlRFU1QpOgorCiAyMDEy LTA1LTIyICBJYW4gVm9sbGljayAgPHZvbGxpY2tAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtj aHJvbWl1bV0gTW92ZSBhc3NlcnRzIGluIENDTGF5ZXJUcmVlSG9zdFRlc3Q6OmRpc3BhdGNoKgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2Mv Q0NMYXllclRyZWVIb3N0Q29tbW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdENvbW1vbi5jcHAKaW5kZXggM2YxYzM4Zjcy NWNkMjMxMjgwN2Y4ODJmYTZkMzg1ZjJiOGI3YWY3NC4uNTFkNTM2NWIyYjdmMmNiMjQ4OWQyOTY4 ODIzNjhkNWEwMDBiYWUyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0Q29tbW9uLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3RDb21t b24uY3BwCkBAIC03OCwxMSArNzgsNiBAQCBzdGF0aWMgSW50UmVjdCBjYWxjdWxhdGVWaXNpYmxl TGF5ZXJSZWN0KExheWVyVHlwZSogbGF5ZXIpCiB7CiAgICAgQVNTRVJUKGxheWVyLT50YXJnZXRS ZW5kZXJTdXJmYWNlKCkpOwogCi0gICAgLy8gQW5pbWF0ZWQgbGF5ZXJzIGNhbiBleGlzdCBpbiB0 aGUgcmVuZGVyIHN1cmZhY2UgdHJlZSB0aGF0IGFyZSBub3QgdmlzaWJsZSBjdXJyZW50bHkKLSAg ICAvLyBhbmQgaGF2ZSB0aGVpciBiYWNrIGZhY2Ugc2hvd2luZy4gSW4gdGhpcyBjYXNlLCB0aGVp ciB2aXNpYmxlIHJlY3Qgc2hvdWxkIGJlIGVtcHR5LgotICAgIGlmICghbGF5ZXItPmRvdWJsZVNp ZGVkKCkgJiYgbGF5ZXItPnNjcmVlblNwYWNlVHJhbnNmb3JtKCkuaXNCYWNrRmFjZVZpc2libGUo KSkKLSAgICAgICAgcmV0dXJuIEludFJlY3QoKTsKLQogICAgIEludFJlY3QgdGFyZ2V0U3VyZmFj ZVJlY3QgPSBsYXllci0+dGFyZ2V0UmVuZGVyU3VyZmFjZSgpLT5jb250ZW50UmVjdCgpOwogCiAg ICAgaWYgKGxheWVyLT51c2VzTGF5ZXJDbGlwcGluZygpKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9jaHJvbWl1bS90ZXN0cy9DQ0xheWVyVHJlZUhvc3RDb21tb25UZXN0LmNwcCBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ0NMYXllclRyZWVIb3N0Q29tbW9uVGVzdC5jcHAKaW5k ZXggYjY3ZjQ0OTg3ZDMxNTBlNzQ3M2MxNmY0YTgwZmJkYjExOTM1OTk2ZS4uMDY5NDQ5ZDhkODYw ODQ3MjFhNTBjM2ExOGU3YWJkZGM3MzhmMjA1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9j aHJvbWl1bS90ZXN0cy9DQ0xheWVyVHJlZUhvc3RDb21tb25UZXN0LmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NDTGF5ZXJUcmVlSG9zdENvbW1vblRlc3QuY3BwCkBAIC0x MzE4LDExICsxMzE4LDExIEBAIFRFU1QoQ0NMYXllclRyZWVIb3N0Q29tbW9uVGVzdCwgdmVyaWZ5 QmFja0ZhY2VDdWxsaW5nKQogCiAgICAgRVhQRUNUX0ZBTFNFKGNoaWxkMi0+dmlzaWJsZUxheWVy UmVjdCgpLmlzRW1wdHkoKSk7CiAKLSAgICAvLyBCdXQgaWYgdGhlIGJhY2sgZmFjZSBpcyB2aXNp YmxlLCB0aGVuIHRoZSB2aXNpYmxlTGF5ZXJSZWN0IHNob3VsZCBiZSBlbXB0eS4KLSAgICBFWFBF Q1RfVFJVRShhbmltYXRpbmdDaGlsZC0+dmlzaWJsZUxheWVyUmVjdCgpLmlzRW1wdHkoKSk7Ci0g ICAgRVhQRUNUX1RSVUUoYW5pbWF0aW5nU3VyZmFjZS0+dmlzaWJsZUxheWVyUmVjdCgpLmlzRW1w dHkoKSk7Ci0gICAgLy8gQW5kIGFueSBsYXllcnMgaW4gdGhlIHN1YnRyZWUgc2hvdWxkIG5vdCBi ZSBjb25zaWRlcmVkIHZpc2libGUgZWl0aGVyLgotICAgIEVYUEVDVF9UUlVFKGNoaWxkT2ZBbmlt YXRpbmdTdXJmYWNlLT52aXNpYmxlTGF5ZXJSZWN0KCkuaXNFbXB0eSgpKTsKKyAgICAvLyBUaGUg YW5pbWF0aW5nIGxheWVycyBzaG91bGQgaGF2ZSBhIHZpc2libGVMYXllclJlY3QgdGhhdCByZXBy ZXNlbnRzIHRoZSBhcmVhIG9mIHRoZSBmcm9udCBmYWNlIHRoYXQgaXMgd2l0aGluIHRoZSB2aWV3 cG9ydC4KKyAgICBFWFBFQ1RfRVEoYW5pbWF0aW5nQ2hpbGQtPnZpc2libGVMYXllclJlY3QoKSwg SW50UmVjdChJbnRQb2ludCgpLCBhbmltYXRpbmdDaGlsZC0+Y29udGVudEJvdW5kcygpKSk7Cisg ICAgRVhQRUNUX0VRKGFuaW1hdGluZ1N1cmZhY2UtPnZpc2libGVMYXllclJlY3QoKSwgSW50UmVj dChJbnRQb2ludCgpLCBhbmltYXRpbmdTdXJmYWNlLT5jb250ZW50Qm91bmRzKCkpKTsKKyAgICAv LyBBbmQgbGF5ZXJzIGluIHRoZSBzdWJ0cmVlIG9mIHRoZSBhbmltYXRpbmcgbGF5ZXIgc2hvdWxk IGhhdmUgdmFsaWQgdmlzaWJsZUxheWVyUmVjdHMgYWxzby4KKyAgICBFWFBFQ1RfRVEoY2hpbGRP ZkFuaW1hdGluZ1N1cmZhY2UtPnZpc2libGVMYXllclJlY3QoKSwgSW50UmVjdChJbnRQb2ludCgp LCBjaGlsZE9mQW5pbWF0aW5nU3VyZmFjZS0+Y29udGVudEJvdW5kcygpKSk7CiB9CiAKIFRFU1Qo Q0NMYXllclRyZWVIb3N0Q29tbW9uVGVzdCwgdmVyaWZ5QmFja0ZhY2VDdWxsaW5nV2l0aFByZXNl cnZlczNkRm9yRmxhdHRlbmluZ1N1cmZhY2UpCg==