86854 2012-05-18 07:24:20 -0700 [Qt] REGRESSION(r117501): It made almost all tests assert in debug mode 2012-05-18 14:09:56 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Blocker --- 79668 85799 1 ossy ostap73 beidson japhet kling ostap73 webkit.review.bot oldest_to_newest 627672 0 ossy 2012-05-18 07:24:20 -0700 examples: Qt 64 bit debug bot: http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Debug/r117580%20%2822936%29/results.html Qt 32 bit debug bot: http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Debug/r117587%20%2820625%29/results.html crash log for DumpRenderTree (pid 8877): STDOUT: <empty> STDERR: ASSERTION FAILED: m_retainOrReleaseIconRequested STDERR: ../../../../Source/WebCore/loader/icon/IconDatabase.cpp(1510) : void WebCore::IconDatabase::performPendingRetainAndReleaseOperations() STDERR: 1 0xf51388f6 /mnt/raptor3/slaves/qt-linux-32-debug/build/WebKitBuild/Debug/lib/libQtWebKit.so.4(WebCore::IconDatabase::performPendingRetainAndReleaseOperations()+0x56) [0xf51388f6] STDERR: 2 0xf5137f25 /mnt/raptor3/slaves/qt-linux-32-debug/build/WebKitBuild/Debug/lib/libQtWebKit.so.4(WebCore::IconDatabase::performURLImport()+0x6f9) [0xf5137f25] STDERR: 3 0xf51366af /mnt/raptor3/slaves/qt-linux-32-debug/build/WebKitBuild/Debug/lib/libQtWebKit.so.4(WebCore::IconDatabase::iconDatabaseSyncThread()+0x4cf) [0xf51366af] STDERR: 4 0xf51361d9 /mnt/raptor3/slaves/qt-linux-32-debug/build/WebKitBuild/Debug/lib/libQtWebKit.so.4(WebCore::IconDatabase::iconDatabaseSyncThreadStart(void*)+0x23) [0xf51361d9] STDERR: 5 0xf5c54cc2 /mnt/raptor3/slaves/qt-linux-32-debug/build/WebKitBuild/Debug/lib/libQtWebKit.so.4(+0x3279cc2) [0xf5c54cc2] STDERR: 6 0xf5c6b910 /mnt/raptor3/slaves/qt-linux-32-debug/build/WebKitBuild/Debug/lib/libQtWebKit.so.4(+0x3290910) [0xf5c6b910] STDERR: 7 0xf0e957b0 /lib/libpthread.so.0(+0x57b0) [0xf0e957b0] STDERR: 8 0xf0bb10be /lib/libc.so.6(clone+0x5e) [0xf0bb10be] 627796 1 142734 ostap73 2012-05-18 10:32:12 -0700 Created attachment 142734 Patch 627799 2 142734 beidson 2012-05-18 10:36:20 -0700 Comment on attachment 142734 Patch Seems okay to me. kling should really take a look, as he is the "most recently intimate" with the lock intricacies involved. 627805 3 142734 rafael.lobo 2012-05-18 10:47:39 -0700 Comment on attachment 142734 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142734&action=review Did you try using tryLock? > Source/WebCore/loader/icon/IconDatabase.cpp:1423 > + // Previous flag check was done outside of the lock and flag could be changed by antoher thread. Typo on another. 627835 4 142734 kling 2012-05-18 11:16:24 -0700 Comment on attachment 142734 Patch Looks great to me. Thanks for the fix! 627860 5 ostap73 2012-05-18 11:37:58 -0700 (In reply to comment #3) > (From update of attachment 142734 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=142734&action=review > > Did you try using tryLock? Why tryLock? I wouldn't touch mutex in the thread loop until it is really necessary. Double checking of the flag, IMHO, quite common. > > Source/WebCore/loader/icon/IconDatabase.cpp:1423 > > + // Previous flag check was done outside of the lock and flag could be changed by antoher thread. > > Typo on another. Thanks. 627871 6 142751 ostap73 2012-05-18 11:45:00 -0700 Created attachment 142751 Patch for commit. 628055 7 142751 webkit.review.bot 2012-05-18 14:09:50 -0700 Comment on attachment 142751 Patch for commit. Clearing flags on attachment: 142751 Committed r117625: <http://trac.webkit.org/changeset/117625> 628056 8 webkit.review.bot 2012-05-18 14:09:56 -0700 All reviewed patches have been landed. Closing bug. 142734 2012-05-18 10:32:12 -0700 2012-05-18 11:45:00 -0700 Patch trunk86584_01.diff text/plain 2045 ostap73 ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwMzQzYWZjLi42MjMxNDY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTItMDUtMTggIFZpYXRjaGVzbGF2IE9zdGFwZW5rbyAgPG9zdGFwZW5rby52aWF0Y2hl c2xhdkBub2tpYS5jb20+CisKKyAgICAgICAgW1F0XSBSRUdSRVNTSU9OKHIxMTc1MDEpOiBJdCBt YWRlIGFsbW9zdCBhbGwgdGVzdHMgYXNzZXJ0IGluIGRlYnVnIG1vZGUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2ODU0CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW5pdGlhbGl6ZSBib29sZWFuIGZsYWcg aW4gY29uc3RydWN0b3IgYW5kIHJlY2hlY2sgdGhlIGZsYWcgd2hpY2ggY2FuIGJlIAorICAgICAg ICBtb2RpZmllZCBieSBhbm90aGVyIHRocmVhZCB1bmRlciBtdXRleC4KKworICAgICAgICBObyBu ZXcgdGVzdHMsIGZpeGVzIHJlZ3Jlc3Npb24gdGhhdCBjYXVzZWQgbGF5b3V0IHRlc3QgY3Jhc2gu CisKKyAgICAgICAgKiBsb2FkZXIvaWNvbi9JY29uRGF0YWJhc2UuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6SWNvbkRhdGFiYXNlOjpJY29uRGF0YWJhc2UpOgorICAgICAgICAoV2ViQ29yZTo6SWNv bkRhdGFiYXNlOjpzeW5jVGhyZWFkTWFpbkxvb3ApOgorCiAyMDEyLTA1LTE4ICBZaSBTaGVuICA8 eWkuNC5zaGVuQG5va2lhLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMTAyNTUzKTogU21h cnQgbGlua3MgZG8gbm90IHdvcmsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9p Y29uL0ljb25EYXRhYmFzZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvaWNvbi9JY29uRGF0 YWJhc2UuY3BwCmluZGV4IDNkYjNmZTguLmRkMWE4MzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2xvYWRlci9pY29uL0ljb25EYXRhYmFzZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9h ZGVyL2ljb24vSWNvbkRhdGFiYXNlLmNwcApAQCAtNzgyLDYgKzc4Miw3IEBAIEljb25EYXRhYmFz ZTo6SWNvbkRhdGFiYXNlKCkKICAgICAsIG1faWNvblVSTEltcG9ydENvbXBsZXRlKGZhbHNlKQog ICAgICwgbV9zeW5jVGhyZWFkSGFzV29ya1RvRG8oZmFsc2UpCiAgICAgLCBtX2Rpc2FibGVkU3Vk ZGVuVGVybWluYXRpb25Gb3JTeW5jVGhyZWFkKGZhbHNlKQorICAgICwgbV9yZXRhaW5PclJlbGVh c2VJY29uUmVxdWVzdGVkKGZhbHNlKQogICAgICwgbV9pbml0aWFsUHJ1bmluZ0NvbXBsZXRlKGZh bHNlKQogICAgICwgbV9jbGllbnQoZGVmYXVsdENsaWVudCgpKQogICAgICwgbV9pbXBvcnRlZChm YWxzZSkKQEAgLTE0MTksNyArMTQyMCwxMCBAQCB2b2lkIEljb25EYXRhYmFzZTo6c3luY1RocmVh ZE1haW5Mb29wKCkKIAogICAgICAgICBpZiAobV9yZXRhaW5PclJlbGVhc2VJY29uUmVxdWVzdGVk KSB7CiAgICAgICAgICAgICBNdXRleExvY2tlciBsb2NrZXIobV91cmxBbmRJY29uTG9jayk7Ci0g ICAgICAgICAgICBwZXJmb3JtUGVuZGluZ1JldGFpbkFuZFJlbGVhc2VPcGVyYXRpb25zKCk7Cisg ICAgICAgICAgICAvLyBQcmV2aW91cyBmbGFnIGNoZWNrIHdhcyBkb25lIG91dHNpZGUgb2YgdGhl IGxvY2sgYW5kIGZsYWcgY291bGQgYmUgY2hhbmdlZCBieSBhbnRvaGVyIHRocmVhZC4KKyAgICAg ICAgICAgIC8vIERvIG5vdCBtb3ZlIG11dGV4IG91dHNpZGUgdG8gYXZvaWQgdW5uZWNlc3Nhcnkg bG9ja2luZyBvbiBldmVyeSBsb29wLCBidXQgcmVjaGVjayB0aGUgZmxhZyB1bmRlciBtdXRleC4K KyAgICAgICAgICAgIGlmIChtX3JldGFpbk9yUmVsZWFzZUljb25SZXF1ZXN0ZWQpCisgICAgICAg ICAgICAgICAgcGVyZm9ybVBlbmRpbmdSZXRhaW5BbmRSZWxlYXNlT3BlcmF0aW9ucygpOwogICAg ICAgICB9CiAgICAgICAgIAogICAgICAgICBib29sIGRpZEFueVdvcmsgPSB0cnVlOwo= 142751 2012-05-18 11:45:00 -0700 2012-05-18 14:09:50 -0700 Patch for commit. trunk86584_02.diff text/plain 2044 ostap73 ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwMzQzYWZjLi4xNmExMTkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTItMDUtMTggIFZpYXRjaGVzbGF2IE9zdGFwZW5rbyAgPG9zdGFwZW5rby52aWF0Y2hl c2xhdkBub2tpYS5jb20+CisKKyAgICAgICAgW1F0XSBSRUdSRVNTSU9OKHIxMTc1MDEpOiBJdCBt YWRlIGFsbW9zdCBhbGwgdGVzdHMgYXNzZXJ0IGluIGRlYnVnIG1vZGUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2ODU0CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgQW5kcmVhcyBLbGluZy4KKworICAgICAgICBJbml0aWFsaXplIGJvb2xlYW4gZmxhZyBp biBjb25zdHJ1Y3RvciBhbmQgcmVjaGVjayB0aGUgZmxhZyB3aGljaCBjYW4gYmUgCisgICAgICAg IG1vZGlmaWVkIGJ5IGFub3RoZXIgdGhyZWFkIHVuZGVyIG11dGV4LgorCisgICAgICAgIE5vIG5l dyB0ZXN0cywgZml4ZXMgcmVncmVzc2lvbiB0aGF0IGNhdXNlZCBsYXlvdXQgdGVzdCBjcmFzaC4K KworICAgICAgICAqIGxvYWRlci9pY29uL0ljb25EYXRhYmFzZS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpJY29uRGF0YWJhc2U6Okljb25EYXRhYmFzZSk6CisgICAgICAgIChXZWJDb3JlOjpJY29u RGF0YWJhc2U6OnN5bmNUaHJlYWRNYWluTG9vcCk6CisKIDIwMTItMDUtMTggIFlpIFNoZW4gIDx5 aS40LnNoZW5Abm9raWEuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIxMDI1NTMpOiBTbWFy dCBsaW5rcyBkbyBub3Qgd29yawpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2lj b24vSWNvbkRhdGFiYXNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9pY29uL0ljb25EYXRh YmFzZS5jcHAKaW5kZXggM2RiM2ZlOC4uNDIxMjEzOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvbG9hZGVyL2ljb24vSWNvbkRhdGFiYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2Fk ZXIvaWNvbi9JY29uRGF0YWJhc2UuY3BwCkBAIC03ODIsNiArNzgyLDcgQEAgSWNvbkRhdGFiYXNl OjpJY29uRGF0YWJhc2UoKQogICAgICwgbV9pY29uVVJMSW1wb3J0Q29tcGxldGUoZmFsc2UpCiAg ICAgLCBtX3N5bmNUaHJlYWRIYXNXb3JrVG9EbyhmYWxzZSkKICAgICAsIG1fZGlzYWJsZWRTdWRk ZW5UZXJtaW5hdGlvbkZvclN5bmNUaHJlYWQoZmFsc2UpCisgICAgLCBtX3JldGFpbk9yUmVsZWFz ZUljb25SZXF1ZXN0ZWQoZmFsc2UpCiAgICAgLCBtX2luaXRpYWxQcnVuaW5nQ29tcGxldGUoZmFs c2UpCiAgICAgLCBtX2NsaWVudChkZWZhdWx0Q2xpZW50KCkpCiAgICAgLCBtX2ltcG9ydGVkKGZh bHNlKQpAQCAtMTQxOSw3ICsxNDIwLDEwIEBAIHZvaWQgSWNvbkRhdGFiYXNlOjpzeW5jVGhyZWFk TWFpbkxvb3AoKQogCiAgICAgICAgIGlmIChtX3JldGFpbk9yUmVsZWFzZUljb25SZXF1ZXN0ZWQp IHsKICAgICAgICAgICAgIE11dGV4TG9ja2VyIGxvY2tlcihtX3VybEFuZEljb25Mb2NrKTsKLSAg ICAgICAgICAgIHBlcmZvcm1QZW5kaW5nUmV0YWluQW5kUmVsZWFzZU9wZXJhdGlvbnMoKTsKKyAg ICAgICAgICAgIC8vIFByZXZpb3VzIGZsYWcgY2hlY2sgd2FzIGRvbmUgb3V0c2lkZSBvZiB0aGUg bG9jayBhbmQgZmxhZyBjb3VsZCBiZSBjaGFuZ2VkIGJ5IGFub3RoZXIgdGhyZWFkLgorICAgICAg ICAgICAgLy8gRG8gbm90IG1vdmUgbXV0ZXggb3V0c2lkZSB0byBhdm9pZCB1bm5lY2Vzc2FyeSBs b2NraW5nIG9uIGV2ZXJ5IGxvb3AsIGJ1dCByZWNoZWNrIHRoZSBmbGFnIHVuZGVyIG11dGV4Lgor ICAgICAgICAgICAgaWYgKG1fcmV0YWluT3JSZWxlYXNlSWNvblJlcXVlc3RlZCkKKyAgICAgICAg ICAgICAgICBwZXJmb3JtUGVuZGluZ1JldGFpbkFuZFJlbGVhc2VPcGVyYXRpb25zKCk7CiAgICAg ICAgIH0KICAgICAgICAgCiAgICAgICAgIGJvb2wgZGlkQW55V29yayA9IHRydWU7Cg==