86815 2012-05-17 23:30:43 -0700 [perf-test] Add a binding benchmark for div.setAttribute() 2012-05-18 00:19:58 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 86581 1 haraken haraken rniwa webkit.review.bot oldest_to_newest 627389 0 haraken 2012-05-17 23:30:43 -0700 We should remove Bindings/dom-attributes.html and instead add more reasonable micro benchmarks by classifying DOM binding call paths. In this bug we add a benchmark for div.setAttribute(). This benchmark covers 'setAttribute' in Dromaeo/dom-attr.html and other DOM methods that return an undefined. 627394 1 142646 haraken 2012-05-17 23:36:24 -0700 Created attachment 142646 Patch 627424 2 142646 webkit.review.bot 2012-05-18 00:19:54 -0700 Comment on attachment 142646 Patch Clearing flags on attachment: 142646 Committed r117553: <http://trac.webkit.org/changeset/117553> 627425 3 webkit.review.bot 2012-05-18 00:19:58 -0700 All reviewed patches have been landed. Closing bug. 142646 2012-05-17 23:36:24 -0700 2012-05-18 00:19:54 -0700 Patch bug-86815-20120518153623.patch text/plain 2853 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3NTM2CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0JpbmRpbmdzL3NldC1hdHRyaWJ1dGUuaHRtbCBiL1BlcmZvcm1hbmNlVGVzdHMvQmluZGluZ3Mv c2V0LWF0dHJpYnV0ZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjdmNDBiNWI5YmI3Y2Q2ZTQ2NmRiMDc3MGJm NTQzMzUzOTUzMjBlYzUKLS0tIC9kZXYvbnVsbAorKysgYi9QZXJmb3JtYW5jZVRlc3RzL0JpbmRp bmdzL3NldC1hdHRyaWJ1dGUuaHRtbApAQCAtMCwwICsxLDE4IEBACis8IURPQ1RZUEUgaHRtbD4K KzxodG1sPgorPGJvZHk+Cis8ZGl2IGlkPSJmb28iPjwvZGl2PgorPHNjcmlwdCBzcmM9Ii4uL3Jl c291cmNlcy9ydW5uZXIuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4KK3ZhciBkaXYgPSBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgiZm9vIik7CisKK1BlcmZUZXN0UnVubmVyLnJ1blBlclNlY29uZCh7 CisgICAgZGVzY3JpcHRpb246ICJUaGlzIGJlbmNobWFyayBjb3ZlcnMgJ3NldEF0dHJpYnV0ZScg aW4gRHJvbWFlby9kb20tYXR0ci5odG1sIGFuZCBvdGhlciBET00gbWV0aG9kcyB0aGF0IHJldHVy biBhbiB1bmRlZmluZWQuIiwKKyAgICBydW46IGZ1bmN0aW9uKCkgeworICAgICAgICB2YXIgbG9j YWxEaXYgPSBkaXY7CisgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgMTAwMDA7IGkrKykKKyAg ICAgICAgICAgIGxvY2FsRGl2LnNldEF0dHJpYnV0ZSgiaWQiLCAiZm9vIik7Cit9fSk7Cis8L3Nj cmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hh bmdlTG9nIGIvUGVyZm9ybWFuY2VUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZGRjMjgzYmE1NDQ2MDkx NmY2MmI5NmY3YjYwYTc2NjM4MDI0YjIwNC4uN2M5YTQ1YjQzMjk3NDM4MDc5ODRjYmMyNzljNDc0 YjI3NzMyYmI2NiAxMDA2NDQKLS0tIGEvUGVyZm9ybWFuY2VUZXN0cy9DaGFuZ2VMb2cKKysrIGIv UGVyZm9ybWFuY2VUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsNSArMSwzOCBAQAogMjAxMi0wNS0xNyAg S2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgW3BlcmYtdGVz dF0gQWRkIGEgYmluZGluZyBiZW5jaG1hcmsgZm9yIGRpdi5zZXRBdHRyaWJ1dGUoKQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODY4MTUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBzaG91bGQgcmVtb3Zl IEJpbmRpbmdzL2RvbS1hdHRyaWJ1dGVzLmh0bWwgYW5kIGluc3RlYWQgYWRkIG1vcmUKKyAgICAg ICAgcmVhc29uYWJsZSBtaWNybyBiZW5jaG1hcmtzIGJ5IGNsYXNzaWZ5aW5nIERPTSBiaW5kaW5n IGNhbGwgcGF0aHMuCisKKyAgICAgICAgVGhpcyBwYXRjaCBhZGRzIGEgYmVuY2htYXJrIGZvciBk aXYuc2V0QXR0cmlidXRlKCkuIFRoaXMgYmVuY2htYXJrCisgICAgICAgIGNvdmVycyAnc2V0QXR0 cmlidXRlJyBpbiBEcm9tYWVvL2RvbS1hdHRyLmh0bWwgYW5kIG90aGVyIERPTSBtZXRob2RzCisg ICAgICAgIHRoYXQgcmV0dXJuIGFuIHVuZGVmaW5lZC4KKworICAgICAgICBUZXN0IHJlc3VsdHMg aW4gbXkgTGludXggZGVza3RvcDoKKworICAgICAgICBSRVNVTFQgQmluZGluZ3M6IHNldC1hdHRy aWJ1dGU9IDc5My43NDUwNzMyNTIgcnVucy9zCisgICAgICAgIG1lZGlhbj0gNzkxLjU4OTY2NTc2 NSBydW5zL3MsIHN0ZGV2PSA2LjAwNDY3MTU5NzA5IHJ1bnMvcywgbWluPSA3ODUuMjc2MDczNjIg cnVucy9zLCBtYXg9IDgwOC4wODA4MDgwODEgcnVucy9zCisKKyAgICAgICAgUkVTVUxUIEJpbmRp bmdzOiBzZXQtYXR0cmlidXRlPSA3OTAuODU4NDQ0MTY0IHJ1bnMvcworICAgICAgICBtZWRpYW49 IDc4Ny45MTg5MjE0MzYgcnVucy9zLCBzdGRldj0gNy44NjI2NDk1MzY1NSBydW5zL3MsIG1pbj0g NzgwLjIzNDA3MDIyMSBydW5zL3MsIG1heD0gODA2LjA0NTM0MDA1IHJ1bnMvcworCisgICAgICAg IFJFU1VMVCBCaW5kaW5nczogc2V0LWF0dHJpYnV0ZT0gNzg3LjI3NzU3MTQxNyBydW5zL3MKKyAg ICAgICAgbWVkaWFuPSA3ODQuMzEzNzI1NDkgcnVucy9zLCBzdGRldj0gNy40NTM2MzM0NjY1NyBy dW5zL3MsIG1pbj0gNzc4LjU4ODgwNzc4NiBydW5zL3MsIG1heD0gODA0LjAyMDEwMDUwMyBydW5z L3MKKworICAgICAgICBSRVNVTFQgQmluZGluZ3M6IHNldC1hdHRyaWJ1dGU9IDc4Mi40MDEzOTM3 OTEgcnVucy9zCisgICAgICAgIG1lZGlhbj0gNzc5LjA2Mjk3ODgwMiBydW5zL3MsIHN0ZGV2PSA2 LjQ4MjUwMDgxNjIxIHJ1bnMvcywgbWluPSA3NzcuNjQyNzcwMzUyIHJ1bnMvcywgbWF4PSA3OTYu MDE5OTAwNDk4IHJ1bnMvcworCisgICAgICAgIFJFU1VMVCBCaW5kaW5nczogc2V0LWF0dHJpYnV0 ZT0gNzkxLjc5MjUxNjYwOCBydW5zL3MKKyAgICAgICAgbWVkaWFuPSA3OTEuNTU2NzI4MjMyIHJ1 bnMvcywgc3RkZXY9IDYuNDkxODI5ODAzOTcgcnVucy9zLCBtaW49IDc3OS4yMjA3NzkyMjEgcnVu cy9zLCBtYXg9IDgwOC4wODA4MDgwODEgcnVucy9zCisKKyAgICAgICAgKiBCaW5kaW5ncy9zZXQt YXR0cmlidXRlLmh0bWw6IEFkZGVkLgorCisyMDEyLTA1LTE3ICBLZW50YXJvIEhhcmEgIDxoYXJh a2VuQGNocm9taXVtLm9yZz4KKwogICAgICAgICBbcGVyZi10ZXN0XSBBZGQgYSBtaWNybyBiZW5j aG1hcmsgZm9yIGRpdi5maXJzdENoaWxkIGdldHRlciBmb3IgYW4gdW5kZWZpbmVkIGZpcnN0Q2hp bGQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2NzI1 CiAK