86814 2012-05-17 23:23:44 -0700 [perf-test] Add a binding benchmark for div.getAttribute() 2012-05-17 23:49:11 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 86581 1 haraken haraken rniwa webkit.review.bot oldest_to_newest 627381 0 haraken 2012-05-17 23:23:44 -0700 We should remove Bindings/dom-attributes.html and instead add more reasonable micro benchmarks by classifying DOM binding call paths. In this bug we add a benchmark for div.getAttribute(). This benchmark covers 'getAttribute' in Dromaeo/dom-attr.html, and other DOM methods that return a String. 627385 1 142644 haraken 2012-05-17 23:26:38 -0700 Created attachment 142644 Patch 627404 2 142644 webkit.review.bot 2012-05-17 23:49:03 -0700 Comment on attachment 142644 Patch Clearing flags on attachment: 142644 Committed r117550: <http://trac.webkit.org/changeset/117550> 627405 3 webkit.review.bot 2012-05-17 23:49:11 -0700 All reviewed patches have been landed. Closing bug. 142644 2012-05-17 23:26:38 -0700 2012-05-17 23:49:02 -0700 Patch bug-86814-20120518152637.patch text/plain 2844 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3NTM2CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0JpbmRpbmdzL2dldC1hdHRyaWJ1dGUuaHRtbCBiL1BlcmZvcm1hbmNlVGVzdHMvQmluZGluZ3Mv Z2V0LWF0dHJpYnV0ZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjc3ZTViNWQ2M2JmM2MyODJlYjUzNmE2MGY1 N2JjZmRiMGU2ZDdlNmYKLS0tIC9kZXYvbnVsbAorKysgYi9QZXJmb3JtYW5jZVRlc3RzL0JpbmRp bmdzL2dldC1hdHRyaWJ1dGUuaHRtbApAQCAtMCwwICsxLDE4IEBACis8IURPQ1RZUEUgaHRtbD4K KzxodG1sPgorPGJvZHk+Cis8ZGl2IGlkPSJmb28iPjwvZGl2PgorPHNjcmlwdCBzcmM9Ii4uL3Jl c291cmNlcy9ydW5uZXIuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4KK3ZhciBkaXYgPSBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgiZm9vIik7CisKK1BlcmZUZXN0UnVubmVyLnJ1blBlclNlY29uZCh7 CisgICAgZGVzY3JpcHRpb246ICJUaGlzIGJlbmNobWFyayBjb3ZlcnMgJ2dldEF0dHJpYnV0ZScg aW4gRHJvbWFlby9kb20tYXR0ci5odG1sLCBhbmQgb3RoZXIgRE9NIG1ldGhvZHMgdGhhdCByZXR1 cm4gYSBTdHJpbmcuIiwKKyAgICBydW46IGZ1bmN0aW9uKCkgeworICAgICAgICB2YXIgbG9jYWxE aXYgPSBkaXY7CisgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgMTAwMDAwOyBpKyspCisgICAg ICAgICAgICBsb2NhbERpdi5nZXRBdHRyaWJ1dGUoImlkIik7Cit9fSk7Cis8L3NjcmlwdD4KKzwv Ym9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nIGIv UGVyZm9ybWFuY2VUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZGRjMjgzYmE1NDQ2MDkxNmY2MmI5NmY3 YjYwYTc2NjM4MDI0YjIwNC4uYTkxNmUxNDUyMGQ0Yjk4ODExOGViOWE1YjM2YzE0ZTMwNjFmNDE5 OCAxMDA2NDQKLS0tIGEvUGVyZm9ybWFuY2VUZXN0cy9DaGFuZ2VMb2cKKysrIGIvUGVyZm9ybWFu Y2VUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsNSArMSwzOCBAQAogMjAxMi0wNS0xNyAgS2VudGFybyBI YXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgW3BlcmYtdGVzdF0gQWRkIGEg YmluZGluZyBiZW5jaG1hcmsgZm9yIGRpdi5nZXRBdHRyaWJ1dGUoKQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODY4MTQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBzaG91bGQgcmVtb3ZlIEJpbmRpbmdz L2RvbS1hdHRyaWJ1dGVzLmh0bWwgYW5kIGluc3RlYWQgYWRkIG1vcmUKKyAgICAgICAgcmVhc29u YWJsZSBtaWNybyBiZW5jaG1hcmtzIGJ5IGNsYXNzaWZ5aW5nIERPTSBiaW5kaW5nIGNhbGwgcGF0 aHMuCisKKyAgICAgICAgVGhpcyBwYXRjaCBhZGRzIGEgYmVuY2htYXJrIGZvciBkaXYuZ2V0QXR0 cmlidXRlKCkuIFRoaXMgYmVuY2htYXJrCisgICAgICAgIGNvdmVycyAnZ2V0QXR0cmlidXRlJyBp biBEcm9tYWVvL2RvbS1hdHRyLmh0bWwsIGFuZCBvdGhlciBET00gbWV0aG9kcworICAgICAgICB0 aGF0IHJldHVybiBhIFN0cmluZy4KKworICAgICAgICBUZXN0IHJlc3VsdHMgaW4gbXkgTGludXgg ZGVza3RvcDoKKworICAgICAgICBSRVNVTFQgQmluZGluZ3M6IGdldC1hdHRyaWJ1dGU9IDI1MC4w ODgxNTg1MzggcnVucy9zCisgICAgICAgIG1lZGlhbj0gMjUwLjQ2OTcyODc2NSBydW5zL3MsIHN0 ZGV2PSA0LjY2NTUxOTAxMzE1IHJ1bnMvcywgbWluPSAyNDAuNjczODg2ODgzIHJ1bnMvcywgbWF4 PSAyNTYuNzM5NDA5NDk5IHJ1bnMvcworCisgICAgICAgIFJFU1VMVCBCaW5kaW5nczogZ2V0LWF0 dHJpYnV0ZT0gMjUwLjIwOTc2NDY5OCBydW5zL3MKKyAgICAgICAgbWVkaWFuPSAyNTAuNjI2OTU5 OTg2IHJ1bnMvcywgc3RkZXY9IDQuMTIwMzAwMDI0NzcgcnVucy9zLCBtaW49IDI0MS4yNTQ1MjM1 MjIgcnVucy9zLCBtYXg9IDI1NS4xMDIwNDA4MTYgcnVucy9zCisKKyAgICAgICAgUkVTVUxUIEJp bmRpbmdzOiBnZXQtYXR0cmlidXRlPSAyNDguOTA3NTMyODg3IHJ1bnMvcworICAgICAgICBtZWRp YW49IDI1MC4zMTI4OTExMTQgcnVucy9zLCBzdGRldj0gMy4yMzE3MzEyNTg3NCBydW5zL3MsIG1p bj0gMjQwLjY3Mzg4Njg4MyBydW5zL3MsIG1heD0gMjUxLjU3MjMyNzA0NCBydW5zL3MKKworICAg ICAgICBSRVNVTFQgQmluZGluZ3M6IGdldC1hdHRyaWJ1dGU9IDI1MC4yNDM2ODA4NDQgcnVucy9z CisgICAgICAgIG1lZGlhbj0gMjUwLjc4Mzc5NzYzNyBydW5zL3MsIHN0ZGV2PSA0LjE5MzI3MTcw MDI0IHJ1bnMvcywgbWluPSAyNDAuOTYzODU1NDIyIHJ1bnMvcywgbWF4PSAyNTUuMTAyMDQwODE2 IHJ1bnMvcworCisgICAgICAgIFJFU1VMVCBCaW5kaW5nczogZ2V0LWF0dHJpYnV0ZT0gMjQ1LjMy OTA0NjYwOCBydW5zL3MKKyAgICAgICAgbWVkaWFuPSAyNDQuOTQ4MDQwNDE2IHJ1bnMvcywgc3Rk ZXY9IDIuMjQzMTQyNDg1MzQgcnVucy9zLCBtaW49IDI0MC4zODQ2MTUzODUgcnVucy9zLCBtYXg9 IDI0OC43NTYyMTg5MDUgcnVucy9zCisKKyAgICAgICAgKiBCaW5kaW5ncy9nZXQtYXR0cmlidXRl Lmh0bWw6IEFkZGVkLgorCisyMDEyLTA1LTE3ICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9t aXVtLm9yZz4KKwogICAgICAgICBbcGVyZi10ZXN0XSBBZGQgYSBtaWNybyBiZW5jaG1hcmsgZm9y IGRpdi5maXJzdENoaWxkIGdldHRlciBmb3IgYW4gdW5kZWZpbmVkIGZpcnN0Q2hpbGQKICAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2NzI1CiAK